[bug #24050] [mm] footnote/end-of-page problem

[Dave]

Follow-up Comment #4, bug #24050 (group groff):

Problem originally reported on bug-groff
(http://lists.gnu.org/r/bug-groff/2007-07/msg00010.html).  That report offers
no additional information about the problem, but does tell who reported it. 
There were no follow-ups on the list.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65885] env.cpp: warning about "-Woverloaded-virtual="

[Bjarni Ingi Gislason]

URL:
  

 Summary: env.cpp: warning about "-Woverloaded-virtual="
   Group: GNU roff
   Submitter: bjarniig
   Submitted: Sat 15 Jun 2024 06:47:07 PM UTC
Category: Core
Severity: 3 - Normal
  Item Group: Warning/Suspicious behaviour
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: None


___

Follow-up Comments:


---
Date: Sat 15 Jun 2024 06:47:07 PM UTC By: Bjarni Ingi Gislason 
Subject: env.cpp: warning about "-Woverloaded-virtual="

Directory: src/roff/troff

gcc-14 (Debian 14-20240330-1) 14.0.1 20240330 (experimental) [master
r14-9728-g6fc84f680d0]

[...]
  CXX  src/roff/troff/env.o
In file included from ../src/roff/troff/env.cpp:29:
../src/roff/troff/reg.h:23:16: warning: 'virtual bool reg::get_value(units*)'
was hidden [-Woverloaded-virtual=]
   23 |   virtual bool get_value(units *);
  |^
../src/roff/troff/env.cpp:3184:8: note:   by 'bool
unsigned_env_reg::get_value(unsigned int*)'
 3184 |   bool get_value(unsigned *val);
  |^
  CXXLDtroff
[...] 








___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65884] [mm] with \n[Pt]=2, indentation not restored correctly after implicit paragraph

[G. Branden Robinson]

Update of bug #65884 (group groff):

  Status: In Progress => Fixed  
 Assigned to:None => gbranden   
 Open/Closed:Open => Closed 
 Planned Release:None => 1.24.0 

___

Follow-up Comment #1:

I goofed the commit messages, alas, but the bug is fixed.

Here's what the commit messages SHOULD have looked like.


commit xxxBOGUSxxx8a423cd26ea49cb3846684f11e640771a62a8f03
Author: G. Branden Robinson 
Date:   Sat Jun 15 06:17:51 2024 -0500

[mm]: Fix Savannah #65865 (suppress P indent).

* contrib/mm/m.tmac (hd*trap): New macro shuts off suppression of
  paragraph indentation.

  (H): Stop trying to figure out whether we should suppress indentation
  based on whether the heading is run-in or not; that is not the
  relevant criterion.  What matters is whether formatted output (such as
  implied paragraph text) follows the heading call.  To that end, set a
  1-line input trap calling the new macro `hd*trap`.

Fixes .  Problem introduced by me
in commit 814e204d16, 24 January 2023.

commit xxxBOGUSxxx93948e20870f9740ce7de392e3e61c54a2a07f96
Author: G. Branden Robinson 
Date:   Sat Jun 15 06:05:40 2024 -0500

[mm]: Regression-test Savannah #65884.

* contrib/mm/tests/P-indentation-works.sh: Do it.

Test fails at this commit.


Here's the patch.


diff --git a/contrib/mm/m.tmac b/contrib/mm/m.tmac
index a84f30d90..f1965d09c 100644
--- a/contrib/mm/m.tmac
+++ b/contrib/mm/m.tmac
@@ -1037,6 +1037,10 @@ .de HU
 .H 0 \\$@
 ..
 .\"-
+.de hd*trap
+.nr par@suppress-indentation 0
+..
+.\"-
 .de H
 .if !r hd*cur-bline .nr hd*cur-bline \\n[nl]
 .br
@@ -1177,10 +1181,7 @@ .de H
 .  if (\\n[Hi]=1)&(\\n[Pt]=1) .ti +\\n[Pi]n
 .  \"  indent size of mark if Hi=2
 .  if \\n[hd*htype]&(\\n[Hi]>1) .ti +\\n[hd*mark-size]u
-.  nr par@suppress-indentation 1
 .\}
-.\" We're setting a run-in heading; the next paragraph is normal.
-.el .nr par@suppress-indentation 0
 .\"
 .\"check if it is time to reset footnotes
 .if (\\n[hd*level]=1)&\\n[ft*clear-at-header] .nr ft*nr 0 1
@@ -1198,6 +1199,8 @@ .de H
 .nr hd*last-hsize \\n[.k]
 .\" HTML: end of heading
 .misc@tag EO-H
+.\" _Any_ output after this heading resets suppression of indentation.
+.itc 1 hd*trap
 ..
 .\"
 .de HM




___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65884] [mm] with \n[Pt]=2, indentation not restored correctly after implicit paragraph

[G. Branden Robinson]

URL:
  

 Summary: [mm] with \n[Pt]=2, indentation not restored
correctly after implicit paragraph
   Group: GNU roff
   Submitter: gbranden
   Submitted: Sat 15 Jun 2024 11:02:35 AM UTC
Category: Macro package mm
Severity: 4 - Important
  Item Group: Incorrect behaviour
  Status: In Progress
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: None


___

Follow-up Comments:


---
Date: Sat 15 Jun 2024 11:02:35 AM UTC By: G. Branden Robinson 
This is a regression from _groff_ 1.22.4 behavior affecting 1.23.0,
unfortunately.  Setting severity to Important to flag it for anyone interested
in backporting.

The scenario is this, which is idiomatic for _mm_ authors.


$ cat ATTIC/Pt-2-blues.mm
.nr Pt 2
.H 1 "Heading Two"
P12 not indented.
.P
P13 indented.
$ nroff -mm ATTIC/Pt-2-blues.mm | cat -s

   ‐ 1 ‐

   1.  Heading Two

   P12 not indented.

   P13 indented.



_groff_ 1.22.4 got this right (but not indentation suppression after lists and
displays).

I have a fix in preparation.







___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/