[bug #65901] [gropdf] unable to render ellipse with dashed/dotted atribute

2024-06-22 Thread Deri James
Follow-up Comment #5, bug #65901 (group groff):

I don't think bug #44530 is related, that seems to be a misunderstanding what
".PS 1i" does to picture. You may have specified a certain space/dashwid but
the inclusion of .PS 1i has the effect of scaling the whole picture down to 1
inch so everything is reduced proportionally including the spaces, but not it
seems, the linethick setting.

Anyway, I have setup bug #65910, so you can have a look at what I am talking
about. 


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[bug #65910] Some dashed ellipse sizes produce irregular dashes

2024-06-22 Thread Deri James
URL:
  

 Summary: Some dashed ellipse sizes produce irregular dashes
   Group: GNU roff
   Submitter: deri
   Submitted: Sat 22 Jun 2024 07:52:18 PM UTC
Category: Preprocessor pic
Severity: 3 - Normal
  Item Group: Rendering/Cosmetics
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: None


___

Follow-up Comments:


---
Date: Sat 22 Jun 2024 07:52:18 PM UTC By: Deri James 
The attached two pdfs are for an 8x3 inch and a 4x1.5 dashed ellipses, i.e.
one is half the size of the other. One looks lovely and one a mess. Both
produced with this command:-

test-groff -Tpdf -ms -p -P-l file.trf > file.pdf

Changing the output device to -Tps does not make any difference, so I think
this indicates the problem lies in pic, possible variable overflow?






___
File Attachments:


---
Name: 8x3.pdf  Size: 4KiB

---
Name: 4x1.5.pdf  Size: 4KiB


AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://git.savannah.nongnu.org/cgit/administration/savane.git/snapshot/savane-3cd0d2c94962908e0e7c31b0cfb957af29c7d567.tar.gz

___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[bug #65901] [gropdf] unable to render ellipse with dashed/dotted atribute

2024-06-22 Thread G. Branden Robinson
Update of bug #65901 (group groff):

 Planned Release:None => 1.24.0 

___

Follow-up Comment #4:

Thanks, Deri!

> when dashed ellipses are very large the dashes are irregular, grops and
gropdf show identical irregularity so I suspect it is a problem in pic.

Bug #44530 might be related, but I'm just guessing.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[bug #65901] [gropdf] unable to render ellipse with dashed/dotted atribute

2024-06-22 Thread Deri James
Update of bug #65901 (group groff):

  Status:None => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #3:

This should be fixed now:-

commit dd63af83c106a6a44dbb15ab36d5f3e211515ca5
Author: Deri James 
Date:   Sat Jun 22 18:33:49 2024 +0100

Fix invalid pdf when using certain sizes of
dashed ellipse in pic.

* src/devices/gropdf/gropdf.pl: For short dashes on flat part
of ellipse some v. small numbers written in form n.nnnE-n which
is invalid for pdfs. Also rather than split each arc always into
4 pieces, split into number of quadrants described between start
and end angle. If arc describes a straight line, use line segment
rather than bezier curve. (grops does this as well)

Fixes https://savannah.gnu.org/bugs/index.php?65901

Thanks to Morten Bo Johansen for reporting this issue.

The problem reported for dotted ellipses could not be reproduced, and the dots
are much easier to see if you include the command "linethick=2" in the
picture.

Although this bug is now closed, and I hate maths, I will be opening a new bug
since when dashed ellipses are very large the dashes are irregular, grops and
gropdf show identical irregularity so I suspect it is a problem in pic.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/