[bug #50770] .PSPIC macro at bottom of page causes unwarranted page break

[G. Branden Robinson]

Follow-up Comment #1, bug #50770 (project groff):

I can reproduce this but I am unable to tell why it's happening.

I'm attaching a diff of groff intermediate output (groff_out(5)) in case that
helps someone with more expertise.

(file #40543)
___

Additional Item Attachment:

File name: bug_50770_groff_out.diff   Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #50921] Minor documentation bug (\D' DX DY' args documented reversed)

[G. Branden Robinson]

Update of bug #50921 (project groff):

 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #50921] Minor documentation bug (\D' DX DY' args documented reversed)

[G. Branden Robinson]

Update of bug #50921 (project groff):

  Status:None => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #50770] .PSPIC macro at bottom of page causes unwarranted page break

[G. Branden Robinson]

Follow-up Comment #3, bug #50770 (project groff):

I think you're right, Deri.

See attachment.

The question now is: is this a bug or a caveat that should be documented
somewhere?

(file #40571)
___

Additional Item Attachment:

File name: savannah-50770-repro.tar.gzSize:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #50770] .PSPIC macro at bottom of page causes unwarranted page break

[G. Branden Robinson]

Update of bug #50770 (project groff):

  Status:None => Confirmed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #50928] configure should fail if "--with-x" given but can't be honored

[G. Branden Robinson]

URL:
  

 Summary: configure should fail if "--with-x" given but can't
be honored
 Project: GNU troff
Submitted by: gbranden
Submitted on: Wed 03 May 2017 01:36:19 PM UTC
Severity: 2 - Minor
  Item Group: None
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: None

___

Details:

If I ask the configure script for something and it cannot honor my request, it
should not exit as if everything is okay, like a configure where X support
_wasn't_ requested.

$ ./configure --prefix=$HOME --program-prefix=local- --with-x
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
[...]
checking for IceConnectionNumber in -lICE... yes
checking for Xaw library and header files... no
checking for Xmu library and header files... no
configure: gxditview and xtotroff won't be built
[...]
config.status: executing depfiles commands

GNU Troff version 1.22.3
--
 Prefix: /home/branden
 Compiler  : gcc -g -O2
 X11 support   : no
 Doc build : yes
--
$ echo $?
0





___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #50016] grog 1.22.3 fails to recognize mom documents.

[G. Branden Robinson]

Update of bug #50016 (project groff):

  Status:None => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

This appears to be fixed in git.  It looks like Bernd Warken, back in 2014,
fixed the problems you identified in your report.

Here's an example on my Debian Stretch system on amd64, where "local-grog" is
grog build from the HEAD of master in groff's git repo.

$ find -name "*.mom" | while read F; do echo $F; local-grog "$F"; done
./contrib/mom/examples/typesetting.mom
man requests found, but file name extension was: mom
groff -T ps -man ./contrib/mom/examples/typesetting.mom
./contrib/mom/examples/letter.mom
groff -T ps ./contrib/mom/examples/letter.mom
./contrib/mom/examples/sample_docs.mom
groff -T ps ./contrib/mom/examples/sample_docs.mom
./contrib/mom/examples/mon_premier_doc.mom
groff -T ps ./contrib/mom/examples/mon_premier_doc.mom
./contrib/mom/examples/mom-pdf.mom
groff -T ps ./contrib/mom/examples/mom-pdf.mom
./doc/automake.mom
groff -T ps -mom ./doc/automake.mom

Here's output from Debian's groff 1.22.3:

$ find -name "*.mom" | while read F; do echo $F; grog "$F"; done
./contrib/mom/examples/typesetting.mom
Undefined subroutine &main::err called at /usr/lib/groff/grog/subs.pl line
995.
./contrib/mom/examples/letter.mom
groff ./contrib/mom/examples/letter.mom
./contrib/mom/examples/sample_docs.mom
groff ./contrib/mom/examples/sample_docs.mom
./contrib/mom/examples/mon_premier_doc.mom
groff ./contrib/mom/examples/mon_premier_doc.mom
./contrib/mom/examples/mom-pdf.mom
groff ./contrib/mom/examples/mom-pdf.mom
./doc/automake.mom
groff -mom ./doc/automake.mom

This is pretty gross and it would be nice if we could do a release soon to get
this fix out into the world.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #50015] want papersize.tmac to accept custom page sizes via the -dpaper=xxx option

[G. Branden Robinson]

Update of bug #50015 (project groff):

Severity:  3 - Normal => 1 - Wish   
  Item Group: Incorrect behaviour => Wishlist   
 Summary: groff does not accept custom pagesizes from the
-dpaper=xxx option => want papersize.tmac to accept custom page sizes via the
-dpaper=xxx option


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #49953] shading a box with rounded corners doesn't work

[G. Branden Robinson]

Update of bug #49953 (project groff):

  Status:None => Need Info  

___

Follow-up Comment #1:

I'm a newcomer to pic.  Can you comment on the attachment and describe how it
differs from your expectations?

What I see is every box shaded red to its be they right-angle or rounded.

(file #40573)
___

Additional Item Attachment:

File name: savannah-49953-repro.tar.gzSize:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #50786] Font generation in font/devpdf broken with ghostscript 9.21

[G. Branden Robinson]

Follow-up Comment #12, bug #50786 (project groff):

Werner:

My God, you're right!

https://www.gnu.org/prep/standards/html_node/Quote-Characters.html

Wow, I've been annoyed with RMS for many years, wrongly it seems!

So _many_ GNU tools use these hideous unbalanced glyphs, abusing the grave
accents as an ersatz quotation mark, that I thought it was part of the GNU
Coding Standards to do so.

Thanks for the pointer to this resource.  Eventually we may get the lances out
of people's eyes.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51054] groff_www(7): Remove a repeated word

[G. Branden Robinson]

Update of bug #51054 (project groff):

  Status:None => Confirmed  
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51054] groff_www(7): Remove a repeated word

[G. Branden Robinson]

Update of bug #51054 (project groff):

  Status:   Confirmed => Fixed  

___

Follow-up Comment #1:

Fixed in commit 12a5b0b0059dad532947a3ee72c0e697cb5b4971.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51054] groff_www(7): Remove a repeated word

[G. Branden Robinson]

Update of bug #51054 (project groff):

 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

Re: grog doesn't detect files that contain .so

[G. Branden Robinson]

At 2017-06-29T22:00:10+0300, Eli Zaretskii wrote:
> Anyway, thanks for confirming my fears about 'grog'.  Is there any
> similar (but working) utility anywhere that you can recommend?

There's lexgrog in the man-db distribution, but I cannot speak for
Ingo's view of its quality.

Regards,
Branden


signature.asc
Description: PGP signature
___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51541] [PATCH] info: Fix some spelling mistakes

[G. Branden Robinson]

Follow-up Comment #1, bug #51541 (project groff):

-The @code{eqn} preprocessor allowed mathematical formulæ to be specified
+The @code{eqn} preprocessor allowed mathematical formulas to be specified

This is not a spelling error, though the use of the æ ligature is in my
opinion a bit of an affectation.  More importantly, it invites character
set/encoding problems.

"Formulae" is a valid plural for "formula" in standard English.

http://grammarist.com/usage/formulas-vs-formulae/

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51071] groff(7): Add a reference to "groff_tmac(5)" about diversions

[G. Branden Robinson]

Update of bug #51071 (project groff):

Category:None => Core   
  Item Group:None => Documentation  
  Status:None => In Progress
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51071] groff(7): Add a reference to "groff_tmac(5)" about diversions

[G. Branden Robinson]

Update of bug #51071 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51076] doc/pic.ms: Remove a repeated word ("the"), untangle, and protect '.' in " ."

[G. Branden Robinson]

Update of bug #51076 (project groff):

Category:None => Preprocessor pic   
  Item Group:None => Documentation  
  Status:None => In Progress
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51076] doc/pic.ms: Remove a repeated word ("the"), untangle, and protect '.' in " ."

[G. Branden Robinson]

Update of bug #51076 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51109] PATCH: an-ext.tmac: Add definitions of strings "la" and "re" for "nroff"

[G. Branden Robinson]

Update of bug #51109 (project groff):

  Status:None => Need Info  
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51397] [PATCH] tty.tmac: Add characters \[la] and \[ra]

[G. Branden Robinson]

Follow-up Comment #2, bug #51397 (project groff):

Hi Bjarni,

Are you sure this isn't a problem with your terminal emulator or installed
fonts for the window system?

I can get left and right angle brackets easily with a UTF-8 environment on an
xterm.

$ cat lara.man 
.TH foobar 1 x y z
.SH NAME
foobar \- bar for foo
.SH DESCRIPTION
\[la]place description here\[ra]


$ MANWIDTH=80 man -l -Tutf8 ./lara.man 
foobar(1)  z
foobar(1)



NAME
   foobar - bar for foo

DESCRIPTION
   ⟨place description here⟩



y  x
foobar(1)


It also degrades to ASCII for more primitive environments.


$ MANWIDTH=80 man -l -Tascii ./lara.man 
foobar(1)  z
foobar(1)



NAME
   foobar - bar for foo

DESCRIPTION
   



y  x
foobar(1)


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51417] [PATCH] www.tmac.in: Change the font name 'C' to 'CR' and define 'CR'

[G. Branden Robinson]

Update of bug #51417 (project groff):

Category:None => Macro - others 
  Status:None => In Progress
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51397] [PATCH] tty.tmac: Add characters \[la] and \[ra]

[G. Branden Robinson]

Update of bug #51397 (project groff):

Category:None => Macro - others 
  Status:None => Need Info  
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51426] [PATCH] manuals: Change reference to font 'C' to 'CR'

[G. Branden Robinson]

Update of bug #51426 (project groff):

  Status:None => In Progress
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51417] [PATCH] www.tmac.in: Change the font name 'C' to 'CR' and define 'CR'

[G. Branden Robinson]

Update of bug #51417 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51426] [PATCH] manuals: Change reference to font 'C' to 'CR'

[G. Branden Robinson]

Update of bug #51426 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51397] [PATCH] tty.tmac: Add characters \[la] and \[ra]

[G. Branden Robinson]

Follow-up Comment #5, bug #51397 (project groff):

Thanks for the follow-up, gentlemen.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51397] [PATCH] tty.tmac: Add characters \[la] and \[ra]

[G. Branden Robinson]

Update of bug #51397 (project groff):

  Status:   Need Info => Invalid
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51109] PATCH: an-ext.tmac: Add definitions of strings "la" and "ra" for "nroff"

[G. Branden Robinson]

Update of bug #51109 (project groff):

  Status:   Need Info => Invalid
 Open/Closed:Open => Closed 
 Summary: PATCH: an-ext.tmac:  Add definitions of strings "la"
and "re" for "nroff" => PATCH: an-ext.tmac:  Add definitions of strings "la"
and "ra" for "nroff"


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51945] [PATCH] pdfpic.tmac: The first use of register '.C' must be in the old style

[G. Branden Robinson]

Update of bug #51945 (project groff):

Category:None => Macro - others 
  Status:None => In Progress
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51945] [PATCH] pdfpic.tmac: The first use of register '.C' must be in the old style

[G. Branden Robinson]

Update of bug #51945 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #50015] want papersize.tmac to accept custom page sizes via the -dpaper=xxx option

[G. Branden Robinson]

Update of bug #50015 (project groff):

Category:None => Macro - others 


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #50971] Automate copyright years update

[G. Branden Robinson]

Follow-up Comment #1, bug #50971 (project groff):

In principle, shouldn't this only be to done files that have seen changes
since the last year update that are eligible for copyright?

See, e.g., https://en.wikipedia.org/wiki/Threshold_of_originality .

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #50990] [Patch] groff.7: Put a paragraph about "groff.info" at the beginning

[G. Branden Robinson]

Update of bug #50990 (project groff):

  Item Group:None => Documentation  
  Status:None => In Progress


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #50990] [Patch] groff.7: Put a paragraph about "groff.info" at the beginning

[G. Branden Robinson]

Update of bug #50990 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51078] src: Remove repeated words in files

[G. Branden Robinson]

Update of bug #51078 (project groff):

  Status:None => In Progress
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51078] src: Remove repeated words in files

[G. Branden Robinson]

Update of bug #51078 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51611] [PATCH] refer-mm.tmac: Protect full stop

[G. Branden Robinson]

Update of bug #51611 (project groff):

  Item Group:None => Incorrect behaviour
  Status:None => In Progress
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51611] [PATCH] refer-mm.tmac: Protect full stop

[G. Branden Robinson]

Update of bug #51611 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #50971] Automate copyright years update

[G. Branden Robinson]

Follow-up Comment #3, bug #50971 (project groff):

Thanks, Werner. I should have RTFMed.

This approach is a bit "reachy" for my taste but on the other hand it saves
the FSF from having to litigate the threshold of originality with all of its
own maintainers. It's a rabbit hole for sure...

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51610] [PATCH] m.tmac: Some formatting and textual fixes

[G. Branden Robinson]

Update of bug #51610 (project groff):

  Status:None => In Progress
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51610] [PATCH] m.tmac: Some formatting and textual fixes

[G. Branden Robinson]

Update of bug #51610 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51609] [PATCH] src: hdtbl.tmac-u: Fix one formatting and one bug

[G. Branden Robinson]

Update of bug #51609 (project groff):

Category:None => Macro - others 
  Status:None => Need Info  

___

Follow-up Comment #1:

I see neither an attachment nor a non-blank "original submission" to this bug.
Is the problem on my end?

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51609] [PATCH] src: hdtbl.tmac-u: Fix one formatting and one bug

[G. Branden Robinson]

Update of bug #51609 (project groff):

  Status:   Need Info => None   

___

Follow-up Comment #4:

Thanks, Bjarni!

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51609] [PATCH] src: hdtbl.tmac-u: Fix one formatting and one bug

[G. Branden Robinson]

Update of bug #51609 (project groff):

  Status:None => In Progress
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51609] [PATCH] src: hdtbl.tmac-u: Fix one formatting and one bug

[G. Branden Robinson]

Follow-up Comment #5, bug #51609 (project groff):

Can someone tell me what the point is of having all these string definitions
end with a null comment?

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51609] [PATCH] src: hdtbl.tmac-u: Fix one formatting and one bug

[G. Branden Robinson]

Follow-up Comment #6, bug #51609 (project groff):

By "all these", I mean:

42  .ds t*hl s\"
43  .ds t*vl s\"
44  .ds t*tal l\"
45  .ds t*hal b\"
46  .ds t*val t\"
47  .ds t*ff \\n[.fam]\"
48  .ds t*fst \\n[.f]\"
49  .ds t*fsz 1 1\"
50  .ds t*fgc red4\"
51  .ds t*bgc bisque\"
52  .ds t*bc red4\"

65  .ds t*cptn "".sp .4" \
66  ".t*pv 1.0 1.0" \
67  ".ad l" \
68  "\m[\\*[t*fgc]]Table \\n+[t*cptn]:\0\c\k*"\"

73  .\" for better error messages
74  .ds nth-1 st\"
75  .ds nth-2 nd\"
76  .ds nth-3 rd\"



___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51609] [PATCH] src: hdtbl.tmac-u: Fix one formatting and one bug

[G. Branden Robinson]

Follow-up Comment #7, bug #51609 (project groff):

The cosmetic half of this ticket is fixed in
d0f0f3fffadaa2c28e8aabe919dfbf6ca3a73d61.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51608] [PATCH] om.tmac-u: Fix some mistakes, fix one bug

[G. Branden Robinson]

Follow-up Comment #1, bug #51608 (project groff):

I've fixed all but a few of these problems; unfortunately the ones that remain
are probably exactly the ones that got Bjarni's attention because they make
groff spew warnings.


@@ -221,6 +221,9 @@ end
 .ds PDFHREF.TEXTCOL.DEFAULT 0.0 0.3 0.9
 .nr PDFHREF.VIEW.LEADING.C 3i
 .nr PDFHREF.VIEW.LEADING.T 1i
+.if !r PDFHREF.VIEW.LEADING \{\
+.nr PDFHREF.VIEW.LEADING 0
+.\}
 .nr PDFHREF.VIEW.LEADING.H \n[PDFHREF.VIEW.LEADING]
 \#
 \# 


That seems like it's asking for trouble; if anything ever dereferences the
PDFHREF.VIEW.LEADING or PDHREF.VIEW.LEADING.H registers before redefining
them, and if they do what their names suggest, the resulting text will be "set
solid" with no interline spacing. Won't it?


@@ -264,6 +267,42 @@ end
 .nr #L_MARGIN \n[.o]  \" Tabs, etc require #L_MARGIN
 .cflags 4 /\[en]  \" So slash and en-dashes get broken
 \#
+\# DEFINE UNDEFINED MACROS AND REGISTERS
+\#
+.if !d AUTO_RELOCATE_TOC \{\
+.de AUTO_RELOCATE_TOC
+..
+.\}
+.
+.if !d BREAK_QUOTE \{\
+.de BREAK_QUOTE
+..
+.\}
+.
+.if !d END \{\
+.de END
+..
+.\}
+.
+.if !d INDENT_REFS \{\
+.de INDENT_REFS
+..
+.\}
+.
+.if !d PDF_LINK_COLOR \{\
+.de PDF_LINK_COLOR
+..
+.\}
+.
+.if !d pdfview \{\
+.de pdfview
+..
+.\}
+.
+.if !r #EN_Q_AUTOLEAD \{\
+.nr #EN_Q_AUTOLEAD 0
+.\}
+\#


I'd like to run these by Peter Schaffter.  There seems to be some assumption
that pdf.tmac or pdfmark.tmac will already be loaded.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51608] [PATCH] om.tmac-u: Fix some mistakes, fix one bug

[G. Branden Robinson]

Update of bug #51608 (project groff):

  Status:None => Need Info  
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51609] [PATCH] src: hdtbl.tmac-u: Fix one formatting and one bug

[G. Branden Robinson]

Update of bug #51609 (project groff):

  Status: In Progress => Need Info  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51598] [PATCH] test-groff.in: Add directories to the search path for "tmac" files

[G. Branden Robinson]

Update of bug #51598 (project groff):

  Status:None => Need Info  
 Assigned to:None => gbranden   

___

Follow-up Comment #1:

This is another one where Savannah ate Bjarni's content.

Bjarni, please follow up.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51588] [PATCH] src: col_rowspan_colors.roff: variable must be an odd integer

[G. Branden Robinson]

Update of bug #51588 (project groff):

  Status:None => In Progress
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51588] [PATCH] src: col_rowspan_colors.roff: variable must be an odd integer

[G. Branden Robinson]

Update of bug #51588 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51568] gropdf: Bug when string '\e014' is in the input

[G. Branden Robinson]

Update of bug #51568 (project groff):

  Status:None => Fixed  
 Assigned to:None => deri   

___

Follow-up Comment #8:

Reported fixed in git HEAD.

commit eaf4526d8c3d52a46f95bdfc06ac692f9d5b424f
Author: Deri James 
Date:   Fri Aug 4 00:56:22 2017 +0100

See bug at: https://savannah.gnu.org/bugs/?51568

* src/devices/gropdf/gropdf: Further 'fix' to handle those octal
characters. See comment #5 - thank you Bjarni.

commit 6a241192be60d0cc1a2ab5464281e297b2c0243d
Author: Deri James 
Date:   Mon Jul 31 17:02:02 2017 +0100

See bug at: https://savannah.gnu.org/bugs/?51568

* src/devices/gropdf/gropdf: previous 'fix' was too narrow, all
'\' characters should be escaped. Also there was an unwanted
interaction with code in routine 'do_t'. Sometimes, do_C, when
the named glyph is mapped to a chr < 32, this is encoded as
octal \nnn, so in this case the '\' must not be escaped.

commit 67c3d46d452ce05082839920a8058091a8797583
Author: Deri James 
Date:   Tue Jul 25 16:43:54 2017 +0100

If input text contained string which could be interpreted as
escaped octal (\ddd) a pdf viewer would interpret as an octal
character.  See bug at: https://savannah.gnu.org/bugs/?51568

* src/devices/gropdf/gropdf: protect text which resembles \ddd
by escaping with extra '\'.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51588] [PATCH] src: col_rowspan_colors.roff: variable must be an odd integer

[G. Branden Robinson]

Follow-up Comment #1, bug #51588 (project groff):

Fixed in e44909563c634c45e0ebc813e6e6d539a17030ed.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51541] [PATCH] info: Fix some spelling mistakes

[G. Branden Robinson]

Update of bug #51541 (project groff):

  Status:None => Fixed  
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51540] [PATCH] Fix some spelling mistakes in source

[G. Branden Robinson]

Update of bug #51540 (project groff):

  Status:None => Fixed  
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51502] [PATCH] manuals: minor textual fixes

[G. Branden Robinson]

Update of bug #51502 (project groff):

  Status:None => Need Info  
 Assigned to:None => gbranden   

___

Follow-up Comment #5:

Comment #3 appears to be blank. Did Savannah eat something?

Can you re-supply the patch that would have been there?

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51609] [PATCH] src: hdtbl.tmac-u: Fix one formatting and one bug

[G. Branden Robinson]

Update of bug #51609 (project groff):

  Status:   Need Info => In Progress

___

Follow-up Comment #9:

Thanks, Werner. I guess I should mention that I was aware of that, but we have
git these days shouting warnings at us if we add trailing whitespace to lines,
and the practice is not consistently followed in the file.  So I was not
sure.

$ grep -nE '^\.\s+ds' contrib/hdtbl/hdtbl.tmac-u | grep -v '"$'
114:.  ds t*FN \\[.F]
115:.  ds t*LN \\[.c]
172:.ds t*bc\\n[t*#]
182:.ds width
248:.ds *a\\n[t*#]
288:.  ds #t#r \\n[t*#]*\\n[t*r#\\n[t*#]]\" table row identifier
343:.  ds *#trc* \\*[#t#r]*\\n[c#\\*[#t#r]]\"   table cell identifier
410:.ds *
451:.  ds #t#r \\n[t*#]*\\n[t*r#\\n[t*#]]\" refresh table row
identifier
824:.  ds #t#r \\n[t*#]*\\n[t*r#\\n[t*#]]\" refresh table row
identifier


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51695] [PATCH] groff.texi: Some textual and formatting changes

[G. Branden Robinson]

Update of bug #51695 (project groff):

  Status:None => In Progress
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51609] [PATCH] src: hdtbl.tmac-u: Fix one formatting and one bug

[G. Branden Robinson]

Update of bug #51609 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51695] [PATCH] groff.texi: Some textual and formatting changes

[G. Branden Robinson]

Update of bug #51695 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51327] [Patch] Manuals: Split lines > 80 characters into more lines

[G. Branden Robinson]

Follow-up Comment #1, bug #51327 (project groff):

As noted in #51441, this patch introduces a space character where one should
not be, in the first hunk of the patch to groff_out.5.man.

Caveat committer.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51441] [PATCH] groff_out.5.man: Remove a space character in front of '..'

[G. Branden Robinson]

Update of bug #51441 (project groff):

  Status:None => Invalid
 Assigned to:None => gbranden   
 Open/Closed:Open => Closed 

___

Follow-up Comment #3:

Closing this as invalid since it doesn't actually apply to the git repo or a
released version.

I did add a comment to #51327 telling whoever reviews that patch (probably me)
to watch out and not lead the space sneak in.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51327] [Patch] Manuals: Split lines > 80 characters into more lines

[G. Branden Robinson]

Follow-up Comment #2, bug #51327 (project groff):

Also note this fix to the patch:


>From cb6936f2eaa7b9ef0b119dc7a385f38470c3e9c1 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason 
Date: Tue, 11 Jul 2017 13:49:44 +
Subject: [PATCH] groff_diff.7.man: Fix splitting of lines in bug #51327

  This fixes some wrong use of an escape type to splitt lines in commit
'a918d83ec'.

Signed-off-by: Bjarni Ingi Gislason 
---
 man/groff_diff.7.man | 11 +--
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/man/groff_diff.7.man b/man/groff_diff.7.man
index 17117dd9..db8f4684 100644
--- a/man/groff_diff.7.man
+++ b/man/groff_diff.7.man
@@ -3506,9 +3506,8 @@ delim $$
 .EN
 .
 .TP
-\f[B]Dp\f[R] $dx sub 1$ $dy sub 1$ $dx sub 2$ $dy sub 2$ $...$ \
+\f[B]Dp\f[R] $dx sub 1$ $dy sub 1$ $dx sub 2$ $dy sub 2$ $...$ \c
 $dx sub n$ $dy sub n$\[rs]n
-
 Draw a polygon with, for $i = 1 ,..., n+1$, the
 .IR i -th
 vertex at the current position
@@ -3519,7 +3518,7 @@ At the moment, GNU pic only uses this command to
generate triangles
 and rectangles.
 .
 .TP
-\f[B]DP\f[R] $dx sub 1$ $dy sub 1$ $dx sub 2$ $dy sub 2$ $...$ $dx sub n$ \
+\f[B]DP\f[R] $dx sub 1$ $dy sub 1$ $dx sub 2$ $dy sub 2$ $...$ $dx sub n$ \c
 $dy sub n$\[rs]n
 .
 Like
@@ -3552,8 +3551,8 @@ does not depend on this.
 .
 Given a drawing command of the form
 .IP
-\f[B]\[rs]D'\f[I]c\f[R] $x sub 1$ $y sub 1$ $x sub 2$ $y sub 2$ $...$ $x \
-sub n$ $y sub n$\f[B]'\f[R]
+\f[B]\[rs]D'\f[I]c\f[R] $x sub 1$ $y sub 1$ $x sub 2$ $y sub 2$ $...$
+$x sub n$ $y sub n$\f[B]'\f[R]
 .
 .P
 where
@@ -3596,7 +3595,7 @@ Thus after executing a
 .BR D \~\c
 command of the form
 .IP
-\f[B]D\f[I]c\f[R] $x sub 1$ $y sub 1$ $x sub 2$ $y sub 2$ $...$ $x sub n$ \
+\f[B]D\f[I]c\f[R] $x sub 1$ $y sub 1$ $x sub 2$ $y sub 2$ $...$ $x sub n$
 $y sub n$\[rs]n
 .
 .P
-- 
2.13.2




___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51440] [PATCH] groff_diff.7.man: Fix splitting of lines in bug #51327

[G. Branden Robinson]

Update of bug #51440 (project groff):

  Status:None => Invalid
 Assigned to:None => gbranden   
 Open/Closed:Open => Closed 

___

Follow-up Comment #3:

#51327 updated with your diff.

Closing this one as invalid (inapplicable to git HEAD or any release).

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #50990] [Patch] groff.7: Put a paragraph about "groff.info" at the beginning

[G. Branden Robinson]

Update of bug #50990 (project groff):

 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51608] [PATCH] om.tmac-u: Fix some mistakes, fix one bug

[G. Branden Robinson]

Follow-up Comment #3, bug #51608 (project groff):

Thanks for the feedback, Peter!

I can reproduce these warnings if I prepare a simple document and import the
mom macros "by hand", not messing with pdfroff and similar.

Is that no longer a valid use case for the mom macros?  It seems to me like it
still could be.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51502] [PATCH] manuals: minor textual fixes

[G. Branden Robinson]

Update of bug #51502 (project groff):

  Status:   Need Info => In Progress

___

Follow-up Comment #7:

Thanks, Bjarni.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51598] [PATCH] test-groff.in: Add directories to the search path for "tmac" files

[G. Branden Robinson]

Update of bug #51598 (project groff):

  Status:   Need Info => In Progress

___

Follow-up Comment #3:

Thanks, Bjarni!

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51609] [PATCH] src: hdtbl.tmac-u: Fix one formatting and one bug

[G. Branden Robinson]

Follow-up Comment #11, bug #51609 (project groff):

Thanks, Werner.  I've fixed the two stragglers.


commit 19a0a27582d9680537641589b47c6214ee74928e
Author: G. Branden Robinson 
Date:   Thu Nov 2 02:53:21 2017 -0400

hdtbl.tmac-u: Terminate string defs with comment.

Per Werner Lemberg and for consistency with the rest of the package,
which is otherwise scrupulous about this (80 out of 82 string defs).

String undefs were left alone.

See Savannah #51609 for discussion.

Signed-off-by: G. Branden Robinson 

diff --git a/contrib/hdtbl/hdtbl.tmac-u b/contrib/hdtbl/hdtbl.tmac-u
index a6b2bf37..822ca6cc 100644
--- a/contrib/hdtbl/hdtbl.tmac-u
+++ b/contrib/hdtbl/hdtbl.tmac-u
@@ -111,8 +111,8 @@ along with this program.  If not, see
<http://www.gnu.org/licenses/>.
 .  nr t*# +1
 .
 .  \" Save current location for error checking at end
-.  ds t*FN \\[.F]
-.  ds t*LN \\[.c]
+.  ds t*FN \\[.F]\"
+.  ds t*LN \\[.c]\"
 .
 .  t*getarg cols \\$@\"from here string `args' contains the rest of
\\$@
 .  ie "\\*[cols]"" \


___

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51609>

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51598] [PATCH] test-groff.in: Add directories to the search path for "tmac" files

[G. Branden Robinson]

Update of bug #51598 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51502] [PATCH] manuals: minor textual fixes

[G. Branden Robinson]

Update of bug #51502 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51483] [PATCH] Warning from the gcc compiler

[G. Branden Robinson]

Update of bug #51483 (project groff):

  Item Group:None => Build/Installation 


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #52374] src: Migrate diagnostic messages away from `quotes like this'

[G. Branden Robinson]

URL:
  

 Summary: src: Migrate diagnostic messages away from `quotes
like this'
 Project: GNU troff
Submitted by: gbranden
Submitted on: Thu 09 Nov 2017 12:01:26 PM UTC
Category: None
Severity: 3 - Normal
  Item Group: Wishlist
  Status: In Progress
 Privacy: Public
 Assigned to: gbranden
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: None

___

Details:

Recently (and at long last) GNU tools have begun migrating away from using
grave accents and apostrophes as if they were mirror-symmetrical quotation
marks.

For example, GNU diff has stayed within ASCII and simple uses "straight"
single quotes (apostrophes) to mark literals within diagnostics:


diff: missing operand after 'nonexistent'
diff: Try 'diff --help' for more information.


GCC has gone even further and uses actual Unicode quotation marks.


src/devices/grolbp/lbp.cpp: In member function ‘void
lbp_printer::setfillmode(int)’:
src/devices/grolbp/lbp.cpp:390:5: warning: this ‘else’ clause does not
guard... [-Wmisleading-indentation]
 else
 ^~~~
src/devices/grolbp/lbp.cpp:393:7: note: ...this statement, but the latter is
misleadingly indented as if it is guarded by the ‘else’
   fill_mode = mode;
   ^


As groff does not appear to be internationalized, and local detection and
message catalogs would be necessary to quote in the GCC style, I propose to
follow GNU diff's example.




___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #52374] src: Migrate diagnostic messages away from `quotes like this'

[G. Branden Robinson]

Follow-up Comment #2, bug #52374 (project groff):

Thanks, Werner!

In a fit of optimism, I am already under way.

I haven't managed to break the build yet, and I've hit every subdirectory of
src except preproc.

I sure do wish we had a test suite that exercised all the error and warning
paths in src/roff/troff/input.cpp, though.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #52374] src: Migrate diagnostic messages away from `quotes like this'

[G. Branden Robinson]

Update of bug #52374 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #52335] src: Some warnings from the compiler that need fixing or explanations in the code

[G. Branden Robinson]

Follow-up Comment #1, bug #52335 (project groff):

Hi Bjarni,

I believe fall-through is the correct behavior for groff.cpp, line 295.

However, I don't have GCC 7 handy.  Can you test the following patch, please?


diff --git a/src/roff/groff/groff.cpp b/src/roff/groff/groff.cpp
index 46cbf018..ef654f6d 100644
--- a/src/roff/groff/groff.cpp
+++ b/src/roff/groff/groff.cpp
@@ -293,6 +293,7 @@ int main(int argc, char **argv)
   break;
 case 'o':
   oflag = 1;
+  __attribute__ ((fallthrough));
 case 'f':
 case 'm':
 case 'r':


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #52335] src: Some warnings from the compiler that need fixing or explanations in the code

[G. Branden Robinson]

Follow-up Comment #2, bug #52335 (project groff):

I think the instances in 
src/preproc/grn/hdb.cpp are false positives as well.

We might be able to silence this warning by decorating fatal_error_exit() in
src/libs/libgroff/fatal.cpp with __attribute__(noreturn), but I'm not
positive.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #52335] src: Some warnings from the compiler that need fixing or explanations in the code

[G. Branden Robinson]

Update of bug #52335 (project groff):

  Status:None => Need Info  

___

Follow-up Comment #3:

The following quiets the sized-deallocation warning, but the most obvious
solution (to me) causes a different warning.

Comments welcome.


diff --git a/src/libs/libgroff/new.cpp b/src/libs/libgroff/new.cpp
index 7a1a4730..dc2580f4 100644
--- a/src/libs/libgroff/new.cpp
+++ b/src/libs/libgroff/new.cpp
@@ -67,3 +67,22 @@ void operator delete(void *p)
 free(p);
 #endif /* COOKIE_BUG */
 }
+
+void operator delete(void *p,
+__attribute__((__unused__)) long unsigned int size)
+{
+  // It's ugly to duplicate the code from delete(void *) above, but if
+  // we don't, g++ 6.3 can't figure out we're calling through it to
+  // free().
+  //
+  // In function 'void operator delete(void*, long unsigned int)':
+  //   warning: deleting 'void*' is undefined [-Wdelete-incomplete]
+  //delete p;
+#ifdef COOKIE_BUG
+  if (p)
+free((void *)((char *)p - 8));
+#else
+  if (p)
+free(p);
+#endif /* COOKIE_BUG */
+}


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #52333] PATCH] om.tmac-u: Compatibility mode demands either name '(.C' or '.do ...'

[G. Branden Robinson]

Update of bug #52333 (project groff):

  Status:None => In Progress
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #52333] PATCH] om.tmac-u: Compatibility mode demands either name '(.C' or '.do ...'

[G. Branden Robinson]

Update of bug #52333 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51646] [PATCH] src: Remove bloody empty space at end of lines

[G. Branden Robinson]

Follow-up Comment #2, bug #51646 (project groff):

Closing as "won't fix" per Bertrand's response.  However I share Bjarni's
antipathy for junky trailing whitespace, and plan to clean it up wherever I
can, collaterally with more substantive changes.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51646] [PATCH] src: Remove bloody empty space at end of lines

[G. Branden Robinson]

Update of bug #51646 (project groff):

  Status:None => Wont Fix   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51513] [PATCH] src: Add missing prototypes

[G. Branden Robinson]

Update of bug #51513 (project groff):

  Status:None => Need Info  
 Assigned to:None => gbranden   

___

Follow-up Comment #3:

Comment #1 is missing its content.  Bjarni, can you provide the missing piece?

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51483] [PATCH] Warning from the gcc compiler

[G. Branden Robinson]

Update of bug #51483 (project groff):

  Status:None => In Progress
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51483] [PATCH] gcc warns of misleading indentation

[G. Branden Robinson]

Update of bug #51483 (project groff):

 Summary: [PATCH]  Warning from the gcc compiler => [PATCH] 
gcc warns of misleading indentation


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #52333] [PATCH] om.tmac-u: Compatibility mode demands either name '(.C' or '.do ...'

[G. Branden Robinson]

Update of bug #52333 (project groff):

 Summary: PATCH] om.tmac-u: Compatibility mode demands either
name '(.C' or '.do ...' => [PATCH] om.tmac-u: Compatibility mode demands
either name '(.C' or '.do ...'


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51482] [PATCH] test-groff.in; troff.1.man: Add options for warnings and backtrace; change "-w all" to " -ww"

[G. Branden Robinson]

Update of bug #51482 (project groff):

 Summary: PATCH] test-groff.in; troff.1.man: Add options for
warnings and  backtrace; change "-w all" to " -ww" => [PATCH] test-groff.in;
troff.1.man: Add options for warnings and  backtrace; change "-w all" to "
-ww"


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51513] [PATCH] src: Add missing prototypes

[G. Branden Robinson]

Update of bug #51513 (project groff):

  Status:   Need Info => In Progress

___

Follow-up Comment #5:

Ah, I see, you reposted it as comment #2, without comment. :P

Thanks!

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51513] [PATCH] src: Add missing prototypes

[G. Branden Robinson]

Update of bug #51513 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51483] [PATCH] gcc warns of misleading indentation

[G. Branden Robinson]

Update of bug #51483 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #52335] src: Some warnings from the compiler that need fixing or explanations in the code

[G. Branden Robinson]

Follow-up Comment #6, bug #52335 (project groff):

I've pushed fixes for all of these except the sized destructor problem, for
which I'm turning to the mailing list for help.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #52335] src: Some warnings from the compiler that need fixing or explanations in the code

[G. Branden Robinson]

Update of bug #52335 (project groff):

  Status:   Need Info => Fixed  
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51482] [PATCH] test-groff.in; troff.1.man: Add options for warnings and backtrace; change "-w all" to " -ww"

[G. Branden Robinson]

Update of bug #51482 (project groff):

  Status:None => In Progress
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51482] [PATCH] test-groff.in; troff.1.man: Add options for warnings and backtrace; change "-w all" to " -ww"

[G. Branden Robinson]

Follow-up Comment #2, bug #51482 (project groff):

The part of this that applies to troff(1) is a duplicate of Savannah #47784,
according to Bertrand's commit 8ca41399a2449fe5d619a6edd292c127c891f4e7 (28
August).

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51482] [PATCH] test-groff.in: Add options enabling warnings and backtrace

[G. Branden Robinson]

Update of bug #51482 (project groff):

 Summary: [PATCH] test-groff.in; troff.1.man: Add options for
warnings and  backtrace; change "-w all" to " -ww" => [PATCH] test-groff.in:
Add options enabling warnings and backtrace


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #51482] [PATCH] test-groff.in: Add options enabling warnings and backtrace

[G. Branden Robinson]

Update of bug #51482 (project groff):

  Status: In Progress => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #52442] groff_mdoc(7): Refer to unstripped symbol names.

[G. Branden Robinson]

URL:
  <http://savannah.gnu.org/bugs/?52442>

 Summary: groff_mdoc(7): Refer to unstripped symbol names.
 Project: GNU troff
Submitted by: gbranden
Submitted on: Sun 19 Nov 2017 03:20:00 AM UTC
Category: Macro - mdoc
Severity: 3 - Normal
  Item Group: Documentation
  Status: In Progress
 Privacy: Public
 Assigned to: gbranden
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: None

___

Details:

The following commit caused some damage, since groff_mdoc(7) assumed the mdoc
symbol names it used were stripped of their "doc-" prefixes.


commit ec303ca205c6471a95d0e874cbea3baba5a76f4b
Author: G. Branden Robinson 
Date:   Sun Nov 12 09:03:35 2017 -0500

* tmac/strip.sed: Stop rewriting symbol names.

A substitution originally intended to strip the "doc-" prefix off of
mdoc macro and string names unintentionally caught some mom stuff.
Harmlessly in this instance, but with potentially surprising future
effects.  Remove (only) this substitution per discussion in
https://lists.gnu.org/archive/html/groff/2017-11/msg00055.html et
sequentia.

Also migrate comments (in both sed _and_ roff syntax) away from
`quotes'.
    
Signed-off-by: G. Branden Robinson 


I have a fix ready and am preparing to commit and push.




___

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52442>

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff