[bug #53243] regression: .hy not working in latest groff build

[G. Branden Robinson]

Follow-up Comment #5, bug #53243 (project groff):


[comment #4 comment #4:]
> [comment #3 comment #3:]
> > Nothing in the tree or commit history explicitly mentions this bug
> 
> The commit message for commit b5aaab51
 is very
terse, but its associated ChangeLog entry does mention fixing this bug.

Ah, somehow I overlooked that.  I probably transposed digits when grepping. 
Thanks, Dave!


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #53243] regression: .hy not working in latest groff build

[Dave]

Follow-up Comment #4, bug #53243 (project groff):

[comment #3 comment #3:]
> Nothing in the tree or commit history explicitly mentions this bug

The commit message for commit b5aaab51
 is very
terse, but its associated ChangeLog entry does mention fixing this bug.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #53243] regression: .hy not working in latest groff build

[G. Branden Robinson]

Update of bug #53243 (project groff):

Category:None => Core   

___

Follow-up Comment #3:

Nothing in the tree or commit history explicitly mentions this bug, but it
seems likely that bug #53196 and this one were fixed together.


commit 4b299723a61cfa2dc8ff57224d681b42e5d10ded
Author: Werner Lemberg 
Date:   Fri Mar 2 18:56:42 2018 +0100

Hyphenation exceptions in pattern files now obey `.hy' (#53196).

* src/roff/troff/env.cpp (hyphen_trie::read_patterns_file): Mark
`\hyphenation' entries with a trailing space.
(hyphen_trie::insert_hyphenation): Updated.
(hyphenate): Make `\hyphenation' entries obey `.hy' restrictions.

* doc/groff.texi (.hy): Updated.



___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #53243] regression: .hy not working in latest groff build

[Dave]

Follow-up Comment #2, bug #53243 (project groff):

Yes, it works now.  Thank you!

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #53243] regression: .hy not working in latest groff build

[Werner LEMBERG]

Update of bug #53243 (project groff):

  Status:None => Fixed  
 Assigned to:None => wl 
 Open/Closed:Open => Closed 
 Planned Release:None => 1.22.4 


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #53243] regression: .hy not working in latest groff build

[Werner LEMBERG]

Follow-up Comment #1, bug #53243 (project groff):

Should be fixed now in git, please test.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff

[bug #53243] regression: .hy not working in latest groff build

[Dave]

URL:
  

 Summary: regression: .hy not working in latest groff build
 Project: GNU troff
Submitted by: barx
Submitted on: Tue 27 Feb 2018 07:33:52 PM CST
Category: None
Severity: 3 - Normal
  Item Group: Incorrect behaviour
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: None

___

Details:

Bjarni Ingi Gislason pointed out this bug in a comment in bug #53196.  That
bug documents a different (but related) issue, so I'm opening up this new bug
report.  As this is a regression since the last release, this should be
addressed before the new version of groff is released.

The problem is that .hy values 4 and 8 seem not to be honored anymore.  I've
confirmed that ".hy 8" works in the official groff release, but not in the
latest code built from git.  I've not yet backtracked to see which commit
introduced the bug.

Three lines of groff input illustrate this:

groff -a << EOF
.hy 8
.ll 1i
He is a skilled acrobat.
EOF

Running this on a groff built from current git code produces:


He is a skilled ac
robat.

".hy 8" should prevent the word "acrobat" from being hyphenated after two
characters.  And indeed, when run on the latest released groff, it does so,
pushing the whole word onto the next line.

(Bjarni's proposed solution is to remove these two values from groff's .hy
documentation and emit a warning if the user uses them.  However, a change to
functionality that has been documented and working in groff for two decades
needs to be discussed on the groff email list before being implemented.  I
will leave it to Bjarni to initiate this discussion if he feels that is the
best way to proceed.)




___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
bug-groff mailing list
bug-groff@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-groff