[bug #65112] [gropdf] glyphs missing from groff_char(7) but not warned about

[G. Branden Robinson]

Follow-up Comment #12, bug#65112 (group groff):


commit 7c0358816253817a3594be6402c4b9b7e68db01d
Author: Deri James 
Date:   Sun Jan 7 19:51:35 2024 +

[...]

Also fix incorrect application of patch in bug #65112.

[...]




___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65112] [gropdf] glyphs missing from groff_char(7) but not warned about

[G. Branden Robinson]

Update of bug#65112 (group groff):

  Status: In Progress => Fixed  
 Assigned to:gbranden => deri   
 Open/Closed:Open => Closed 
 Planned Release:None => 1.24.0 

___

Follow-up Comment #11:


commit 6e45bb0bc682e20549ed2d9160cafaeaafbb8c24
Author: Deri James 
Date:   Thu Jan 4 05:29:19 2024 +

[gropdf]: Fix Savannah #65112 (subsetting).

* src/devices/gropdf/gropdf.pl (subs_call): Type 1 fonts have a section
  of numbered subroutines which can be called from the actual glyph
  definition; I have seen over 1000 in some large fonts.  So, when you
  are subsetting you need to subset (and renumber) any relevant
  subroutines used by the glyph you are subsetting.

Fixes .




___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65112] [gropdf] glyphs missing from groff_char(7) but not warned about

[Deri James]

Update of bug#65112 (group groff):

  Status:None => In Progress
 Assigned to:None => gbranden   

___

Follow-up Comment #10:

No, it was not intentional. What sometimes happens is that I open the bug
page, then compose a reply in dasher (which could take quite a while) and
paste it to the open page, meanwhile someone changes the status fields and
when I submit my reply it uses the values they had when I opened the page.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65112] [gropdf] glyphs missing from groff_char(7) but not warned about

[G. Branden Robinson]

Follow-up Comment #9, bug#65112 (group groff):


[comment #8 comment #8:]
> On Bookworm I did this:-

I have that same package installed but apparently its contents are not the
ones that get found on my system.

Did you mean to update/clear the "Status" and "Assigned to" fields?


> derij@raspberrypi5:~ $ dpkg -s fonts-urw-base35
> Package: fonts-urw-base35
> Status: install ok installed
> Priority: optional
> Section: fonts
> Installed-Size: 15558
> Maintainer: Debian Fonts Task Force 
> Architecture: all
> Multi-Arch: foreign
> Version: 20200910-7
> Replaces: gsfonts (<< 2:20200910-2~), gsfonts-x11 (<< 2:20200910-2~)
> Depends: xfonts-utils
> Suggests: fonts-freefont-otf | fonts-freefont-ttf, fonts-texgyre
> Breaks: gsfonts (<< 2:20200910-2~), gsfonts-x11 (<< 2:20200910-2~)
> Conffiles:
>  /etc/X11/fonts/Type1/fonts-urw-base35.alias
32ee9a005b7c7a089bdd5a5c4ee19c89
>  /etc/X11/fonts/Type1/fonts-urw-base35.scale
1027533ffa7574e6b30b528d72287445
>  /etc/ghostscript/fontmap.d/10fonts-urw-base35.conf
a97fb8d980202e59cc253c9c21bb2d30
> Description: font set metric-compatible with the 35 PostScript Level 2 Base
Fonts
>  A commercial-quality set of PostScript Type 1 fonts, metric-compatible
>  with the 35 PostScript Language Level 2 Base Fonts. This package contains
>  outlines in .t1 format and metrics in .afm format of the following fonts:
>  .
>   C059
>   D05L
>   Nimbus Mono PS
>   Nimbus Roman
>   Nimbus Sans
>   Nimbus Sans Narrow
>   P052
>   Standard Symbols PS
>   URW Bookman
>   URW Gothic
>   Z003
>  .
>  This package also makes the fonts available to an X server under both
>  their "urw" names and via fonts.alias under the official "adobe" names.
>  .
>  Extensive remakes of these fonts in the OpenType format are available in
the
>  GUST TeX Gyre collection in the fonts-texgyre package. The Cyrillic glyphs
>  added to the now obsolete urwcyr fork of these fonts have been merged into
>  the GNU FreeFont collection available in the fonts-freefont-otf or
>  fonts-freefont-ttf packages.
> Homepage: https://github.com/ArtifexSoftware/urw-base35-fonts




___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65112] [gropdf] glyphs missing from groff_char(7) but not warned about

[Deri James]

Update of bug#65112 (group groff):

  Status: In Progress => None   
 Assigned to:gbranden => None   

___

Follow-up Comment #8:

On Bookworm I did this:-

derij@raspberrypi5:~ $ dpkg -s fonts-urw-base35
Package: fonts-urw-base35
Status: install ok installed
Priority: optional
Section: fonts
Installed-Size: 15558
Maintainer: Debian Fonts Task Force 
Architecture: all
Multi-Arch: foreign
Version: 20200910-7
Replaces: gsfonts (<< 2:20200910-2~), gsfonts-x11 (<< 2:20200910-2~)
Depends: xfonts-utils
Suggests: fonts-freefont-otf | fonts-freefont-ttf, fonts-texgyre
Breaks: gsfonts (<< 2:20200910-2~), gsfonts-x11 (<< 2:20200910-2~)
Conffiles:
 /etc/X11/fonts/Type1/fonts-urw-base35.alias 32ee9a005b7c7a089bdd5a5c4ee19c89
 /etc/X11/fonts/Type1/fonts-urw-base35.scale 1027533ffa7574e6b30b528d72287445
 /etc/ghostscript/fontmap.d/10fonts-urw-base35.conf
a97fb8d980202e59cc253c9c21bb2d30
Description: font set metric-compatible with the 35 PostScript Level 2 Base
Fonts
 A commercial-quality set of PostScript Type 1 fonts, metric-compatible
 with the 35 PostScript Language Level 2 Base Fonts. This package contains
 outlines in .t1 format and metrics in .afm format of the following fonts:
 .
  C059
  D05L
  Nimbus Mono PS
  Nimbus Roman
  Nimbus Sans
  Nimbus Sans Narrow
  P052
  Standard Symbols PS
  URW Bookman
  URW Gothic
  Z003
 .
 This package also makes the fonts available to an X server under both
 their "urw" names and via fonts.alias under the official "adobe" names.
 .
 Extensive remakes of these fonts in the OpenType format are available in the
 GUST TeX Gyre collection in the fonts-texgyre package. The Cyrillic glyphs
 added to the now obsolete urwcyr fork of these fonts have been merged into
 the GNU FreeFont collection available in the fonts-freefont-otf or
 fonts-freefont-ttf packages.
Homepage: https://github.com/ArtifexSoftware/urw-base35-fonts




___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65112] [gropdf] glyphs missing from groff_char(7) but not warned about

[G. Branden Robinson]

Update of bug#65112 (group groff):

  Status:None => In Progress
 Assigned to:None => gbranden   


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65112] [gropdf] glyphs missing from groff_char(7) but not warned about

[G. Branden Robinson]

Follow-up Comment #7, bug#65112 (group groff):

Hi Deri,

Thanks for the explanation!

I got this ancient version of the Symbol font from this Debian package.


$ dpkg -s gsfonts
Package: gsfonts
Status: install ok installed
Priority: optional
Section: text
Installed-Size: 4439
Maintainer: Masayuki Hatta (mhatta) 
Architecture: all
Multi-Arch: foreign
Version: 1:8.11+urwcyr1.0.7~pre44-4.5
Conflicts: gs (<< 5.50-5), gs-aladdin (<< 6.50-4), gsfonts-x11 (<< 0.13)
Conffiles:
 /etc/ghostscript/fontmap.d/10gsfonts.conf 39b53e1126184b434b52585a113fe125
Description: Fonts for the Ghostscript interpreter(s)
 These are free look-alike fonts of the Adobe PostScript fonts.
 Recommended for all flavors of Ghostscript (gs-gpl, gs-afpl and gs-esp).
Homepage: http://www.ghostscript.com/




___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65112] [gropdf] glyphs missing from groff_char(7) but not warned about

[Deri James]

Follow-up Comment #6, bug#65112 (group groff):

Apologies for the brevity, it was one of those "go to bed and wake up bolt
upright with the answer", just wanted you to confirm the fix was good. Now the
explanation:-

Type 1 fonts have a section of numbered subroutines which can be called from
the actual glyph definition, I have seen over 1000 in some large fonts. So,
when you are subsetting you need to subset (and renumber) any relevent
subroutines used by the glyph you are subsetting.

What went wrong (only with your version of the Symbol font) was that the
required subroutines were not making it to the subsetted font. Usually
including a subroutine is simple: a number is pushed onto the stack and
"callsubr" is called, but in this font it users this form:-

22 1 3 callothersubr
pop
callsubr

The number popped is actually 22 so it is this subroutine which needs to be
included.

It is interesting that of the 4 different versions of the Symbol font I looked
at, it is only the oldest (yours) which used this form:-

Your version:- (s05l.pfb)

%!PS-AdobeFont-1.0: StandardSymL 001.005
%%CreationDate: Thu Oct 21 1999
% Copyright URW Software, Copyright 1997 by URW
% URW Software, Copyright 1997 by URW
% See the file COPYING (GNU General Public License) for license conditions.

Bookworm:- (StandardSymbolsPS)

%!PS-AdobeFont-1.0: StandardSymbolsPS 2.00
%%CreationDate: Tue May 31 2016
% Copyright URW Software, Copyright 2015 by URW
% URW Software, Copyright 2015 by URW

Buster?:- (StandardSymbolsPS)

%!PS-AdobeFont-1.0: StandardSymbolsPS 2.00
%%CreationDate: Tue May 31 2016
% Copyright URW Software, Copyright 2015 by URW
% URW Software, Copyright 2015 by URW

Mageia 9:- (s05l.pfb)

%!PS-AdobeFont-1.0: StandardSymL 001.005_%{version}-%{release}
%%Title: StandardSymL
%Version: 001.005_%{version}-%{release}
%%CreationDate: Wed Mar 30 23:15:51 2022
%%Creator: Unknown
%Copyright: Copyright URW Software, Copyright 1997 by URW
% Generated by FontForge 20201107 (http://fontforge.sf.net/)

I don't know if this will make it onto the website, but it should send the
email. I hope this helps you write a commit message.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

Re: [bug #65112] [gropdf] glyphs missing from groff_char(7) but not warned about

[G. Branden Robinson]

Savannah is still angry (just with me?) so I can't reply to the ticket
via the web interface.[1]

---

Paydirt!

The trig example in _eqn_(1) and the missing glyphs listed in comment #0
are all restored!

I have no idea how to describe the change, though.  Happy to commit with
you as author, but I am slackjawed as to what to write in the
ChangeLog... 

Care to reveal your secret? :D

Regards,
Branden

[1] https://savannah.nongnu.org/support/?111000

At 2024-01-04T00:29:19-0500, Deri James wrote:
> Follow-up Comment #5, bug#65112 (group groff):
> 
> Try this.
> 
> diff --git a/src/devices/gropdf/gropdf.pl b/src/devices/gropdf/gropdf.pl
> index e26bc6b43..d55bc1e00 100644
> --- a/src/devices/gropdf/gropdf.pl
> +++ b/src/devices/gropdf/gropdf.pl
> @@ -4733,7 +4733,11 @@ sub subs_call
>  my $n2=$charstr->[++$j];
>  push(@c,[$n2,0]);
>  
> -if ($n2==6) # seac
> +if ($n2==16)# callothersub
> +{
> +$c[$#c-4]->[0]=MarkSub("#$c[$#c-4]->[0]") if
> ($c[$#c-4]->[1]);
> +}
> +elsif ($n2==6) # seac
>  {
>  my $ch=$StdEnc{$c[$#c-2]->[0]};
>  my $chf;
> 
> 
> 
> 
> ___
> 
> Reply to this item at:
> 
>   
> 
> ___
> Message sent via Savannah
> https://savannah.gnu.org/


signature.asc
Description: PGP signature

[bug #65112] [gropdf] glyphs missing from groff_char(7) but not warned about

[Deri James]

Follow-up Comment #5, bug#65112 (group groff):

Try this.

diff --git a/src/devices/gropdf/gropdf.pl b/src/devices/gropdf/gropdf.pl
index e26bc6b43..d55bc1e00 100644
--- a/src/devices/gropdf/gropdf.pl
+++ b/src/devices/gropdf/gropdf.pl
@@ -4733,7 +4733,11 @@ sub subs_call
 my $n2=$charstr->[++$j];
 push(@c,[$n2,0]);
 
-if ($n2==6) # seac
+if ($n2==16)# callothersub
+{
+$c[$#c-4]->[0]=MarkSub("#$c[$#c-4]->[0]") if
($c[$#c-4]->[1]);
+}
+elsif ($n2==6) # seac
 {
 my $ch=$StdEnc{$c[$#c-2]->[0]};
 my $chf;




___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65112] [gropdf] glyphs missing from groff_char(7) but not warned about

[G. Branden Robinson]

Follow-up Comment #4, bug#65112 (group groff):

[comment #3 comment #3:]
> Ooh, a proper bug. Please can you look in font/devpdf/download file and send
me whichever file is assigned to the Symbol font. I can't duplicate the
problem with three different versions of the Symbol font file but you may have
a fourth.

Sure thing.


$ grep -i symbol build/font/devpdf/download 
Symbol  */usr/share/fonts/type1/gsfonts/s05l.pfb


> I have a suspicion of where the bug probably lies

I'm throwing my money on


4662 if ($sec{"/$n"}->[0] != $i) 
4663 {   
4664 # duplicate glyph name !!! discard ???  
4665 $lines->[$i]=undef; 
4666 }


like a roulette player.  :P

> but I need a font which causes it.

Attached.

(file #55521)

___

Additional Item Attachment:

File name: s05l.pfb   Size:32 KB



AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://git.savannah.nongnu.org/cgit/administration/savane.git/snapshot/savane-64f71c9e61c99f5e0fa8f7988d21ea179eb554bc.tar.gz


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65112] [gropdf] glyphs missing from groff_char(7) but not warned about

[Deri James]

Follow-up Comment #3, bug#65112 (group groff):

Ooh, a proper bug. Please can you look in font/devpdf/download file and send
me whichever file is assigned to the Symbol font. I can't duplicate the
problem with three different versions of the Symbol font file but you may have
a fourth. I have a suspicion of where the bug probably lies but I need a font
which causes it.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65112] [gropdf] glyphs missing from groff_char(7) but not warned about

[G. Branden Robinson]

Follow-up Comment #2, bug#65112 (group groff):

Hi Deri,

[comment #1 comment #1:]
> Please can you attach the pdf produced, but first could you try the
> run with -P-e.

It's already generated with `-P -e`.

doc/doc.am:


doc/groff-man-pages.pdf: $(GROFF_MAN_PAGES_ALL) eqn pic tbl \
  $(TMAC_PACKAGE_MAN) $(TMAC_PACKAGE_MDOC) font/devps/freeeuro.pfa
$(GROFF_V)$(DOC_GROFF) -pet -mandoc -dHF=HB -rC1 \
  -rCHECKSTYLE=3 -Tpdf -P-e \
  $(GROFF_MAN_PAGES1) \
  $(tmac_srcdir)/sv.tmac $(GROFF_MAN_PAGES2) \
  $(tmac_srcdir)/en.tmac $(GROFF_MAN_PAGES3) > $@


> Without this, all the fonts used (except symbol
> slanted) are base fonts so no fonts are embedded (so no subsetting
> either), and its pot luck if your pdf viewer picks a font which
> contains all the glyphs required.
> 
> I have run groff_char.7 here:-
>
> [derij@pip build (deri-gropdf-ng)]$ ./test-groff man/groff_char.7 -Tpdf -t
-man -P-e |okular -
> troff:man/groff_char.7:1046: warning: special character '.j' not defined
> troff:man/groff_char.7:1468: warning: special character 'vA' not defined
> troff:man/groff_char.7:1598: warning: special character 'bs' not defined
> troff:man/groff_char.7:1771: warning: special character '-+' not defined
> troff:man/groff_char.7:1820: warning: special character 'coproduct' not
defined
> troff:man/groff_char.7:1915: warning: special character '+e' not defined

Yup.  These 6 diagnostics are expected, and documented in the "PROBLEMS"
file.

> /home/derij/groff-git/groff/build/gropdf:man/groff_char.7: warning: Using
nospace mode for font 'EURO'

Yup.  We're covering that one in bug #65111.

> /home/derij/groff-git/groff/build/gropdf:man/groff_char.7: warning:
> unable to embed font file for 'Symbol-Slanted' (SS) (missing entry in
> 'download' file?)

I don't get this one, yet, but that is I think because I have not
cherry-picked the relevant support from your branch onto master yet.

> Along with the known missing glyphs there is the warning about EURO
> (dealt with separately) and I also have not added SlantedSymbol to the
> download file. I've attached a png showing the fonts used by okular.

I'm using Okular as well.

The attachment would be 1.5MiB large (a savings of nearly 3 megs over
"old generation" gropdf!) and I don't think Savannah will accept that.
However you can find the file at my Dropbox account.

https://www.dropbox.com/sh/17ftu3z31couf07/AAC_9kq0ZA-Ra2ZhmZFWlLuva?dl=0

It's "groff-man-pages.2024-01-03.pdf".

Let me know how I can be of further assistance.

Regards,
Branden



___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65112] [gropdf] glyphs missing from groff_char(7) but not warned about

[Deri James]

Follow-up Comment #1, bug#65112 (group groff):

Please can you attach the pdf produced, but first could you try the run with
-P-e. Without this, all the fonts used (except symbol slanted) are base fonts
so no fonts are embedded (so no subsetting either), and its pot luck if your
pdf viewer picks a font which contains all the glyphs required.

I have run groff_char.7 here:-

[derij@pip build (deri-gropdf-ng)]$ ./test-groff man/groff_char.7 -Tpdf -t
-man -P-e |okular -
troff:man/groff_char.7:1046: warning: special character '.j' not defined
troff:man/groff_char.7:1468: warning: special character 'vA' not defined
troff:man/groff_char.7:1598: warning: special character 'bs' not defined
troff:man/groff_char.7:1771: warning: special character '-+' not defined
troff:man/groff_char.7:1820: warning: special character 'coproduct' not
defined
troff:man/groff_char.7:1915: warning: special character '+e' not defined
/home/derij/groff-git/groff/build/gropdf:man/groff_char.7: warning: Using
nospace mode for font 'EURO'
/home/derij/groff-git/groff/build/gropdf:man/groff_char.7: warning: unable to
embed font file for 'Symbol-Slanted' (SS) (missing entry in 'download' file?)

Along with the known missing glyphs there is the warning about EURO (dealt
with separately) and I also have not added SlantedSymbol to the download file.
I've attached a png showing the fonts used by okular.

(file #55520)

___

Additional Item Attachment:

File name: Fonts.png  Size:96 KB



AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://git.savannah.nongnu.org/cgit/administration/savane.git/snapshot/savane-739efcb88d2528965d3c4e746313c5dd0a172b9e.tar.gz


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #65112] [gropdf] glyphs missing from groff_char(7) but not warned about

[G. Branden Robinson]

URL:
  

 Summary: [gropdf] glyphs missing from groff_char(7) but not
warned about
   Group: GNU roff
   Submitter: gbranden
   Submitted: Wed 03 Jan 2024 12:48:17 PM UTC
Category: Driver gropdf
Severity: 3 - Normal
  Item Group: Incorrect behaviour
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: None


___

Follow-up Comments:


---
Date: Wed 03 Jan 2024 12:48:17 PM UTC By: G. Branden Robinson 
This may have to do with the not-yet-merged SlantedSymbol PDF font, but what
is present and missing seems mighty odd if that's the case.


\[AN] logical and
\[**] mathematical asterisk
\[=~] approximately equal to
\[ap] similar to, tilde operator
\[~~] almost equal to
\[~=] "
\[Re] blackletter R, real part
\[*B] uppercase beta
\[*E] uppercase epsilon
\[*U] uppercase upsilon
\[*a] lowercase alpha
\[*b] lowercase beta
\[*d] lowercase delta
\[*e] lowercase epsilon
\[*z] lowercase zeta
\[*y] lowercase eta
\[*c] lowercase xi
\[+h] variant theta
\[+f] variant phi
\[ts] terminal lowercase sigma
\[CL] solid club suit


Did something go wrong with the font subsetting, and it got too aggressive?







___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/