[bug #65788] gropdf: warning: PDF Dict Key 'User' does not start with '/'

2024-05-25 Thread G. Branden Robinson
Update of bug #65788 (group groff):

 Planned Release:None => 1.24.0 


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[bug #65788] gropdf: warning: PDF Dict Key 'User' does not start with '/'

2024-05-25 Thread Dave
Update of bug #65788 (group groff):

 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[bug #65788] gropdf: warning: PDF Dict Key 'User' does not start with '/'

2024-05-25 Thread Deri James
Update of bug #65788 (group groff):

  Status:None => Fixed  
 Assigned to:None => deri   

___

Follow-up Comment #1:


commit b8038971a3cc51cd3981af49092dbdb493f76c06 (HEAD -> master)
Author: Deri James 
Date:   Sat May 25 13:40:21 2024 +0100

[gropdf] Deal better with invalid destination names.

Bookmark destinations (supplied by -T to .pdfbookmark)
are "Name Objects" in pdf terms, as such they are limited
to characters in the range 33 (!) to 126 (~). Characters
outside this range must be coded as a # followed by the
2 digit hex number. So a space character should be '#20'.

Gropdf produces pdfs which conform to this rule, but the
pdf parser (used to import pdfs for pdfpic) expects only
valid syntax. To convert pdfmark input to a pdf object
gropdf used this inbuilt parser.

The .TH macro in an.tmac passes its first parameter as a
bookmark destination. Normally this is fine, since the
convention is that this will be the name of the program
the man page is documenting. The problem in this case
is the line:-

.TH "Pamaltsat User Manual" 0 "14 September 2018"
"netpbm documentation"

The first parameter contains spaces, which yields invalid
syntax when parsed as "/Dest /Pamaltsat User Manual(0)".

* src/devices/gropdf/gropdf: Don't use internal parser
on "user" supplied input, be a bit more careful.

Fixes: https://savannah.gnu.org/bugs/?65788

Thanks to Bjarni for the report.

There are a few other issues with this man page, such as an invalid . TS/TE
tbl, but these are more to do with the conversion from html to man, rather
than gropdf.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/




[bug #65788] gropdf: warning: PDF Dict Key 'User' does not start with '/'

2024-05-24 Thread Bjarni Ingi Gislason
URL:
  

 Summary: gropdf: warning: PDF Dict Key 'User' does not start
with '/'
   Group: GNU roff
   Submitter: bjarniig
   Submitted: Fri 24 May 2024 09:10:23 PM UTC
Category: Driver gropdf
Severity: 3 - Normal
  Item Group: Warning/Suspicious behaviour
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: None


___

Follow-up Comments:


---
Date: Fri 24 May 2024 09:10:23 PM UTC By: Bjarni Ingi Gislason 
Subject: gropdf: warning: PDF Dict Key 'User' does not start with '/'

man -Tpdf pamaltsat


gropdf:-: warning: PDF Dict Key 'User' does not start with '/'
/usr/bin/man: command exited with status 1: (cd /usr/share/man &&
/usr/libexec/man-db/zsoelim) | (cd /usr/share/man &&
/usr/libexec/man-db/manconv -f UTF-8:ISO-8859-1 -t UTF-8//IGNORE) | (cd
/usr/share/man && preconv -e UTF-8) | (cd /usr/share/man &&
/home/bg/git/groff/build/tbl) | (cd /usr/share/man && test-groff -b -ww -s
-mandoc -rCHECKSTYLE=5 -dpaper=a4
-M/home/bg/git/groff/build/s-tmac:/home/bg/git/groff/tmac -rF=0 -rLL=90m
-dAD=l -rHY=0 -rLT=90m -dMF=R -Tpdf)

-.-

pamaltsat: Using libnetpbm from Netpbm Version: Netpbm 11.6.1
pamaltsat: Built from source dated 2024-05-05 15:58:05
pamaltsat: Built by Debian
pamaltsat: BSD defined
pamaltsat: RGB_ENV='RGBDEF'
pamaltsat: RGBENV= 'RGBDEF' (env vbl is unset)








___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/