Re: GRUB 0.5.92 problem
From: Mark Lundeberg <[EMAIL PROTECTED]> Subject: Re: GRUB 0.5.92 problem Date: Sun, 8 Aug 1999 13:16:58 -0700 (PDT) > That works for the first try at the password, but I'd hate to see what > happens if the user failed the password check and tried again. AFAIK, > isspace() doesn't return 1 for null chars, so change > while (! isspace (*pptr)) > to > while (! isspace (*pptr) && *pptr) Thanks. I'll apply this. -- OKUJI Yoshinori <[EMAIL PROTECTED]> ^o-o^ http://duff.kuicr.kyoto-u.ac.jp/~okuji (in English) m /
Re: GRUB 0.5.92 problem
On Sun, 8 Aug 1999, OKUJI Yoshinori wrote:
> From: Mark Lundeberg <[EMAIL PROTECTED]>
> Subject: Re: GRUB 0.5.92 problem
> Date: Sat, 7 Aug 1999 18:34:52 -0700 (PDT)
>
> > am having trouble with getting grub to use passwords. I type in the
> > correct password, but it gives me a "Failed!" message. I tried running the
> > simulator under gdb, and the password variable is correctly set to
> > " (hd0,1)/boot/grub/menup.lst"
>
> Thanks for your report. Can you try this patch?
>
> --- grub-0.5.92.orig/stage2/stage2.c Thu Jun 24 09:03:29 1999
> +++ grub-0.5.92/stage2/stage2.c Sun Aug 8 12:37:09 1999
> @@ -377,6 +377,10 @@
>
> while (! isspace (*pptr))
> pptr ++;
> +
> + /* terminate PASSWORD. */
> + *pptr++ = 0;
> +
> if (! strcmp (password, entered))
> {
> char *new_file = config_file;
That works for the first try at the password, but I'd hate to see what
happens if the user failed the password check and tried again. AFAIK,
isspace() doesn't return 1 for null chars, so change
while (! isspace (*pptr))
to
while (! isspace (*pptr) && *pptr)
> > Also, I am having trouble booting up other bootloaders off floppies from
> > grub (with chainloader command). I tried to boot up a grub boot disk from
> > the grub on my harddrive, and it gave me a Hard Disk Error when I typed in
> > boot. I tried to boot up my redhat install disk, and that didn't word
> > either. When I tried to boot up my master bootloader (lilo), from grub, it
> > worked fine, and lilo is able to boot these 2 floppies with no problems.
>
> Your information is too ambiguous to understand what happened. We
> need to know what you did exactly.
Sorry, stupid me forgot to do root=(fd0)
Re: GRUB 0.5.92 problem
From: Mark Lundeberg <[EMAIL PROTECTED]>
Subject: Re: GRUB 0.5.92 problem
Date: Sat, 7 Aug 1999 18:34:52 -0700 (PDT)
> am having trouble with getting grub to use passwords. I type in the
> correct password, but it gives me a "Failed!" message. I tried running the
> simulator under gdb, and the password variable is correctly set to
> " (hd0,1)/boot/grub/menup.lst"
Thanks for your report. Can you try this patch?
--- grub-0.5.92.orig/stage2/stage2.cThu Jun 24 09:03:29 1999
+++ grub-0.5.92/stage2/stage2.c Sun Aug 8 12:37:09 1999
@@ -377,6 +377,10 @@
while (! isspace (*pptr))
pptr ++;
+
+ /* terminate PASSWORD. */
+ *pptr++ = 0;
+
if (! strcmp (password, entered))
{
char *new_file = config_file;
> Also, I am having trouble booting up other bootloaders off floppies from
> grub (with chainloader command). I tried to boot up a grub boot disk from
> the grub on my harddrive, and it gave me a Hard Disk Error when I typed in
> boot. I tried to boot up my redhat install disk, and that didn't word
> either. When I tried to boot up my master bootloader (lilo), from grub, it
> worked fine, and lilo is able to boot these 2 floppies with no problems.
Your information is too ambiguous to understand what happened. We
need to know what you did exactly.
--
OKUJI Yoshinori <[EMAIL PROTECTED]> ^o-o^
http://duff.kuicr.kyoto-u.ac.jp/~okuji (in English) m /
Re: GRUB 0.5.92 problem
On Sat, 7 Aug 1999, OKUJI Yoshinori wrote: > Perhaps RedHat has an old and buggy version of binutils. You can > examine what version you use by "ld -v". See the requirement in the > file README. Ah. I thought my old version (2.9.1.0.4) was fine, as no compiler errors occured. It works nicely now that I have the new 2.9.1.0.25 . However, I am having trouble with getting grub to use passwords. I type in the correct password, but it gives me a "Failed!" message. I tried running the simulator under gdb, and the password variable is correctly set to " (hd0,1)/boot/grub/menup.lst" Also, I am having trouble booting up other bootloaders off floppies from grub (with chainloader command). I tried to boot up a grub boot disk from the grub on my harddrive, and it gave me a Hard Disk Error when I typed in boot. I tried to boot up my redhat install disk, and that didn't word either. When I tried to boot up my master bootloader (lilo), from grub, it worked fine, and lilo is able to boot these 2 floppies with no problems.
Re: GRUB 0.5.92 problem
Hi Mark, please submit any bug report related to GNU GRUB to [EMAIL PROTECTED] instead of debian-hurd. From: Mark Lundeberg <[EMAIL PROTECTED]> Subject: GRUB 0.5.92 problem Date: Fri, 6 Aug 1999 14:31:07 -0700 (PDT) > I compiled grub on a Redhat Linux 5.1 system. hd0 is 210MB. I use lilo as > my master bootloader. Perhaps RedHat has an old and buggy version of binutils. You can examine what version you use by "ld -v". See the requirement in the file README. -- OKUJI Yoshinori <[EMAIL PROTECTED]> ^o-o^ http://duff.kuicr.kyoto-u.ac.jp/~okuji (in English) m /
