bug#25804: [PATCH] api-procedures.texi: typo: 'an' -> 'on'
* doc/ref/api-procedures.texi: fix typo 'an' -> 'on' Signed-off-by: Sergei Trofimovich --- doc/ref/api-procedures.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/ref/api-procedures.texi b/doc/ref/api-procedures.texi index 02bf6822a..df24178f9 100644 --- a/doc/ref/api-procedures.texi +++ b/doc/ref/api-procedures.texi @@ -836,7 +836,7 @@ Let us call this new procedure @code{foo}. (define foo (make-procedure-with-setter foo-ref foo-set!)) @end lisp -@code{foo} can from now an be used to either read from the data +@code{foo} can from now on be used to either read from the data structure stored in @code{f}, or to write into the structure. @lisp -- 2.11.1
bug#25805: [PATCH] tweak 'u+0007' to 'U+0007' (as the rest of the table)
* doc/ref/api-data.texi: tweak codepoint notation Signed-off-by: Sergei Trofimovich --- doc/ref/api-data.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/ref/api-data.texi b/doc/ref/api-data.texi index 1b3170e4f..9d677371e 100644 --- a/doc/ref/api-data.texi +++ b/doc/ref/api-data.texi @@ -2002,7 +2002,7 @@ names, described in the table below. @multitable {@code{#\backspace}} {Preferred} @item Character Name @tab Codepoint @item @code{#\nul} @tab U+ -@item @code{#\alarm} @tab u+0007 +@item @code{#\alarm} @tab U+0007 @item @code{#\backspace} @tab U+0008 @item @code{#\tab} @tab U+0009 @item @code{#\linefeed} @tab U+000A -- 2.11.1
bug#25803: [PATCH] guile-snarf: skip -g* arguments to avoid build failure
Steps to reproduce: $ ./configure CFLAGS=-ggdb3 $ make make[1]: Entering directory '/home/slyfox/dev/git/guile/libguile' CC libguile_2.2_la-alist.lo In file included from alist.c:398:0: ../libguile/alist.x: In function 'scm_init_alist': ../libguile/alist.x:2:2537: error: conflicting types for 'scm_i_foreign_call' The problem here is in gcc -ggdb3 which leaves too much of unrelated input. guile-snarf does not understand how to drop it: The fix is to ignore -g* flags. They should only affect debugging output. * libguile/guile-snarf.in: skip -g* arguments to avoid build failure Bug: https://bugs.gentoo.org/608190 Bug: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25803 Signed-off-by: Sergei Trofimovich --- libguile/guile-snarf.in | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/libguile/guile-snarf.in b/libguile/guile-snarf.in index 47bbc0422..22dc1d389 100644 --- a/libguile/guile-snarf.in +++ b/libguile/guile-snarf.in @@ -95,10 +95,22 @@ if [ x"$CPP" = x ] ; then cpp="@CPP@" ; else cpp="$CPP" ; fi trap "rm -rf $tempdir" 0 1 2 15 +# filter out -g* flags from commandline +# as some flags like -ggdb3 cause CPP + +cpp_args="" +for arg in "$@" +do +case "$arg" in +-g*) ;; # skip debug flag +*) cpp_args="$cpp_args $arg" ;; +esac +done + if [ ! "$outfile" = "-" ] ; then -modern_snarf "$@" > $outfile +modern_snarf $cpp_args > $outfile else -modern_snarf "$@" +modern_snarf $cpp_args fi # zonk outfile if errors occurred -- 2.11.1
bug#25803: ./configure CFLAGS=-ggdb3 fails 'guile-snarf'
It popped out as a https://bugs.gentoo.org/show_bug.cgi?id=608190 where one of packages failed to build with CFLAGS=-ggdb3 was guile-2.0.13 guile git master is also affected: $ ./configure CFLAGS=-ggdb3 $ make make[1]: Entering directory '/home/slyfox/dev/git/guile/libguile' CC libguile_2.2_la-alist.lo In file included from alist.c:398:0: ../libguile/alist.x: In function 'scm_init_alist': ../libguile/alist.x:2:2537: error: conflicting types for 'scm_i_foreign_call' The problem here is in gcc -ggdb3 which leaves too much of unrelated input. guile-snarf does not understand how to drop it: guile/libguile $ guile-snarf alist.c -DHAVE_CONFIG_H -DBUILDING_LIBGUILE=1 -I.. -I.. -I../lib -I../lib -I/usr/lib64/libffi-3.2.1/include -I/home/slyfox/dev/git/guile -ggdb2 | wc -c 1389 guile/libguile $ guile-snarf alist.c -DHAVE_CONFIG_H -DBUILDING_LIBGUILE=1 -I.. -I.. -I../lib -I../lib -I/usr/lib64/libffi-3.2.1/include -I/home/slyfox/dev/git/guile -ggdb3 | wc -c 230085 Fails on both gcc-5.4.0 / gcc-6.3.0 -- Sergei pgpuMYU8GbLCp.pgp Description: Цифровая подпись OpenPGP
bug#25463: guile-2.0.13 Check errors
Hello, On 02/11/2017 11:03 PM, Ludovic Courtès wrote: > Hello! > > ren...@openmailbox.org skribis: > >> I am trying to build guile version 2.0.13 in GNU Hurd through Guix >> package manager, in the 'Check' phase I have 4 errors; I am attaching >> the build log(config.zip), environment >> variables(environment-variables) and test log(check-guile.zip). >> >> This is a grep of errors, any idea how I can deal with this? >> >> /*-*/ >> ERROR: 00-repl-server.test: repl-server: simple expression - >> arguments: ((system-error "fport_fill_input" "~A" ("Transport endpoint >> is not connected") (1073741881))) >> ERROR: 00-repl-server.test: repl-server: HTTP inter-protocol attack - >> arguments: ((system-error "fport_fill_input" "~A" ("Transport endpoint >> is not connected") (1073741881))) > > The Guix package for Guile incorporates a patch that corresponds to > Guile commit 2fbde7f02adb8c6585e9baf6e293ee49cd23d4c4, which fixes a > race condition for these tests. > While using guile 2.0.14, which has commit 2fbde7f02adb8c6, the bug is still present. Any ideas on what could be causing this Ludo? Manolis export BASH_LOADABLES_PATH="/gnu/store/yp9sv3bxqmfs6ccwqpgrh4b1xgwfmgby-bash-4.4.11/lib/bash" export CPLUS_INCLUDE_PATH="/gnu/store/kv1fll5g4d8i7fw6lpnfmvh0bpqx63xr-gcc-5.4.0/include:/gnu/store/f24mf0bhal2cq2d3gcmndc0q5vldm55z-glibc-2.23/include:/gnu/store/xv680p7pyv2cdx36asjy2vzwv71yxipc-file-boot0-5.28/include:/gnu/store/7iwm17i5fax2as55niv85rbwyx8ncyan-libffi-3.2.1/include:/gnu/store/lww8qzam6v020h7ln8b44c0k62dgprjq-readline-7.0/include:/gnu/store/l572k641i8416abxwnzrpmdp9rwx13gc-libunistring-0.9.7/include:/gnu/store/a4jvbp8c1y9jisr2xs4wjwshq76j11yr-libltdl-2.4.6/include:/gnu/store/ydf34bv6gw92nwhjg35clxchp72s4wj5-libgc-7.4.2/include:/gnu/store/x1rq5mdlbccsrdss6k4r9v00j8zbkp95-gmp-6.1.2/include:/gnu/store/s6578zzds1sksfxm78mdlwmvgizf5w3p-hurd-core-headers-0.9/include:/gnu/store/1qinaapzsx7ldf7pnlqrd9lmj5cwhz75-ncurses-6.0/include" export C_INCLUDE_PATH="/gnu/store/kv1fll5g4d8i7fw6lpnfmvh0bpqx63xr-gcc-5.4.0/include:/gnu/store/f24mf0bhal2cq2d3gcmndc0q5vldm55z-glibc-2.23/include:/gnu/store/xv680p7pyv2cdx36asjy2vzwv71yxipc-file-boot0-5.28/include:/gnu/store/7iwm17i5fax2as55niv85rbwyx8ncyan-libffi-3.2.1/include:/gnu/store/lww8qzam6v020h7ln8b44c0k62dgprjq-readline-7.0/include:/gnu/store/l572k641i8416abxwnzrpmdp9rwx13gc-libunistring-0.9.7/include:/gnu/store/a4jvbp8c1y9jisr2xs4wjwshq76j11yr-libltdl-2.4.6/include:/gnu/store/ydf34bv6gw92nwhjg35clxchp72s4wj5-libgc-7.4.2/include:/gnu/store/x1rq5mdlbccsrdss6k4r9v00j8zbkp95-gmp-6.1.2/include:/gnu/store/s6578zzds1sksfxm78mdlwmvgizf5w3p-hurd-core-headers-0.9/include:/gnu/store/1qinaapzsx7ldf7pnlqrd9lmj5cwhz75-ncurses-6.0/include" export GUILE_SYSTEM_COMPILED_PATH="/gnu/store/5bgjirxr6qgs8bpa3mn9j86x7nr6z652-guile-bootstrap-2.0/lib/guile/2.0/ccache" export GUILE_SYSTEM_PATH="/gnu/store/5bgjirxr6qgs8bpa3mn9j86x7nr6z652-guile-bootstrap-2.0/share/guile/2.0" export HOME="/homeless-shelter" export LD_ORIGIN_PATH="/gnu/store" export LIBRARY_PATH="/gnu/store/yp9sv3bxqmfs6ccwqpgrh4b1xgwfmgby-bash-4.4.11/lib:/gnu/store/f24mf0bhal2cq2d3gcmndc0q5vldm55z-glibc-2.23/lib:/gnu/store/xv680p7pyv2cdx36asjy2vzwv71yxipc-file-boot0-5.28/lib:/gnu/store/7iwm17i5fax2as55niv85rbwyx8ncyan-libffi-3.2.1/lib:/gnu/store/lww8qzam6v020h7ln8b44c0k62dgprjq-readline-7.0/lib:/gnu/store/l572k641i8416abxwnzrpmdp9rwx13gc-libunistring-0.9.7/lib:/gnu/store/a4jvbp8c1y9jisr2xs4wjwshq76j11yr-libltdl-2.4.6/lib:/gnu/store/ydf34bv6gw92nwhjg35clxchp72s4wj5-libgc-7.4.2/lib:/gnu/store/x1rq5mdlbccsrdss6k4r9v00j8zbkp95-gmp-6.1.2/lib:/gnu/store/s6578zzds1sksfxm78mdlwmvgizf5w3p-hurd-core-headers-0.9/lib:/gnu/store/1qinaapzsx7ldf7pnlqrd9lmj5cwhz75-ncurses-6.0/lib" export NIX_BUILD_CORES="1" export NIX_BUILD_TOP="/tmp/guix-build-guile-2.0.14.drv-0" export NIX_STORE="/gnu/store" export OLDPWD export PATH="/gnu/store/0rqa4ls1g8m8km4nfqcsyadgw6jqqnsj-pkg-config-0.29.1/bin:/gnu/store/yp9sv3bxqmfs6ccwqpgrh4b1xgwfmgby-bash-4.4.11/bin:/gnu/store/kv1fll5g4d8i7fw6lpnfmvh0bpqx63xr-gcc-5.4.0/bin:/gnu/store/rpsm2lfadm8pl7cgyfkdw8dygvx2rdb2-ld-wrapper-boot3-0/bin:/gnu/store/f24mf0bhal2cq2d3gcmndc0q5vldm55z-glibc-2.23/bin:/gnu/store/f24mf0bhal2cq2d3gcmndc0q5vldm55z-glibc-2.23/sbin:/gnu/store/wn2z27fd0zzdyya5fq5si6q2j4ckjgzq-ld-wrapper-boot0-0/bin:/gnu/store/0d6x5r6vn48dr265krm83dsavhk5bs9m-binutils-cross-boot0-2.27/bin:/gnu/store/w570h7qvhd3qllm4wxrnrpjrxqwlflgb-make-boot0-4.2.1/bin:/gnu/store/5nznhj7fcv8whv1n24srmg0pcdf8d6qk-diffutils-boot0-3.5/bin:/gnu/store/1zvidsd4ynws9dc19g9drbzfmkv0gqas-findutils-boot0-4.6.0/bin:/gnu/store/xv680p7pyv2cdx36asjy2vzwv71yxipc-file-boot0-5.28/bin:/gnu/store/2vzzgpdpch9y2yqk257v6bq4yyszxi43-bootstrap-binaries-0/bin:/gnu/store/lww8qzam6v020h7ln8b44c0k62dgprjq-readline-7.0/bin:/gnu/store/s6578zzds1sksfxm78mdlwmvgizf5w3p-hurd-core-headers-0.9/bin:/gnu/store/1qinaapzsx7ldf7pnlqrd9lmj5cwhz75-ncurses-6.0/bin" export PKG_CONFI
bug#25791: address argument to atomic operation must be a pointer to _Atomic type with 2.1.7 on macOS
On macOS 10.11 and 10.12 building with Xcode 8, guile 2.1.7 fails to compile with several errors saying "address argument to atomic operation must be a pointer to _Atomic type." I can avoid this by setting ac_cv_header_stdatomic_h=no. Build logs here: https://gist.github.com/ilovezfs/b18b7e6160e0a4c5da297cc430961f63 https://gist.github.com/57e1513e03ede26dc97c0f63eaad3a98 Build failure is ``` CC libguile_2.2_la-arrays.lo CC libguile_2.2_la-async.lo In file included from async.c:27: ../libguile/atomics-internal.h:37:10: error: address argument to atomic operation must be a pointer to _Atomic type ('gl_uint32_t *' (aka 'unsigned int *') invalid) return atomic_fetch_sub (loc, arg); ^ ~~~ /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/8.0.0/include/stdatomic.h:149:43: note: expanded from macro 'atomic_fetch_sub' #define atomic_fetch_sub(object, operand) __c11_atomic_fetch_sub(object, operand, __ATOMIC_SEQ_CST) ``` and several similar errors. Previously (as of guile 2.1.4) I had been able to work around the issue without setting ac_cv_header_stdatomic_h=no with this patch: https://raw.githubusercontent.com/ilovezfs/formula-patches/d2798a468346a7a28fbcd1c8aa3c1ccd5627b03f/guile/guile-atomic-type.patch However, the patch is no longer sufficient since now void** is one the types needing _Atomic, which isn't allowed.
bug#25790: SOCK_CLOEXEC and SOCK_NONBLOCK undeclared identifier errors with 2.1.7
Despite the "accept4 flags. No ifdef as accept4 has a gnulib implementation" building 2.1.7 fails with undeclared identifier errors for SOCK_CLOEXEC and SOCK_NONBLOCK on macOS. Wrapping the relevant sections in ifdef SOCK_CLOEXEC and ifdef SOCK_NONBLOCK seems to work around the build failure, but I'm not sure if there are any problems with doing this, or why the build isn't correctly taking advantage of the gnulib accept4 implementation. Build logs here: https://gist.github.com/ilovezfs/248677aac5bededf97ce429245295cd0 https://gist.github.com/21924118f0954831f2d62e7a79bef81d Build failure is ``` CC libguile_2.2_la-net_db.lo CC libguile_2.2_la-socket.lo socket.c:1658:47: error: use of undeclared identifier 'SOCK_CLOEXEC' scm_c_define ("SOCK_CLOEXEC", scm_from_int (SOCK_CLOEXEC)); ^ socket.c:1659:48: error: use of undeclared identifier 'SOCK_NONBLOCK' scm_c_define ("SOCK_NONBLOCK", scm_from_int (SOCK_NONBLOCK)); ^ 2 errors generated. make[3]: *** [libguile_2.2_la-socket.lo] Error 1 make[2]: *** [install] Error 2 make[1]: *** [install-recursive] Error 1 make: *** [install] Error 2 ``` The workaround I'm using is here https://gist.githubusercontent.com/ilovezfs/90060a1be3b0478c1c89e78d23377ff8/raw/eed5c6beb984e13ab52bf7942360383488cd43d3/gistfile1.txt ``` diff --git a/libguile/socket.c b/libguile/socket.c index 64df64f..446243c 100644 --- a/libguile/socket.c +++ b/libguile/socket.c @@ -1655,8 +1655,12 @@ scm_init_socket () /* accept4 flags. No ifdef as accept4 has a gnulib implementation. */ +#ifdef SOCK_CLOEXEC scm_c_define ("SOCK_CLOEXEC", scm_from_int (SOCK_CLOEXEC)); +#endif +#ifdef SOCK_NONBLOCK scm_c_define ("SOCK_NONBLOCK", scm_from_int (SOCK_NONBLOCK)); +#endif /* setsockopt level. ```