Re: Fix for guile-www/cgi.scm (cgi:make-cookie)
Thien-Thi Nguyen [EMAIL PROTECTED] writes: From: Thamer Al-Harbash [EMAIL PROTECTED] Date: Thu, 28 Aug 2003 10:53:34 -0400 (EDT) This cgi::make-cookie breaks under guile-1.6 because it's using a #key and the (bound?) macro which seem to be no longer available or depreciated. Please accept my patch below which fixes the problem: sounds like guile-1.6 breaks guile-www, not the other way around. To clarify: 1.6 still supports the # syntax but warns that it is deprecated. The 'bound?' macro has been removed since it was a bug to expose SCM_UNDEFINED as a Scheme value. another idea if guile-1.6 has no desire to support #foo, is to provide (ice-9 optargs-kw) as a simple wrapper/alias for its changed (ice-9 optargs), at which point i would be happy to change guile-www to use (ice-9 optargs-kw) since that would be available in guile-1.4.x and 1.6. We should just move forward and fix existing code in this case, like Thamer did. -- GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3 331E FAF8 226A D5D4 E405 ___ Bug-guile mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-guile
Re: Fix for guile-www/cgi.scm (cgi:make-cookie)
From: Thamer Al-Harbash [EMAIL PROTECTED] Date: Thu, 28 Aug 2003 10:53:34 -0400 (EDT) This cgi::make-cookie breaks under guile-1.6 because it's using a #key and the (bound?) macro which seem to be no longer available or depreciated. Please accept my patch below which fixes the problem: sounds like guile-1.6 breaks guile-www, not the other way around. the solution to supporting both #foo and #:foo style taken for guile-1.4.x is to leave (ice-9 optargs) alone and introduce (ice-9 optargs-kw) which handles the #:foo style. perhaps this can be done for guile-1.6 so that it supports interoperability w/ old code. another idea if guile-1.6 has no desire to support #foo, is to provide (ice-9 optargs-kw) as a simple wrapper/alias for its changed (ice-9 optargs), at which point i would be happy to change guile-www to use (ice-9 optargs-kw) since that would be available in guile-1.4.x and 1.6. thi ___ Bug-guile mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-guile
Re: Fix for guile-www/cgi.scm (cgi:make-cookie)
From: Thamer Al-Harbash [EMAIL PROTECTED] Date: Fri, 29 Aug 2003 09:00:57 -0400 (EDT) If this patch works fine with the optargs module why not use it for the sake of simplicity? Does my patch break something? the optargs module has an interface and a name. its interface was changed for guile-1.6 while its name remained the same. this broke old code (a mistake that is not too late to correct). your patch would reinforce the confusion. (btw, simplicity is a matter of how much you leave out of the picture. ;-) thi ___ Bug-guile mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-guile
Re: Fix for guile-www/cgi.scm (cgi:make-cookie)
On Fri, 29 Aug 2003, Thien-Thi Nguyen wrote: another idea if guile-1.6 has no desire to support #foo, is to provide (ice-9 optargs-kw) as a simple wrapper/alias for its changed (ice-9 optargs), at which point i would be happy to change guile-www to use (ice-9 optargs-kw) since that would be available in guile-1.4.x and 1.6. If this patch works fine with the optargs module why not use it for the sake of simplicity? Does my patch break something? -- Thamer Al-Harbash GPG Key fingerprint: D7F3 1E3B F329 8DD5 FAE3 03B1 A663 E359 D686 AA1F HLAGHLHALUAG (KTHANX) ___ Bug-guile mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-guile
