bug#29072: guix system: error: qemu-CVE-2017-7493.patch: patch not found

[myglc2]

On 11/05/2017 at 19:46 Efraim Flashner writes:

> On Sat, Nov 04, 2017 at 07:50:10PM -0400, myglc2 wrote:
>> On 11/01/2017 at 22:44 Leo Famulari writes:
>> 
>> > On Wed, Nov 01, 2017 at 10:40:47PM -0400, myglc2 wrote:
>> >> On 11/01/2017 at 11:27 Leo Famulari writes:
>> >> 
[...]
>> > The 'gnu/packages/qemu.scm' file was removed from Guix in July 2017,
>> > with commit 59132b800093e486e4d81aed6b837e9ac76aa86c. The QEMU packages
>> > were moved into 'gnu/packages/virtualization.scm'.
>> >
[...]
>> 
>> root@g1 ~/con/15# guix system --cores=4 --max-jobs=4 -K --on-error=debug 
>> build sys.scm
>> guix system: error: failed to load 'sys.scm':
>> ice-9/boot-9.scm:2795:6: In procedure resolve-interface:
>> ice-9/boot-9.scm:2795:6: no code for module (gnu packages qemu)
>> 
>
> Can you post your sys.scm? It sounds like you might have a references to
> (gnu packages qemu) listed there.

Yes Efraim, that was it. Actually, Leo mentioned that qemu had moved
(above) but I failed to realize the implication for the config file.

Many thanks! - George

bug#29072: guix system: error: qemu-CVE-2017-7493.patch: patch not found

[Efraim Flashner]

On Sat, Nov 04, 2017 at 07:50:10PM -0400, myglc2 wrote:
> On 11/01/2017 at 22:44 Leo Famulari writes:
> 
> > On Wed, Nov 01, 2017 at 10:40:47PM -0400, myglc2 wrote:
> >> On 11/01/2017 at 11:27 Leo Famulari writes:
> >> 
> >> > On Wed, Nov 01, 2017 at 10:40:28AM -0400, myglc2 wrote:
> >> >> Binary file ./gnu/packages/qemu.go matches   
> >> >
> >> > Try deleting this compiled qemu.go and then try again.
> >> 
> >> Thank you Leo.
> >> 
> >> I deleted ./gnu/packages/qemu.go and re-ran make.
> >> 
> >> Make failed to regenerate ./gnu/packages/qemu.go
> >> 
> >> So now I am really confused.
> >
> > The 'gnu/packages/qemu.scm' file was removed from Guix in July 2017,
> > with commit 59132b800093e486e4d81aed6b837e9ac76aa86c. The QEMU packages
> > were moved into 'gnu/packages/virtualization.scm'.
> >
> > I'm not an Autotools expert, but in cases like this I usually try `make
> > clean && ./configure --localstatedir=/var && make`. Did you try
> > something like that yet?
> 
> Thanks Leo.
> 
> I did a new git pull and a clean build as you suggested (please see the
> grep of the make.log below for details)
> 
> Now when I try 'guix system build sys.scm I get ...
> 
> guix system: error: failed to load 'sys.scm':
> ice-9/boot-9.scm:2795:6: In procedure resolve-interface:
> ice-9/boot-9.scm:2795:6: no code for module (gnu packages qemu)
> 
> ... please see details further below. Obviously something is calling
> 'gnu/packages/qemu.scm' but I don't understand what.
> 
> TIA - George
> 
> make.log
> 
> g1@g1 ~/src/guix$ grep g1@g1 make.log 
> g1@g1 ~/src/guix$ guix environment -e "(@ (gnu packages package-management) 
> guix)" -M 4 -c 4
> g1@g1 ~/src/guix [env]$ git fetch
> g1@g1 ~/src/guix [env]$ git pull
> g1@g1 ~/src/guix [env]$ git status
> g1@g1 ~/src/guix [env]$ rm -fr /home/g1/.cache/guile/ccache/*
> g1@g1 ~/src/guix [env]$ make clean-go

was there any mention at the end of 'make clean-go' about there being
stray *go files left?

> g1@g1 ~/src/guix [env]$ ./bootstrap
> g1@g1 ~/src/guix [env]$ ./configure --localstatedir=/var
> g1@g1 ~/src/guix [env]$ make -j 10 check
> g1@g1 ~/src/guix [env]$ ln -f -s -T ~/src/guix/ ~/.config/guix/latest
> g1@g1 ~/src/guix [env]$ sudo ln -f -s -T ~/src/guix/ /root/.config/guix/latest
> g1@g1 ~/src/guix [env]$ git status
> g1@g1 ~/src/guix [env]$ git remote -vv
> g1@g1 ~/src/guix [env]$ git branch -av | grep \*
> g1@g1 ~/src/guix [env]$ exit
> g1@g1 ~/src/guix$ exit
> g1@g1 ~/src/guix$
> 
> 
> root@g1 ~/con/15# guix system --cores=4 --max-jobs=4 -K --on-error=debug 
> build sys.scm
> guix system: error: failed to load 'sys.scm':
> ice-9/boot-9.scm:2795:6: In procedure resolve-interface:
> ice-9/boot-9.scm:2795:6: no code for module (gnu packages qemu)
> 

Can you post your sys.scm? It sounds like you might have a references to
(gnu packages qemu) listed there.


-- 
Efraim Flashner  אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted


signature.asc
Description: PGP signature

bug#28948: feh does encounter certificate errors with valid certificates

[Ludovic Courtès]

Marius Bakke  skribis:

> Marius Bakke  writes:
>
>> I submitted it upstream in hope of getting feedback/testing there, but
>> it was simply merged as-is: 
>>
>> I do agree that it's rather crude, will try to improve it a bit.
>
> Feh 2.22 has been released with this patch, so I pushed the
> native-search-path update with it.

Neat.

> I think we should add the CURL_CA_BUNDLE search path to the "curl"
> package too so that we can control it on foreign distros (it seems to
> opportunistically search /etc/ssl/certs), and make libcurl users that
> implement it inherit from curl using (package-native-search-paths ...).
>
> I'll do that on 'core-updates' in a few days if no further comments.

Sounds good!

Not entirely sure about duplicating the ‘native-search-paths’ in all the
users of libcurl: it’s inelegant, but OTOH it solves the problem, so
it’s definitely an improvement.

Thank you,
Ludo’.

bug#29106: Build loop after changing pulseaudio and emacs-ido-completing-read+

[Ludovic Courtès]

Oleg Pykhalov  skribis:

> From 9a012229f41d60610e37639363f3b513a3900465 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov 
> Date: Wed, 1 Nov 2017 15:58:48 +0300
> Subject: [PATCH] gnu: emacs-ido-completing-read+: Update to 4.5.
>
> * gnu/packages/emacs.scm (emacs-ido-completing-read+): Update to 4.5.

Please also mention the ‘emacs-ido-ubiquitous’ changes.


[...]

>  (define-public emacs-ido-ubiquitous
> +  ;; Preserve for people already uses `emacs-ido-ubiquitous'
>(package
> -(name "emacs-ido-ubiquitous")
> -(version "3.12")
> -(source (origin
> -  (method url-fetch)
> -  (uri (string-append "https://raw.githubusercontent.com";
> -  "/DarwinAwardWinner/ido-ubiquitous/v"
> -  version "/ido-ubiquitous.el"))
> -  (file-name (string-append "ido-ubiquitous-" version ".el"))
> -  (sha256
> -   (base32
> -"197ypji0fb6jsdcq40rpnknwlh3imas6s6jbsvkfm0pz9988c3q2"
> -(build-system emacs-build-system)
> -(propagated-inputs
> - `(("emacs-ido-completing-read+" ,emacs-ido-completing-read+)))
> -(home-page "https://github.com/DarwinAwardWinner/ido-ubiquitous";)
> -(synopsis "Use ido (nearly) everywhere")
> -(description
> - "Ido-ubiquitous enables ido-style completion for almost every function
> -that uses the standard completion function completing-read.")
> -  (license license:gpl3+)))
> +(inherit emacs-ido-completing-read+)
> +(name "emacs-ido-ubiquitous")))

Should it be defined using ‘deprecated-package’ instead?

Also, is the “build loop” you mentioned fixed with this patch?

Thanks,
Ludo’.

bug#29102: FAIL: make check-system TESTS="btrfs-root-os" not enough space

[Ludovic Courtès]

Hi Oleg,

Oleg Pykhalov  skribis:

> There is an issue with not enough space:
>
> $ make check-system TESTS="btrfs-root-os"
>
> I succeed by “double” this:

Good catch.

> diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm
> index a80c520ec..0e97de0a8 100644
> --- a/gnu/tests/install.scm
> +++ b/gnu/tests/install.scm
> @@ -202,7 +202,7 @@ reboot\n")
> #:imported-modules '((gnu services herd)
>  (guix combinators
>(installation-disk-image-file-system-type "ext4")
> -  (target-size (* 1200 MiB)))
> +  (target-size (* 2200 MiB)))

Maybe you can even change this one to 'guess?

Otherwise OK to push to master, thank you!

Ludo’.

bug#28948: feh does encounter certificate errors with valid certificates

[Marius Bakke]

Marius Bakke  writes:

> I submitted it upstream in hope of getting feedback/testing there, but
> it was simply merged as-is: 
>
> I do agree that it's rather crude, will try to improve it a bit.

Feh 2.22 has been released with this patch, so I pushed the
native-search-path update with it.

I think we should add the CURL_CA_BUNDLE search path to the "curl"
package too so that we can control it on foreign distros (it seems to
opportunistically search /etc/ssl/certs), and make libcurl users that
implement it inherit from curl using (package-native-search-paths ...).

I'll do that on 'core-updates' in a few days if no further comments.


signature.asc
Description: PGP signature

bug#29091: VPATH builds are broken

[Ludovic Courtès]

Hi Eric,

Eric Bavier  skribis:

> Starting at commit 2890ad332fcdfd4bc92b127d783975437c8b718b, vpath builds no 
> longer work.  I.e. one must configure and build in $(top_srcdir).  I believe 
> this also means that `make distcheck` will fail.  I get the following 
> backtrace from compile-all.scm:

Good catch!  AFAICS this is fixed by the attached patch.  I’ll commit it
soon if that’s fine with you.

Thanks for your report!

Ludo’.

>From 17b45feb84594e57b487d525810d3d70693ad792 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= 
Date: Sun, 5 Nov 2017 12:49:57 +0100
Subject: [PATCH] compile: Fix VPATH builds.

Fixes .
Reported by Eric Bavier .

* guix/build/compile.scm (relative-file): New procedure.
(load-files): Use it before calling 'file-name->module-name'.
(compile-files): Likewise before calling 'scm->go'.
* guix/build/pull.scm (build-guix): Remove 'with-directory-excursion'
and file name hack from ce33c3af76b0e5c68cc42dddf2b9c4b017386fd8.
Pass OUT to 'all-scheme-files'.
---
 guix/build/compile.scm | 28 --
 guix/build/pull.scm| 53 +-
 2 files changed, 40 insertions(+), 41 deletions(-)

diff --git a/guix/build/compile.scm b/guix/build/compile.scm
index ea0c36fa3..8b5a2faf8 100644
--- a/guix/build/compile.scm
+++ b/guix/build/compile.scm
@@ -77,6 +77,12 @@
   "Strip the \".scm\" suffix from FILE, and append \".go\"."
   (string-append (string-drop-right file 4) ".go"))
 
+(define (relative-file directory file)
+  "Return FILE relative to DIRECTORY, if possible."
+  (if (string-prefix? (string-append directory "/") file)
+  (string-drop file (+ 1 (string-length directory)))
+  file))
+
 (define* (load-files directory files
  #:key
  (report-load (const #f))
@@ -93,13 +99,14 @@
  (report-load #f total completed))
*unspecified*)
   ((file files ...)
-   (report-load file total completed)
-   (format debug-port "~%loading '~a'...~%" file)
+   (let ((file (relative-file directory file)))
+ (report-load file total completed)
+ (format debug-port "~%loading '~a'...~%" file)
 
-   (parameterize ((current-warning-port debug-port))
- (resolve-interface (file-name->module-name file)))
+ (parameterize ((current-warning-port debug-port))
+   (resolve-interface (file-name->module-name file)))
 
-   (loop files (+ 1 completed))
+ (loop files (+ 1 completed)))
 
 (define-syntax-rule (with-augmented-search-path path item body ...)
   "Within the dynamic extent of BODY, augment PATH by adding ITEM to the
@@ -135,11 +142,12 @@ files are for HOST, a GNU triplet such as \"x86_64-linux-gnu\"."
 (with-fluids ((*current-warning-prefix* ""))
   (with-target host
 (lambda ()
-  (compile-file file
-#:output-file (string-append build-directory "/"
- (scm->go file))
-#:opts (append warning-options
-   (optimization-options file))
+  (let ((relative (relative-file source-directory file)))
+(compile-file file
+  #:output-file (string-append build-directory "/"
+   (scm->go relative))
+  #:opts (append warning-options
+ (optimization-options relative)))
 (with-mutex progress-lock
   (set! completed (+ 1 completed
 
diff --git a/guix/build/pull.scm b/guix/build/pull.scm
index 3573241a7..a011e366f 100644
--- a/guix/build/pull.scm
+++ b/guix/build/pull.scm
@@ -121,41 +121,32 @@ containing the source code.  Write any debugging output to DEBUG-PORT."
 
 ;; Compile the .scm files.  Hide warnings.
 (parameterize ((current-warning-port (%make-void-port "w")))
-  (with-directory-excursion out
-;; Filter out files depending on Guile-SSH when Guile-SSH is missing.
-(let ((files (filter has-all-its-dependencies?
- (all-scheme-files "."
-  (compile-files out out
+  ;; Filter out files depending on Guile-SSH when Guile-SSH is missing.
+  (let ((files (filter has-all-its-dependencies?
+   (all-scheme-files out
+(compile-files out out files
 
- ;; XXX: 'compile-files' except ready-to-use relative
- ;; file names.
- (map (lambda (file)
-(if (string-prefix? "./" file)
-(string-drop file 2)
-file))
-  files)
+   #:workers (parallel-job-count)
 
- #:workers (parallel-job-count)
+   ;; Dis