bug#37569: Mount does not honor 'user' option.

[Diego Nicola Barbato]

Hello Danny,

Danny Milosavljevic  writes:

> Hmm, how is that solved with other distributions?  Is "mount" suid root there?

Indeed, in Debian both mount and umount are suid root:

  $ stat -c "%a %U:%G %n" /bin/*mount
  4755 root:root /bin/fusermount
  4755 root:root /bin/mount
  4755 root:root /bin/umount

Thanks,

Diego

bug#37565: [use profile manifest] upstream VCS informations only available after a guix pull

[Ludovic Courtès]

Hi,

YOANN P  skribis:

>>> YOANN P  skribis:
>>> Not sure if it should be considerated as a bug but it seems that the 
>>> upstream VCS information are only available after a "guix pull".
>>
>>You mean that ‘guix describe’ doesn’t work for ‘guix’ not obtained from ‘guix 
>>pull’, right?
>>
>
> Not exactly but has the same behavior indeed.
> I was talking about upstream VCS informations in ~/.guix-profile/manifest 
> (user profile manifest)
> Every packages installed with "guix install xxx" from a fresh install ( 1.0.1 
> in my case ) doesn't have upstream VCS informations in 
> ~/.guix-profile/manifest as you described here ( 
> https://lists.gnu.org/archive/html/guix-devel/2018-10/msg00018.html ).

Ah yes, it’s the same issue as with ‘guix describe’.

Thanks,
Ludo’.

bug#37505: "make check" fails on a fresh Guix checkout

[Ludovic Courtès]

Hello!

Konrad Hinsen  skribis:

> OK, I triple-checked: there still is a problem. There are two places in
> pull.scm that used '~*'. The attached patch removes the second one.

Oops, my bad.

> From 370579d7ac4e01fd66bdf4518d31f7d3bc17a65a Mon Sep 17 00:00:00 2001
> From: Konrad Hinsen 
> Date: Tue, 1 Oct 2019 17:06:58 +0200
> Subject: [PATCH] pull: Do not use '~*', which 'msgfmt' fails to interpret.
>
> Really fixes .

Applied, thanks!

Ludo’.

bug#37569: Mount does not honor 'user' option.

[Danny Milosavljevic]

Hmm, how is that solved with other distributions?  Is "mount" suid root there?


pgpO07B97QGhK.pgp
Description: OpenPGP digital signature

bug#37505: "make check" fails on a fresh Guix checkout

[Konrad Hinsen]

Konrad Hinsen  writes:

> Konrad Hinsen  writes:
>
>> Unfortunately, a very similar error still blocks compiling a fresh Guix
>> checkout:
>
> Sorry, false alarm. I have been typing in the wrong terminal window.

OK, I triple-checked: there still is a problem. There are two places in
pull.scm that used '~*'. The attached patch removes the second one.

Konrad.

>From 370579d7ac4e01fd66bdf4518d31f7d3bc17a65a Mon Sep 17 00:00:00 2001
From: Konrad Hinsen 
Date: Tue, 1 Oct 2019 17:06:58 +0200
Subject: [PATCH] pull: Do not use '~*', which 'msgfmt' fails to interpret.

Really fixes .
---
 guix/scripts/pull.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm
index e018985469..04970cf503 100644
--- a/guix/scripts/pull.scm
+++ b/guix/scripts/pull.scm
@@ -314,7 +314,7 @@ to display."
(removed
 (let ((count (length removed)))
   (format (current-error-port)
-  (N_ "  ~*One channel removed:~%"
+  (N_ "  ~a channel removed:~%"
   "  ~a channels removed:~%" count)
   count)
   (for-each display-channel removed
-- 
2.23.0

bug#37569: Mount does not honor 'user' option.

[Diego Nicola Barbato]

Hey Guix,

I have added the following to `file-systems' in my operating-system
config:

--8<---cut here---start->8---
(file-system   
  (device "127.0.0.1") 
  (mount-point "/home/diego/inf")  
  (type "9p")  
  (options "noextend,trans=tcp,dfltuid=1000,dfltgid=998,port=9001,user,nofail")
  (mount? #f))
--8<---cut here---end--->8---

It works almost as expected except that when I try to mount the file
system as a regular user (which is what the option 'user' is supposed to
allow) I get:

  $ LC_ALL=C mount inf
  mount: /home/diego/inf: must be superuser to use mount.

The command succeeds if I run it as root.

The following steps reproduce the issue without using a 9p file system:

1. Prepare a file system on a loopback device:

  $ dd if=/dev/zero of=foo.img bs=1024 count=524288
  $ udisksctl loop-setup --file foo.img
  Mapped file foo.img as /dev/loop0.
  $ sudo mkfs.ext4 -L foofs /dev/loop0

2. Add the following line to /etc/fstab replacing  with something
more appropriate:

  LABEL=foofs /home//foofs ext4 defaults,user

3. Try to mount the filesystem as an unprivileged user (This should work
and does work on e.g. Debian 10):

  $ mkdir foofs
  $ LC_ALL=C mount foofs
  mount: /home//foofs: must be superuser to use mount.

4. Try it with sudo to confirm that everything else works as expected:

  $ sudo mount foofs
  $ ls foofs
  lost+found/

Regards,

Diego

bug#37565: [use profile manifest] upstream VCS informations only available after a guix pull

[YOANN P]

>De : Ludovic Courtès 
>Envoyé : mardi 1 octobre 2019 09:28
>À : YOANN P 
>Cc : 37...@debbugs.gnu.org <37...@debbugs.gnu.org>
>Objet : Re: bug#37565: [use profile manifest] upstream VCS informations only 
>available after a guix pull
>
>Hi,
>
>> YOANN P  skribis:
>> Not sure if it should be considerated as a bug but it seems that the 
>> upstream VCS information are only available after a "guix pull".
>
>You mean that ‘guix describe’ doesn’t work for ‘guix’ not obtained from ‘guix 
>pull’, right?
>

Not exactly but has the same behavior indeed.
I was talking about upstream VCS informations in ~/.guix-profile/manifest (user 
profile manifest)
Every packages installed with "guix install xxx" from a fresh install ( 1.0.1 
in my case ) doesn't have upstream VCS informations in ~/.guix-profile/manifest 
as you described here ( 
https://lists.gnu.org/archive/html/guix-devel/2018-10/msg00018.html ).
Those informations only appear after a "guix pull" and think those informations 
should be available even on a fresh install.

>> If it is not a bug, it will be nice to have this information even on a fresh 
>> install by putting as VCS information a default git repository 
>> (https://git.savannah.gnu.org/git/guix.git) and the current tag as commit 
>> (or the real commit if available somewhere in binary install files) ?
>
>I agree it’d be nice.
>Thanks,
>Ludo’.

Regards,

bug#37505: "make check" fails on a fresh Guix checkout

[Konrad Hinsen]

Konrad Hinsen  writes:

> Unfortunately, a very similar error still blocks compiling a fresh Guix
> checkout:

Sorry, false alarm. I have been typing in the wrong terminal window.
Too many Guix installations in my life ;-)

Konrad.

bug#37505: "make check" fails on a fresh Guix checkout

[Konrad Hinsen]

Ludovic Courtès  writes:

> Konrad Hinsen  skribis:
>
>> e...@boldquot.po:2849: format specifications in 'msgstr[0]' are not a subset 
>> of those in 'msgid_plural'
>> e...@boldquot.po:2856: format specifications in 'msgstr[0]' are not a subset 
>> of those in 'msgid_plural'
>> /gnu/store/6z2rl8vrbcghvwcjdcf740b8l2cgx25a-profile/bin/msgfmt: found 2 
>> fatal errors
>
> Fixed in 43f7fd8783af1e824904a76115a8ae8ccbb19f06, thanks!

Thanks!

Unfortunately, a very similar error still blocks compiling a fresh Guix
checkout:

   make[5]: Entering directory '/home/hinsen/guix/guix/po/guix'
   sed -e '/^#/d' -e 's/HEADER/en@boldquot.header/g' ./insert-header.sin > 
en@boldquot.insert-header
   en@boldquot:
   en@boldquot:
   msgmerge  --lang=en@boldquot e...@boldquot.po guix.pot -o 
e...@boldquot.new.po
   

 done.
   make[5]: Leaving directory '/home/hinsen/guix/guix/po/guix'
   make[4]: Leaving directory '/home/hinsen/guix/guix/po/guix'
   rm -f e...@boldquot.gmo && 
/gnu/store/6z2rl8vrbcghvwcjdcf740b8l2cgx25a-profile/bin/msgfmt -c --statistics 
--verbose -o e...@boldquot.gmo e...@boldquot.po
   e...@boldquot.po:2864: format specifications in 'msgstr[0]' are not a subset 
of those in 'msgid_plural'
   /gnu/store/6z2rl8vrbcghvwcjdcf740b8l2cgx25a-profile/bin/msgfmt: found 1 
fatal error

Cheers,
  Konrad.

bug#37505: "make check" fails on a fresh Guix checkout

[Ludovic Courtès]

Hello,

Konrad Hinsen  skribis:

> e...@boldquot.po:2849: format specifications in 'msgstr[0]' are not a subset 
> of those in 'msgid_plural'
> e...@boldquot.po:2856: format specifications in 'msgstr[0]' are not a subset 
> of those in 'msgid_plural'
> /gnu/store/6z2rl8vrbcghvwcjdcf740b8l2cgx25a-profile/bin/msgfmt: found 2 fatal 
> errors

Fixed in 43f7fd8783af1e824904a76115a8ae8ccbb19f06, thanks!

Ludo'.

bug#37550: [core-updates] [PATCH] gnu: gcc: Fix i686-linux cross compiler.

[Ludovic Courtès]

Hello,

Thanks for pushing this patch!

Jan Nieuwenhuizen  skribis:

> ./pre-inst-env guix build --target=i686-unknown-linux-gnu hello

Note that on x86_64 you can perform native builds for i686 with
“guix build -s i686-linux hello”.

You probably already know it but I thought I’d mention it because native
builds are much easier.  :-)

Ludo’.

bug#37565: [use profile manifest] upstream VCS informations only available after a guix pull

[Ludovic Courtès]

Hi,

YOANN P  skribis:

> Not sure if it should be considerated as a bug but it seems that the upstream 
> VCS information are only available after a "guix pull".

You mean that ‘guix describe’ doesn’t work for ‘guix’ not obtained from
‘guix pull’, right?

> If it is not a bug, it will be nice to have this information even on a fresh 
> install by putting as VCS information a default git repository 
> (https://git.savannah.gnu.org/git/guix.git) and the current tag as commit (or 
> the real commit if available somewhere in binary install files) ?

I agree it’d be nice.

Thanks,
Ludo’.