bug#37850: Glib documentation is missing

2019-11-08 Thread Alexandros Theodotou

I missed this part.

glib documentation must be built with gtk-doc which in turn depends on 
glib,

so we need to define glib-minimal which does not depend on gtk-doc.


In this case the way I have seen other distros do it is by having a 
*-bootstrap package (same as the *-minimal that you mention), which 
doesn't sound like a bad approach.



What about 'hiding' the normal glib package


Maybe the *-bootstrap package can be hidden. Then the normal glib 
package can have its "doc" back?






bug#37850: Glib documentation is missing

2019-11-08 Thread Alexandros Theodotou
I am new to guix so please excuse my ignorance, but is there an issue 
with just adding a "doc" output to the current glib, as mentioned in the 
manual?

http://guix.gnu.org/manual/en/guix.html#Packages-with-Multiple-Outputs

I find this approach nice and clean and I am personally not too fond of 
the idea of having "*-minimal" and "*-with-documentation" packages.






bug#38142: Evolution: e-mail wizard fails due to missing service file

2019-11-08 Thread Sam

Hello,
evolution, the gnome e-mail program, currently (3.30.5) is not able to 
add an E-mail account ootb. The set-up works fine until the very last 
moment, when the configuration is supposed to be saved.

When the finish button is pressed, this error message appears:
"The name org.gnome.evolution.dataserver.Sources5 was not provided by 
any .service files".
NixOS had a the same error, but somehow managed to fix it: 
https://github.com/NixOS/nixpkgs/issues/12756 in this patch: 
https://github.com/NixOS/nixpkgs/pull/17926.

However, I am not sure how to translate this fix to Guix.
If I can somehow help with this bug, please let me know.

Thank you,
Sam





bug#38100: ‘--with-input’ causes unintended rebuilds

2019-11-08 Thread Ludovic Courtès
Hi,

Ludovic Courtès  skribis:

> Indeed, evaluating:
>
>   (bag-transitive-inputs
>(package->bag ((package-input-rewriting '()) glib)))
>
> shows that we have two “python” packages there that are not ‘eq?’.

The problem is that ‘glib’ depends on ‘python-libxml2’, which uses
‘python-build-system’ and thus has ‘python’ as an implicit input.

‘package-input-rewriting’ doesn’t touch implicit inputs so it leaves
that implicit ‘python’ untouched.

Since ‘transitive-inputs’ (used by ‘bag-transitive-inputs’) uses pointer
equality, we end up with two “python” packages that are not ‘eq?’ but
are functionally equivalent: the one produced by
‘package-input-rewriting’, and the implicit dependency of
‘python-libxml2’.  QED.

(This is essentially the same as .)

I’m not sure how to address it.

Ludo’.





bug#36375: [PATCH] Re: ‘guix package’ should lock the profile

2019-11-08 Thread Julien Lepiller
Le Fri, 08 Nov 2019 21:03:05 +0100,
Ludovic Courtès  a écrit :

> Hello!
> 
> Julien Lepiller  skribis:
> 
> > From 71a85b5a8aac6c0bd5a1a4e3b52e409b2112df7a Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller 
> > Date: Thu, 7 Nov 2019 21:50:54 +0100
> > Subject: [PATCH 1/2] guix: Add file-locking with no wait.
> >
> > * guix/build/syscalls.scm (with-file-lock/no-wait): New procedure.
> > (lock-file): Take a #:wait? key.  
> 
> [...]
> 
> > From 50c792e155d1207127f10ff0c0360442b7736a64 Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller 
> > Date: Fri, 25 Oct 2019 21:39:21 +0200
> > Subject: [PATCH 2/2] guix: package: lock profiles when processing
> > them.
> >
> > * guix/scripts/package.scm (process-actions): Get a per-profile
> > lock to prevent concurrent actions on profiles.
> > * tests/guix-package.sh: Add test.  
> 
> LGTM!
> 
> I tested ‘with-file-lock’ on an NFSv3 mount, and ‘F_SETLKW’ is
> correctly implemented, FWIW.
> 
> Thank you!
> 
> Ludo’.

Pushed as f49e9131889775a74a85c1f9b29f108030337b8b and
b1fb663404894268b5ee92c040f12c52c0bee425.





bug#36375: [PATCH] Re: ‘guix package’ should lock the profile

2019-11-08 Thread Ludovic Courtès
Hello!

Julien Lepiller  skribis:

> From 71a85b5a8aac6c0bd5a1a4e3b52e409b2112df7a Mon Sep 17 00:00:00 2001
> From: Julien Lepiller 
> Date: Thu, 7 Nov 2019 21:50:54 +0100
> Subject: [PATCH 1/2] guix: Add file-locking with no wait.
>
> * guix/build/syscalls.scm (with-file-lock/no-wait): New procedure.
> (lock-file): Take a #:wait? key.

[...]

> From 50c792e155d1207127f10ff0c0360442b7736a64 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller 
> Date: Fri, 25 Oct 2019 21:39:21 +0200
> Subject: [PATCH 2/2] guix: package: lock profiles when processing them.
>
> * guix/scripts/package.scm (process-actions): Get a per-profile lock to
> prevent concurrent actions on profiles.
> * tests/guix-package.sh: Add test.

LGTM!

I tested ‘with-file-lock’ on an NFSv3 mount, and ‘F_SETLKW’ is correctly
implemented, FWIW.

Thank you!

Ludo’.





bug#37967: guix environment -CN: Operation not permitted mounting host's /var/run/nscd

2019-11-08 Thread Björn Höfling
On Mon, 04 Nov 2019 23:37:07 +0100
Ludovic Courtès  wrote:

> Hi,
> 
> Ivan Vilata i Balaguer  skribis:
> 
> > I applied your patch on top of bf7b08c4, pulled Guix and did
> > successfully start `guix environment -CN`, with network support and
> > all.  
> 
> Awesome, pushed as 625bdf09d344302ec2d5da7f35fe35ca1d128a93.

Hi,

I had the same issue and was too lazy to report. I can confirm that the
commit fixed it.

Thanks for reporting and fixing.

Björn


pgphUhN1mf_hy.pgp
Description: OpenPGP digital signature


bug#26302: [website] translations

2019-11-08 Thread sirgazil via Bug reports for GNU Guix
 On Fri, 08 Nov 2019 12:13:56 -0500 pelzflorian (Florian Pelz) 
 wrote 

 > > German is slightly wider than English and Chinese will be slightly 
 > > smaller.  Hopefully it won’t matter, otherwise the navbar could be put 
 > > in a div container with display: flex; or something for spacing 
 > > between elements. 
 > > 
 >  
 > For example, the navbar could be given a width 
 >  
 >  
 >  
 > and the ul inside could be given display:flex and justify-content 
 >  
 >  
 >  
 > Or not.  Maybe it is good as it is. 


Or we could wait until there is a visible problem :)

Eventually, it would be good to update the layout-related CSS of the website to 
use flex  and grid when appropriate. Maybe for another iteration :)






bug#26302: [website] translations

2019-11-08 Thread pelzflorian (Florian Pelz)
On Fri, Nov 08, 2019 at 05:18:28PM +0100, pelzflorian (Florian Pelz) wrote:
> I changed it now, also for the dropdowns.  The change is online now
> that the website was rebuilt.
> 
>

Dropdowns are fixed for real now.


> > But now that the width of the menu will vary depending on each
> > language, the whole menu bar will probably have to be redesigned.
> > 
> 
> German is slightly wider than English and Chinese will be slightly
> smaller.  Hopefully it won’t matter, otherwise the navbar could be put
> in a div container with display: flex; or something for spacing
> between elements.
> 

For example, the navbar could be given a width



and the ul inside could be given display:flex and justify-content



Or not.  Maybe it is good as it is.

Regards,
Florian





bug#26302: [website] translations

2019-11-08 Thread pelzflorian (Florian Pelz)
On Fri, Nov 08, 2019 at 05:18:29PM +0100, pelzflorian (Florian Pelz) wrote:
> I changed it now, also for the dropdowns.

Oops, dropdowns are not quite right yet.





bug#26302: [website] translations

2019-11-08 Thread pelzflorian (Florian Pelz)
On Fri, Nov 08, 2019 at 09:01:17AM -0500, sirgazil wrote:
> Hi, Florian :)
> 
>  On Fri, 08 Nov 2019 04:02:16 -0500 pelzflorian (Florian Pelz) 
>  wrote 
> 
>  > Another thing is that perhaps the CSS margin of the .menu-item:link 
>  > elements in the navbar should be reduced.  What do you think: 
>  >  
>  > https://guix.gnu.org/.i18n/de/ 
>  > https://guix.gnu.org/.i18n/en/ 
> 
> Yes. For now, I think "margin: 0px 2px" would be ok. 
> […]

I changed it now, also for the dropdowns.  The change is online now
that the website was rebuilt.


> But now that the width of the menu will vary depending on each
> language, the whole menu bar will probably have to be redesigned.
> 

German is slightly wider than English and Chinese will be slightly
smaller.  Hopefully it won’t matter, otherwise the navbar could be put
in a div container with display: flex; or something for spacing
between elements.

Regards,
Florian





bug#38135: Mate: missing gio-launch-desktop

2019-11-08 Thread Diego Nicola Barbato
Hi Guix,

Launching a program from the start menu of the Mate desktop (as provided
by the ‘mate-desktop-service-type’) currently (commit: 41ee209) fails.
The error message complains about a missing ‘gio-launch-desktop’ (found
in the “bin” output of ‘glib’).

This can be worked around by adding ‘(list glib "bin")’ to the list of
global packages in the ‘operating-system’ configuration.

Regards,

Diego





bug#26302: [website] translations

2019-11-08 Thread sirgazil via Bug reports for GNU Guix
Hi, Florian :)

 On Fri, 08 Nov 2019 04:02:16 -0500 pelzflorian (Florian Pelz) 
 wrote 

 > Another thing is that perhaps the CSS margin of the .menu-item:link 
 > elements in the navbar should be reduced.  What do you think: 
 >  
 > https://guix.gnu.org/.i18n/de/ 
 > https://guix.gnu.org/.i18n/en/ 

Yes. For now, I think "margin: 0px 2px" would be ok. 

However, I noticed that the items with dropdown menus in 
https://guix.gnu.org/.i18n/de/ don't seem to have horizontal margin, while the 
rest of the items do. So the space between items is different, which also 
results in the items with subitems not aligning well with the other menu items 
in the narrow screen presentation.

But now that the width of the menu will vary depending on each language, the 
whole menu bar will probably have to be redesigned.






bug#37860: [PATCH v2] gnu: qemu: Add upstream patch for failing test.

2019-11-08 Thread Miguel Arruga Vivas
Hi,

They have solved the problem on qemu's master branch, as the author
kindly told me[1], so I propose this patch to add their patch on top
of our current version.  I've tested it on x86_64, WDYT?

Happy hacking!
Miguel

[1]
https://lists.nongnu.org/archive/html/qemu-devel/2019-11/msg00340.html
From b91245b18c4e66f05ea9dbc37e62be64ae3bbf07 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?=
 
Date: Fri, 8 Nov 2019 02:13:38 +0100
Subject: [PATCH] gnu: qemu: Add upstream patch for failing test.

* gnu/packages/virtualization.scm (qemu)[patches]: Add upstream patch
to fix tests on linux-libre >= 5.3.
---
 gnu/packages/virtualization.scm | 11 ++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index f113eee5f7..afe88e16ea 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -114,7 +114,16 @@
  version ".tar.xz"))
  (sha256
   (base32
-   "1ih9v6gxgild3m4g80ld4dr3wp9db3bpy203k73fxgc9hqhn0vk5"
+   "1ih9v6gxgild3m4g80ld4dr3wp9db3bpy203k73fxgc9hqhn0vk5"))
+ (patches
+  (list
+   ;; XXX: Patch from master branch, to be removed with next
+   ;; upstream release.
+   (qemu-patch
+"bf9e0313c27d8e6ecd7f7de3d63e1cb25d8f6311"
+"qemu-tests-make-filemonitor-test-more-robust.patch"
+(base32
+ "1242wqpr8id3cn88pzbig3sqh4znml0g0h2mwdmdyhp81blq7s7n"))
 (build-system gnu-build-system)
 (arguments
  '(;; Running tests in parallel can occasionally lead to failures, like:
-- 
2.23.0



bug#26302: [website] translations

2019-11-08 Thread pelzflorian (Florian Pelz)
After Ludo’s reviews I’ve pushed and rebased everything again.  What
is missing is making nginx redirect accesses only to html files to
their localized version if one exists.  This would mean the
non-localized URLs remain valid and their use could be continued.

I would prefer if someone familiar with nginx could help here.

I have not researched enough to know how to redirect index files in
nginx, i.e. https://guix.gnu.org/contribute/ should serve
de/contribute/index.html.

The nginx accept language module can determine if it should redirect
to de or en like this:

diff --git a/hydra/nginx/berlin.scm b/hydra/nginx/berlin.scm
index 2947759..8b83d1e 100644
--- a/hydra/nginx/berlin.scm
+++ b/hydra/nginx/berlin.scm
@@ -468,6 +468,13 @@ PUBLISH-URL."
 (uri "/guix")
 (body (list "root /var/www;")))
 
+   (nginx-location-configuration
+(uri "~ (.html|.htm)$")
+(body (list
+   ;; put en first so it is the default:
+   "set_from_accept_language $lang en de;"
+   "try_files /$lang/$uri $uri =404;")))
+
(nginx-location-configuration  ;certbot
 (uri "/.well-known")
 (body (list "root /var/www;")
@@ -767,5 +774,11 @@ PUBLISH-URL."
 (define %nginx-configuration
   (nginx-configuration
(server-blocks %berlin-servers)
+   (load-modules
+(list
+ ;; We need this module for redirecting users to the localized
+ ;; website of their choice.
+ (file-append nginx-mod-accept-language "\
+/etc/nginx/modules/ngx_http_accept_language_module.so")))
(extra-content
 (string-join %extra-content "\n"


Another thing is that perhaps the CSS margin of the .menu-item:link
elements in the navbar should be reduced.  What do you think:

https://guix.gnu.org/.i18n/de/
https://guix.gnu.org/.i18n/en/

Regards,
Florian