bug#56365: Emacs crash when built with Guix

2022-07-02 Thread Ryan Prior via Bug reports for GNU Guix 
I've been getting a persistent crash when I select text in Emacs this past 
couple days. I'll post the stacktrace below.

using guix 9829f53
repository URL: https://git.savannah.gnu.org/git/guix.git
branch: master commit: 9829f53a3f4e245e962073528be46918ad2e

Using GNU Emacs 29.0.50 (the "emacs-next" package)

Stacktrace:

/home/ryan/.guix-profile/bin/emacs[0x56af8e]
/home/ryan/.guix-profile/bin/emacs[0x425bad]
/home/ryan/.guix-profile/bin/emacs[0x42609e]
/home/ryan/.guix-profile/bin/emacs[0x5695f8]
/home/ryan/.guix-profile/bin/emacs[0x569669]
/gnu/store/5h2w4qi9hk1qzzgi1w83220ydslinr4s-glibc-2.33/lib/libpthread.so.0(+0x11d80)[0x7f1f638c1d80]
/gnu/store/fa43ijbrb96x08621qigxxiphp503lsi-libx11-1.7.3.1/lib/libX11.so.6(XVisualIDFromVisual+0x0)[0x7f1f64b789b0]
/gnu/store/ll5s37859kfz8j7j4isz2qm9n0ykikgh-gtk+-3.24.30/lib/libgdk-3.so.0(gdk_x11_window_foreign_new_for_display+0x15a)[0x7f1f6537555a]
/gnu/store/ll5s37859kfz8j7j4isz2qm9n0ykikgh-gtk+-3.24.30/lib/libgdk-3.so.0(+0x69d48)[0x7f1f6535cd48]
/gnu/store/ll5s37859kfz8j7j4isz2qm9n0ykikgh-gtk+-3.24.30/lib/libgdk-3.so.0(+0x70151)[0x7f1f65363151]
/gnu/store/ll5s37859kfz8j7j4isz2qm9n0ykikgh-gtk+-3.24.30/lib/libgdk-3.so.0(+0x6fc23)[0x7f1f65362c23]
/gnu/store/ll5s37859kfz8j7j4isz2qm9n0ykikgh-gtk+-3.24.30/lib/libgdk-3.so.0(gdk_display_get_event+0x40)[0x7f1f6532b9b0]
/gnu/store/ll5s37859kfz8j7j4isz2qm9n0ykikgh-gtk+-3.24.30/lib/libgdk-3.so.0(+0x6f8b2)[0x7f1f653628b2]
/gnu/store/bnsf9il448hl5xjavbhq3rcx355svz2v-glib-2.70.2/lib/libglib-2.0.so.0(g_main_context_dispatch+0x23b)[0x7f1f64d054cb]
/gnu/store/bnsf9il448hl5xjavbhq3rcx355svz2v-glib-2.70.2/lib/libglib-2.0.so.0(+0x55748)[0x7f1f64d05748]
/gnu/store/bnsf9il448hl5xjavbhq3rcx355svz2v-glib-2.70.2/lib/libglib-2.0.so.0(g_main_context_iteration+0x2f)[0x7f1f64d057ef]
/gnu/store/ll5s37859kfz8j7j4isz2qm9n0ykikgh-gtk+-3.24.30/lib/libgtk-3.so.0(gtk_main_iteration+0x15)[0x7f1f65642665]
/home/ryan/.guix-profile/bin/emacs[0x50d65b]
/home/ryan/.guix-profile/bin/emacs[0x552432]
/home/ryan/.guix-profile/bin/emacs[0x75]
/home/ryan/.guix-profile/bin/emacs[0x659055]
/home/ryan/.guix-profile/bin/emacs[0x481f25]
/home/ryan/.guix-profile/bin/emacs[0x44d340]
/home/ryan/.guix-profile/bin/emacs[0x461115]
/home/ryan/.guix-profile/bin/emacs[0x46e500]
/home/ryan/.guix-profile/bin/emacs[0x47532c]
/home/ryan/.guix-profile/bin/emacs[0x453106]
/home/ryan/.guix-profile/bin/emacs[0x47db49]
/home/ryan/.guix-profile/bin/emacs[0x47e352]
/home/ryan/.guix-profile/bin/emacs[0x5598f7]
/home/ryan/.guix-profile/bin/emacs[0x55b97d]
/home/ryan/.guix-profile/bin/emacs[0x55d603]
/home/ryan/.guix-profile/bin/emacs[0x5d3217]
/home/ryan/.guix-profile/bin/emacs[0x549f1a]
/home/ryan/.guix-profile/bin/emacs[0x5d3171]
/home/ryan/.guix-profile/bin/emacs[0x549ebf]
/home/ryan/.guix-profile/bin/emacs[0x550d23]
/home/ryan/.guix-profile/bin/emacs[0x55109a]
/home/ryan/.guix-profile/bin/emacs[0x42e197]
/gnu/store/5h2w4qi9hk1qzzgi1w83220ydslinr4s-glibc-2.33/lib/libc.so.6(__libc_start_main+0xcd)[0x7f1f635197dd]
/home/ryan/.guix-profile/bin/emacs[0x42e63a]
...
Segmentation fault

bug#56288: Pitivi can't be started

2022-07-02 Thread Christian Miller via Bug reports for GNU Guix 
Hello Josselin,

thanks for your solution it works.

This is definitely not user friendly and should be fixed. Is it possible to 
change the subject to something more appropriate?

Best regards
Christian Miller

bug#56353: sbcl-2.2.6 build fail

2022-07-02 Thread Christopher Baines 

Guillaume Le Vaillant  writes:

> [[PGP Signed Part:Undecided]]
> Christopher Baines  skribis:
>
>> Tobias Geerinckx-Rice via Bug reports for GNU Guix  writes:
>>
>>> On 2 July 2022 09:29:22 UTC, Wensheng Xie  wrote:
Das Erstellungsprotokoll kann unter 
„/var/log/guix/drvs/6l/q7dfdfzrlp24lmhj95fcnvkr2mrqfz-sbcl-2.2.6.drv.bz2“ 
eingesehen werden.
>>>
>>>
>>> This log file is always a good idea to include.
>>
>> I think this is the equivalent non-grafted derivation:
>>
>>   
>> https://data.guix.gnu.org/gnu/store/m7xw777v5agldb76gbqkqdvrrlj5d7zy-sbcl-2.2.6.drv
>>
>> There are plenty of failed builds on bordeaux.guix.gnu.org. I managed to
>> get it to build successfully once though on my laptop.
>>
>> Guillaume, any ideas if sbcl@2.2.6 is just really unlikely to build
>> successfully, or if there's particular conditions for it to build?
>>
>> Thanks,
>>
>> Chris
>
> According to the logs, the 'build-doc' phase fails to compile the
> documentation for SIMD related functions. There's a patch disabling this
> part of the doc unless we compile on x86_64, but maybe not all x86_64
> CPUs have the required instructions...
>
> Would it be possible to get the result of "lscpu" on some machines where
> it fails?

Sure, here is the lscpu output from the bayfront and harbourfront
machines.

Architecture:x86_64
  CPU op-mode(s):32-bit, 64-bit
  Address sizes: 48 bits physical, 48 bits virtual
  Byte Order:Little Endian
CPU(s):  32
  On-line CPU(s) list:   0-31
Vendor ID:   AuthenticAMD
  Model name:AMD Opteron(tm) Processor 6278
CPU family:  21
Model:   1
Thread(s) per core:  2
Core(s) per socket:  8
Socket(s):   2
Stepping:2
Frequency boost: enabled
CPU max MHz: 2400.
CPU min MHz: 1400.
BogoMIPS:4799.96
Flags:   fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge 
mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt 
pdpe1gb rdtscp lm constant_tsc rep_go
 od nopl nonstop_tsc cpuid extd_apicid amd_dcm 
aperfmperf pni pclmulqdq monitor ssse3 cx16 sse4_1 sse4_2 popcnt aes xsave avx 
lahf_lm cmp_legacy svm extapic cr8_legac
 y abm sse4a misalignsse 3dnowprefetch osvw ibs xop 
skinit wdt lwp fma4 topoext perfctr_core perfctr_nb cpb hw_pstate ssbd vmmcall 
arat npt lbrv svm_lock nrip_save ts
 c_scale vmcb_clean flushbyasid decodeassists 
pausefilter pfthreshold
Virtualization features: 
  Virtualization:AMD-V
Caches (sum of all): 
  L1d:   512 KiB (32 instances)
  L1i:   1 MiB (16 instances)
  L2:32 MiB (16 instances)
  L3:24 MiB (4 instances)
NUMA:
  NUMA node(s):  4
  NUMA node0 CPU(s): 0-7
  NUMA node1 CPU(s): 8-15
  NUMA node2 CPU(s): 16-23
  NUMA node3 CPU(s): 24-31
Vulnerabilities: 
  Itlb multihit: Not affected
  L1tf:  Not affected
  Mds:   Not affected
  Meltdown:  Not affected
  Spec store bypass: Mitigation; Speculative Store Bypass disabled via 
prctl and seccomp
  Spectre v1:Mitigation; usercopy/swapgs barriers and __user 
pointer sanitization
  Spectre v2:Mitigation; Full AMD retpoline, STIBP disabled, RSB 
filling
  Srbds: Not affected
  Tsx async abort:   Not affected
Architecture:   x86_64
  CPU op-mode(s):   32-bit, 64-bit
  Address sizes:38 bits physical, 48 bits virtual
  Byte Order:   Little Endian
CPU(s): 8
  On-line CPU(s) list:  0-7
Vendor ID:  GenuineIntel
  Model name:   Intel(R) Xeon(R) CPU   E5420  @ 2.50GHz
CPU family: 6
Model:  23
Thread(s) per core: 1
Core(s) per socket: 4
Socket(s):  2
Stepping:   10
BogoMIPS:   4987.55
Flags:  fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge 
mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ht tm pbe syscall nx lm 
constant_tsc arch_perfmon pebs bts 
rep_good nopl cpuid aperfmperf pni dtes64 monitor 
ds_cpl est tm2 ssse3 cx16 xtpr pdcm dca sse4_1 xsave lahf_lm pti dtherm
Caches (sum of all):
  L1d:  256 KiB (8 instances)
  L1i:  256 KiB (8 instances)
  L2:   24 MiB (4 instances)
NUMA:   
  NUMA node(s): 1
  NUMA node0 CPU(s):0-7
Vulnerabilities:
  Itlb multihit:KVM: Mitigation: VMX unsupported
  L1tf: Mitigation; PTE Inversion
  Mds:  Vulnerable: Clear CPU buffers attempted, no microcode; 
SMT disabled
  Meltdown: Mitigation; PTI
  Spec store bypass:Vulnerable
  Spectre v1:

bug#56353: sbcl-2.2.6 build fail

2022-07-02 Thread Guillaume Le Vaillant 
Christopher Baines  skribis:

> Tobias Geerinckx-Rice via Bug reports for GNU Guix  writes:
>
>> On 2 July 2022 09:29:22 UTC, Wensheng Xie  wrote:
>>>Das Erstellungsprotokoll kann unter 
>>>„/var/log/guix/drvs/6l/q7dfdfzrlp24lmhj95fcnvkr2mrqfz-sbcl-2.2.6.drv.bz2“ 
>>>eingesehen werden.
>>
>>
>> This log file is always a good idea to include.
>
> I think this is the equivalent non-grafted derivation:
>
>   
> https://data.guix.gnu.org/gnu/store/m7xw777v5agldb76gbqkqdvrrlj5d7zy-sbcl-2.2.6.drv
>
> There are plenty of failed builds on bordeaux.guix.gnu.org. I managed to
> get it to build successfully once though on my laptop.
>
> Guillaume, any ideas if sbcl@2.2.6 is just really unlikely to build
> successfully, or if there's particular conditions for it to build?
>
> Thanks,
>
> Chris

According to the logs, the 'build-doc' phase fails to compile the
documentation for SIMD related functions. There's a patch disabling this
part of the doc unless we compile on x86_64, but maybe not all x86_64
CPUs have the required instructions...

Would it be possible to get the result of "lscpu" on some machines where
it fails?

The build always works on my machine:
--8<---cut here---start->8---
Architecture:x86_64
  CPU op-mode(s):32-bit, 64-bit
  Address sizes: 48 bits physical, 48 bits virtual
  Byte Order:Little Endian
CPU(s):  32
  On-line CPU(s) list:   0-31
Vendor ID:   AuthenticAMD
  Model name:AMD Ryzen 9 5950X 16-Core Processor
CPU family:  25
Model:   33
Thread(s) per core:  2
Core(s) per socket:  16
Socket(s):   1
Stepping:0
Frequency boost: enabled
CPU max MHz: 5083.3979
CPU min MHz: 2200.
BogoMIPS:6786.83
Flags:   fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge 
mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt 
pdpe1gb rdtscp lm constant_tsc rep_go
 od nopl nonstop_tsc cpuid extd_apicid aperfmperf rapl 
pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave avx 
f16c rdrand lahf_lm cmp_legacy sv
 m extapic cr8_legacy abm sse4a misalignsse 
3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpext 
perfctr_llc mwaitx cpb cat_l3 cdp_l3 hw_pstate
  ssbd mba ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 
smep bmi2 erms invpcid cqm rdt_a rdseed adx smap clflushopt clwb sha_ni 
xsaveopt xsavec xgetbv1 xsaves cqm_llc c
 qm_occup_llc cqm_mbm_total cqm_mbm_local clzero irperf 
xsaveerptr rdpru wbnoinvd arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean 
flushbyasid decodeassists paus
 efilter pfthreshold avic v_vmsave_vmload vgif 
v_spec_ctrl umip pku ospke vaes vpclmulqdq rdpid overflow_recov succor smca fsrm
Virtualization features: 
  Virtualization:AMD-V
Caches (sum of all): 
  L1d:   512 KiB (16 instances)
  L1i:   512 KiB (16 instances)
  L2:8 MiB (16 instances)
  L3:64 MiB (2 instances)
NUMA:
  NUMA node(s):  1
  NUMA node0 CPU(s): 0-31
Vulnerabilities: 
  Itlb multihit: Not affected
  L1tf:  Not affected
  Mds:   Not affected
  Meltdown:  Not affected
  Mmio stale data:   Not affected
  Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
  Spectre v1:Mitigation; usercopy/swapgs barriers and __user 
pointer sanitization
  Spectre v2:Mitigation; Retpolines, IBPB conditional, IBRS_FW, 
STIBP always-on, RSB filling
  Srbds: Not affected
  Tsx async abort:   Not affected
--8<---cut here---end--->8---


signature.asc
Description: PGP signature

bug#56353: sbcl-2.2.6 build fail

2022-07-02 Thread Christopher Baines 

Tobias Geerinckx-Rice via Bug reports for GNU Guix  writes:

> On 2 July 2022 09:29:22 UTC, Wensheng Xie  wrote:
>>Das Erstellungsprotokoll kann unter 
>>„/var/log/guix/drvs/6l/q7dfdfzrlp24lmhj95fcnvkr2mrqfz-sbcl-2.2.6.drv.bz2“ 
>>eingesehen werden.
>
>
> This log file is always a good idea to include.

I think this is the equivalent non-grafted derivation:

  
https://data.guix.gnu.org/gnu/store/m7xw777v5agldb76gbqkqdvrrlj5d7zy-sbcl-2.2.6.drv

There are plenty of failed builds on bordeaux.guix.gnu.org. I managed to
get it to build successfully once though on my laptop.

Guillaume, any ideas if sbcl@2.2.6 is just really unlikely to build
successfully, or if there's particular conditions for it to build?

Thanks,

Chris


signature.asc
Description: PGP signature

bug#56353: sbcl-2.2.6 build fail

2022-07-02 Thread Tobias Geerinckx-Rice via Bug reports for GNU Guix 
On 2 July 2022 09:29:22 UTC, Wensheng Xie  wrote:
>Das Erstellungsprotokoll kann unter 
>„/var/log/guix/drvs/6l/q7dfdfzrlp24lmhj95fcnvkr2mrqfz-sbcl-2.2.6.drv.bz2“ 
>eingesehen werden.


This log file is always a good idea to include.

If it's more than a few hundred kilobytes compressed, send only the last ~300K 
or so.
Hi,

Kind regards,

T G-R

Sent on the go.  Excuse or enjoy my brevity.

bug#56349: [PATCH v2] gnu: Add kaidan.

2022-07-02 Thread Liliana Marie Prikler 
Hi Raghav,

Am Samstag, dem 02.07.2022 um 05:06 -0400 schrieb Raghav Gururajan:
> * gnu/packages/messaging.scm (kaidan): New variable.
I cleaned up your patch and pushed it.

Cheers

bug#55936: [PATCH] services: docker: Fix race condition.

2022-07-02 Thread Oleg Pykhalov 
Fixes .

* gnu/packages/patches/containerd-create-pid-file.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add this.
* gnu/packages/docker.scm (containerd)[source]: Add this patch.
* gnu/services/docker.scm
(containerd-shepherd-service): Add #:pid-file and #:pid-file-timeout.
* gnu/services/docker.scm (docker-shepherd-service): Add --containerd flag.
---
 gnu/local.mk  |  3 +-
 gnu/packages/docker.scm   |  6 ++--
 .../patches/containerd-create-pid-file.patch  | 31 +++
 gnu/services/docker.scm   |  5 ++-
 4 files changed, 41 insertions(+), 4 deletions(-)
 create mode 100644 gnu/packages/patches/containerd-create-pid-file.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index 3a56ad371d..5cd235286c 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -17,7 +17,7 @@
 # Copyright © 2017, 2020 Mathieu Othacehe 
 # Copyright © 2017, 2018, 2019 Gábor Boskovits 
 # Copyright © 2018 Amirouche Boubekki 
-# Copyright © 2018, 2019, 2020, 2021 Oleg Pykhalov 
+# Copyright © 2018, 2019, 2020, 2021, 2022 Oleg Pykhalov 
 # Copyright © 2018 Stefan Stefanović 
 # Copyright © 2018, 2020, 2021, 2022 Maxim Cournoyer 

 # Copyright © 2019, 2020, 2021, 2022 Guillaume Le Vaillant 
@@ -965,6 +965,7 @@ dist_patch_DATA =   
\
   %D%/packages/patches/cmh-support-fplll.patch \
   %D%/packages/patches/coda-use-system-libs.patch  \
   %D%/packages/patches/collectd-5.11.0-noinstallvar.patch  \
+  %D%/packages/patches/containerd-create-pid-file.patch\
   %D%/packages/patches/combinatorial-blas-awpm.patch   \
   %D%/packages/patches/combinatorial-blas-io-fix.patch \
   %D%/packages/patches/cool-retro-term-wctype.patch\
diff --git a/gnu/packages/docker.scm b/gnu/packages/docker.scm
index ae4ee419af..184280b38f 100644
--- a/gnu/packages/docker.scm
+++ b/gnu/packages/docker.scm
@@ -6,7 +6,7 @@
 ;;; Copyright © 2020 Michael Rohleder 
 ;;; Copyright © 2020 Katherine Cox-Buday 
 ;;; Copyright © 2020 Jesse Dowell 
-;;; Copyright © 2021 Oleg Pykhalov 
+;;; Copyright © 2021, 2022 Oleg Pykhalov 
 ;;; Copyright © 2022 Pierre Langlois 
 ;;;
 ;;; This file is part of GNU Guix.
@@ -184,7 +184,9 @@ (define-public containerd
  (commit (string-append "v" version
(file-name (git-file-name name version))
(sha256
-(base32 "1vsl747i3wyy68j4lp4nprwxadbyga8qxlrk892afcd2990zp5mr"
+(base32 "1vsl747i3wyy68j4lp4nprwxadbyga8qxlrk892afcd2990zp5mr"))
+   (patches
+(search-patches "containerd-create-pid-file.patch"
 (build-system go-build-system)
 (arguments
  (let ((make-flags #~(list (string-append "VERSION=" #$version)
diff --git a/gnu/packages/patches/containerd-create-pid-file.patch 
b/gnu/packages/patches/containerd-create-pid-file.patch
new file mode 100644
index 00..668ffcd9e9
--- /dev/null
+++ b/gnu/packages/patches/containerd-create-pid-file.patch
@@ -0,0 +1,31 @@
+Copyright © 2022 Oleg Pykhalov 
+
+Create a PID file after containerd is ready to serve requests.
+
+Fixes .
+
+--- a/cmd/containerd/command/notify_linux.go   1970-01-01 03:00:01.0 
+0300
 b/cmd/containerd/command/notify_linux.go   2022-07-02 04:42:35.553753495 
+0300
+@@ -22,15 +22,22 @@
+   sd "github.com/coreos/go-systemd/v22/daemon"
+ 
+   "github.com/containerd/containerd/log"
++
++  "os"
++  "strconv"
+ )
+ 
+ // notifyReady notifies systemd that the daemon is ready to serve requests
+ func notifyReady(ctx context.Context) error {
++  pidFile, _ := os.Create("/run/containerd/containerd.pid")
++  defer pidFile.Close()
++  pidFile.WriteString(strconv.FormatInt(int64(os.Getpid()), 10))
+   return sdNotify(ctx, sd.SdNotifyReady)
+ }
+ 
+ // notifyStopping notifies systemd that the daemon is about to be stopped
+ func notifyStopping(ctx context.Context) error {
++  os.Remove("/run/containerd/containerd.pid")
+   return sdNotify(ctx, sd.SdNotifyStopping)
+ }
+ 
diff --git a/gnu/services/docker.scm b/gnu/services/docker.scm
index 846ebe8334..741bab5a8c 100644
--- a/gnu/services/docker.scm
+++ b/gnu/services/docker.scm
@@ -98,6 +98,8 @@ (define (containerd-shepherd-service config)
  ;; For finding containerd-shim binary.
  #:environment-variables
  (list (string-append "PATH=" #$containerd "/bin"))
+ #:pid-file "/run/containerd/containerd.pid"
+ #:pid-file-timeout 300
  #:log-file "/var/log/containerd.log"))
(stop #~(make-kill-destructor)
 
@@ -135,7 +137,8 @@ (define (docker-shepherd-service config)
   '("--userland-proxy=false"))
(if #$enable-iptables?
"--iptables"

bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?

2022-07-02 Thread Pierre Neidhardt 
Robert Goldman from ASDF found out why the "COMPONENT not found" issue happens:

https://gitlab.common-lisp.net/asdf/asdf/-/issues/119#note_9808

So either we fix most of the Prove-depending libraries, or we just do
what's expected from every one, that is, add the directory to the ASDF
registries.

The latter is much easier of course...


signature.asc
Description: PGP signature

bug#56297: Guix style imperfections

2022-07-02 Thread Ludovic Courtès 
Hi,

Maxime Devos  skribis:

> "guix style" occasionally makes some decision that seem a bit
> questionable to me.

Let’s keep in mind that some are bugs/limitations that can be fixed,
while others cannot really be addressed because our tastes vary
depending on context and the pretty printer could hardly be made smart
enough to distinguish all the subtleties.

>> (define-public guile-next
>>  (let ((version "3.0.7") (revision "0")
>>(commit "d70c1dbebf9ac0fd45af4578c23983ec4a7da535"))
>
> Conventionally 'revision' is put on another line -- for these kind of let 
> bindings,
> (maybe all?), I would recommend to put all of them on separate lines.

This one is a bug IMO: ‘let’ bindings should be treated specially, and
currently they’re not.

>>   (substitute-keyword-arguments (package-arguments guile-3.0)
>> ((#:phases phases
>>   '%standard-phases) `(modify-phases ,phases
>
> Put %standard-phases on the same line ad #:phases phases and `(modify-phases 
> ,phases
> on a new lineg 

OK.

>> (add-before 'check 'skip-failing-tests
>>   (lambda _
>> (substitute* 
>> "test-suite/standalone/test-out-of-memory"
>>   (("!#") "!#
>>
>>(exit 77)
>>"))
>
> I'd prefer the original "!#\n\n(exit 77)\n" here, but I don't know if that's
> something 'Guix style' could feasibly do (there might be situations where a
> newline might be appropriate, how could "guix style" which is the case?).

Exactly: in synopses/descriptions, we do want to print newlines as-is
(see ‘tests/style.scm’).

Perhaps we could come up with heuristics that make different choices
depending on context, but that sounds tricky.

>> (delete-file
>>  "test-suite/tests/version.test") 
>> #t))
>
> (Would be nice if "guix style" could be taught to remove those #t, but that 
> seems
> more a feature limitation than a bug to me.)

That could be the job of a different style rule (the ‘-S’ option).

>>  (native-inputs (modify-inputs (package-native-inputs guile-3.0)
>>   (prepend autoconf
>>automake
>>libtool
>>flex
>>gnu-gettext
>>texinfo
>>gperf)))
>
> I'd consider it tidier to put (modify-inputs ...) on a new line

Dunno it’s a matter of taste.  :-)

Ludo’.

bug#56353: sbcl-2.2.6 build fail

2022-07-02 Thread Wensheng Xie 
Hi, guix:

the command:
guix package -u

log:
/gnu/store/6lq7dfdfzrlp24lmhj95fcnvkr2mrqfz-sbcl-2.2.6.drv wird erstellt …
- „build-doc“-Phasebuilder for 
`/gnu/store/6lq7dfdfzrlp24lmhj95fcnvkr2mrqfz-sbcl-2.2.6.drv' failed with exit 
code 1
Erstellung von /gnu/store/6lq7dfdfzrlp24lmhj95fcnvkr2mrqfz-sbcl-2.2.6.drv 
fehlgeschlagen
Das Erstellungsprotokoll kann unter 
„/var/log/guix/drvs/6l/q7dfdfzrlp24lmhj95fcnvkr2mrqfz-sbcl-2.2.6.drv.bz2“ 
eingesehen werden.
guix package: Fehler: build of
`/gnu/store/6lq7dfdfzrlp24lmhj95fcnvkr2mrqfz-sbcl-2.2.6.drv' failed

This is what I had right. If you need more, please let me know.

best regards
wxie

bug#56349: [PATCH v2] gnu: Add kaidan.

2022-07-02 Thread Raghav Gururajan via Bug reports for GNU Guix 
* gnu/packages/messaging.scm (kaidan): New variable.
---
 gnu/packages/messaging.scm | 64 +-
 1 file changed, 63 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 9b1d06e21a..4798119871 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -25,7 +25,7 @@
 ;;; Copyright © 2020 Jonathan Brielmaier 
 ;;; Copyright © 2020 Mason Hock 
 ;;; Copyright © 2020, 2021 Michael Rohleder 
-;;; Copyright © 2020 Raghav Gururajan 
+;;; Copyright © 2020, 2021 Raghav Gururajan 
 ;;; Copyright © 2020, 2021 Robert Karszniewicz 
 ;;; Copyright © 2020 Giacomo Leidi 
 ;;; Copyright © 2021 Denis 'GNUtoo' Carikli 
@@ -89,6 +89,7 @@ (define-module (gnu packages messaging)
   #:use-module (gnu packages icu4c)
   #:use-module (gnu packages image)
   #:use-module (gnu packages kde)
+  #:use-module (gnu packages kde-frameworks)
   #:use-module (gnu packages kerberos)
   #:use-module (gnu packages less)
   #:use-module (gnu packages libcanberra)
@@ -3359,4 +3360,65 @@ (define-public python-harmony
 (home-page "https://github.com/taylordotfish/harmony;)
 (license license:gpl3+)))
 
+(define-public kaidan
+  (package
+   (name "kaidan")
+   (version "0.8.0")
+   (source
+(origin
+ (method url-fetch)
+ (uri
+  (string-append "mirror://kde/unstable/kaidan/"
+ version "/kaidan-" version ".tar.xz"))
+ (modules '((guix build utils)))
+ (snippet
+  `(begin
+ (delete-file-recursively "3rdparty")))
+ (sha256
+  (base32 "195iddv35gc3k83r226y17avsab2b9bszgd7z7ynbddsgbf75rx7"
+   (build-system qt-build-system)
+   (arguments
+`(#:configure-flags
+  (list
+   "-DBUILD_TESTS=TRUE")))
+   (native-inputs
+(list
+ extra-cmake-modules
+ perl
+ pkg-config
+ python-wrapper))
+   (inputs
+(list
+ kirigami
+ knotifications
+ qtbase-5
+ qtdeclarative
+ qtgraphicaleffects
+ qtlocation
+ qtquickcontrols2
+ qtsvg
+ qtmultimedia
+ qtxmlpatterns
+ qqc2-desktop-style
+ qxmpp
+ zxing-cpp))
+   (home-page "https://www.kaidan.im/;)
+   (synopsis "Qt-based XMPP/Jabber Client")
+   (description "Kaidan is a chat client.  It uses the open communication
+protocol XMPP (Jabber).  The user interface makes use of Kirigami and QtQuick,
+while the back-end of Kaidan is entirely written in C++ using Qt and the
+Qt-based XMPP library QXmpp.")
+   (license
+(list
+ ;; Graphics
+ license:cc-by-sa4.0
+ ;; Files:
+ ;; src/{StatusBar.cpp|StatusBar.h|singleapp/*|hsluv-c/*}
+ ;; utils/generate-license.py
+ license:expat
+ ;; QrCodeVideoFrame
+ license:asl2.0
+ ;; Others
+ license:gpl3+
+
 ;;; messaging.scm ends here
-- 
2.36.1

bug#56349: [PATCH] gnu: Add kaidan.

2022-07-02 Thread Raghav Gururajan via Bug reports for GNU Guix 
* gnu/packages/messaging.scm (kaidan): New variable.
---
 gnu/packages/messaging.scm | 63 +-
 1 file changed, 62 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 9b1d06e21a..67841efc8a 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -25,7 +25,7 @@
 ;;; Copyright © 2020 Jonathan Brielmaier 
 ;;; Copyright © 2020 Mason Hock 
 ;;; Copyright © 2020, 2021 Michael Rohleder 
-;;; Copyright © 2020 Raghav Gururajan 
+;;; Copyright © 2020, 2021 Raghav Gururajan 
 ;;; Copyright © 2020, 2021 Robert Karszniewicz 
 ;;; Copyright © 2020 Giacomo Leidi 
 ;;; Copyright © 2021 Denis 'GNUtoo' Carikli 
@@ -89,6 +89,7 @@ (define-module (gnu packages messaging)
   #:use-module (gnu packages icu4c)
   #:use-module (gnu packages image)
   #:use-module (gnu packages kde)
+  #:use-module (gnu packages kde-frameworks)
   #:use-module (gnu packages kerberos)
   #:use-module (gnu packages less)
   #:use-module (gnu packages libcanberra)
@@ -3359,4 +3360,64 @@ (define-public python-harmony
 (home-page "https://github.com/taylordotfish/harmony;)
 (license license:gpl3+)))
 
+(define-public kaidan
+  (package
+   (name "kaidan")
+   (version "0.8.0")
+   (source
+(origin
+ (method url-fetch)
+ (uri
+  (string-append "mirror://kde/unstable/kaidan/"
+ version "/kaidan-" version ".tar.xz"))
+ (modules '((guix build utils)))
+ (snippet
+  `(begin
+ (delete-file-recursively "3rdparty")))
+ (sha256
+  (base32 "195iddv35gc3k83r226y17avsab2b9bszgd7z7ynbddsgbf75rx7"
+   (build-system qt-build-system)
+   (arguments
+`(#:configure-flags
+  (list
+   "-DBUILD_TESTS=TRUE")))
+   (native-inputs
+(list
+ extra-cmake-modules
+ perl
+ pkg-config
+ python-wrapper))
+   (inputs
+(list
+ kirigami
+ knotifications
+ qtbase-5
+ qtdeclarative
+ qtlocation
+ qtquickcontrols2
+ qtsvg
+ qtmultimedia
+ qtxmlpatterns
+ qqc2-desktop-style
+ qxmpp
+ zxing-cpp))
+   (home-page "https://www.kaidan.im/;)
+   (synopsis "Qt-based XMPP/Jabber Client")
+   (description "Kaidan is a chat client.  It uses the open communication
+protocol XMPP (Jabber).  The user interface makes use of Kirigami and QtQuick,
+while the back-end of Kaidan is entirely written in C++ using Qt and the
+Qt-based XMPP library QXmpp.")
+   (license
+(list
+ ;; Graphics
+ license:cc-by-sa4.0
+ ;; Files:
+ ;; src/{StatusBar.cpp|StatusBar.h|singleapp/*|hsluv-c/*}
+ ;; utils/generate-license.py
+ license:expat
+ ;; QrCodeVideoFrame
+ license:asl2.0
+ ;; Others
+ license:gpl3+
+
 ;;; messaging.scm ends here
-- 
2.36.1

bug#56343: ‘tests/services/telephony.scm’ fails to run

2022-07-02 Thread Maxim Cournoyer 
On July 1, 2022 5:34:37 PM EDT, "Ludovic Courtès"  wrote:
>Hi,
>
>The ‘tests/services/telephony.scm’ file exercises procedures that were
>removed from (gnu build jami-service) in
>85b4dabd94d53f8179f31a42046cd83fc3a352fc, which prevents ‘make check’
>from proceeding:
>
>--8<---cut here---start->8---
>$ make check -j5
>
>[...]
>
>PASS: tests/services/file-sharing.scm
>PASS: tests/services.scm
>PASS: tests/services/linux.scm
>make[4]: *** [Makefile:6079: tests/services/telephony.log] Error 1
>make[4]: *** Waiting for unfinished jobs
>PASS: tests/sets.scm
>PASS: tests/packages.scm
>PASS: tests/pack.scm
>PASS: tests/lint.scm
>make[4]: Leaving directory '/home/ludo/src/guix'
>make[3]: *** [Makefile:6061: check-TESTS] Error 2
>--8<---cut here---end--->8---
>
>Should we keep some of the tests in this file, or has it become obsolete
>entirely?

It isn't obsolete, but I had forgotten there were both unit and functional 
(system) tests for our Jami seevice. It's probably easy to adjust, I can look 
into it when I'm back from travels in a few days.

Cheers,

Maxim




Hi,