bug#60951: issues.guix.gnu.org javascript is blocked by LibreJS

2023-01-19 Thread Maxim Cournoyer
Hi,

It seems the JavaScript behind some of the new fancy MUMI features has
not been tagged as free software in the source, as LibreJS reports the
two following scripts as "external [...] with no known license":

--8<---cut here---start->8---
https://issues.guix.gnu.org/js/tokeninput.js
https://issues.guix.gnu.org/js/theme-switcher.js
--8<---cut here---end--->8---

We've had this in the past on ci.guix.gnu.org and Mathieu was able to
mark the JS as free software, if I remember correctly.  We should do the
same here.

-- 
Thanks,
Maxim





bug#59855: Emacs Debbugs reply (was Re: bug#59855: Guix Shell with FHS Feedback: lib/tls/x86_64/x86_64?)

2023-01-19 Thread John Kehayias via Bug reports for GNU Guix
Hi simon,

On Thu, Jan 05, 2023 at 12:31 PM, Simon Tournier wrote:

> Hi John,
>
> On Fri, 23 Dec 2022 at 05:39, John Kehayias via Bug reports for GNU
> Guix  wrote:
>
>> (resending as it seems debbugs in Emacs doesn't automatically add
>> the
>> bug number email in the To/CC list.)
>
> Well, I think it is about Gnus and not Debbugs.  There is bunch of
> option to reply with Gnus. :-)
>
> 9 candidates:
> gnus-summary-reply
> gnus-summary-wide-reply
> gnus-summary-very-wide-reply
> gnus-summary-reply-with-original
> gnus-summary-reply-broken-reply-to
> gnus-summary-wide-reply-with-original
> gnus-summary-reply-to-list-with-original
> gnus-summary-very-wide-reply-with-original
> gnus-summary-reply-broken-reply-to-with-original
>
>
> Personally, I have this config (the only Gnus keybinding I use ;-))
>
>   (define-key gnus-summary-mode-map "R" 
> 'gnus-summary-wide-reply-with-original)
>   (define-key gnus-article-mode-map "R" 
> 'gnus-summary-wide-reply-with-original)
>
> which is consistent with Emacs Notmuch key binding.
>
>
> Hope that helps,
> simon

Yes that helps, exactly what I would have expected, thanks! It is now also my 
only Gnus keybindings, matching my others (mu4e in my case).

Much appreciated,
John






bug#60946: [patch] use correct input in classpath phase

2023-01-19 Thread Dr. Arne Babenhauserheide
Hi,

the patch fixes the build of java-logback-classic (needed for maven).

From 43e16240894bcc7782fe958439aa67001e0d7bda Mon Sep 17 00:00:00 2001
From: Arne Babenhauserheide 
Date: Thu, 19 Jan 2023 20:53:37 +0100
Subject: [PATCH] gnu: java-logback-classic: fix build: use correct input name.

* gnu/packages/java.scm (java-logback-classic)[phases]: use input name java-javaee-servletapi
---
 gnu/packages/java.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 15a4e62de1..e55684d2a3 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -13006,7 +13006,7 @@ (define-public java-logback-classic
 (find-files (assoc-ref inputs input)
 ".*.jar"))
   '("java-logback-core" "java-slf4j-api"
-"java-commons-compiler" "servlet"
+"java-commons-compiler" "java-javaee-servletapi"
 "groovy")))
":"))
  (apply invoke "groovyc" "-d" "build/classes" "-j"
-- 
2.39.1

From 43e16240894bcc7782fe958439aa67001e0d7bda Mon Sep 17 00:00:00 2001
From: Arne Babenhauserheide 
Date: Thu, 19 Jan 2023 20:53:37 +0100
Subject: [PATCH] gnu: java-logback-classic: fix build: use correct input name.

* gnu/packages/java.scm (java-logback-classic)[phases]: use input name java-javaee-servletapi
---
 gnu/packages/java.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 15a4e62de1..e55684d2a3 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -13006,7 +13006,7 @@ (define-public java-logback-classic
 (find-files (assoc-ref inputs input)
 ".*.jar"))
   '("java-logback-core" "java-slf4j-api"
-"java-commons-compiler" "servlet"
+"java-commons-compiler" "java-javaee-servletapi"
 "groovy")))
":"))
  (apply invoke "groovyc" "-d" "build/classes" "-j"
-- 
2.39.1



Best wishes,
Arne
-- 
Unpolitisch sein
heißt politisch sein,
ohne es zu merken.
draketo.de


signature.asc
Description: PGP signature


bug#60890: least-authority-wrapper and make-forkexec-constructor composition problem

2023-01-19 Thread Ludovic Courtès
Hello!

Maxim Cournoyer  skribis:

> It was found that using something like:
>
> (make-forkexec-constructor
>   (least-authority
> (list (file-append coreutils "/bin/true"))
> (mappings (delq 'user %namespaces))
>   #:user  "nobody"
>   #:group "nobody"))
>
> Would fail with EPERM, because in order to be able to drop the user
> namespace, the CAP_SYS_ADMIN capability is required, but in the above
> case, make-forkexec-constructor has already changed the user to
> "nobody", which lacks such capability.

Thanks for the reminder!

I guess the problem is limited to cases where you need the program to
run in the global user namespace.

For example, Tor does not need to run in the global user namespace, and
thus does the following:

--8<---cut here---start->8---
(define (tor-shepherd-service config)
  "Return a  running Tor."
  (let* ((torrc (tor-configuration->torrc config))
 (tor   (least-authority-wrapper
 (file-append (tor-configuration-tor config) "/bin/tor")
 #:name "tor"
 #:mappings (list …)
 #:namespaces (delq 'net %namespaces
(list (shepherd-service
   (provision '(tor))
   ;; …
   (start #~(make-forkexec-constructor
 (list #$tor "-f" #$torrc)
 #:user "tor" #:group "tor"))
   (stop #~(make-kill-destructor))
   (actions (list (shepherd-configuration-action torrc)))
   (documentation "Run the Tor anonymous network overlay.")
--8<---cut here---end--->8---

Here ‘make-forkexec-constructor’ calls setuid/setgid before it invokes
the wrapped program, and everything’s fine.

Ludo’.





bug#60947: Two different derivations for ‘guix’ depending on whether grafts are enabled

2023-01-19 Thread Ludovic Courtès
Ludovic Courtès  skribis:

> We have a problem!  Depending on whether grafts are enabled, we end up
> building one of two different derivations for ‘guix’ (“real”
> derivations; none of them is a mere grafting derivation):
>
> $ guix describe
> Generation 241  Jan 16 2023 00:26:44(current)
>   guix 5c92197
> repository URL: https://git.savannah.gnu.org/git/guix.git
> branch: master
> commit: 5c921977179489caef4a9e54ada6696fc86d2f0b
> $ guix build guix -n
> The following derivation would be built:
>   /gnu/store/hfaffzsjia7x1rbwaryyygh01bskxvvx-guix-1.4.0-1.9fe5b49.drv
> $ guix build guix -n --no-grafts
> /gnu/store/zasc3k9cnk3l1kvi03a4wml33awg21gf-guix-1.4.0-1.9fe5b49
> $ guix build guix -n --no-grafts -d
> /gnu/store/lczdc4jl1yl7cf4mrzqw2b9wiwmc5pwb-guix-1.4.0-1.9fe5b49.drv

Fixed in 88854b1a4e364263b0d3c0d1e87de1ce7da51d34!

Ludo'.





bug#60947: Two different derivations for ‘guix’ depending on whether grafts are enabled

2023-01-19 Thread Ludovic Courtès
We have a problem!  Depending on whether grafts are enabled, we end up
building one of two different derivations for ‘guix’ (“real”
derivations; none of them is a mere grafting derivation):

--8<---cut here---start->8---
$ guix describe
Generation 241  Jan 16 2023 00:26:44(current)
  guix 5c92197
repository URL: https://git.savannah.gnu.org/git/guix.git
branch: master
commit: 5c921977179489caef4a9e54ada6696fc86d2f0b
$ guix build guix -n
The following derivation would be built:
  /gnu/store/hfaffzsjia7x1rbwaryyygh01bskxvvx-guix-1.4.0-1.9fe5b49.drv
$ guix build guix -n --no-grafts
/gnu/store/zasc3k9cnk3l1kvi03a4wml33awg21gf-guix-1.4.0-1.9fe5b49
$ guix build guix -n --no-grafts -d
/gnu/store/lczdc4jl1yl7cf4mrzqw2b9wiwmc5pwb-guix-1.4.0-1.9fe5b49.drv
--8<---cut here---end--->8---

The difference between those two .drv is guile-gnutls-3.7.11.drv, which
themselves differ in their gnulib-2022-12-06-1.440b528.drv.  At the
bottom, the difference is:

diff -ubBr --show-c-function --label \#\ --label \#\ /tmp/buffer-content-DQf9jh /tmp/buffer-content-xYoO4v
--- #
+++ #
@@ -138,7 +138,7 @@
 			(find-ucd-files . names)
 			(map find-ucd-file names))
 		  (with-directory-excursion "lib"
-			(invoke "/gnu/store/p4piblscgrfrsc4sk4ln1vga2ncn502y-gcc-10.3.0/bin/gcc" "-O" "-Wall" "gen-uni-tables.c" "-Iunictype" "-o" "gen-uni-tables")
+			(invoke "/gnu/store/g8la8r45k1bc8yrgg6sw3rz930y0n3rl-gcc-10.3.0/bin/gcc" "-O" "-Wall" "gen-uni-tables.c" "-Iunictype" "-o" "gen-uni-tables")
 			(apply invoke "./gen-uni-tables"
 			   (append
 (find-ucd-files "UnicodeData.txt" "PropList.txt" "DerivedCoreProperties.txt" "emoji/emoji-data.txt" "ArabicShaping.txt" "Scripts.txt" "Blocks.txt")


To be continued…

Ludo’.


bug#60946: java-logback-classic fails to build

2023-01-19 Thread Dr. Arne Babenhauserheide
To reproduce:

guix build java-logback-classic

This is a dependency of maven.

Result:

starting phase `patch-generated-file-shebangs'
phase `patch-generated-file-shebangs' succeeded after 0.0 seconds
starting phase `build'
error: in phase 'build': uncaught exception:
wrong-type-arg #f "Wrong type (expecting ~A): ~S" ("string" #f) (#f) 
phase `build' failed after 0.0 seconds
Backtrace:
  19 (primitive-load "/gnu/store/7my17jqik49hmy3lwp4lrns09rv…")
In guix/build/gnu-build-system.scm:
906:2 18 (gnu-build #:source _ #:outputs _ #:inputs _ #:phases . #)
In ice-9/boot-9.scm:
  1752:10 17 (with-exception-handler _ _ #:unwind? _ # _)
In srfi/srfi-1.scm:
634:9 16 (for-each # …)
In ice-9/boot-9.scm:
  1752:10 15 (with-exception-handler _ _ #:unwind? _ # _)
In guix/build/gnu-build-system.scm:
   927:23 14 (_)
In ice-9/eval.scm:
619:8 13 (_ #(#(#) (# # …)))
159:9 12 (_ #(#(#) (# # …)))
159:9 11 (_ #(#(#) (# # …)))
159:9 10 (_ #(#(#) (# # …)))
In ice-9/boot-9.scm:
   222:29  9 (map1 ("java-logback-core" "java-slf4j-api" "java-co…" …))
   222:29  8 (map1 ("java-slf4j-api" "java-commons-compiler" "ser…" …))
   222:29  7 (map1 ("java-commons-compiler" "servlet" "groovy"))
   222:17  6 (map1 ("servlet" "groovy"))
In guix/build/utils.scm:
   491:10  5 (find-files #f _ #:stat _ #:directories? _ # _)
In ice-9/ftw.scm:
   447:23  4 (file-system-fold _ _ _ _ _ # …)
In ice-9/boot-9.scm:
  1747:15  3 (with-exception-handler # …)
In unknown file:
   2 (lstat #f)
In ice-9/boot-9.scm:
  1685:16  1 (raise-exception _ #:continuable? _)
  1685:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
Wrong type (expecting string): #f
builder for 
`/gnu/store/x2b3pwfmzb3clxnnpnq3ndd9sdzlz4j8-java-logback-classic-1.2.3.drv' 
failed with exit code 1
Erstellung von 
/gnu/store/x2b3pwfmzb3clxnnpnq3ndd9sdzlz4j8-java-logback-classic-1.2.3.drv 
fehlgeschlagen
Das Erstellungsprotokoll kann unter 
„/var/log/guix/drvs/x2/b3pwfmzb3clxnnpnq3ndd9sdzlz4j8-java-logback-classic-1.2.3.drv.gz“
 eingesehen werden.
guix build: Fehler: build of 
`/gnu/store/x2b3pwfmzb3clxnnpnq3ndd9sdzlz4j8-java-logback-classic-1.2.3.drv' 
failed

Best wishes,
Arne

b3pwfmzb3clxnnpnq3ndd9sdzlz4j8-java-logback-classic-1.2.3.drv.gz
Description: Binary data

-- 
Unpolitisch sein
heißt politisch sein,
ohne es zu merken.
draketo.de


signature.asc
Description: PGP signature


bug#60831: Are our graphs okay?

2023-01-19 Thread Ludovic Courtès
Liliana Marie Prikler  skribis:

> The ‘patch-compilation-driver’ phase pulls in libgccjit even though it has
> been deliberately removed from emacs-minimal.
>
> * gnu/packages/emacs.scm (emacs)[#:phases]: Delete ‘patch-compilation-driver’.
> ---
> Thanks Josselin for pointing this out.

Yay, thanks for fixing it!

Perhaps you can add:

  #:disallowed-references (list libgccjit)

for good measure in ‘emacs-minimal’.

Anyway, LGTM too, thanks!

Ludo’.