bug#33609: fortune-mod build (test) failure

2022-07-13 Thread Maxim Cournoyer 
Hi,

Sarah Morgensen  writes:

> Hi,
>
> Pierre Neidhardt  writes:
>
>> I've pushed 6185732390003ca36a730231bb6280b68c37ee8e which skips the
>> valgrind test.  This is not ideal but better than having a broken
>> package.
>>
>> Upstream has https://github.com/shlomif/fortune-mod/issues/21 which
>> could be related.
>
> This seems to be fixed now.  I've attached a patch below to reenable it.
>
> It could probably do with an update, too.  It now vendors 'rinutils'
> (which we already have as an input) so that would need to be removed.

Our fortune-mod package is now at version 3.14.0.  I haven't reviewed
bundling status, but if there are problem, we can open a new issue.

Closing for now,

Thanks!

Maxim

bug#33609: fortune-mod build (test) failure

2021-09-13 Thread Sarah Morgensen 
Hi,

Pierre Neidhardt  writes:

> I've pushed 6185732390003ca36a730231bb6280b68c37ee8e which skips the
> valgrind test.  This is not ideal but better than having a broken
> package.
>
> Upstream has https://github.com/shlomif/fortune-mod/issues/21 which
> could be related.

This seems to be fixed now.  I've attached a patch below to reenable it.

It could probably do with an update, too.  It now vendors 'rinutils'
(which we already have as an input) so that would need to be removed.

--
Sarah

>From 5aa332afa3f624ecab54ffd411026700b0d0dfb8 Mon Sep 17 00:00:00 2001
Message-Id: <5aa332afa3f624ecab54ffd411026700b0d0dfb8.1631594857.git.iskar...@mgsn.dev>
From: Sarah Morgensen 
Date: Mon, 13 Sep 2021 21:40:43 -0700
Subject: [PATCH] gnu: fortune-mod: Re-enable test.

Re-enable the valgrind test, fixed in a previous version update.

* gnu/packages/games.scm (fortune-mod)[arguments]<#:phases>
{fix-build-env}: Re-enable test.
---
 gnu/packages/games.scm | 6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index a2f756e3a7..4236560143 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -7633,11 +7633,7 @@ original.")
(copy-file cmake-rules
   (string-append "fortune-mod/cmake/"
  (strip-store-file-name cmake-rules)))
-   (chdir "fortune-mod")
-   ;; TODO: Valgrind tests fail for some reason.
-   ;; Similar issue: https://github.com/shlomif/fortune-mod/issues/21 (?)
-   (delete-file "tests/t/valgrind.t")
-   #t)))
+   (chdir "fortune-mod"
  (add-after 'install 'fix-install-directory
(lambda* (#:key outputs #:allow-other-keys)
  ;; Move binary from "games/" to "bin/" and remove the latter.  This

base-commit: 72297993a174586ee0a23b95b6b9ee2f3db34cf1
-- 
2.33.0

bug#33609: fortune-mod build (test) failure

2018-12-04 Thread Leo Famulari 
On Tue, Dec 04, 2018 at 11:10:33AM +0100, Danny Milosavljevic wrote:
> # Looks like you failed 4 tests of 4.
> /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t 
>  (Wstat: 1024 Tests: 4 Failed: 4)
>   Failed tests:  1-4
>   Non-zero exit status: 4
> Files=5, Tests=10, 22 wallclock secs ( 0.40 usr  0.05 sys + 14.69 cusr  6.35 
> csys = 21.49 CPU)
> Result: FAIL

I wonder, does this program really need a test suite that includes
Valgrind?


signature.asc
Description: PGP signature

bug#33609: fortune-mod build (test) failure

2018-12-04 Thread Danny Milosavljevic 
Running [prove 
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/check-cookies.t
 
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-m.t
 
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-o-rot.t
 
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/trailing-space-and-CRs.t
 /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t]
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/check-cookies.t
 ... ok
(computers)
%
(cookie)
%
(politics)
%
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-m.t
 .. ok
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-o-rot.t
 .. ok
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/trailing-space-and-CRs.t
 .. ok
No fortunes found

#   Failed test 'fortune valgrind test'
#   at 
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t 
line 15.
No fortunes found

#   Failed test 'fortune -f valgrind test'
#   at 
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t 
line 25.
No fortunes found

#   Failed test 'fortune -m valgrind test'
#   at 
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t 
line 35.
No fortunes found

#   Failed test 'fortune -i -m valgrind test'
#   at 
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t 
line 45.
# Looks like you failed 4 tests of 4.
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t   
   (Wstat: 1024 Tests: 4 Failed: 4)
  Failed tests:  1-4
  Non-zero exit status: 4
Files=5, Tests=10, 22 wallclock secs ( 0.40 usr  0.05 sys + 14.69 cusr  6.35 
csys = 21.49 CPU)
Result: FAIL
Running [prove 
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/check-cookies.t
 
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-m.t
 
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-o-rot.t
 
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/trailing-space-and-CRs.t
 /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t] 
failed! at 
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/run-tests.pl line 32.
make[3]: *** [CMakeFiles/check.dir/build.make:60: CMakeFiles/check] Error 1
make[3]: Leaving directory 
'/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/build'



pgp46l9vpXU9n.pgp
Description: OpenPGP digital signature