bug#47028: [PATCH 2/2] lint: Warn about single-character package names.

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

zimoun writes:

My point is: I am not even sure that “r” should be whitelisted.


I think it deserves the name, but my reasons are fuzzy and feely. 
Anyway: I added that exception for ‘r’ and pushed as 
1126bb9cf33f10f004a5f53331389c777c025e75 et al.


Kind regards,

T G-R


signature.asc
Description: PGP signature

bug#47028: [PATCH 2/2] lint: Warn about single-character package names.

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

zimoun writes:

Maybe the length can be negative or zero. ;-)


‘Defensive programming’!

Thanks, :-)

T G-R

bug#47028: [PATCH 2/2] lint: Warn about single-character package names.

[zimoun]

Hi,

On Tue, 09 Mar 2021 at 22:41, Tobias Geerinckx-Rice  wrote:

> +(define (check-name package)
> +  "Check whether PACKAGE's name matches our guidelines."
> +  ;; Currently checks only whether the name is too short.
> +  (if (<= (string-length (package-name package)) 1)

Maybe the length can be negative or zero. ;-)


Well, both patches are LGTM.


Cheers,
simon

bug#47028: [PATCH 2/2] lint: Warn about single-character package names.

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

* guix/lint.scm (check-name): New procedure.
(%local-checkers): Add it.
---
 guix/lint.scm | 16 +++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/guix/lint.scm b/guix/lint.scm
index 311bc94cc3..5144fa139d 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -6,7 +6,7 @@
 ;;; Copyright © 2016 Danny Milosavljevic 
 ;;; Copyright © 2016 Hartmut Goebel 
 ;;; Copyright © 2017 Alex Kost 
-;;; Copyright © 2017 Tobias Geerinckx-Rice 
+;;; Copyright © 2017, 2021 Tobias Geerinckx-Rice 
 ;;; Copyright © 2017, 2018, 2020 Efraim Flashner 
 ;;; Copyright © 2018, 2019 Arun Isaac 
 ;;; Copyright © 2020 Chris Marusich 
@@ -170,6 +170,16 @@
   (requires-store? lint-checker-requires-store?
(default #f)))
 
+(define (check-name package)
+  "Check whether PACKAGE's name matches our guidelines."
+  ;; Currently checks only whether the name is too short.
+  (if (<= (string-length (package-name package)) 1)
+  (list
+   (make-warning package
+ (G_ "name should be longer than a single character")
+ #:field 'name))
+  '()))
+
 (define (properly-starts-sentence? s)
   (string-match "^[(\"'`[:upper:][:digit:]]" s))
 
@@ -1445,6 +1455,10 @@ them for PACKAGE."
 
 (define %local-checkers
   (list
+   (lint-checker
+ (name'name)
+ (description "Validate package names")
+ (check   check-name))
(lint-checker
  (name'description)
  (description "Validate package descriptions")
-- 
2.30.1