bug#51918: home-bash-service-type adds the defaults and aliases to the end of the file

[Andrew Tropin]

On 2021-12-19 09:45, Xinglu Chen wrote:

> Hi,
>
> On Wed, Nov 17 2021, Andrew Tropin wrote:
>
>> Test in guix-home.sh looks correct, but it fails:
>> https://git.savannah.gnu.org/cgit/guix.git/tree/tests/guix-home.sh?h=5eb5c0789f34e87ee417a53ddfcfa3b6521bb337#n98
>>
>> Seems something changed in home-bash-service-type, for some reason it
>> adds the serialized content of aliases field and guix-bashrc variable
>> after the content of bashrc field.
>
> This was changed in commit 2f665d4309053d5a9fe25bc93ee78d55dbc30cb7
> after discussing it with Liliana[1].  I didn’t really have a strong
> opinion on the order of the things; do you think that it should be changed?
>
> [1]: 

Seems Ludovic fixed it in c322d97832081e6e1913c6311616030d1fad4ee2, I
just had a slightly outdated local repository, when I was reporting this
bug, everything is ok now)

-- 
Best regards,
Andrew Tropin


signature.asc
Description: PGP signature

bug#51918: home-bash-service-type adds the defaults and aliases to the end of the file

[Xinglu Chen]

Hi,

On Wed, Nov 17 2021, Andrew Tropin wrote:

> Test in guix-home.sh looks correct, but it fails:
> https://git.savannah.gnu.org/cgit/guix.git/tree/tests/guix-home.sh?h=5eb5c0789f34e87ee417a53ddfcfa3b6521bb337#n98
>
> Seems something changed in home-bash-service-type, for some reason it
> adds the serialized content of aliases field and guix-bashrc variable
> after the content of bashrc field.

This was changed in commit 2f665d4309053d5a9fe25bc93ee78d55dbc30cb7
after discussing it with Liliana[1].  I didn’t really have a strong
opinion on the order of the things; do you think that it should be changed?

[1]: 


signature.asc
Description: PGP signature

bug#51918: home-bash-service-type adds the defaults and aliases to the end of the file

[Andrew Tropin]

Test in guix-home.sh looks correct, but it fails:
https://git.savannah.gnu.org/cgit/guix.git/tree/tests/guix-home.sh?h=5eb5c0789f34e87ee417a53ddfcfa3b6521bb337#n98

Seems something changed in home-bash-service-type, for some reason it
adds the serialized content of aliases field and guix-bashrc variable
after the content of bashrc field.

Original implementation works as expected and adds the content of bashrc
to the end of ~/.bashrc.

--8<---cut here---start->8---
(list
 ((@ (gnu services) service)
  (@ (gnu home-services shells) home-bash-service-type)
  ((@ (gnu home-services shells) home-bash-configuration)
   (guix-defaults? #t)
   (bashrc (list "echo hi"
 ((@ (gnu services) simple-service)
  'test-bash
  (@ (gnu home-services shells) home-bash-service-type)
  ((@ (gnu home-services shells) home-bash-extension)
   (bashrc (list "echo very hi")
--8<---cut here---end--->8---

https://git.sr.ht/~abcdw/rde/tree/master/item/gnu/home-services/shells.scm

-- 
Best regards,
Andrew Tropin


signature.asc
Description: PGP signature