bug#56444: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions

[Maxime Devos]

On 29-08-2022 14:57, Thompson, David wrote:


I disagree.  I believe we shouldn't let perfect be the enemy of the good.


I don't think your patch counts as "good" here -- while fixing the bug 
counts as "good", you are at the same time introducing a new bug (the 
non-atomicity), which is bad.  You would have to weigh the goodness and 
the badness to end up with an overall "good" (or maybe "bad", depending 
on the conclusion), but I'd think that the time required to do such a 
weighing is better spent by doing a tiny bit of extra effort to 
implement the new field (it should be very low effort, see other response).


Greetings,
Maxime.


OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

bug#56444: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions

[Maxime Devos]

On 29-08-2022 14:57, Thompson, David wrote:

[...]
Can any other maintainers please chime in here?


To correct a misunderstanding, I'm not a maintainer, at least if you 
meant "maintainer" in the same sense as used at 
.


Greetings,
Maxime




OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

bug#56444: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions

[Maxime Devos]

On 29-08-2022 14:57, Thompson, David wrote:

Hi Maxime,

I disagree.  I believe we shouldn't let perfect be the enemy of the 
good.  I haven't sent patches to Guix in quite some time, but I've 
never felt roadblocked like this and it is concerning to me.


It's almost trivial to implement 'the perfect' here, almost no more 
effort than your partial solution; there is no "perfect enemy of the 
good" situation here -- "perfect enemy of the good" only applies when 
"the perfect" is significantly harder / more effort than "the good", but 
that's not the case here.


Given that a proper fix is very easy, simple and low-effort and 
furthermore, it is even known what form the proper fix would take (see: 
extra field, + adjust procedure in (gnu build activation) slightly), 
there aren't any roadblocks except for an apparent refusal by you to 
invest a little extra effort.


If you genuinely find it actually hard to implement, please tell so and 
I can give you some pointers on what procedures appear to be need to be 
modified. Currently, your response appears to be made in bad faith t me.


Greetings,
Maxime



OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

bug#56444: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions

[Thompson, David]

Hi Maxime,

I disagree.  I believe we shouldn't let perfect be the enemy of the good.
I haven't sent patches to Guix in quite some time, but I've never felt
roadblocked like this and it is concerning to me.

Can any other maintainers please chime in here?

- Dave

On Mon, Aug 29, 2022 at 8:52 AM Maxime Devos  wrote:

>
> On 29-08-2022 14:49, Thompson, David wrote:
> > Hi again Maxime,
> >
> > What do you think of my proposal?  Do any other maintainers care to
> > chime in here?
> >
> > - Dave
>
> Backlogged thing have a tendency to be backlogged indefinitely, and my
> proposal for a home-permissions-bits seems straightforward and simple to
> me, so I would rather not trade a bug for another bug but rather do a
> proper fix.
>
> Greetings,
> Maxime.
>