bug#59131: gnu: emacs-magit: Tests fail.

[Maxim Cournoyer]

"("  writes:

> Fixed independently of my patch by updating to that commit.

Thanks for the heads-up; closing.

-- 
Thanks,
Maxim

bug#59131:

[paren--- via Bug reports for GNU Guix]

Fixed independently of my patch by updating to that commit.

-- (

bug#59131: gnu: emacs-magit: Tests fail.

[paren--- via Bug reports for GNU Guix]

Heya,

On Wed Nov 9, 2022 at 4:04 AM GMT, Kyle Meyer wrote:
> (In terms of fixing Guix's emacs-magit build, 36059e0b applies cleanly
> to v3.3.0's tree.)

Done: .

-- (

bug#59131: gnu: emacs-magit: Tests fail.

[paren--- via Bug reports for GNU Guix]

Heya,

On Wed Nov 9, 2022 at 4:04 AM GMT, Kyle Meyer wrote:
> Thanks for posting this.  This recently started failing on Magit's CI,
> but nobody had looked into it too deeply yet.  Your message suggested
> that bisecting Git v2.38.0..v2.38.1 would be a good place to start.
>
> That pointed to this being fallout from Git's a1d4f67c12 (transport:
> make `protocol.file.allow` be "user" by default, 2022-10-01), and the
> two failures above are now resolved by Magit's 36059e0b (test: Set
> protocol.file.allow=always to restore old Git behavior, 2022-11-08).
>
> (In terms of fixing Guix's emacs-magit build, 36059e0b applies cleanly
> to v3.3.0's tree.)

Thanks for the investigation and fix! I'll submit a patch to apply 36059e0b
on top of our emacs-magit source.

-- (

bug#59131: gnu: emacs-magit: Tests fail.

[Kyle Meyer]

paren--- via Bug reports for GNU Guix writes:

>   $ guix describe
>   Generation 240  Nov 08 2022 18:38:30(current)
>   guix c52cdd1
> repository URL: https://git.savannah.gnu.org/git/guix.git
> branch: master
> commit: c52cdd18d6f869dfb1f8b5214a0db6ebb562
> [...]
>
>   2 unexpected results:
>  FAILED  magit-get
>  FAILED  magit-toplevel:submodule
>
>   1 skipped results:
> SKIPPED  magit-toplevel:tramp
>
>   make: *** [Makefile:111: test] Error 1
>
> This appears to have been caused by commit 83ede5a ("gnu: git: Update to 
> 2.38.1.").

Thanks for posting this.  This recently started failing on Magit's CI,
but nobody had looked into it too deeply yet.  Your message suggested
that bisecting Git v2.38.0..v2.38.1 would be a good place to start.

That pointed to this being fallout from Git's a1d4f67c12 (transport:
make `protocol.file.allow` be "user" by default, 2022-10-01), and the
two failures above are now resolved by Magit's 36059e0b (test: Set
protocol.file.allow=always to restore old Git behavior, 2022-11-08).

(In terms of fixing Guix's emacs-magit build, 36059e0b applies cleanly
to v3.3.0's tree.)

bug#59131: gnu: emacs-magit: Tests fail.

[paren--- via Bug reports for GNU Guix]

Heya Guix,

  $ guix describe
  Generation 240Nov 08 2022 18:38:30(current)
  guix c52cdd1
repository URL: https://git.savannah.gnu.org/git/guix.git
branch: master
commit: c52cdd18d6f869dfb1f8b5214a0db6ebb562
  [...]

EMACS-MAGIT fails to build on master, as two tests fail:

  starting phase `check'
  Loading /tmp/guix-build-emacs-magit-3.3.0.drv-0/source/t/magit-tests.el 
(source)...
  Running 20 tests (2022-11-08 19:45:52+, selector ‘t’)
 passed   1/20  magit--with-safe-default-directory (0.012841 sec)
  Keeping test directory:
/tmp/guix-build-emacs-magit-3.3.0.drv-0/magit-HMOZ05/
  Test magit-get backtrace:
signal(magit-git-error ("clone of '/tmp/guix-build-emacs-magit-3.3.0
(condition-case err (let* ((vnew #'(lambda (&rest _))) (old (symbol-
(let ((dir (file-name-as-directory (make-temp-file "magit-" t))) (pr
(let ((lexical-binding nil)) (let ((dir (file-name-as-directory (mak
(lambda nil (let ((lexical-binding nil)) (let ((dir (file-name-as-di
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name magit-get :documentation nil :body (l
ert-run-or-rerun-test(#s(ert--stats :selector t :tests [... ... ... 
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
(progn (load-file "t/magit-tests.el") (ert-run-tests-batch-and-exit)
eval((progn (load-file "t/magit-tests.el") (ert-run-tests-batch-and-
command-line-1(("-L" "./lisp" "-L" "./../dash" "-L" "./../libgit" "-
command-line()
normal-top-level()
  Test magit-get condition:
  (magit-git-error "clone of 
'/tmp/guix-build-emacs-magit-3.3.0.drv-0/magit-HMOZ05/remote' into submodule 
path '/tmp/guix-build-emacs-magit-3.3.0.drv-0/magit-HMOZ05/super/repo' failed 
(in /tmp/guix-build-emacs-magit-3.3.0.drv-0/magit-HMOZ05/super/)")
 FAILED   2/20  magit-get (0.381424 sec)
 passed   3/20  magit-get-boolean (0.149823 sec)
 passed   4/20  magit-get-{current|next}-tag (0.366224 sec)
 passed   5/20  magit-in-bare-repo (0.027539 sec)
 passed   6/20  magit-in-non-bare-repo (0.042858 sec)
 passed   7/20  magit-list-{|local-|remote-}branch-names (0.152424 sec)
 passed   8/20  magit-process:match-prompt-match-non-first-prompt (0.29 
sec)
 passed   9/20  magit-process:match-prompt-nil-when-no-match (0.19 sec)
 passed  10/20  magit-process:match-prompt-non-nil-when-match (0.19 sec)
 passed  11/20  magit-process:match-prompt-preserves-match-group (0.24 
sec)
 passed  12/20  magit-process:match-prompt-suffixes-prompt (0.21 sec)
 passed  13/20  magit-process:password-prompt (0.29 sec)
 passed  14/20  magit-process:password-prompt-observed (0.000308 sec)
 passed  15/20  magit-status:file-sections (0.417049 sec)
 passed  16/20  magit-status:log-sections (0.432241 sec)
 passed  17/20  magit-toplevel:basic (0.155159 sec)
  Keeping test directory:
/tmp/guix-build-emacs-magit-3.3.0.drv-0/magit-F6vcoC/
  Test magit-toplevel:submodule backtrace:
signal(magit-git-error ("clone of '/tmp/guix-build-emacs-magit-3.3.0
(condition-case err (let* ((vnew #'(lambda (&rest _))) (old (symbol-
(let ((dir (file-name-as-directory (make-temp-file "magit-" t))) (pr
(let ((find-file-visit-truename nil)) (let ((dir (file-name-as-direc
(let ((lexical-binding nil)) (let ((find-file-visit-truename nil)) (
(lambda nil (let ((lexical-binding nil)) (let ((find-file-visit-true
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name magit-toplevel:submodule :documentati
ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
(progn (load-file "t/magit-tests.el") (ert-run-tests-batch-and-exit)
eval((progn (load-file "t/magit-tests.el") (ert-run-tests-batch-and-
command-line-1(("-L" "./lisp" "-L" "./../dash" "-L" "./../libgit" "-
command-line()
normal-top-level()
  Test magit-toplevel:submodule condition:
  (magit-git-error "clone of 
'/tmp/guix-build-emacs-magit-3.3.0.drv-0/magit-F6vcoC/remote' into submodule 
path '/tmp/guix-build-emacs-magit-3.3.0.drv-0/magit-F6vcoC/super/repo' failed 
(in /tmp/guix-build-emacs-magit-3.3.0.drv-0/magit-F6vcoC/super/)")
 FAILED  18/20  magit-toplevel:submodule (0.180480 sec)
skipped  19/20  magit-toplevel:tramp (0.79 sec)
 passed  20/20  magit-utils:add-face-text-property (0.25 sec)

  Ran 20 tests, 17 results as expected, 2 unexpected, 1 skipped (2022-11-08 
19:45:54+, 2.453376 sec)

  2 unexpected results:
 FAILED  magit-get
 FAILED  magit-toplevel:submodule

  1 skipped results:
SKIPPED  magit-toplevel:tramp

  make: *** [Makefile:111: test] Error 1

This appears to have been caused b