bug#69682: [PATCH v2] gnu: ocaml-extlib: Convert to dune-build-system.

2024-03-09 Thread Vivien Kraus via Bug reports for GNU Guix
* gnu/packages/ocaml.scm (ocaml-extlib) [build-system]: Convert to
dune-build-system.
[arguments]: Remove '#:phases' and add '#:package'.

Change-Id: Ia50c05423f3062200704fbcbb0680f2b326a7ca4
---
Opam still builds on gnome-team.

 gnu/packages/ocaml.scm | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 0f4c351141..b70e925d51 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -644,11 +644,9 @@ (define-public ocaml-extlib
   (sha256
(base32
 "1jydzw2n84cfiz9y6lk4gih4wbr8jybanmiryfs01svd07g4vpjq"
-(build-system ocaml-build-system)
+(build-system dune-build-system)
 (arguments
- `(#:phases
-   (modify-phases %standard-phases
- (delete 'configure
+ (list #:package "extlib"))
 (native-inputs
   (list ocaml-cppo))
 (home-page "https://github.com/ygrek/ocaml-extlib";)

base-commit: 2f441fc738976175d438f7942211b1894e2eb416
-- 
2.41.0





bug#69682: [PATCH v2] gnu: ocaml-extlib: Convert to dune-build-system.

2024-03-24 Thread pukkamustard


Sorry for being late to the party. But the conversion to use
dune-build-system looks good to me!

I ran into the same issue when updating opam to 2.1.5 but never managed
to get to the bottom of it. Thanks for figuring this out!

-pukkamustard

Vivien Kraus  writes:

> * gnu/packages/ocaml.scm (ocaml-extlib) [build-system]: Convert to
> dune-build-system.
> [arguments]: Remove '#:phases' and add '#:package'.
>
> Change-Id: Ia50c05423f3062200704fbcbb0680f2b326a7ca4
> ---
> Opam still builds on gnome-team.
>
>  gnu/packages/ocaml.scm | 6 ++
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
> index 0f4c351141..b70e925d51 100644
> --- a/gnu/packages/ocaml.scm
> +++ b/gnu/packages/ocaml.scm
> @@ -644,11 +644,9 @@ (define-public ocaml-extlib
>(sha256
> (base32
>  "1jydzw2n84cfiz9y6lk4gih4wbr8jybanmiryfs01svd07g4vpjq"
> -(build-system ocaml-build-system)
> +(build-system dune-build-system)
>  (arguments
> - `(#:phases
> -   (modify-phases %standard-phases
> - (delete 'configure
> + (list #:package "extlib"))
>  (native-inputs
>(list ocaml-cppo))
>  (home-page "https://github.com/ygrek/ocaml-extlib";)
>
> base-commit: 2f441fc738976175d438f7942211b1894e2eb416