Re: [PATCH] ifconfig hurd: Notify pfinet of interfaces
September 28, 2022 12:25 PM, "Alfred M. Szmidt" wrote: > Alfred M. Szmidt, le mer. 28 sept. 2022 11:21:34 -0400, a ecrit: >>> have you signed copyright assignment papers for InetUtils, >> >> I didn't know there was copyright assignment for InetUtils :/ >> >> It has always been the case. The process is a few days in the best of >> cases, and even if it is a week or more, it doesn't slow down progress >> much, if at all. > > I have very often seen it take months. > > If it takes that long, please escalate to the FSF clerk and RMS. It > shouldn't take that long. Once 20 years ago, it did take a while but > the process is now mostly digital. I wish it could be as easy as a web based application.
Re: [hurd,commited] hurd: Increase SOMAXCONN to 4096
Andreas Schwab, le mer. 28 sept. 2022 09:48:33 +0200, a ecrit: > On Sep 27 2022, Samuel Thibault wrote: > > > Notably fakeroot-tcp may introduce a lot of parallel connections. > > --- > > sysdeps/mach/hurd/bits/socket.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sysdeps/mach/hurd/bits/socket.h > > b/sysdeps/mach/hurd/bits/socket.h > > index 70fce4fb27..4ece37f1dd 100644 > > --- a/sysdeps/mach/hurd/bits/socket.h > > +++ b/sysdeps/mach/hurd/bits/socket.h > > @@ -147,7 +147,7 @@ enum __socket_type > > #defineAF_MAX PF_MAX > > > > /* Maximum queue length specifiable by listen. */ > > -#define SOMAXCONN 128 /* 5 on the origional 4.4 BSD. */ > > +#define SOMAXCONN 4096/* 5 on the origional 4.4 BSD. */ > > Perhaps fix the comment as well. Right, done so :) Samuel
Re: doxygen: FTBFS on hurd-i386
Control: forwarded -1 https://github.com/doxygen/doxygen/pull/9514 Svante Signell, le mer. 28 sept. 2022 17:40:32 +0200, a ecrit: > Currently doxygen FTBFS on GNU/Hurd due to a PATH_MAX issue. This issue was already forwarded upstream on https://github.com/doxygen/doxygen/pull/9514 they said it was actually imported from another project: https://github.com/gulrak/filesystem/pull/154 In the meanwhile we already have patched version 1.9.4-2+hurd.1 available in unreleased. Samuel
Re: [PATCH] ifconfig hurd: Notify pfinet of interfaces
Alfred M. Szmidt, le mer. 28 sept. 2022 11:21:34 -0400, a ecrit: >> have you signed copyright assignment papers for InetUtils, > >I didn't know there was copyright assignment for InetUtils :/ > > It has always been the case. The process is a few days in the best of > cases, and even if it is a week or more, it doesn't slow down progress > much, if at all. I have very often seen it take months. Samuel
Re: [PATCH] ifconfig hurd: Notify pfinet of interfaces
We collect as per usual copyright assignments for the GNU network utilities. Just as per normal GNU policies.
Re: doxygen: FTBFS on hurd-i386
Svante Signell, le mer. 28 sept. 2022 18:09:58 +0200, a ecrit: > On Wed, 2022-09-28 at 17:50 +0200, Samuel Thibault wrote: > > Control: forwarded -1 https://github.com/doxygen/doxygen/pull/9514 > > > > Svante Signell, le mer. 28 sept. 2022 17:40:32 +0200, a ecrit: > > > Currently doxygen FTBFS on GNU/Hurd due to a PATH_MAX issue. > > > > This issue was already forwarded upstream on > > https://github.com/doxygen/doxygen/pull/9514 > > > > they said it was actually imported from another project: > > https://github.com/gulrak/filesystem/pull/154 > > > > In the meanwhile we already have patched version 1.9.4-2+hurd.1 > > available in unreleased. > > Thanks, I did not know about this. Maybe you can create a version > 1.9.4-3.hurd.1 version to avoid doxygen-latex not being held when > upgrading. Well, I could do that but that would be moot whenever a newer doxygen package gets uploaded again. Samuel
Re: doxygen: FTBFS on hurd-i386
On Wed, 2022-09-28 at 17:50 +0200, Samuel Thibault wrote: > Control: forwarded -1 https://github.com/doxygen/doxygen/pull/9514 > > Svante Signell, le mer. 28 sept. 2022 17:40:32 +0200, a ecrit: > > Currently doxygen FTBFS on GNU/Hurd due to a PATH_MAX issue. > > This issue was already forwarded upstream on > https://github.com/doxygen/doxygen/pull/9514 > > they said it was actually imported from another project: > https://github.com/gulrak/filesystem/pull/154 > > In the meanwhile we already have patched version 1.9.4-2+hurd.1 > available in unreleased. Thanks, I did not know about this. Maybe you can create a version 1.9.4-3.hurd.1 version to avoid doxygen-latex not being held when upgrading. (when upgrading/dist-upgrading it is very annoying to see these messages). Thanks again, your solution is much better than mine (though very similar). thanks!
socat: FTBFS on hurd-i386
Source: socat Version: 1.7.4.3-3 Severity: important Tags: patch User: debian-h...@lists.debian.org Usertags: hurd Cc: bug-hurd Hi, Currently socat FTBFS on GNU/Hurd due to differing values for O_RDONLY, O_WRONLY and O_RDWR compared to Linux systems. The attached patch, xioinitialize.c.patch, fixes the build problem. Unfortunately, since util-linux build-depends on socat, that package cannot be built. A problem is that socat depends on netstat or ip to function properly, and is used in the tests, not being available for GNU/Hurd. So building the package w/o tests is recommended. (No patch is attached to disable tests in this posting). Additionally ifconfig is needed for the tests, but probably inetutils- ifconfig can be used as a replacement. That package just need to add a link of /usr/bin/inetutils-ifconfig to /sbin/ifconfig. Thanks! --- a/xioinitialize.c 2019-04-04 10:59:55.0 +0200 +++ b/xioinitialize.c 2022-09-02 19:20:22.0 +0200 @@ -27,10 +27,15 @@ assert(sizeof(uint32_t)==4); /* assertions regarding O_ flags - important for XIO_READABLE() etc. */ +#ifdef __GNU__ + assert(O_RDONLY==1); + assert(O_WRONLY==2); + assert(O_RDWR==3); +#else assert(O_RDONLY==0); assert(O_WRONLY==1); assert(O_RDWR==2); - +#endif assert(SHUT_RD==0); assert(SHUT_WR==1); assert(SHUT_RDWR==2);
Re: [PATCH] ifconfig hurd: Notify pfinet of interfaces
Alfred M. Szmidt, le mer. 28 sept. 2022 11:21:34 -0400, a ecrit: >> have you signed copyright assignment papers for InetUtils, > >I didn't know there was copyright assignment for InetUtils :/ > > It has always been the case. The process is a few days in the best of > cases, and even if it is a week or more, it doesn't slow down progress > much, if at all. I have very often seen it take months. If it takes that long, please escalate to the FSF clerk and RMS. It shouldn't take that long. Once 20 years ago, it did take a while but the process is now mostly digital.
Re: [PATCH] ifconfig hurd: Notify pfinet of interfaces
> have you signed copyright assignment papers for InetUtils, I didn't know there was copyright assignment for InetUtils :/ It has always been the case. The process is a few days in the best of cases, and even if it is a week or more, it doesn't slow down progress much, if at all. I now have sent the form to the clerk, but really, such process slows down contributions, particularly if not all code is copyright by FSF. Thanks.
doxygen: FTBFS on hurd-i386
Source: doxygen
Version: 1.9.4-3
Severity: important
Tags: patch
User: debian-h...@lists.debian.org
Usertags: hurd
Hi,
Currently doxygen FTBFS on GNU/Hurd due to a PATH_MAX issue.
The attached patch, filesystem_filesystem.hpp.diff, fixes the build
problem by special-casing for Hurd. In fact the patch could be applied
to all glibc-based systems and upstreamed.
However, it is not very C++-ish, maybe some better solution could be
used. Cc-ing bug-hurd for comments, WDYT?
Thanks!
Index: doxygen-1.9.4/filesystem/filesystem.hpp
===
--- doxygen-1.9.4.orig/filesystem/filesystem.hpp
+++ doxygen-1.9.4/filesystem/filesystem.hpp
@@ -56,6 +56,8 @@
#define GHC_OS_MACOS
#elif defined(__linux__)
#define GHC_OS_LINUX
+#elif defined(__GNU__)
+#define GHC_OS_GNU
#if defined(__ANDROID__)
#define GHC_OS_ANDROID
#endif
@@ -4081,6 +4083,13 @@ GHC_INLINE path current_path(std::error_
return path();
}
return path(std::wstring(buffer.get()), path::native_format);
+#elif defined(GHC_OS_GNU)
+char* buffer = ::getcwd (NULL, 0);
+if (buffer == nullptr) {
+ec = detail::make_system_error();
+return path();
+}
+return path(buffer);
#else
size_t pathlen = static_cast(std::max(int(::pathconf(".", _PC_PATH_MAX)), int(PATH_MAX)));
std::unique_ptr buffer(new char[pathlen + 1]);
Re: [PATCH] ifconfig hurd: Notify pfinet of interfaces
Hello, Simon Josefsson, le mer. 28 sept. 2022 13:46:52 +0200, a ecrit: > have you signed copyright assignment papers for InetUtils, I didn't know there was copyright assignment for InetUtils :/ I now have sent the form to the clerk, but really, such process slows down contributions, particularly if not all code is copyright by FSF. Samuel
Re: [PATCH] ifconfig hurd: Notify pfinet of interfaces
Samuel Thibault writes: > Hello, > > Simon Josefsson, le mer. 28 sept. 2022 13:46:52 +0200, a ecrit: >> have you signed copyright assignment papers for InetUtils, > > I didn't know there was copyright assignment for InetUtils :/ > > I now have sent the form to the clerk, but really, such process slows > down contributions, particularly if not all code is copyright by FSF. Thank you! If someone could engage with the FSF on what a suitable copyright assignment policy for InetUtils would be, that would clarify. I agree that requiring copyright assignments for a patch that fixes bugs in code not owned by the FSF anyway is detrimental to contributions. /Simon signature.asc Description: PGP signature
Re: [PATCH] ifconfig hurd: Notify pfinet of interfaces
Both your patches looks good to me -- however, have you signed copyright assignment papers for InetUtils, or how are these contributed? Generally I'm not sure how useful it is to require copyright assignment for smaller InetUtils contributions -- the majority of the code is not copyright by FSF anyway. If you can sign papers for InetUtils, that question is not relevant though. /Simon signature.asc Description: PGP signature
Re: [hurd,commited] hurd: Increase SOMAXCONN to 4096
On Sep 27 2022, Samuel Thibault wrote: > Notably fakeroot-tcp may introduce a lot of parallel connections. > --- > sysdeps/mach/hurd/bits/socket.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/mach/hurd/bits/socket.h b/sysdeps/mach/hurd/bits/socket.h > index 70fce4fb27..4ece37f1dd 100644 > --- a/sysdeps/mach/hurd/bits/socket.h > +++ b/sysdeps/mach/hurd/bits/socket.h > @@ -147,7 +147,7 @@ enum __socket_type > #define AF_MAX PF_MAX > > /* Maximum queue length specifiable by listen. */ > -#define SOMAXCONN128 /* 5 on the origional 4.4 BSD. */ > +#define SOMAXCONN4096/* 5 on the origional 4.4 BSD. */ Perhaps fix the comment as well. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."
