Re: [PATCH 22/28] ddb/db_expr.c (db_add_expr): remove unnecessary variable

2013-12-08 Thread Samuel Thibault
Marin Ramesa, le Sun 08 Dec 2013 12:40:24 +0100, a écrit :
> Value db_tok_string[0] can be used instead of c.

Ditto.

> * ddb/db_expr.c (db_add_expr): Remove unnecessary variable.
> 
> ---
>  ddb/db_expr.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/ddb/db_expr.c b/ddb/db_expr.c
> index bd68f92..a74cdec 100644
> --- a/ddb/db_expr.c
> +++ b/ddb/db_expr.c
> @@ -226,16 +226,14 @@ db_add_expr(valuep)
>  {
>   db_expr_t   lhs, rhs;
>   int t;
> - charc;
>  
>   if (!db_mult_expr(&lhs))
>   return (FALSE);
>  
>   t = db_read_token();
>   while (t == tPLUS || t == tMINUS || t == tBIT_OR) {
> - c = db_tok_string[0];
>   if (!db_mult_expr(&rhs)) {
> - db_printf("Expression syntax error after '%c'\n", c);
> + db_printf("Expression syntax error after '%c'\n", 
> db_tok_string[0]);
>   db_error(0);
>   /*NOTREACHED*/
>   }
> -- 
> 1.8.1.4
> 
> 

-- 
Samuel
if (argc > 1 && strcmp(argv[1], "-advice") == 0) {
printf("Don't Panic!\n");
exit(42);
}
-- Arnold Robbins in the LJ of February '95, describing RCS



[PATCH 22/28] ddb/db_expr.c (db_add_expr): remove unnecessary variable

2013-12-08 Thread Marin Ramesa
Value db_tok_string[0] can be used instead of c.

* ddb/db_expr.c (db_add_expr): Remove unnecessary variable.

---
 ddb/db_expr.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/ddb/db_expr.c b/ddb/db_expr.c
index bd68f92..a74cdec 100644
--- a/ddb/db_expr.c
+++ b/ddb/db_expr.c
@@ -226,16 +226,14 @@ db_add_expr(valuep)
 {
db_expr_t   lhs, rhs;
int t;
-   charc;
 
if (!db_mult_expr(&lhs))
return (FALSE);
 
t = db_read_token();
while (t == tPLUS || t == tMINUS || t == tBIT_OR) {
-   c = db_tok_string[0];
if (!db_mult_expr(&rhs)) {
-   db_printf("Expression syntax error after '%c'\n", c);
+   db_printf("Expression syntax error after '%c'\n", 
db_tok_string[0]);
db_error(0);
/*NOTREACHED*/
}
-- 
1.8.1.4