Re: [hurd,commited] htl: Enable more tests
Samuel Thibault, le lun. 08 juin 2020 13:34:42 +0200, a ecrit: > Andreas Schwab, le lun. 08 juin 2020 12:43:16 +0200, a ecrit: > > On Jun 07 2020, Samuel Thibault wrote: > > > > > * htl/Makefile: Remove rules adding libpthread.so and libpthread.a to link > > > lines. > > > * nptl/Makefile: Move rules adding libpthread.so and libpthread.a to > > > link lines to... > > > * sysdeps/pthread/Makefile: ... here. > > > > That breaks powerpc: > [...] > > make[2]: *** [../Rules:223: > > /home/abuild/rpmbuild/BUILD/glibc-2.31.9000.532.g314a431d37/cc-base/nptl/test-get_hwcap] > > Error 1 > > Oh... > So it's a test added by sysdeps/powerpc/Makefile, and it seems > sysdeps/powerpc gets included *after* sysdeps/pthread, thus the missing > rules for this test. I'll copy back the rules to htl/ and nptl/ for now. Done so. Samuel
Re: [hurd,commited] htl: Enable more tests
Andreas Schwab, le lun. 08 juin 2020 12:43:16 +0200, a ecrit: > On Jun 07 2020, Samuel Thibault wrote: > > > * htl/Makefile: Remove rules adding libpthread.so and libpthread.a to link > > lines. > > * nptl/Makefile: Move rules adding libpthread.so and libpthread.a to > > link lines to... > > * sysdeps/pthread/Makefile: ... here. > > That breaks powerpc: [...] > make[2]: *** [../Rules:223: > /home/abuild/rpmbuild/BUILD/glibc-2.31.9000.532.g314a431d37/cc-base/nptl/test-get_hwcap] > Error 1 Oh... So it's a test added by sysdeps/powerpc/Makefile, and it seems sysdeps/powerpc gets included *after* sysdeps/pthread, thus the missing rules for this test. I'll copy back the rules to htl/ and nptl/ for now. Samuel
Re: [hurd,commited] htl: Enable more tests
On Jun 07 2020, Samuel Thibault wrote: > * htl/Makefile: Remove rules adding libpthread.so and libpthread.a to link > lines. > * nptl/Makefile: Move rules adding libpthread.so and libpthread.a to > link lines to... > * sysdeps/pthread/Makefile: ... here. That breaks powerpc: /usr/lib64/gcc/powerpc64-suse-linux/10/../../../../powerpc64-suse-linux/bin/ld: /home/abuild/rpmbuild/BUILD/glibc-2.31.9000.532.g314a431d37/cc-base/support/libsupport_nonshared.a(xpthread_create.oS): in function `xpthread_create': /home/abuild/rpmbuild/BUILD/glibc-2.31.9000.532.g314a431d37/support/xpthread_create.c:26: undefined reference to `pthread_create' /usr/lib64/gcc/powerpc64-suse-linux/10/../../../../powerpc64-suse-linux/bin/ld: /home/abuild/rpmbuild/BUILD/glibc-2.31.9000.532.g314a431d37/cc-base/support/libsupport_nonshared.a(xpthread_join.oS): in function `xpthread_join': /home/abuild/rpmbuild/BUILD/glibc-2.31.9000.532.g314a431d37/support/xpthread_join.c:25: undefined reference to `pthread_join' collect2: error: ld returned 1 exit status make[2]: *** [../Rules:223: /home/abuild/rpmbuild/BUILD/glibc-2.31.9000.532.g314a431d37/cc-base/nptl/test-get_hwcap] Error 1 Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."
