Re: Gnumach: locore.S copyin vs. copyinmsg

2006-11-10 Thread Barry deFreese 


- Original Message - 
From: "Thomas Bushnell BSG" <[EMAIL PROTECTED]>

To: "Samuel Thibault" <[EMAIL PROTECTED]>
Cc: "Barry deFreese" <[EMAIL PROTECTED]>; 
Sent: Friday, November 10, 2006 1:04 PM
Subject: Re: Gnumach: locore.S copyin vs. copyinmsg

Yeah, I already added declarations for copyinmsg and copyoutmsg in locore.h.

Thanks for the replies!

Barry 




___
Bug-hurd mailing list
Bug-hurd@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-hurd

Re: Gnumach: locore.S copyin vs. copyinmsg

2006-11-10 Thread Thomas Bushnell BSG 
On Fri, 2006-11-10 at 16:07 +0100, Samuel Thibault wrote:
> Hi,
> 
> Barry deFreese, le Fri 10 Nov 2006 09:58:20 -0500, a écrit :
> > From my extremely limited knowledge of assembler, copyin and  
> > copyinmsg look to be exactly the same.
> 
> They are not the same when using gprof: see asm.h, in that case ENTRY
> does a bit more stuff.
> 
> Moreover, when looking at the calls to copyin, copyinmsg, copyout and
> copyoutmsg, it looks like the prototypes should respectively be
> 
> int copyin(const void *from, void *to, size_t size);
> int copyinmsg(vm_offset_t from, vm_offset_t to, size_t size);
> int copyout(const void *from, void *to, size_t size);
> int copyoutmsg(vm_offset_t from, vm_offset_t to, size_t size);
> 
> May somebody more experienced with these functions confirm this?

Yes Samuel, you are correct here, AFAICT and R.

Thomas



signature.asc
Description: This is a digitally signed message part
___
Bug-hurd mailing list
Bug-hurd@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-hurd

Re: Gnumach: locore.S copyin vs. copyinmsg

2006-11-10 Thread Samuel Thibault 
Hi,

Barry deFreese, le Fri 10 Nov 2006 09:58:20 -0500, a écrit :
> From my extremely limited knowledge of assembler, copyin and  
> copyinmsg look to be exactly the same.

They are not the same when using gprof: see asm.h, in that case ENTRY
does a bit more stuff.

Moreover, when looking at the calls to copyin, copyinmsg, copyout and
copyoutmsg, it looks like the prototypes should respectively be

int copyin(const void *from, void *to, size_t size);
int copyinmsg(vm_offset_t from, vm_offset_t to, size_t size);
int copyout(const void *from, void *to, size_t size);
int copyoutmsg(vm_offset_t from, vm_offset_t to, size_t size);

May somebody more experienced with these functions confirm this?

(and btw you may drop the explicit casts in a lot of cases).

Samuel


___
Bug-hurd mailing list
Bug-hurd@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-hurd