Re: doxygen: FTBFS on hurd-i386

2022-09-28 Thread Samuel Thibault 
Control: forwarded -1 https://github.com/doxygen/doxygen/pull/9514

Svante Signell, le mer. 28 sept. 2022 17:40:32 +0200, a ecrit:
> Currently doxygen FTBFS on GNU/Hurd due to a PATH_MAX issue.

This issue was already forwarded upstream on
https://github.com/doxygen/doxygen/pull/9514

they said it was actually imported from another project:
https://github.com/gulrak/filesystem/pull/154

In the meanwhile we already have patched version 1.9.4-2+hurd.1
available in unreleased.

Samuel

Re: doxygen: FTBFS on hurd-i386

2022-09-28 Thread Samuel Thibault 
Svante Signell, le mer. 28 sept. 2022 18:09:58 +0200, a ecrit:
> On Wed, 2022-09-28 at 17:50 +0200, Samuel Thibault wrote:
> > Control: forwarded -1 https://github.com/doxygen/doxygen/pull/9514
> > 
> > Svante Signell, le mer. 28 sept. 2022 17:40:32 +0200, a ecrit:
> > > Currently doxygen FTBFS on GNU/Hurd due to a PATH_MAX issue.
> > 
> > This issue was already forwarded upstream on
> > https://github.com/doxygen/doxygen/pull/9514
> > 
> > they said it was actually imported from another project:
> > https://github.com/gulrak/filesystem/pull/154
> > 
> > In the meanwhile we already have patched version 1.9.4-2+hurd.1
> > available in unreleased.
> 
> Thanks, I did not know about this. Maybe you can create a version
> 1.9.4-3.hurd.1 version to avoid doxygen-latex not being held when
> upgrading.

Well, I could do that but that would be moot whenever a newer
doxygen package gets uploaded again.

Samuel

Re: doxygen: FTBFS on hurd-i386

2022-09-28 Thread Svante Signell 
On Wed, 2022-09-28 at 17:50 +0200, Samuel Thibault wrote:
> Control: forwarded -1 https://github.com/doxygen/doxygen/pull/9514
> 
> Svante Signell, le mer. 28 sept. 2022 17:40:32 +0200, a ecrit:
> > Currently doxygen FTBFS on GNU/Hurd due to a PATH_MAX issue.
> 
> This issue was already forwarded upstream on
> https://github.com/doxygen/doxygen/pull/9514
> 
> they said it was actually imported from another project:
> https://github.com/gulrak/filesystem/pull/154
> 
> In the meanwhile we already have patched version 1.9.4-2+hurd.1
> available in unreleased.

Thanks, I did not know about this. Maybe you can create a version
1.9.4-3.hurd.1 version to avoid doxygen-latex not being held when
upgrading. (when upgrading/dist-upgrading it is very annoying to see
these messages).

Thanks again, your solution is much better than mine (though very
similar).

thanks!

doxygen: FTBFS on hurd-i386

2022-09-28 Thread Svante Signell 
Source: doxygen
Version: 1.9.4-3
Severity: important
Tags: patch
User: debian-h...@lists.debian.org
Usertags: hurd

Hi,

Currently doxygen FTBFS on GNU/Hurd due to a PATH_MAX issue.

The attached patch, filesystem_filesystem.hpp.diff, fixes the build
problem by special-casing for Hurd. In fact the patch could be applied
to all glibc-based systems and upstreamed. 

However, it is not very C++-ish, maybe some better solution could be
used. Cc-ing bug-hurd for comments, WDYT?

Thanks!




Index: doxygen-1.9.4/filesystem/filesystem.hpp
===
--- doxygen-1.9.4.orig/filesystem/filesystem.hpp
+++ doxygen-1.9.4/filesystem/filesystem.hpp
@@ -56,6 +56,8 @@
 #define GHC_OS_MACOS
 #elif defined(__linux__)
 #define GHC_OS_LINUX
+#elif defined(__GNU__)
+#define GHC_OS_GNU
 #if defined(__ANDROID__)
 #define GHC_OS_ANDROID
 #endif
@@ -4081,6 +4083,13 @@ GHC_INLINE path current_path(std::error_
 return path();
 }
 return path(std::wstring(buffer.get()), path::native_format);
+#elif defined(GHC_OS_GNU)
+char* buffer = ::getcwd (NULL, 0);
+if (buffer == nullptr) {
+ec = detail::make_system_error();
+return path();
+}
+return path(buffer);
 #else
 size_t pathlen = static_cast(std::max(int(::pathconf(".", _PC_PATH_MAX)), int(PATH_MAX)));
 std::unique_ptr buffer(new char[pathlen + 1]);