Re: Change_iterator refuses to move a NullVoice into a Staff

2017-04-07 Thread Dan Eble

> On Apr 7, 2017, at 03:58, David Kastrup  wrote:
> 
>> Please try this.  I haven’t tested your patch.
> 
> I'm sort of annoyed at the somewhat roundabout \RemoveEmptyStaves bit
> but I guess that's likely a pretty direct way to figure out where the
> NullVoice went.  One doesn't get to see a lot of it otherwise.

I feel the same, but the only other idea I had involved lyrics, which
would have been more complicated.  In its favor, this test covers
something that I actually noticed rather than something contrived.

Thanks again for fixing the problem.
— 
Dan


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: Change_iterator refuses to move a NullVoice into a Staff

2017-04-07 Thread David Kastrup
Dan Eble  writes:

>> Tracker issue:
>> 5116 (https://sourceforge.net/p/testlilyissues/issues/5116/)
>> Rietveld issue:
>> 322820043 (https://codereview.appspot.com/322820043)
>
> Thank you.
>
>> Could you rework your almost minimal example into a regtest?
>> Those give me much more of a headache than most code changes
>> since there is no "obviously best" regtest to aim for.
>
> Please try this.  I haven’t tested your patch.

I'm sort of annoyed at the somewhat roundabout \RemoveEmptyStaves bit
but I guess that's likely a pretty direct way to figure out where the
NullVoice went.  One doesn't get to see a lot of it otherwise.

I guess I'll take it.  Thanks.

-- 
David Kastrup

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond