Re: pitchedTrill bug?

2019-06-18 Thread James 

Hello

On 18/06/2019 20:48, Aaron Hill wrote:

On 2019-06-18 11:02 am, Jean-Charles Malahieude wrote:

Hi all,

Is there any reason why I get an natural when there is none to be ?

{
  \key c \major
  \pitchedTrill
  c''2\startTrillSpan d'' c''\stopTrillSpan
  \pitchedTrill
  c''2\startTrillSpan b' c''\stopTrillSpan
}


This is hard-coded logic [1] that naturals will always be printed for 
TrillPitchAccidental grobs.


[1]: 
https://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=blob;f=lily/pitched-trill-engraver.cc;h=325bf5a76bde8baa279fe19cf045baae9647e48d;hb=HEAD#l123


As a workaround, you could do something like this:


\version "2.19.82"

hideUnforcedNaturals = #(lambda (grob)
  (and (eqv? (ly:grob-property grob 'alteration) 0)
   (let ((cause (ly:grob-property grob 'cause)))
    (not (ly:event-property cause 'force-accidental #f)))
    (set! (ly:grob-property grob 'stencil) #f)))

\fixed c'' {
  \override TrillPitchAccidental.before-line-breaking = 
#hideUnforcedNaturals

  \pitchedTrill cis2\startTrillSpan dis cis\stopTrillSpan
  \pitchedTrill cis2\startTrillSpan d cis\stopTrillSpan
  \pitchedTrill cis2\startTrillSpan d! cis\stopTrillSpan
}



-- Aaron Hill


Thanks, I have made a minor patch to improve the documentation.

https://sourceforge.net/p/testlilyissues/issues/5528/


Regards


James


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: pitchedTrill bug?

2019-06-18 Thread Aaron Hill 

On 2019-06-18 11:02 am, Jean-Charles Malahieude wrote:

Hi all,

Is there any reason why I get an natural when there is none to be ?

{
  \key c \major
  \pitchedTrill
  c''2\startTrillSpan d'' c''\stopTrillSpan
  \pitchedTrill
  c''2\startTrillSpan b' c''\stopTrillSpan
}


This is hard-coded logic [1] that naturals will always be printed for 
TrillPitchAccidental grobs.


[1]: 
https://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=blob;f=lily/pitched-trill-engraver.cc;h=325bf5a76bde8baa279fe19cf045baae9647e48d;hb=HEAD#l123


As a workaround, you could do something like this:


\version "2.19.82"

hideUnforcedNaturals = #(lambda (grob)
  (and (eqv? (ly:grob-property grob 'alteration) 0)
   (let ((cause (ly:grob-property grob 'cause)))
(not (ly:event-property cause 'force-accidental #f)))
(set! (ly:grob-property grob 'stencil) #f)))

\fixed c'' {
  \override TrillPitchAccidental.before-line-breaking = 
#hideUnforcedNaturals

  \pitchedTrill cis2\startTrillSpan dis cis\stopTrillSpan
  \pitchedTrill cis2\startTrillSpan d cis\stopTrillSpan
  \pitchedTrill cis2\startTrillSpan d! cis\stopTrillSpan
}



-- Aaron Hill

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

pitchedTrill bug?

2019-06-18 Thread Jean-Charles Malahieude 

Hi all,

Is there any reason why I get an natural when there is none to be ?

{
  \key c \major
  \pitchedTrill
  c''2\startTrillSpan d'' c''\stopTrillSpan
  \pitchedTrill
  c''2\startTrillSpan b' c''\stopTrillSpan
}

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond