Re: # comments in the PO files

2015-09-28 Thread Federico Bruni 
Il giorno lun 28 set 2015 alle 12:19, Benno Schulenberg 
 ha scritto:


On 2015-09-28 07:39, Federico Bruni wrote:

 Il giorno mer 23 set 2015 alle 9:50, Benno Schulenberg
  ha scritto:

 grep -A3 "# FIXME" lilypond-2.19.26.nl.po | grep -v "#:"
 # FIXME: trailing space?


 This is strange, it's only in the dutch PO file.


No, it's not strange: I put those comments there.  :)


That's what I thought (you or Jan), but then I don't understand why you 
opened this thread :)




(Comments that start with "# " are made by translators themselves,
ones that start with "#." are extracted from the source by xgettext
-- and most of these shouldn't be in the POT file as they are not
addressed to the translators.)


 cd lilypond-git
 grep -A3 "# FIXME" po/*.po | grep -v "#:"


Then my PO file still has not been imported into git.


Yes, it is:
http://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=45a35a03c3dd7b6dc3bc6347ffd97958f20b1fd2



 Perhaps a wrong import from pot template?
 You can fix it manually?


No need to fix anything.  My "# " comments are hints for the
maintainers to improve something.


for the translation maintainers.. ok




___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

# comments in the PO files

2015-09-28 Thread Benno Schulenberg 

On 2015-09-28 07:39, Federico Bruni wrote:
> Il giorno mer 23 set 2015 alle 9:50, Benno Schulenberg 
>  ha scritto:
>> grep -A3 "# FIXME" lilypond-2.19.26.nl.po | grep -v "#:"
>> # FIXME: trailing space?
> 
> This is strange, it's only in the dutch PO file.

No, it's not strange: I put those comments there.  :)

(Comments that start with "# " are made by translators themselves,
ones that start with "#." are extracted from the source by xgettext
-- and most of these shouldn't be in the POT file as they are not
addressed to the translators.)

> cd lilypond-git
> grep -A3 "# FIXME" po/*.po | grep -v "#:"

Then my PO file still has not been imported into git.

> Perhaps a wrong import from pot template?
> You can fix it manually?

No need to fix anything.  My "# " comments are hints for the
maintainers to improve something.

Regards,

Benno


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: # comments in the PO files

2015-09-28 Thread Jean-Charles Malahieude 

Le 28/09/2015 12:19, Benno Schulenberg a écrit :


Then my PO file still has not been imported into git.



Yes it has been imported on Saturday 26 by commit "PO: sync Dutch and 
German from FTP" 45a35a03c3dd7b6dc3bc6347ffd97958f20b1fd2 and is part of 
2.19.28, with all your comments.


Cheers,
Jean-Charles


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: # comments in the PO files

2015-09-28 Thread Benno Schulenberg 

On 2015-09-28 13:00, Federico Bruni wrote:
> Il giorno lun 28 set 2015 alle 12:19, Benno Schulenberg 
>  ha scritto:
>> No, it's not strange: I put those comments there.  :)
> 
> That's what I thought (you or Jan), but then I don't understand why
> you opened this thread :)

Well, you started the thread; I just hijacked it.  :)
For the reason, see below.

>> My "# " comments are hints for the 
>> maintainers to improve something.
> 
> for the translation maintainers.. ok

No, for the Lilypond maintainers.  They could improve the source.
For example:

# FIXME: this and next two should be one
msgid "Use the `alignment-offsets' sub-property of\n"
msgid "NonMusicalPaperColumn #'line-break-system-details\n"
msgid "to set fixed distances between staves.\n"

This means, the above three msgids should be a single msgid, one string.

So, in the source it should not say:

stderr_write (_ ("Use the `alignment-offsets' sub-property of\n"))
stderr_write (_ ("NonMusicalPaperColumn #'line-break-system-details\n"))
stderr_write (_ ("to set fixed distances between staves.\n"))

but:

stderr_write (_ ("Use the `alignment-offsets' sub-property of\n"
 "NonMusicalPaperColumn #'line-break-system-details\n"
 "to set fixed distances between staves.\n"))

And maybe dropping the first \n too.

Benno

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond