Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Updates: Status: Fixed Labels: -Patch-push fixed_2_15_20 Comment #23 on issue 1572 by adam.spi...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 Pushed fix to staging as ee5738e01788aa2d. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Updates: Owner: adam.spi...@gmail.com Labels: -fixed_2_15_20 fixed_2_15_21 Comment #24 on issue 1572 by carl.d.s...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 Change fixed version ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Updates: Labels: -Patch-countdown Patch-push Comment #22 on issue 1572 by colinpkc...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 Counted down to 2010 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Comment #18 on issue 1572 by adam.spi...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 Based on discussion in http://codereview.appspot.com/5320074 I have been advised to resubmit the whole patch series as a new Rietveld issue, so please hold off on pushing this. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Comment #19 on issue 1572 by adam.spi...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 Now resubmitted as http://codereview.appspot.com/5343050/ ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Updates: Labels: -Patch-countdown Patch-review Comment #20 on issue 1572 by pkx1...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 Passes make and two reg test diffs attached James Attachments: Screenshot-1.png 53.2 KB Screenshot.png 142 KB ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Updates: Labels: -Patch-new Patch-review Comment #16 on issue 1572 by pkx1...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 http://codereview.appspot.com/5320074 Passes Make and reg test diffs attached James Attachments: Screenshot-1.png 53.2 KB Screenshot.png 141 KB ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Updates: Labels: -Patch-needs_work Patch-review Comment #11 on issue 1572 by pkx1...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 Passes Make, reg test diffs attached James Attachments: Screenshot.png 217 KB ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Updates: Labels: -Patch-review Patch-needs_work Comment #12 on issue 1572 by carl.d.s...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Updates: Labels: -Patch-needs_work Patch-new Comment #13 on issue 1572 by carl.d.s...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 New patch uploaded ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Updates: Labels: -Patch-new Patch-needs_work Comment #14 on issue 1572 by pkx1...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 Carl, sorry patch needs rebasing again -snip-- jlowe@jlowe-lilybuntu2:~/lilypond-git$ patch -p1 ../Desktop/issue5320074_11001.diff patching file Documentation/included/chord-names-jazz.ly patching file Documentation/notation/chords.itely patching file Documentation/notation/notation-appendices.itely patching file input/regression/chord-additional-pitch-prefix.ly patching file input/regression/chord-name-minor.ly patching file input/regression/chord-slash-separator.ly patching file input/regression/chords-funky-ignatzek.ly patching file ly/chord-modifiers-init.ly Hunk #1 FAILED at 23. Hunk #2 FAILED at 57. 2 out of 2 hunks FAILED -- saving rejects to file ly/chord-modifiers-init.ly.rej patching file ly/engraver-init.ly patching file scm/chord-ignatzek-names.scm patching file scm/define-context-properties.scm --snip-- ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Updates: Labels: -Patch-needs_work Patch-new Comment #15 on issue 1572 by carl.d.s...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 Rebased ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Updates: Owner: carl.d.s...@gmail.com Labels: -Patch-needs_work Patch-new Comment #8 on issue 1572 by pkx1...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 http://codereview.appspot.com/5320074/ New patch set. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Updates: Labels: -Patch-new Patch-review Comment #9 on issue 1572 by pkx1...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 Patch doesn't apply to current master.. --snip-- jlowe@jlowe-lilybuntu2:~/lilypond-git$ patch -p1 ../Desktop/issue5320074_2001.diff patching file Documentation/included/chord-names-jazz.ly patching file Documentation/notation/chords.itely patching file Documentation/notation/notation-appendices.itely patching file input/regression/chord-additional-pitch-prefix.ly patching file input/regression/chord-name-minor.ly patching file input/regression/chord-slash-separator.ly patching file input/regression/chords-funky-ignatzek.ly patching file ly/chord-modifiers-init.ly Hunk #1 FAILED at 27. 1 out of 1 hunk FAILED -- saving rejects to file ly/chord-modifiers-init.ly.rej patching file ly/engraver-init.ly patching file scm/chord-ignatzek-names.scm Hunk #1 FAILED at 130. Hunk #2 FAILED at 168. Hunk #3 FAILED at 183. Hunk #4 FAILED at 217. 4 out of 4 hunks FAILED -- saving rejects to file scm/chord-ignatzek-names.scm.rej patching file scm/define-context-properties.scm ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Updates: Labels: -Patch-review Patch-needs_work Comment #10 on issue 1572 by colinpkc...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Updates: Labels: -Patch-new Patch-needs_work Comment #7 on issue 1572 by pkx1...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 Passes make but fails reg test: --snip-- Processing cf/lily-2272dc04 Processing 5b/lily-9b351691 Processing 77/lily-34d19eca fatal error: Children (6) exited with errors. command failed: /home/jlowe/lilypond-git/build/out/bin/lilypond -I /home/jlowe/lilypond-git/input/regression/ -I ./out-test -I /home/jlowe/lilypond-git/input -I /home/jlowe/lilypond-git/Documentation -I /home/jlowe/lilypond-git/Documentation/snippets -I /home/jlowe/lilypond-git/input/regression/ -I /home/jlowe/lilypond-git/Documentation/included/ -I /home/jlowe/lilypond-git/build/mf/out/ -I /home/jlowe/lilypond-git/build/mf/out/ -I /home/jlowe/lilypond-git/Documentation/pictures -I /home/jlowe/lilypond-git/build/Documentation/pictures/./out-test -dbackend=eps --formats=ps -djob-count=7 -dseparate-log-files -dinclude-eps-fonts -dgs-load-lily-fonts --header=texidoc -I /home/jlowe/lilypond-git/Documentation/included/ -ddump-profile -dcheck-internal-types -ddump-signatures -danti-alias-factor=1 -I /home/jlowe/lilypond-git/build/out/lybook-testdb -I /home/jlowe/lilypond-git/build/input/regression -I /home/jlowe/lilypond-git/input/regression -I /home/jlowe/lilypond-git/build/input/regression/out-test -I /home/jlowe/lilypond-git/input -I /home/jlowe/lilypond-git/Documentation -I /home/jlowe/lilypond-git/Documentation/snippets -I /home/jlowe/lilypond-git/input/regression -I /home/jlowe/lilypond-git/Documentation/included -I /home/jlowe/lilypond-git/build/mf/out -I /home/jlowe/lilypond-git/build/mf/out -I /home/jlowe/lilypond-git/Documentation/pictures -I /home/jlowe/lilypond-git/build/Documentation/pictures/out-test --formats=eps -deps-box-padding=3.00 -dread-file-list -dno-strip-output-dir /home/jlowe/lilypond-git/build/out/lybook-testdb/snippet-names--1413227953.ly Child returned 1 make[2]: *** [out-test/collated-files.texi] Error 1 rm out-test/weblinks.itexi make[2]: Leaving directory `/home/jlowe/lilypond-git/build/input/regression' make[1]: *** [local-test] Error 2 make[1]: Leaving directory `/home/jlowe/lilypond-git/build/input/regression' make: *** [test] Error 2 ---snip-- relevant failed files attached. Attachments: Failed_files.tar.gz 1.4 KB ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Updates: Summary: Change chord name separator and inversion separator, separately Status: Started Comment #3 on issue 1572 by pkx1...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Updates: Owner: janek.li...@gmail.com Labels: -Priority-Low Comment #4 on issue 1572 by percival.music.ca: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 could we always have an Owner for a started thing? In the case of frogs / casual contributors, mark them as Janek. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Change chord name separator and inversion separator, separately
Comment #5 on issue 1572 by janek.li...@gmail.com: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 Patch by Adam here: http://codereview.appspot.com/4981052/ ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Enhancement req: Change chord name separator and inversion separator, separately
Comment #1 on issue 1572 by adam.spi...@gmail.com: Enhancement req: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 See also issue 1503. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1572 in lilypond: Enhancement req: Change chord name separator and inversion separator, separately
Comment #2 on issue 1572 by adam.spi...@gmail.com: Enhancement req: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 I have incorporated this patch into the master branch of my git repository (which will be available at https://github.com/aspiers/lilypond soon) and will submit this and other patches for formal review soon. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Issue 1572 in lilypond: Enhancement req: Change chord name separator and inversion separator, separately
Status: Accepted Owner: Labels: Type-Enhancement Priority-Low New issue 1572 by brownian.box: Enhancement req: Change chord name separator and inversion separator, separately http://code.google.com/p/lilypond/issues/detail?id=1572 Proposed by Arnout Engelen, http://lists.gnu.org/archive/html/bug-lilypond/2011-03/msg00283.html : %8- Hi. This is more of a feature request: I noticed I can change the 'chord name separator', but this also changes the symbol used to separate the chord from its root in case of for example c:/g. A naive way of allowing some more control might be: [patch and example here...] %8- Sorry, i know nothing about patches; so, please update labels and attach patches if necessary. Thanks! ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Change chord name separator and inversion separator, separately
On Mon 14 Mar 2011, 23:19 Arnout Engelen wrote:
I'm not top posting.
Thank you, added as 1572:
http://code.google.com/p/lilypond/issues/detail?id=1572
Hi. This is more of a feature request: I noticed I can change the 'chord name
separator', but this also changes the symbol used to separate the chord from
its
root in case of for example c:/g.
A naive way of allowing some more control might be:
diff --git a/ly/engraver-init.ly b/ly/engraver-init.ly
index 0720893..f9702bb 100644
--- a/ly/engraver-init.ly
+++ b/ly/engraver-init.ly
@@ -646,6 +646,7 @@ automatically when an output definition (a @code{\score}
or
majorSevenSymbol = #whiteTriangleMarkup
chordNameLowercaseMinor = ##f
chordNameSeparator = #(make-simple-markup /)
+ chordInversionSeparator = #(make-simple-markup /)
chordNameExceptions = #ignatzekExceptions
chordNoteNamer = #'()
chordRootNamer = #note-name-markup
diff --git a/scm/chord-ignatzek-names.scm b/scm/chord-ignatzek-names.scm
index 696d02f..38ef219 100644
--- a/scm/chord-ignatzek-names.scm
+++ b/scm/chord-ignatzek-names.scm
@@ -168,6 +168,7 @@ work than classifying the pitches.
(make-line-markup total)))
(let* ((sep (ly:context-property context 'chordNameSeparator))
+ (invSep (ly:context-property context 'chordInversionSeparator))
(root-markup (name-root root lowercase-root?))
(add-markups (map (lambda (x) (glue-word-to-step add x))
addition-pitches))
@@ -183,7 +184,7 @@ work than classifying the pitches.
suffixes
add-markups) sep))
(base-stuff (if (ly:pitch? bass-pitch)
- (list sep (name-note bass-pitch #f))
+ (list invSep (name-note bass-pitch #f))
'(
(set! base-stuff
diff --git a/scm/define-context-properties.scm b/scm/define-context-
properties.scm
index 439f68a..e3accb7 100644
--- a/scm/define-context-properties.scm
+++ b/scm/define-context-properties.scm
@@ -148,6 +148,8 @@ of pitches to chord names.)
(chordNameLowercaseMinor ,boolean? Downcase roots of minor chords?)
(chordNameSeparator ,markup? The markup object used to
separate parts of a chord name.)
+ (chordInversionSeparator ,markup? The markup object used to
+separate a chord name from its root note in case of inversions.)
(chordNoteNamer ,procedure? A function that converts from a pitch
object to a text markup. Used for single pitches.)
(chordPrefixSpacer ,number? The space added between the root
Example lilypond code:
\new ChordNames {
\chordmode {
% default behavior:
c c:7.11 c:/a c:7.11/a \break
% change the seperator for 'c:7/add11' and for 'c:/a'
independently
\set chordNameSeparator = \markup { | }
\set chordInversionSeparator = \markup { : }
c c:7.11 c:/a c:7.11/a \break
}
}
___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond
--
Dmytro O. Redchuk
Bug Squad
___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond
Change chord name separator and inversion separator, separately
I'm not top posting.
Hi. This is more of a feature request: I noticed I can change the 'chord name
separator', but this also changes the symbol used to separate the chord from
its
root in case of for example c:/g.
A naive way of allowing some more control might be:
diff --git a/ly/engraver-init.ly b/ly/engraver-init.ly
index 0720893..f9702bb 100644
--- a/ly/engraver-init.ly
+++ b/ly/engraver-init.ly
@@ -646,6 +646,7 @@ automatically when an output definition (a @code{\score} or
majorSevenSymbol = #whiteTriangleMarkup
chordNameLowercaseMinor = ##f
chordNameSeparator = #(make-simple-markup /)
+ chordInversionSeparator = #(make-simple-markup /)
chordNameExceptions = #ignatzekExceptions
chordNoteNamer = #'()
chordRootNamer = #note-name-markup
diff --git a/scm/chord-ignatzek-names.scm b/scm/chord-ignatzek-names.scm
index 696d02f..38ef219 100644
--- a/scm/chord-ignatzek-names.scm
+++ b/scm/chord-ignatzek-names.scm
@@ -168,6 +168,7 @@ work than classifying the pitches.
(make-line-markup total)))
(let* ((sep (ly:context-property context 'chordNameSeparator))
+ (invSep (ly:context-property context 'chordInversionSeparator))
(root-markup (name-root root lowercase-root?))
(add-markups (map (lambda (x) (glue-word-to-step add x))
addition-pitches))
@@ -183,7 +184,7 @@ work than classifying the pitches.
suffixes
add-markups) sep))
(base-stuff (if (ly:pitch? bass-pitch)
- (list sep (name-note bass-pitch #f))
+ (list invSep (name-note bass-pitch #f))
'(
(set! base-stuff
diff --git a/scm/define-context-properties.scm b/scm/define-context-
properties.scm
index 439f68a..e3accb7 100644
--- a/scm/define-context-properties.scm
+++ b/scm/define-context-properties.scm
@@ -148,6 +148,8 @@ of pitches to chord names.)
(chordNameLowercaseMinor ,boolean? Downcase roots of minor chords?)
(chordNameSeparator ,markup? The markup object used to
separate parts of a chord name.)
+ (chordInversionSeparator ,markup? The markup object used to
+separate a chord name from its root note in case of inversions.)
(chordNoteNamer ,procedure? A function that converts from a pitch
object to a text markup. Used for single pitches.)
(chordPrefixSpacer ,number? The space added between the root
Example lilypond code:
\new ChordNames {
\chordmode {
% default behavior:
c c:7.11 c:/a c:7.11/a \break
% change the seperator for 'c:7/add11' and for 'c:/a'
independently
\set chordNameSeparator = \markup { | }
\set chordInversionSeparator = \markup { : }
c c:7.11 c:/a c:7.11/a \break
}
}
___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond
