Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Updates:
Status: Verified
Comment #20 on issue 1268 by brownian.box: [PATCH] span-bar problem
http://code.google.com/p/lilypond/issues/detail?id=1268
I guess it is really fixed -- no tiny example, but regtest added. So,
Verified.
However, that regtest is hard to verify, one will have to print the source
and check every [span]bar line whether it satisfies it's "definition" in
the source ('line-positions or 'bar-extent).
___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Updates: Status: Fixed Labels: -Patch-review fixed_2_13_48 Comment #19 on issue 1268 by percival.music.ca: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 Pushed. ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Updates: Labels: -Patch-needs_work Patch-review Comment #18 on issue 1268 by percival.music.ca: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 New patch looks good. ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Updates: Labels: -Patch-review Patch-needs_work Comment #17 on issue 1268 by percival.music.ca: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 Neil has identified some problems with this patch. Unfortunately I really should move ahead with 2.13.47 right now, so all those version numbers need to be updated. If you create a patch, then do a global search&replace in that patch for: 2.13.47 -> 2.13.48 (2, 13, 47) -> (2, 13, 48) then the result should work ok. Just apply that search&replace'd patch to a new git branch, then make the edits Neil wanted, and we'll go test the next draft. 2.13.48 will probably happen quite soon, so don't worry about missing .47. ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Updates: Status: Started Comment #16 on issue 1268 by carl.d.s...@gmail.com: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Updates: Labels: -Patch Patch-review Comment #15 on issue 1268 by percival.music.ca: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 A few minor nitpicks, but nothing terribly wrong, so I'll move it to patch-review. ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Comment #14 on issue 1268 by benko@gmail.com: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 patchset at http://codereview.appspot.com/4025044/ ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Updates: Status: Accepted Comment #13 on issue 1268 by percival.music.ca: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 Yes; since there is now active discussion and work on the patch, it's certainly not invalid. ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Comment #12 on issue 1268 by brownian.box: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 Sorry, why "Invalid" so far? Shouldn't it be changed so smth else? ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Comment #11 on issue 1268 by benko.pal: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 new patch in http://lists.gnu.org/archive/html/lilypond-devel/2011-01/msg00040.html ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Comment #10 on issue 1268 by benko.pal: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 hi Joe, (sorry if you got it twice) thanks for the hint. do you think my patch is a good start? I removed the center setting code and that (with my patch still active) made my example perfect; however, the attached complementary test (with bar lines only within staff, not between them) failed, but it's perfect with current center setting (independently whether my original patch is active or not). ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Comment #9 on issue 1268 by joeneeman: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 I've tracked the problem down to Bar_line::compound_barline, which tries to center the bar line around the center of the staff (see lines 119 and below). ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Comment #8 on issue 1268 by benko.pal: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 the problem is not specific to ancient music, I think: it's that overriding Staff.StaffSymbol #'line-positions makes something inconsistent: either the refpoint of the staff or the distance to the next staff or... the original message contains an example; I'd love to get an explanation what goes on - I tried to discover it, but didn't succeeded; the patch attached to the original message shows the stage I couldn't move further. to sum it up: the patch may well be invalid, my explanation also, but there is a problem somewhere. I'm willing to work on it but can't move on on my own. ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Comment #7 on issue 1268 by jameseli...@googlemail.com: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 So I understand • There is a problem with the span-bar in ancient music when using a mensurstrich layout • The patch submitted does not actually do what it intended and could possibly cause problems in other aspects of the program. My question: Is the span-bar problem in ancient music when using mensurstriche an actual problem that should be kept on the tracker, or should I mark this as verified (invalid) and close the issue? ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Comment #6 on issue 1268 by benko.pal: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 Re comment 2: the intent was to - replace bar-size by line_span - return not an uninitialised but default constructed variable, like the original version ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Comment #5 on issue 1268 by bealingsplayfordnews: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 I was checking the bug reports which did not have a valid status - i.e. accepted or started. Based on Graham's comment, it didn't seem a good idea to leave it floating. If you want to update it and comment on Graham's comment, that's fine with me. ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Updates: Cc: PhilEHolmes Comment #4 on issue 1268 by v.villenave: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 This patch was meant to address a very specific issue with ancient music and custom staff-positions... Phil, do you know if this issue has been added to the tracker? ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Updates: Status: Invalid Comment #3 on issue 1268 by PhilEHolmes: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Comment #2 on issue 1268 by percival.music.ca: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 As far as I can see, this patch: - removes the bar-size property from the calc_bar_extent() function - returns an uninitalized variable if it can't get a staff_symbol. I have no knowledge of this side of lilypond, but this looks quite suspicious to me. ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1268 in lilypond: [PATCH] span-bar problem
Updates: Labels: Priority-Medium Comment #1 on issue 1268 by percival.music.ca: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Issue 1268 in lilypond: [PATCH] span-bar problem
Status: New Owner: Labels: Type-Enhancement Patch New issue 1268 by neziap: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 http://lists.gnu.org/archive/html/lilypond-devel/2010-09/msg00019.html ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
