Re: Issue 1816 in lilypond: Lilypond-book music runs off right side of the page
Updates: Status: Verified Comment #17 on issue 1816 by philehol...@googlemail.com: Lilypond-book music runs off right side of the page http://code.google.com/p/lilypond/issues/detail?id=1816 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1816 in lilypond: Lilypond-book music runs off right side of the page
Comment #15 on issue 1816 by brownian.box: Lilypond-book music runs off right side of the page http://code.google.com/p/lilypond/issues/detail?id=1816 I believe fixed_2_15_9 is wrong. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1816 in lilypond: Lilypond-book music runs off right side of the page
Updates: Labels: -fixed_2_15_9 fixed_2_15_10 Comment #16 on issue 1816 by reinhold...@gmail.com: Lilypond-book music runs off right side of the page http://code.google.com/p/lilypond/issues/detail?id=1816 Ah, sorry, I missed that Graham has released 2.15.9 meanwhile... ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1816 in lilypond: Lilypond-book music runs off right side of the page
Updates: Status: Fixed Labels: fixed_2_15_9 Comment #14 on issue 1816 by reinhold...@gmail.com: Lilypond-book music runs off right side of the page http://code.google.com/p/lilypond/issues/detail?id=1816 Pushed as 93d4e8aa80360c95696e065b9fd4744f269f4ea8 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1816 in lilypond: Lilypond-book music runs off right side of the page
Comment #13 on issue 1816 by philehol...@googlemail.com: Lilypond-book music runs off right side of the page http://code.google.com/p/lilypond/issues/detail?id=1816 For the record - it's been marked as not a duplicate of Issue 1638. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1816 in lilypond: Lilypond-book music runs off right side of the page
Updates: Labels: -Patch-new Patch-review Comment #10 on issue 1816 by percival.music.ca: Lilypond-book music runs off right side of the page http://code.google.com/p/lilypond/issues/detail?id=1816 The patch does not break compiling. I am not able to easily test whether the generated html+pdf look good until I return to Glasgow. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1816 in lilypond: Lilypond-book music runs off right side of the page
Comment #12 on issue 1816 by percival.music.ca: Lilypond-book music runs off right side of the page http://code.google.com/p/lilypond/issues/detail?id=1816 Issue 1638 has been merged into this issue. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1816 in lilypond: Lilypond-book music runs off right side of the page
Issue 1816: Lilypond-book music runs off right side of the page http://code.google.com/p/lilypond/issues/detail?id=1816 This issue is now blocking issue 1691. See http://code.google.com/p/lilypond/issues/detail?id=1691 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1816 in lilypond: Lilypond-book music runs off right side of the page
Comment #7 on issue 1816 by philehol...@googlemail.com: Lilypond-book music runs off right side of the page http://code.google.com/p/lilypond/issues/detail?id=1816 I've tested this exhaustively. I've manually updated the book-snippets.py in my build tree, and run it against my test file, prior and post this update. Both outputs are attached. As you see, without the [quote] option, this does inded get rid of the black bars/overfull hbox. Not quite sure why, since these are quite wide compared to the snippets with [quote] but that's because I don't understand the working of -book, latex, etc. However, there's no effect on the lines compiled with [quote], which continue to have bars and overfull hbox warnings. However, if you make the change I'm suggesting (indeed, 2.05 only needs changing to 2.02) you get the 3rd result - with no bars at all. See the 3rd PDF. I've run the test file with multipliers of 1.95, 1.96, 1.97, 1.98, 1.99, 2.00, 2.01, 2.02 and 2.03. 1.95 to 1.98 give the same result in terms of the point size of the overfull hbox - 2.0635 to 4 decimal digits. 1.99 to 2.01 give the same result (1.05977), different from 1.96. 2.02 is zero, and hence no black bars. It seems beyond obvious that Reinhold has fixed one bug, and the [quote] bug is down to a rounding error. Please, please, please can we stop pointless arguing about angels on the head of a pin, and make a simple change that fixes a lot of horrible output in our documentation - make the multiplier of indent just bigger than 2. If this is not agreed, I'll give up and move on to other more valued work - other work than Lilypond. Attachments: LineLengthPre1819.pdf 169 KB LineLengthPre202.pdf 178 KB LineLengthPost202.pdf 178 KB ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1816 in lilypond: Lilypond-book music runs off right side of the page
Comment #8 on issue 1816 by percival.music.ca: Lilypond-book music runs off right side of the page http://code.google.com/p/lilypond/issues/detail?id=1816 I will put this patch on a countdown later tonight. I will cancel any new GOP proposals for the next two weeks. I am returning to the UK next week; flying away from Vancouver on the 24th, and arriving at 13:40 on the 25th (assuming that I catch my flight from Heathrow to Glasgow). I will probably sleep for 5-6 hours (jetlag), and be at university at approximately 00:01 on the 26th. If Reinhold (or anybody else) has not figured out what the problem is with [quote], I will absolutely give this my highest priority. Could you please wait a week? This is my last chance to see friends and family for the next few months. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1816 in lilypond: Lilypond-book music runs off right side of the page
Comment #9 on issue 1816 by percival.music.ca: Lilypond-book music runs off right side of the page http://code.google.com/p/lilypond/issues/detail?id=1816 To avoid misunderstandings: when I wrote this patch in comment 8, I was referring to Reinhold's patch which fixes the music-off-side-of-page for no [options]. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1816 in lilypond: Lilypond-book music runs off right side of the page
Comment #2 on issue 1816 by percival.music.ca: Lilypond-book music runs off right side of the page http://code.google.com/p/lilypond/issues/detail?id=1816 The first @lilypond has no bar numbers nor instrument names. [quote] is also a red herring. lilypond-book produces images which overflow the allowable space by latex. That should not happen. What's the size of the mbox (or hbox) allocated to the eps image that lilypond-book is going to create? What's the size of the bbox of the eps image that lilypond produces? These are not the same thing, and they *should* be (or at least, the size of the bbox eps should be less than the mbox in latex). Either: 1) we have hard-coded constants for this width, and those constants are wrong, or 2) we don't get correct information from latex about the width, or 3) we get correct info from latex, but don't use that information correctly These problems exist whether or not we use [quote]. They are exacerbated by having an instrument name, but since it's even broken without an instrument name, that's also a red herring. ETA: 1 hour if you know latex+eps, python, and maybe scheme as well. 10 hours if you don't. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1816 in lilypond: Lilypond-book music runs off right side of the page
Comment #3 on issue 1816 by bealings...@googlemail.com: Lilypond-book music runs off right side of the page http://code.google.com/p/lilypond/issues/detail?id=1816 [quote] is not a red herring. It implements the situation that is needed - i.e. lilypond output that doesn't flow off the right of the page. I didn't say that this bug doesn't exist - merely pointed out a way either to work around it, or to use as a source to solving it. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1816 in lilypond: Lilypond-book music runs off right side of the page
Updates: Status: Started Owner: reinhold...@gmail.com Labels: Patch-new Comment #4 on issue 1816 by reinhold...@gmail.com: Lilypond-book music runs off right side of the page http://code.google.com/p/lilypond/issues/detail?id=1816 It's case 3) Lilypond-book has proper width detection, but for some reason there is code to clear the auto-detected width (from latex) or the default with (from texinfo) in most cases. I don't see any reason why it should be cleared at all. After all, ragged and quote will MODIFY the current line-width, so they still depend on a sensitive default value to start with... Here's a patch that should fix the width of the snippets: http://codereview.appspot.com/4888046/ However, we still have a problem with instrument names, because lilypond does not include them for the line-width calculation, so the second snippet will still be way too wide... I don't see any chance to fix this... ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1816 in lilypond: Lilypond-book music runs off right side of the page
Comment #5 on issue 1816 by percival.music.ca: Lilypond-book music runs off right side of the page http://code.google.com/p/lilypond/issues/detail?id=1816 Thank you so much, Reinhold! According to git blame, those lines came from d4a36739 but that doesn't really help; that was the big Factor out the formatting from lilypond-book into separate classes patch from 2010-05-11. I don't know if that helps in tracking down why we were doing it, though; that part probably just came from the original code. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1816 in lilypond: Lilypond-book music runs off right side of the page
Comment #1 on issue 1816 by philehol...@googlemail.com: Lilypond-book music runs off right side of the page http://code.google.com/p/lilypond/issues/detail?id=1816 It appears that this occurs because -book does not take note of the fact that included snippets are indented from the left of the page - it allows them the full width of the page, and the indentation therefore pushes the snippet to the right. This behaviour is exacerbated by LilyPond furniture (e.g. instrument names) which aren't counted as part of the line width - see Issue 766. texi2pdf signals where text/pictures go into the right margin by putting a black bar down the side - this can be turned off, but probably shouldn't be. -book can be made to improve this behaviour by using the [quote] option - the question is - why is this not the default? Why would -book ever want to ignore the indents? ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
