Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: -Patch-review Patch-needs_work Comment #98 on issue 2148 by colinpkc...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Per David's comment, this has almost certai9nly got a locki on the most discussed patch ever, but it just doesn't sound as though it's ready to fly. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: -Patch-new Patch-review Comment #95 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 mensural-ligatures: the second BL. In size26, B and Largo are getting too cozy without any need. Similar in other sizes, but the large size makes it more obvious. pedal-ped again. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-new Comment #96 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c96 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-review Comment #91 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c91 Patchy the autobot says: LGTM. And a few usual suspects. Transparency in tabs is treated like non-existence, the rotated stencil, the negative padding for pedal-ped or so. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-new Comment #92 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c92 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #93 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c93 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #94 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c94 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-new Comment #86 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c86 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #88 on issue 2148 by joenee...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Could you send me the lilypond files you used for this profile? Also, you'll get better profiles (at least, the call graphs will have real information) if you do an unoptimized build. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #89 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c89 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
On Mar 1, 2012, at 4:12 PM, lilyp...@googlecode.com wrote: Comment #90 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 If transparency is not supposed to have an impact anymore, why do we still have different callbacks for maybe-transparent stencils even in the latest iteration? If this is dead code, it should be removed. There should only be one callback, and it should not look at transparency. Because I haven't pushed my tabVoice code yet. It doesn't have an impact in the regression tests you're talking about, but it would have an impact in all of the tab regtests. Once I push the tabVoice patch, I'll be able to get rid of this code. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
m...@apollinemike.com m...@apollinemike.com writes: On Mar 1, 2012, at 4:12 PM, lilyp...@googlecode.com wrote: Comment #90 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 If transparency is not supposed to have an impact anymore, why do we still have different callbacks for maybe-transparent stencils even in the latest iteration? If this is dead code, it should be removed. There should only be one callback, and it should not look at transparency. Because I haven't pushed my tabVoice code yet. It doesn't have an impact in the regression tests you're talking about, but it would have an impact in all of the tab regtests. Yes, it has an impact on the tab regtests. That's how I noticed that transparency _has_ an impact still. Once I push the tabVoice patch, I'll be able to get rid of this code. Please don't let your code attempt to mask unrelated bugs. It makes it harder to understand and review and means that the unrelated bugs will get harder to diagnose and fix _properly_, and that the interactions with your code _after_ they get fixed get very hard to find and remove. It makes it likely that the need for a proper fix for the original bug will get overlooked, and it makes it likely that the necessity of removing the workaround afterwards will get overlooked. And it complicated the review and makes it likely that it gets entangled in code that should not be there anyway. It is a triple recipe for trouble, and that only in order to make the regtests appear better temporarily for no good reason. -- David Kastrup ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #79 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c79 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: -Patch-new Patch-needs_work Comment #80 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: -Patch-needs_work Patch-new Comment #81 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-needs_work Comment #82 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c82 Patchy the autobot says: markup-note-dot.ly takes more space. figured-bass-implicit.ly should likely have a bit of padding to the extender line in order to not have it look like a divider. size16.ly takes up more space without convincing reason. pedal-ped.ly does not seem to heed the negative padding. size23.ly takes extra space: debatable. stencil-color-rotation again. It would still appear that transparency is considered in the skylines when it shouldn't. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #83 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 markup-note-dot.ly is, in my opinion, an improvement, as the dot of the whole note was uncomfortably close to the half note. figured-bass-implicit is an interesting case: Before, the p of implicit shifted the whole markup up whereas now it fits between two figured bass symbols. One way to fix this is to make the vertical-skylines for BassFigureLine simpler so that they can't be interlocked with the vertical axis group above or below. I'd be interested in hearing from a figured bass expert, but this'd likely be a separate commit. All of the changes in sizeX come from an interesting phenomenon with the forte glyph. The cozy spacing in the original sizeX.ly regtests comes from the fact that the bounding box is set to be smaller than the actual glyph. This results in almost-collisions between cantabile and forte. In my newest patchset, the outside-staff-horizontal-padding pushes cantabile to the outside of forte. If you change the word to liedhaft, the problem goes away. It's a matter of taste if people like objects so closely spaced. One way to achieve this in the current model is to use horizontal skylines in add_grobs_of_one_priority instead of the Skyline::left () and Skyline::right () to determine bounds. But this'd definitely be another patch. For the moment, for me, it's not a game breaker. I don't think transparency is having an impact anymore. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #84 on issue 2148 by janek.li...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Judging form what you say, i thing i get different output in figured-bass-implicit (attached). as for sizeX, i think that a proper solution would be to add a new feature: horizontal stretching when some scripts are just a little to long to be placed in one line. In other words, it would work as \textLengthOn, but only when it wouldn't disturb horizontal spacing too much (hope this is clear). This would also solve markup-note-dot problem. As for now i think that we can declare these changes intentional. Attachments: figured-bass-implicit.png 27.6 KB ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #85 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Before, the p of implicit forced the skyline up, so the issue that David's talking about wasn't present (we're talking about 0.1 units maximum, but it's enough to be seen as a difference). It doesn't bother me, but I'd be interested to see what a specialist says. To implement the horizontal stretching of which you speak (which is a great idea), rods could be used. It'd take a lot of work on the horizontal spacing code. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-new Comment #76 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c76 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: -Patch-new Patch-needs_work Comment #77 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-new Comment #78 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c78 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-review Comment #74 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c74 Patchy the autobot says: LGTM. stem-length-estimation now produces an overfull-page warning. Should be checked for accuracy. And of course the rotated stencil thingy again. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-new Comment #68 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c68 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-needs_work Comment #69 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c69 Patchy the autobot says: figured-bass-extenders-markup should be checked by an expert, figured-bass-implicit clearly looks wrong, stencil-color-rotation has a collision. Totally amazing work with impressive results all in all. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-new Comment #70 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c70 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #71 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Good eye! Easy fix for the BassFigure stuff. On the other hand, the stencil-color-rotation poses a problem. As rotation is only tacked on at the very end, there will invariably be a collision, as the vertical skyline of the grob is estimated from the unrotated stencil. I'm not sure what the best thing to do is. I'd kinda like to rename rotation and scale extra-rotation and extra-scale. This is more in keeping with where they are in the stream (and better from a UI perspective, as they then join extra-offset as things tacked on way downstream). ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-review Comment #72 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c72 Patchy the autobot says: LGTM. Well, stencil-color-rotation again. But that's it. Wow. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-new Comment #73 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c73 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-new Comment #63 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c63 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-review Comment #64 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c64 Patchy the autobot says: LGTM. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-needs_work Comment #65 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c65 Patchy the autobot says: Sorry for the fluke. Bad output for drums.ly (some accents creep under beams). harp-pedals-tweaking.ly seems dense. script-shift.ly looks buggy. Bad tie in laissez-vibrer-ties.ly. harp-pedals-sanity-checks.ly interleaved. Bad tie in laissez-vibrer-chords.ly. Overlap in stencil-color-rotation.ly. And of course gazillion improvements. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-new Comment #66 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c66 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: -Patch-new Patch-needs_work Comment #67 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: -Patch-review Patch-needs_work Comment #61 on issue 2148 by colinpkc...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 The discussion on Rietveld seems to be going in a couple of different directions (speeding up the skyline calculations, and handling OTF fonts), and David's comment @60 suggests this needs work. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #62 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Comment #60 just implies that other areas will require work in order to get reasonably good tweakless results. It does not concern the patch in itself. In particular it would appear that some padding against incestuous skyline interactions of elements that are of the same kind and thus can interact in confusing manners seems desirable. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-review Comment #59 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c59 Patchy the autobot says: LGTM. But for example harp-pedals-sanity-checks shows that it would be a good idea to have extra padding between some elements of the same kind as staggering them gets quite confusing (2nd and 3rd diagram). ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #56 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Ugh, I tested the previous version. It compiled modulo the three whitespace errors. One thing might be that a bit of spring/padding around texts might not be the worst idea. But finetuning like that is probably a matter for lots of new little issues. Attachments: voice-5-midi.compare.jpeg 5.1 KB ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-review Comment #57 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c57 Patchy the autobot says: LGTM. Gazillion changes, most of them looking good. stencil-color-rotation is one exception. Whitespace errors gone. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: -Patch-review Patch-new Comment #58 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: -Patch-new Patch-needs_work Comment #44 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Mike, this again did not even make it through plain make. Since test-patches at the current point of time recreates a test baseline any time it tests a thing, and since the first issue to break breaks the whole test run (which is stupid but work in progress), it is currently quite expensive to me and to LilyPond in general (as other patches get delayed) when a patch breaks. Wastes more than an hour of my computing time, and delays other patches by half a day. Yes, this is something we need to get fixed in Patchy (and I'll try some of Julien's patches in that area), but in the mean time, could you run at least make all, preferably even followed by make test before uploading? You'll also get diagnostics that are more to the point than what I can extract from the logs. Thanks. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #45 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 I've been working w/ it for days now w/o it breaking make. I just ran make again it went thru fine. So what you're doing is very helpful, as it is showing me errors that are coming through on your machine and not mine. I'd actually very much appreciate seeing what is in your logfiles, as it'll help me determine what's going wrong (because I'm having difficulty reproducing the error here). ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #46 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Well, it is usually dependency stuff or files you forget to check in. Make a fresh clone with git clone /my/current/lilypond/dir /some/target/dir and try building in there. Also try using make -j2 right away (even on single-core systems, this is good for triggering timing/dependency problems). ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #47 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 What options do I need to pass to ./autogen.sh so that -j2 is enabled? ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: -Patch-needs_work Patch-new Comment #48 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 I am putting this to Patch-new right now simply because it is the easiest way for me to include this in the automatic tests. But it would really speed up things if you figured out how to trigger the problems on your own setup. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-needs_work Comment #49 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c49 Patchy the autobot says: make -j3 fails. Details will follow, and three trailing whitespace errors in diff. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #50 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 I think I got rid of the error. You can cancel the build and I'll post a clean patch soon. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #51 on issue 2148 by d...@gnu.org: vertical skylines should use
stencil integrals
http://code.google.com/p/lilypond/issues/detail?id=2148
Same as before. The problematic passage in the log (not easy to read
because of parallel make) appears to be:
fatal error: cannot find font: `emmentaler-11'
/tmp/lilypond-autobuild/build/out/share/lilypond/current/scm/lily.scm
@{char@:close@:79@:0@:2.80501@:1.40251@:1.40251@:2.80501@:0@:close.0M1@}
[79]
@{char@:close@:80@:1.40251@:1.40251@:2.80501@:0@:1.40251@:0@:close.11@} [80]
@{char@:Half thin
lahead@:103@:0@:3.66487@:1.19016@:1.19016@:3.66487@:0@:s1laTh
in@} [103]
@{char@:Quarter
lahead@:104@:0@:3.66487@:1.19016@:1.19016@:3.66487@:0@:s2laThin
@} [104]
@{char@:Whole up
tihead@:105@:0@:3.66487@:1.19016@:1.19016@:3.66487@:0.33324@:s
0ti@} [105]
@{char@:Half up
tihead@:106@:0@:3.66487@:1.19016@:1.19016@:3.66487@:0.33324@:u1
ti@} [106]
@{char@:Half down
tihead@:107@:0@:3.66487@:1.19016@:1.19016@:3.66487@:-0.33324@
:d1ti@} [107]
@{char@:close@:81@:1.40251@:1.40251@:0@:2.80501@:1.40251@:0@:close.1M1@}
[81]
@{puorg@:arrowheads@}
) (/tmp/lilypond-autobuild/mf/feta-dots.mfmake[1]: *** [out/font-cache.scm]
Error 1
make[1]: *** Waiting for unfinished jobs
A bit above you can find:
@{char@:Quarter thin
dohead@:64@:0@:3.66487@:1.19016@:1.19016@:3.66487@:-0.9778
@:u2doThin@} [64]
@{char@:Whole
rehead@:65@:0@:3.66487@:1.19016@:1.19016@:3.66487@:0.47606@:s0re@
} [65]
@{char@:3/4
Sharp@:55@:0@:4.48804@:4.20752@:4.20752@:4.48804@:0@:sharp.slashsla
sh.stemstemstem@} [55]
@{char@:Natural@:56@:0@:1.87001@:4.20752@:4.20752@:1.87001@:0@:natural@}
[56]]
[/tmp/lilypond-autobuild/ly/script-init.ly]
[/tmp/lilypond-autobuild/ly/chord-repetition-init.ly]
@{char@:Half down
rehead@:67@:0@:3.66487@:1.19016@:1.19016@:3.66487@:-0.47606@:
d1re@} [67]
[/tmp/lilypond-autobuild/ly/scale-definitions-init.ly]
@{char@:Quarter up
rehead@:68@:0@:3.66487@:1.19016@:1.19016@:3.66487@:0.47606@:
u2re@} [68]
[/tmp/lilypond-autobuild/ly/dynamic-scripts-init.ly
@{char@:Quarter down
rehead@:69@:0@:3.66487@:1.19016@:1.19016@:3.66487@:-0.4760
6@:d2re@} [69]]
[/tmp/lilypond-autobuild/ly/spanners-init.ly
@{char@:Arrowed Natural (arrow
up)@:57@:1.27414@:1.87001@:4.20752@:7.57352@:1.8
7001@:0@:natural.arrowup@} [57]]
@{char@:Arrowed Natural (arrow
down)@:58@:0@:1.87001@:7.57352@:4.20752@:1.87001
@:0@:natural.arrowdown@} [58]
[/tmp/lilypond-autobuild/ly/predefined-fretboards-init.ly]
[/tmp/lilypond-autobuild/ly/string-tunings-init.ly
@{char@:Whole thin
rehead@:70@:0@:3.66487@:1.19016@:1.19016@:3.66487@:0.47606@:
s0reThin@} [70]
@{char@:Half up thin
rehead@:71@:0@:3.66487@:1.19016@:1.19016@:3.66487@:0.47606
@:u1reThin@} [71]
@{char@:Half down thin
rehead@:72@:0@:3.66487@:1.19016@:1.19016@:3.66487@:-0.47
606@:d1reThin@} [72]]
[/tmp/lilypond-autobuild/ly/property-init.ly
So it would appear that parallel make is already trying to run lilypond for
some purpose before it has finished generating fonts. And before it has
finished generating fonts, it is unlikely that the font cache is available.
Searching further backwards, the problematic line appears to be
/tmp/lilypond-autobuild/build/out/bin/lilypond --verbose
/tmp/lilypond-autobuild
/ly/generate-font-integrals out/font-cache.scm
So it would appear that you are trying to generate the font cache before
the fonts have been generated. It would appear that you need to add _all_
fonts lilypond needs for running to the dependencies of the font cache file.
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #52 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Thank you very much. I know it was a pain for you to have your computer tied down with that, but this info helps me quite a lot. It corroborates some research I was doing this afternoon on make and fontforge. The bottom line is that it is actually very difficult to sneak this information into the otf-tables because of build-order issues compounded with metafont's inability to spit out log files that enumerate glyphs as a series of lines and 3rd order beziers (or at least my inability to tell it how to do this). I've fixed the problem in a new version by removing build-related stuff altogether and not caching the font data. It actually doesn't slow the patch down in the tests I've done and may in fact be a better way to do this for fonts like gonville that wouldn't have a font-cache.scm but may have svg backends. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #53 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 If you want readable fontinfo from metafont (not metapost), the way to get it is using the program gftype on the gf file resulting from the metafont run. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-new Comment #54 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c54 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #40 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c40 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-needs_work Comment #41 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c41 Patchy the autobot says: Fails with make -j3 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-new Comment #42 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c42 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #43 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c43 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #38 on issue 2148 by milimet...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 A problem with a slanted trill is still visible, see: http://lists.gnu.org/archive/html/lilypond-devel/2012-02/msg00353.html (an email from Reinhold Keinhofer) ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-new Comment #39 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c39 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-new Comment #35 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c35 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-needs_work Comment #36 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c36 Patchy the autobot says: Still the font-cache.scm target apparently. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-new Comment #33 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c33 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-needs_work Comment #34 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c34 Patchy the autobot says: Looks more like a dependency problem than anything else: [/tmp/lilypond-autobuild/ly/context-mods-init.ly] [/tmp/lilypond-autobuild/ly/engraver-init.ly]] [/tmp/lilypond-autobuild/ly/generate-font-integrals.ly [/tmp/lilypond-autobuild/build/out/share/lilypond/current/scm/stencil-integral.scm] [/tmp/lilypond-autobuild/build/out/share/lilypond/current/scm/stencil.scm] fatal error: cannot find font: `emmentaler-11 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Owner: mts...@gmail.com Comment #31 on issue 2148 by colinpkc...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Counted down to 20120209, please push. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: -Patch-countdown Patch-needs_work Comment #32 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 I'm gonna hold off on pushing this for a while and set it to patch needs-work, as the patch is currently in a remote branch and in need of more testing. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #30 on issue 2148 by janek.li...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Oops, i didn't know! Sorry. However, this is a serious problem ii think. Many of our bug reports needs evidence (in form of pdfs or pngs), which are sometimes big (i have a great example of lyrics positioning - but it's a 20meg pdf :/). If i use a 3rd party hosting service, the file will be deleted after some time. Do we have free space available on lilypond.org? Janek ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #27 on issue 2148 by janek.li...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 A quick test of latest Rietveld Patch attached (i've marked problematic places in red, hover cursor over markings to see explanations). I'll do more testing later. Attachments: marked Tota pulchra es Maria.pdf 496 KB ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #28 on issue 2148 by philehol...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Jan - please try to avoid large attachments. We've got a measly 50 megs left on code.google, and there's no way to reclaim space by deleting attachments. If you can, please link to another location. Thanks. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-needs_work Comment #17 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c17 Patchy the autobot says: make check fails, will see if I can find more useful data in the log. And still 7 lines add whitespace errors. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #18 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Failure log attached. Attachments: lily-fd7f2bc2.log 2.8 KB ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: -Patch-needs_work Patch-new Comment #19 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #21 on issue 2148 by janek.li...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 WOW! This is way cool!!! Mike wrote: Could you post the code for the slur and lyric extender padding stuff so I can develop the current patch against it? I've discovered now that lyric extenders are actually totally fine. The ugly output in 'lyric extender padding - bad outlines' was caused by slur and lyrics outlines - see attachment; it's already better thanks to your fix for issue 695. And what do you mean by slur stuff? PS i usually attach source code to pdfs (inside-pdf-attachment). Attachments: lyric extender padding - surprise.pdf 29.9 KB ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #22 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c22 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #23 on issue 2148 by m...@apollinemike.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 I don't need the stuff from the examples anymore...thanks tho! I'm gonna take care of all the stencil clean up first before expanding much on this patch. The goal then is to give TextScripts vertical skylines via this patch, which will be possible after the stencil cleanup. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #24 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c24 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #25 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c25 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Updates: Labels: Patch-review Comment #26 on issue 2148 by d...@gnu.org: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c26 Patchy the autobot says: LGTM. About two dozen cases of vertically tighter spacing, almost always an improvement. Considerable increases of memory use across the board. No idea concerning time use. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #15 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2148 in lilypond: vertical skylines should use stencil integrals
Comment #16 on issue 2148 by mts...@gmail.com: vertical skylines should use stencil integrals http://code.google.com/p/lilypond/issues/detail?id=2148#c16 Gets vertical skylines from grob stencils http://codereview.appspot.com/5626052 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
