Issue 2347 in lilypond: Patch: Improving \harmonicBy... functions

[lilypond]

Status: New
Owner: 
Labels: Type-Enhancement Patch-new

New issue 2347 by m...@hohlart.de: Patch: Improving \harmonicBy... functions
http://code.google.com/p/lilypond/issues/detail?id=2347

Improving \harmonicBy... functions

These functions work now as expected for guitar music.
We have dotted harmonics and mixed harmonic note heads.

http://codereview.appspot.com/5695059


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 2347 in lilypond: Patch: Improving \harmonicBy... functions

[lilypond]

Updates:
Labels: Patch-review

Comment #1 on issue 2347 by d...@gnu.org: Patch: Improving \harmonicBy...  
functions

http://code.google.com/p/lilypond/issues/detail?id=2347#c1

Patchy the autobot says: LGTM.


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 2347 in lilypond: Patch: Improving \harmonicBy... functions

[lilypond]

Comment #2 on issue 2347 by m...@hohlart.de: Patch: Improving  
\harmonicBy... functions

http://code.google.com/p/lilypond/issues/detail?id=2347#c2

Improving \harmonicBy... functions

These functions work now as expected for guitar music.
We have dotted harmonics and mixed harmonic note heads.

http://codereview.appspot.com/5695059


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 2347 in lilypond: Patch: Improving \harmonicBy... functions

[lilypond]

Updates:
Labels: -Patch-review Patch-new

Comment #3 on issue 2347 by julien.r...@gmail.com: Patch: Improving  
\harmonicBy... functions

http://code.google.com/p/lilypond/issues/detail?id=2347

(No comment was entered for this change.)


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 2347 in lilypond: Patch: Improving \harmonicBy... functions

[lilypond]

Updates:
Labels: Patch-review

Comment #4 on issue 2347 by julien.r...@gmail.com: Patch: Improving  
\harmonicBy... functions

http://code.google.com/p/lilypond/issues/detail?id=2347#c4

Patchy the autobot says: LGTM.


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 2347 in lilypond: Patch: Improving \harmonicBy... functions

[lilypond]

Updates:
Labels: -Patch-countdown Patch-push

Comment #6 on issue 2347 by colinpkc...@gmail.com: Patch: Improving  
\harmonicBy... functions

http://code.google.com/p/lilypond/issues/detail?id=2347

Counted down to 20120228, please push.


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 2347 in lilypond: Patch: Improving \harmonicBy... functions

[lilypond]

Comment #7 on issue 2347 by d...@gnu.org: Patch: Improving \harmonicBy...  
functions

http://code.google.com/p/lilypond/issues/detail?id=2347

Marc?  You don't have push access apparently.  Would you like to send me a  
mail with a git format-patch inside?


David


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 2347 in lilypond: Patch: Improving \harmonicBy... functions

[lilypond]

Comment #8 on issue 2347 by m...@hohlart.de: Patch: Improving  
\harmonicBy... functions

http://code.google.com/p/lilypond/issues/detail?id=2347

Done. David, thanks for the reminder!

Marc


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 2347 in lilypond: Patch: Improving \harmonicBy... functions

[lilypond]

Updates:
Status: Fixed
Labels: -Patch-push Fixed_2_15_32

Comment #9 on issue 2347 by d...@gnu.org: Patch: Improving \harmonicBy...  
functions

http://code.google.com/p/lilypond/issues/detail?id=2347

Pushed as 2d276844d7c20dd5838f9764d0eae37f53bebab3 to staging.  I could not  
mark you as owner of this issue: "Issue owner must be a project member".



___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 2347 in lilypond: Patch: Improving \harmonicBy... functions

[lilypond]

Updates:
Status: Verified

Comment #10 on issue 2347 by colingh...@gmail.com: Patch: Improving  
\harmonicBy... functions

http://code.google.com/p/lilypond/issues/detail?id=2347

Verified that this patch is in the repo using Phil's web tool.

Also confirmed committish is part of 2.15.32 using git log and grepping for  
the committish



___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 2347 in lilypond: Patch: Improving \harmonicBy... functions

[lilypond]

Updates:
Status: Fixed

Comment #11 on issue 2347 by philehol...@gmail.com: Patch: Improving  
\harmonicBy... functions

http://code.google.com/p/lilypond/issues/detail?id=2347

Reverted to fixed, since this needs reverifying by checking the source as  
pulled from git, not just the commitish.



___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 2347 in lilypond: Patch: Improving \harmonicBy... functions

[lilypond]

Updates:
Status: Verified

Comment #12 on issue 2347 by julien.r...@gmail.com: Patch: Improving  
\harmonicBy... functions

http://code.google.com/p/lilypond/issues/detail?id=2347

These changes to the music functions harmonicByFret and harmonicByRatio are  
part of the source tree as checked out from git release/unstable.



___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond