Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Updates: Status: Verified Comment #29 on issue 2348 by colingh...@gmail.com: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 Verified that the commitish for this patch was part of release 2.15.34. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Updates: Labels: -Patch-countdown Patch-push Comment #27 on issue 2348 by colinpkc...@gmail.com: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 Counted down to 20120311, please push. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Updates: Owner: m...@hohlart.de Comment #26 on issue 2348 by m...@hohlart.de: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Updates: Labels: -Patch-needs_work Patch-new Comment #20 on issue 2348 by d...@gnu.org: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 Uh Marc: after correcting a patch, you need to set its status to Patch-new or it won't get tested again. And if it is Patch-needs_work, it won't be considered for countdowns either. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Comment #21 on issue 2348 by m...@hohlart.de: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 Am 08.03.2012 09:22, schrieb lilyp...@googlecode.com: Am I allowed to set the status? Obviously, I am not the owner, so I don't see a way to do anything more than writing comments. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Comment #22 on issue 2348 by pkx1...@gmail.com: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 You need permissions to change status, although if you use the recent git-cl that is documented here: http://lilypond.org/doc/v2.15/Documentation/contributor/commits-and-patches#uploading-a-patch-for-review This should do it all for you and you don't need to worry about having to change it manually. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Comment #23 on issue 2348 by gra...@percival-music.ca: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 Marc: you need to have a google account. Contact Phil. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Updates: Labels: Patch-review Comment #24 on issue 2348 by d...@gnu.org: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348#c24 Patchy the autobot says: LGTM. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Comment #15 on issue 2348 by m...@hohlart.de: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 I stumbled upon comment #12 - how does this patch interfere with Mike's work? Are there any reasons not to include this patch in one of the next countdowns? ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Updates: Status: Started Owner: d...@gnu.org Labels: -Patch-needs_work Patch-new Comment #16 on issue 2348 by d...@gnu.org: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 I think that Colin may be confusing this with the transparent/stencil patches that have already been committed IIRC. There may or may not be merge conflicts. I am setting this issue to Patch-new. Once it passes the normal patch testing, I think I can justify pushing it for you (it is most convenient if you sent me a git-format-patch: make sure that the commit message is consistent with the whole content after the bazillion of changes the name choices went through). Would it be possible for somebody to register you as a member of the LilyPond project? It seems awkward to have to mark this issue as owned by me since I can't put ownership to you. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Updates: Labels: Patch-needs_work Comment #17 on issue 2348 by d...@gnu.org: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348#c17 Patchy the autobot says: Patchy actually does not complain, but the diffs show an inconsistent mixture of exclude (in engraver-init.ly) and restrain ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Comment #18 on issue 2348 by m...@hohlart.de: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348#c18 Handling of open strings in tablature This patch creates a switch called ignoreOpenStrings. When set to #f (default), LilyPond handles open strings as usual. Setting ignoreOpenStrings to #t excludes open strings and forces the fret calculation routine to find a fretted position even for pitches equal to an open string. http://codereview.appspot.com/5695058 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Comment #19 on issue 2348 by m...@hohlart.de: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 Am 06.03.2012 11:20, schrieb lilyp...@googlecode.com: Corrected. Sorry for the nuisance. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Comment #13 on issue 2348 by m...@hohlart.de: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348#c13 Handling of open strings in tablature This patch creates a switch called ignoreOpenStrings. When set to #f (default), LilyPond handles open strings as usual. Setting ignoreOpenStrings to #t excludes open strings and forces the fret calculation routine to find a fretted position even for pitches equal to an open string. http://codereview.appspot.com/5695058 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Comment #14 on issue 2348 by m...@hohlart.de: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 Ok, so I changed excludeOpenStrings to restrainOpenStrings. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Comment #10 on issue 2348 by d...@gnu.org: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 Ok, seems like I am too stupid to make up my mind. It's not likely worth stopping the countdown for that reason alone, but here is _another_ proposal for a #f-defaulting option: restrainOpenStrings. That feels better than excludeOpenStrings since it is somewhat closer to implying that they are only cut back to the level of the fingered strings, not excluded. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Updates: Labels: -Patch-countdown Patch-push Comment #11 on issue 2348 by colinpkc...@gmail.com: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 Counted down to 20120228, please push. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Updates: Labels: -Patch-push Patch-needs_work Comment #12 on issue 2348 by colinpkc...@gmail.com: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 I see Mike wants to hold this one out of the sequence, so I'\ll put it on Needs-work for now. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Comment #8 on issue 2348 by m...@hohlart.de: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348#c8 Handling of open strings in tablature This patch creates a switch called ignoreOpenStrings. When set to #f (default), LilyPond handles open strings as usual. Setting ignoreOpenStrings to #t excludes open strings and forces the fret calculation routine to find a fretted position even for pitches equal to an open string. http://codereview.appspot.com/5695058 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Comment #9 on issue 2348 by d...@gnu.org: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 Ok, I am officially an idiot. It turns out that my assertion that properties were usually defaulting to #f was totally wonkers if you take a look at ly/engraver-init.ly. Don't ask me what I have been thinking or drinking. For example, we have %% tablature: stringOneTopmost = ##t highStringOne = ##t So for the sake of people not having to head-scratch more than necessary, I do a full reverse turn and propose that the property is called includeOpenStrings or allowOpenStrings or admitOpenStrings and has the reverse logic. Because in this manner, the special action taken for open strings, even though the default, corresponds to #t. And all attempts to come up with a nice naming for the reverse logic are really strained. Sorry for having caused this rather painful endrun by blubbering something without verification that I somehow thought I remembered to be the case. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Comment #3 on issue 2348 by m...@hohlart.de: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348#c3 Handling of open strings in tablature This patch creates a switch called ignoreOpenStrings. When set to #f (default), LilyPond handles open strings as usual. Setting ignoreOpenStrings to #t excludes open strings and forces the fret calculation routine to find a fretted position even for pitches equal to an open string. http://codereview.appspot.com/5695058 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Updates: Labels: -Patch-needs_work Patch-new Comment #4 on issue 2348 by julien.r...@gmail.com: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Updates: Labels: Patch-review Comment #5 on issue 2348 by julien.r...@gmail.com: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348#c5 Patchy the autobot says: LGTM. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Comment #6 on issue 2348 by m...@hohlart.de: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348#c6 Handling of open strings in tablature This patch creates a switch called ignoreOpenStrings. When set to #f (default), LilyPond handles open strings as usual. Setting ignoreOpenStrings to #t excludes open strings and forces the fret calculation routine to find a fretted position even for pitches equal to an open string. http://codereview.appspot.com/5695058 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Status: New Owner: Labels: Type-Enhancement Patch-new New issue 2348 by m...@hohlart.de: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348 Handling of open strings in tablature This patch creates a switch called ignoreOpenStrings. When set to #f (default), LilyPond handles open strings as usual. Setting ignoreOpenStrings to #t excludes open strings and forces the fret calculation routine to find a fretted position even for pitches equal to an open string. http://codereview.appspot.com/5695058 ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2348 in lilypond: Patch: Handling of open strings in tablature
Updates: Labels: Patch-needs_work Comment #1 on issue 2348 by d...@gnu.org: Patch: Handling of open strings in tablature http://code.google.com/p/lilypond/issues/detail?id=2348#c1 Patchy the autobot says: /usr/local/tmp/lilypond/issue5695058_2001.diff:15: trailing whitespace. /usr/local/tmp/lilypond/issue5695058_2001.diff:16: trailing whitespace. } /usr/local/tmp/lilypond/issue5695058_2001.diff:21: trailing whitespace. g, d 1 /usr/local/tmp/lilypond/issue5695058_2001.diff:23: trailing whitespace. g, d 1 warning: 4 lines add whitespace errors. Problem with issue 2348 Failed runner: nice make check -j3 See the log file log-2348-nice-make-check--j3.txt Log file no longer available, but my guess is the \version of 2.15.32 which does not correspond to the next release. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
