Re: Issue 1201 in lilypond: fix for 1112 produces bad page breaking in make test and doc

[lilypond]

Updates:
Status: Verified

Comment #18 on issue 1201 by percival.music.ca: fix for 1112 produces bad  
page breaking in make test and doc

http://code.google.com/p/lilypond/issues/detail?id=1201

I just looked at at the official pdf for regtests for 2.13.32, and saw that  
bookparts.ly prints a table of contents with pages 1, 2, 3.  That's what we  
expect, so I'm marking this verified.



___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 1201 in lilypond: fix for 1112 produces bad page breaking in make test and doc

[lilypond]

Comment #16 on issue 1201 by percival.music.ca: fix for 1112 produces bad  
page breaking in make test and doc

http://code.google.com/p/lilypond/issues/detail?id=1201

fixed_2_13_30


___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 1201 in lilypond: fix for 1112 produces bad page breaking in make test and doc

[lilypond]

Updates:
Labels: fixed_2_13_30

Comment #17 on issue 1201 by percival.music.ca: fix for 1112 produces bad  
page breaking in make test and doc

http://code.google.com/p/lilypond/issues/detail?id=1201

oops


___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 1201 in lilypond: fix for 1112 produces bad page breaking in make test and doc

[lilypond]

Updates:
Summary: fix for 1112 produces bad page breaking in make test and doc
Owner: joeneeman

Comment #11 on issue 1201 by percival.music.ca: fix for 1112 produces bad  
page breaking in make test and doc

http://code.google.com/p/lilypond/issues/detail?id=1201

ok, an hour of git bisect (great tool, BTW!) identifies

4a6773dd60ef6ef481e37b00049c9eedcb5b8193 is first bad commit
commit 4a6773dd60ef6ef481e37b00049c9eedcb5b8193
Author: Joe Neeman joenee...@gmail.com
Date:   Mon Jun 14 19:30:55 2010 +0300

Fix 1112.

Add support for minimum-distance into the page-breaker.

:04 04 471affc36eb7a56dd5ffb184b5d2fca870aa6187  
f0fc295981428f8c68e039940664bc61a8d88826 M	input
:04 04 b0f78727fad9439995b0c1753789e0558ced4e0d  
0218c8e1ac9554c6898beceb9b31b77bc05ef820 M	lily

--

Test process:
(in build dir)
rm -rf *
../lilypond/configure ; nice make -j4 ; nice make -j4 CPU_COUNT=4 test
more out/lybook-testdb/52/lily-23a75a14.log
  (this is the file for bookparts.ly -- this might be different on another  
computer)


- so yes, this is a build from scratch every time
- good: fitting music on 1 page 3 times.  bad: more than 1 page; in some  
cases, 4 or 5 pages.



I have *not* been able to reproduce this with any type of lilypond  
command-line options, or any type of minimal lilypond-book command.  I only  
see it in make doc or make test.


List of files affected are:
  bookparts.ly
  page-breaking-title-padding2.ly
  page-breaking-title-padding3.ly
  page-spacing-markups.ly
  score-text.ly
  toc.ly

HTH.


___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 1201 in lilypond: fix for 1112 produces bad page breaking in make test and doc

[lilypond]

Comment #12 on issue 1201 by joeneeman: fix for 1112 produces bad page  
breaking in make test and doc

http://code.google.com/p/lilypond/issues/detail?id=1201

I can't reproduce (ie. it just works on one page for me), but I've pushed  
something that should fix it.



___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 1201 in lilypond: fix for 1112 produces bad page breaking in make test and doc

[lilypond]

Updates:
Status: Fixed

Comment #13 on issue 1201 by percival.music.ca: fix for 1112 produces bad  
page breaking in make test and doc

http://code.google.com/p/lilypond/issues/detail?id=1201

Curse you... I was just about to go to bed when I saw your commit.  You  
forced me to get dressed, walk to university, and test it.


It works, thanks.  Building 2.13.30 now.


___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 1201 in lilypond: fix for 1112 produces bad page breaking in make test and doc

[lilypond]

Comment #14 on issue 1201 by joeneeman: fix for 1112 produces bad page  
breaking in make test and doc

http://code.google.com/p/lilypond/issues/detail?id=1201

Oops, sorry :)

I hope you aren't staying up to wait for the build to finish


___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Issue 1201 in lilypond: fix for 1112 produces bad page breaking in make test and doc

[lilypond]

Comment #15 on issue 1201 by percival.music.ca: fix for 1112 produces bad  
page breaking in make test and doc

http://code.google.com/p/lilypond/issues/detail?id=1201

Well, I'm officially still jetlagged (I woke up at 7.30 this morning -- as  
a graduate student, I really shouldn't be waking up before noon!)


it's 20:36, which isn't too bad.  GUB just finishing building the tests;  
it's doing the comparison now.  Then there's the docs, which takes an  
hour.  And uploading is something like 15-20 minutes.  I figure I'll get  
home at 22:00 or so, which is a decent time for sleeping.  :)



___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond