Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Comment #21 on issue 2336 by julien.r...@gmail.com: Patch: Add layout changing command \layout-from for getting context defs from music http://code.google.com/p/lilypond/issues/detail?id=2336 The changes to ly/context-mods-init.ly are missing from the source tree as checked out from git release/unstable, and although the added regression test input/regression/layout-from.ly is there, it does not contain \layout-from. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Updates: Status: Verified Comment #22 on issue 2336 by d...@gnu.org: Patch: Add layout changing command \layout-from for getting context defs from music http://code.google.com/p/lilypond/issues/detail?id=2336 This has been removed in the course of implementing issue 2358. Keeping it removed was actually a chore since it was apparently resuscitated by manual merge conflict resolution, and I had to stomp it out again manually on every try of fixing the merge. It is good to know that it is gone, but I have a hard time assigning a useful status to this issue. I put it at Verified since it _was_ verifiably in 2.15.31 (?) and it is now intentionally gone. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Comment #23 on issue 2336 by julien.r...@gmail.com: Patch: Add layout changing command \layout-from for getting context defs from music http://code.google.com/p/lilypond/issues/detail?id=2336 The removal of layout-from as part of 2358 was indeed successful. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Updates: Status: Fixed Comment #20 on issue 2336 by philehol...@gmail.com: Patch: Add layout changing command \layout-from for getting context defs from music http://code.google.com/p/lilypond/issues/detail?id=2336 Reverted to fixed, since this needs reverifying by checking the source as pulled from git, not just the commitish. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Updates: Status: Verified Comment #19 on issue 2336 by colingh...@gmail.com: Patch: Add layout changing command \layout-from for getting context defs from music http://code.google.com/p/lilypond/issues/detail?id=2336 Verified that the commitish from Comment #6 is in the repo. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Comment #18 on issue 2336 by d...@gnu.org: Patch: Add layout changing command \layout-from for getting context defs from music http://code.google.com/p/lilypond/issues/detail?id=2336 Hi Janek. Check out issue 2358. That would obsolete \layout-from. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Comment #13 on issue 2336 by janek.li...@gmail.com: Patch: Add layout changing command \layout-from for getting context defs from music http://code.google.com/p/lilypond/issues/detail?id=2336 David, sorry for such stupid question, but i don't understand one thing: in the patch you posted (commit dd7a75b0862bf05adec8033a1c4a15f225255101), there is no such thing as settingsFrom function. I remember that settingsFrom was user as an intermediate function in your drafts that were posted on mailing lists, but i thought it was deleted. From what i understand, everything is now done using \layout-from, and it can be used both in \midi and \layout. So, why are you discussing renaming settingsFrom to anything? If i understand it correctly and \layout-from is *the* function used, i think that \context-properties-from is a good name for it. \layout-from is more catchy and easier to understand, but it's also confusing. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Comment #14 on issue 2336 by janek.li...@gmail.com: Patch: Add layout
changing command \layout-from for getting context defs from music
http://code.google.com/p/lilypond/issues/detail?id=2336
David, you wrote: ... Instead, when music is encountered in a context def
or output def, just call a Scheme function for harvesting it, period ...
Do you mean that you are considering having your
\layout-from-or-whatever-name-we-choose function automatically used inside
\layout block? I.e., sth like
\layout {
\accidentalStyle dodecaphonic
}
would work automatically, without requiring the user to use \layout-from at
all?
If yes, that would be **__absolutely awesome!!__**
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Comment #15 on issue 2336 by d...@gnu.org: Patch: Add layout changing command \layout-from for getting context defs from music http://code.google.com/p/lilypond/issues/detail?id=2336 Regarding comment #13: commit 83e6304ae3cc708a8e4d0462249ca8babae265a3 Author: David Kastrup d...@gnu.org Date: Mon Nov 21 01:05:07 2011 +0100 Add Scheme context-mods, reimplement \grobdescriptions, add \settingsFrom \settingsFrom translates music with layout instructions (\set, \unset, \override, \revert) into a context modification. That way, you can use most of the definitions from ly/property-init.ly as context modifications. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Comment #16 on issue 2336 by janek.li...@gmail.com: Patch: Add layout changing command \layout-from for getting context defs from music http://code.google.com/p/lilypond/issues/detail?id=2336 wow, i didn't realize \settingsFrom was added in November! ok, so i understand that \settingsFrom and \layout-from are similar but independent from themselves. Still, one thing puzzles me: are there any situations in which \layout-from can't be used and \settingsFrom works? Every example of \settingsFrom usage i found on mailing list could be replaced with \layout-from, unless i'm wrong somewhere. Maybe we shall deprecate \settingsFrom? \layout-from is more user-friendly i think. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Comment #17 on issue 2336 by d...@gnu.org: Patch: Add layout changing command \layout-from for getting context defs from music http://code.google.com/p/lilypond/issues/detail?id=2336 \settingsFrom creates a context-mod. You can pass that around and use it in a lot more situations than a hardwired setting of output variables. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Updates: Status: Fixed Labels: -Patch-push Fixed_2_15_31 Comment #6 on issue 2336 by d...@gnu.org: Patch: Add layout changing command \layout-from for getting context defs from music http://code.google.com/p/lilypond/issues/detail?id=2336 Pushed a version changed along the suggested lines as dd7a75b0862bf05adec8033a1c4a15f225255101 to staging. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Issue 2336: Patch: Add layout changing command \layout-from for getting context defs from music http://code.google.com/p/lilypond/issues/detail?id=2336 This issue is no longer blocking issue 2322. See http://code.google.com/p/lilypond/issues/detail?id=2322 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Comment #8 on issue 2336 by d...@gnu.org: Patch: Add layout changing
command \layout-from for getting context defs from music
http://code.google.com/p/lilypond/issues/detail?id=2336
Ok, I am not altogether happy. The regexp example with its
\midi { \layout-from { \tempo 4 = 80 } }
makes quite obvious that this is rather \context-defs-from or \output-from
even though it will most often be used as \layout { \layout-from ...
Its purpose is to adjust context-defs while in an output-def. Does anybody
have a better suggestion for its name? It's pushed to staging already, but
it would still be pretty painless to change its name. The name should
contain a hyphen (to prevent accidental use inside of music). It serves a
somewhat similar purpose as \settingsFrom (which is used inside of a single
context-def and actually could also make use of a hyphen: it is
less dangerous since it does not actively change variables in the current
module but just returns a context-def).
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Comment #9 on issue 2336 by d...@gnu.org: Patch: Add layout changing
command \layout-from for getting context defs from music
http://code.google.com/p/lilypond/issues/detail?id=2336
Ok, what do people say to the following:
a) rename settingsFrom to \context-like
b) rename \layout-from to \output-like
Then we may do things like
\midi {
\Score { \context-like { \tempo 4 = 80 } }
}
\layout {
\output-like { \accidentalStyle modern }
}
Is that better than xxx-from ?
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Ok, what do people say to the following:
a) rename settingsFrom to \context-like
b) rename \layout-from to \output-like
Then we may do things like
\midi {
\Score { \context-like { \tempo 4 = 80 } }
}
\layout {
\output-like { \accidentalStyle modern }
}
Is that better than xxx-from ?
I totally agree.
It is an evidence that \context-like deals with contexts and,
from a non English native user point of view, I know that layout deals
with printable; therefore I would get confused to be allowed to mention
\layout-from in a midi block...
Cheers,
Jean-Charles
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Comment #10 on issue 2336 by carl.d.s...@gmail.com: Patch: Add layout
changing command \layout-from for getting context defs from music
http://code.google.com/p/lilypond/issues/detail?id=2336
I think I would prefer
\layout-properties-from
\context-properties-from
It's more typing, but I think it's clearer.
\midi {
\Score {
\context-properties-from { \tempo 4 = 80}
}
}
\layout {
\layout-properties-from { \accidentalStyle modern }
}
Thanks,
Carl
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Comment #12 on issue 2336 by d...@gnu.org: Patch: Add layout changing
command \layout-from for getting context defs from music
http://code.google.com/p/lilypond/issues/detail?id=2336
I am actually starting to lean towards not bothering about the naming at
all. Instead, when music is encountered in a context def or output def,
just call a Scheme function for harvesting it, period.
That would make \midi { \tempo 4 = 80 } work again as expected. The only
disadvantage is that you can't specify what to do with layout properties
for Bottom then, but in that case one could still use
\layout { \with-Bottom #'TabVoice \FullTabulature } or so.
Sure, it is not really all that conceptually clean, but one can throw a
warning for any kind of music not belonging in there.
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Updates: Labels: -Patch-countdown Patch-push Comment #5 on issue 2336 by colinpkc...@gmail.com: Patch: Add layout changing command \layout-from for getting context defs from music http://code.google.com/p/lilypond/issues/detail?id=2336 Counted down to 20120223, please push. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 2336 in lilypond: Patch: Add layout changing command \layout-from for getting context defs from music
Updates: Labels: Patch-review Comment #1 on issue 2336 by d...@gnu.org: Patch: Add layout changing command \layout-from for getting context defs from music http://code.google.com/p/lilypond/issues/detail?id=2336#c1 Patchy the autobot says: LGTM. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
