Re: Segmentation fault: \addquote chokes on \new Voice
Erik Sandberg schreef: On Wednesday 18 October 2006 10:12, Han-Wen Nienhuys wrote: Erik Sandberg schreef: On Thursday 12 October 2006 01:53, Han-Wen Nienhuys wrote: Thanks for fixing this; can you update issue #111 and add a fixed2925 tag? Done. Should I mark somehow that I'm the one who fixed it (through 'Owner' field or similar), or is it sufficient that I'm the one who wrote the 'fixed' comment? we can tell by the comment, I suppose. -- Han-Wen Nienhuys - [EMAIL PROTECTED] - http://www.xs4all.nl/~hanwen LilyPond Software Design -- Code for Music Notation http://www.lilypond-design.com ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Segmentation fault: \addquote chokes on \new Voice
On Wednesday 18 October 2006 10:12, Han-Wen Nienhuys wrote: > Erik Sandberg schreef: > > On Thursday 12 October 2006 01:53, Han-Wen Nienhuys wrote: > Thanks for fixing this; can you update issue #111 and add a fixed2925 tag? Done. Should I mark somehow that I'm the one who fixed it (through 'Owner' field or similar), or is it sufficient that I'm the one who wrote the 'fixed' comment? -- Erik ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Segmentation fault: \addquote chokes on \new Voice
Erik Sandberg schreef: On Thursday 12 October 2006 01:53, Han-Wen Nienhuys wrote: Marcus Macauley schreef: I just upgraded to 2.9.22 (for Linux), and this bug persists. So here it is again (below) with the proper version number. http://code.google.com/p/lilypond/issues/detail?id=111 Erik, I believe this may be related to your changes. Can you have a look at this? Thanks, The attached patch fixes this. The problem is that context::implementation isn't initialised. They don't need to be, because quote and friends use non-translator listeners. The patch inserts checks for implementation_ != 0 everywhere. Thanks for fixing this; can you update issue #111 and add a fixed2925 tag? -- Han-Wen Nienhuys - [EMAIL PROTECTED] - http://www.xs4all.nl/~hanwen LilyPond Software Design -- Code for Music Notation http://www.lilypond-design.com ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Segmentation fault: \addquote chokes on \new Voice
Erik Sandberg schreef: On Tuesday 17 October 2006 00:02, Han-Wen Nienhuys wrote: Erik Sandberg schreef: The attached patch fixes this. The problem is that context::implementation isn't initialised. They don't need to be, because quote and friends use non-translator listeners. The patch inserts checks for implementation_ != 0 everywhere. I wanted to do it like this, but I thought there would be a solution where this is not necessary. Please apply. Problem: 'make' fails with: [...] Writing "lilypond-internals.texi"... error: can't find description for property stringFingerOrientations (translation) make[2]: *** [out/lilypond-internals.texi] Error 1 fixed. -- Han-Wen Nienhuys - [EMAIL PROTECTED] - http://www.xs4all.nl/~hanwen LilyPond Software Design -- Code for Music Notation http://www.lilypond-design.com ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Segmentation fault: \addquote chokes on \new Voice
On Tuesday 17 October 2006 00:02, Han-Wen Nienhuys wrote: > Erik Sandberg schreef: > > The attached patch fixes this. > > > > The problem is that context::implementation isn't initialised. They don't > > need to be, because quote and friends use non-translator listeners. The > > patch inserts checks for implementation_ != 0 everywhere. > > I wanted to do it like this, but I thought there would be a solution > where this is not necessary. > > Please apply. Problem: 'make' fails with: [...] Writing "lilypond-internals.texi"... error: can't find description for property stringFingerOrientations (translation) make[2]: *** [out/lilypond-internals.texi] Error 1 -- Erik ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Segmentation fault: \addquote chokes on \new Voice
On Tuesday 17 October 2006 00:02, Han-Wen Nienhuys wrote: > Erik Sandberg schreef: > > The attached patch fixes this. > > > > The problem is that context::implementation isn't initialised. They don't > > need to be, because quote and friends use non-translator listeners. The > > patch inserts checks for implementation_ != 0 everywhere. > > I wanted to do it like this, but I thought there would be a solution > where this is not necessary. The best solution IMHO is to scrap Context::implementation altogether, which will happen after 2.10. -- Erik ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Segmentation fault: \addquote chokes on \new Voice
Erik Sandberg schreef: The attached patch fixes this. The problem is that context::implementation isn't initialised. They don't need to be, because quote and friends use non-translator listeners. The patch inserts checks for implementation_ != 0 everywhere. I wanted to do it like this, but I thought there would be a solution where this is not necessary. Please apply. -- Han-Wen Nienhuys - [EMAIL PROTECTED] - http://www.xs4all.nl/~hanwen LilyPond Software Design -- Code for Music Notation http://www.lilypond-design.com ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Segmentation fault: \addquote chokes on \new Voice
On Thursday 12 October 2006 01:53, Han-Wen Nienhuys wrote:
> Marcus Macauley schreef:
> > I just upgraded to 2.9.22 (for Linux), and this bug persists.
> >
> > So here it is again (below) with the proper version number.
>
> http://code.google.com/p/lilypond/issues/detail?id=111
>
> Erik,
>
> I believe this may be related to your changes. Can you have a look at
> this? Thanks,
The attached patch fixes this.
The problem is that context::implementation isn't initialised. They don't need
to be, because quote and friends use non-translator listeners. The patch
inserts checks for implementation_ != 0 everywhere.
In addition I removed recording_group_engraver, I hope that's ok.
--
Erik
Index: lily/context.cc
===
RCS file: /sources/lilypond/lilypond/lily/context.cc,v
retrieving revision 1.89
diff -u -r1.89 context.cc
--- lily/context.cc 11 Oct 2006 23:56:44 - 1.89
+++ lily/context.cc 16 Oct 2006 21:13:54 -
@@ -509,7 +509,9 @@
Context::remove_context (SCM)
{
/* ugh, the translator group should listen to RemoveContext events by itself */
- implementation ()->disconnect_from_context ();
+ Translator_group *impl = implementation ();
+ if (impl)
+impl->disconnect_from_context ();
disconnect_from_parent ();
}
Index: lily/translator-group-ctors.cc
===
RCS file: /sources/lilypond/lilypond/lily/translator-group-ctors.cc,v
retrieving revision 1.6
diff -u -r1.6 translator-group-ctors.cc
--- lily/translator-group-ctors.cc 6 Jan 2006 09:13:24 - 1.6
+++ lily/translator-group-ctors.cc 16 Oct 2006 21:13:55 -
@@ -10,7 +10,6 @@
#include "score-performer.hh"
#include "engraver-group.hh"
#include "performer-group.hh"
-#include "recording-group-engraver.hh"
#include "warn.hh"
/*
@@ -27,8 +26,6 @@
return new Score_engraver ();
else if (sym == ly_symbol2scm ("Score_performer"))
return new Score_performer ();
- else if (sym == ly_symbol2scm ("Recording_group_engraver"))
-return new Recording_group_engraver ();
programming_error ("Couldn't find type");
scm_flush (scm_current_error_port ());
Index: lily/translator-group.cc
===
RCS file: /sources/lilypond/lilypond/lily/translator-group.cc,v
retrieving revision 1.158
diff -u -r1.158 translator-group.cc
--- lily/translator-group.cc 22 Sep 2006 07:51:37 - 1.158
+++ lily/translator-group.cc 16 Oct 2006 21:13:55 -
@@ -202,7 +202,7 @@
Translator_group *tg
= dynamic_cast (c->implementation ());
- if (dir == DOWN)
+ if (tg && dir == DOWN)
{
tg->precomputed_translator_foreach (idx);
tg->call_precomputed_self_method (idx);
@@ -212,7 +212,7 @@
s = scm_cdr (s))
precomputed_recurse_over_translators (unsmob_context (scm_car (s)), idx, dir);
- if (dir == UP)
+ if (tg && dir == UP)
{
tg->precomputed_translator_foreach (idx);
tg->call_precomputed_self_method (idx);
@@ -225,7 +225,7 @@
Translator_group *tg
= dynamic_cast (c->implementation ());
- if (dir == DOWN)
+ if (tg && dir == DOWN)
{
(tg->*tg_ptr) ();
translator_each (tg->get_simple_trans_list (), ptr);
@@ -235,7 +235,7 @@
s = scm_cdr (s))
recurse_over_translators (unsmob_context (scm_car (s)), ptr, tg_ptr, dir);
- if (dir == UP)
+ if (tg && dir == UP)
{
translator_each (tg->get_simple_trans_list (),
ptr);
Index: ly/declarations-init.ly
===
RCS file: /sources/lilypond/lilypond/ly/declarations-init.ly,v
retrieving revision 1.104
diff -u -r1.104 declarations-init.ly
--- ly/declarations-init.ly 24 Aug 2006 14:45:10 - 1.104
+++ ly/declarations-init.ly 16 Oct 2006 21:13:56 -
@@ -97,16 +97,8 @@
#(set-default-paper-size (ly:get-option 'paper-size))
-
partCombineListener = \layout {
\context {
- \Voice
- \consists Note_heads_engraver
- \consists Rest_engraver
- \type "Recording_group_engraver"
- recordEventSequence = #notice-the-events-for-pc
-}
-\context {
\Score
skipTypesetting = ##t
ignoreBarChecks = ##t
___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Segmentation fault: \addquote chokes on \new Voice
Marcus Macauley schreef: I just upgraded to 2.9.22 (for Linux), and this bug persists. So here it is again (below) with the proper version number. http://code.google.com/p/lilypond/issues/detail?id=111 Erik, I believe this may be related to your changes. Can you have a look at this? Thanks, Han-Wen -- Han-Wen Nienhuys - [EMAIL PROTECTED] - http://www.xs4all.nl/~hanwen LilyPond Software Design -- Code for Music Notation http://www.lilypond-design.com ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Segmentation fault: \addquote chokes on \new Voice
I just upgraded to 2.9.22 (for Linux), and this bug persists.
So here it is again (below) with the proper version number.
Marcus
\version "2.9.22"
% When lilypond is run on this file, it generates a segmentation fault.
% Apparently \addquote can't handle the \new Voice.
%
% The documentation mentions this --
% "8.3.3 Quoting other voices"
%
http://lilypond.org/doc/v2.9/Documentation/user/lilypond/Quoting-other-voices.html
% -- but doesn't say anything about a segmentation fault.
%
% Here's the quote from that documentation page:
% "Only the contents of the first Voice occurring in an \addquote command
% will be considered for quotation, so music can not contain \new and
% \context Voice statements that would switch to a different Voice."
violinmusic = \relative g' { << \new Voice {r4 g f e} \\ {g,2 c} >> }
\addquote violin \violinmusic % comment out this line and it works just
fine
\score { \violinmusic
\layout { ragged-right = ##t }
}
___
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond
