Re: slurs in polyphony and TabStaff problems
On Sun, Jun 10, 2012 at 03:08:58AM +0200, Federico Bruni wrote: Il 07/06/2012 11:21, m...@apollinemike.com ha scritto: On 7 juin 2012, at 07:36, Federico Bruni wrote: The slur in TabStaff is really ugly. Tested with 2.15.40 packaged version Thanks, Federico Hey Federico, It is and it isn't. It's likely linked to the same underlying problem, but the problem you identify above already exists in 2.14.0. My work on Stems and Flags exacerbated the problem for certain slurs. The problem is that, around line 167 of lily/slur-scoring.cc, there is not enough checking to see if the stems are printed on the page. As a result, ghosted stems are taken into account. Before I fix this, I'll need a bit of feedback from a guitar player/enthusiast - could someone who knows tablature inside out look at Federico's example and let me know how the slur should be typeset (ideally w/ a PDF)? Should these be treated more or less like whole notes? Cheers, MS Hi Mike, I'm CCing lilypond-user, hoping that they will give you some feedback. I'm not expert in notation at all. All I can say is that slur should be closer to notes (see .svg file edited in Inkscape). I've created an issue tracker for this report from Federico: http://code.google.com/p/lilypond/issues/detail?id=2595 Cheers, Colin. -- Colin Hall ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: slurs in polyphony and TabStaff problems
On Sun, Jun 10, 2012 at 03:08:58AM +0200, Federico Bruni wrote: Il 07/06/2012 11:21, m...@apollinemike.com ha scritto: On 7 juin 2012, at 07:36, Federico Bruni wrote: Il 04/06/2012 09:11, m...@apollinemike.com ha scritto: On 4 juin 2012, at 08:05, David Kastrup wrote: Federico Brunifedel...@gmail.com writes: Another report about slurs and TabStaff. IIUC, now slurs connect note heads in polyphony (instead of stems). I _think_ that it's a desired output. Frankly, it does not look like an improvement to me on the normal staff either. I thought that maybe the EventChord changes would have been responsible, but it does not seem so. Maybe Stem/Flag? You're right. Solution found, running regtests, will post soon. Hey Mike, I _think_ this is related: try the attached example, the problem is with \voiceTwo activated. The slur in TabStaff is really ugly. Tested with 2.15.40 packaged version Thanks, Federico Hey Federico, It is and it isn't. It's likely linked to the same underlying problem, but the problem you identify above already exists in 2.14.0. My work on Stems and Flags exacerbated the problem for certain slurs. The problem is that, around line 167 of lily/slur-scoring.cc, there is not enough checking to see if the stems are printed on the page. As a result, ghosted stems are taken into account. Before I fix this, I'll need a bit of feedback from a guitar player/enthusiast - could someone who knows tablature inside out look at Federico's example and let me know how the slur should be typeset (ideally w/ a PDF)? Should these be treated more or less like whole notes? Cheers, MS Hi Mike, I'm CCing lilypond-user, hoping that they will give you some feedback. I'm not expert in notation at all. All I can say is that slur should be closer to notes (see .svg file edited in Inkscape). Hi Federico, The SVG file you sent looks nothing like the PNG images that you sent in your original bug report that started this thread. It looks a bit like the one for your other bug report Ugly slur in TabStaff if font is changed Can you clarify please? Here are the two bug reports and related trackers: Ugly slur in TabStaff if font is changed Report: http://lists.gnu.org/archive/html/bug-lilypond/2012-06/msg00019.html Tracker: http://code.google.com/p/lilypond/issues/detail?id=2587 -- also: -- slurs in polyphony and TabStaff problems Report: http://lists.gnu.org/archive/html/bug-lilypond/2012-06/msg00022.html Tracker (which I just created): http://code.google.com/p/lilypond/issues/detail?id=2587 - Cheers, Colin. -- Colin Hall ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: slurs in polyphony and TabStaff problems
Il 10/06/2012 14:42, Colin Hall ha scritto:
Hi Federico,
The SVG file you sent looks nothing like the PNG images that you sent
in your original bug report that started this thread. It looks a bit
like the one for your other bug report Ugly slur in TabStaff if font
is changed
Can you clarify please?
sorry for the confusion
Actually, the second example I sent is not a regression.
As Mike pointed out
(http://lists.gnu.org/archive/html/bug-lilypond/2012-06/msg00046.html),
the same problem occurred in 2.14.x
I made a simpler minimal example.
Manual beaming is responsible of the wrong slur in TabStaff:
\version 2.14.2
music = \relative c, {
% comment \voiceTwo or remove manual beaming and the output is good
\voiceTwo
\acciaccatura { f16[ f] } f4
}
\score {
\new StaffGroup
\new Staff
\context Voice { \clef G_8 \music }
\new TabStaff
\context TabVoice { \clef moderntab \music }
}
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: slurs in polyphony and TabStaff problems
On Sun, Jun 10, 2012 at 03:42:36PM +0200, Federico Bruni wrote: Il 10/06/2012 14:42, Colin Hall ha scritto: Hi Federico, The SVG file you sent looks nothing like the PNG images that you sent in your original bug report that started this thread. It looks a bit like the one for your other bug report Ugly slur in TabStaff if font is changed Can you clarify please? sorry for the confusion That's ok. You'll forgive me, I hope, but my interest begins and ends with administration of the issue tracker. So, could you confirm whether there are two distinct bug reports here, or just one? Cheers, Colin. -- Colin Hall ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: slurs in polyphony and TabStaff problems
Il 10/06/2012 17:11, Colin Hall ha scritto: You'll forgive me, I hope, but my interest begins and ends with administration of the issue tracker. So, could you confirm whether there are two distinct bug reports here, or just one? they are both about ugly slurs, but they are distinct: #2587: it occurs when TabStaff font is changed #2595: ...well, it's something different (not related to font) ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: slurs in polyphony and TabStaff problems
Il 07/06/2012 11:21, m...@apollinemike.com ha scritto:
On 7 juin 2012, at 07:36, Federico Bruni wrote:
Il 04/06/2012 09:11, m...@apollinemike.com ha scritto:
On 4 juin 2012, at 08:05, David Kastrup wrote:
Federico Brunifedel...@gmail.com writes:
Another report about slurs and TabStaff.
IIUC, now slurs connect note heads in polyphony (instead of stems).
I _think_ that it's a desired output.
Frankly, it does not look like an improvement to me on the normal staff
either. I thought that maybe the EventChord changes would have been
responsible, but it does not seem so. Maybe Stem/Flag?
You're right. Solution found, running regtests, will post soon.
Hey Mike,
I _think_ this is related: try the attached example, the problem
is with \voiceTwo activated.
The slur in TabStaff is really ugly.
Tested with 2.15.40 packaged version
Thanks,
Federico
Hey Federico,
It is and it isn't. It's likely linked to the same underlying problem, but the
problem you identify above already exists in 2.14.0. My work on Stems and
Flags exacerbated the problem for certain slurs.
The problem is that, around line 167 of lily/slur-scoring.cc, there is not
enough checking to see if the stems are printed on the page. As a result,
ghosted stems are taken into account.
Before I fix this, I'll need a bit of feedback from a guitar player/enthusiast
- could someone who knows tablature inside out look at Federico's example and
let me know how the slur should be typeset (ideally w/ a PDF)? Should these be
treated more or less like whole notes?
Cheers,
MS
Hi Mike,
I'm CCing lilypond-user, hoping that they will give you some feedback.
I'm not expert in notation at all. All I can say is that slur should be
closer to notes (see .svg file edited in Inkscape).
Hope other users will give you better feedback.
\version 2.14.2
music = \relative c {
\set stringTunings = #guitar-open-d-tuning
% comment \voiceTwo and the output is good
\voiceTwo
g4 \acciaccatura g8 f4 d \acciaccatura { f16[ f] } f4
}
\score {
\new StaffGroup
\new Staff
\context Voice { \clef G_8 \music }
\new TabStaff
\context TabVoice { \clef moderntab \music }
}attachment: ugly-slurs-tabstaff.preview.svg___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: slurs in polyphony and TabStaff problems
Hello,
2012/6/3 Federico Bruni fedel...@gmail.com
Another report about slurs and TabStaff.
IIUC, now slurs connect note heads in polyphony (instead of stems).
I _think_ that it's a desired output.
However, it's breaking the TabStaff slurs.
Find attached .png examples (see differences between 2.14.2 and 2.15.40).
here's the minimal example:
\version 2.15.40
first = \relative c' {
b8( c)
}
second = \relative c {
d8( e)
}
\score {
\new StaffGroup
\new Staff = guitar
\context Voice = first voice { \clef G_8 \voiceOne \first }
\context Voice = second voice { \clef G_8 \voiceTwo \second }
\new TabStaff = tab
\context TabVoice = tab first voice { \clef moderntab \voiceOne
\first }
\context TabVoice = tab second voice { \clef moderntab \voiceTwo
\second }
}
Colin has opened an issue for this:
http://code.google.com/p/lilypond/issues/detail?id=2587
Colin, please do not forget to inform the list when you add an tracker
issue... :(
Marek
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: slurs in polyphony and TabStaff problems
Hi Marek, On Fri, Jun 08, 2012 at 10:40:54PM +0200, Marek Klein wrote: Hello, 2012/6/3 Federico Bruni fedel...@gmail.com Another report about slurs and TabStaff. IIUC, now slurs connect note heads in polyphony (instead of stems). I _think_ that it's a desired output. However, it's breaking the TabStaff slurs. Colin has opened an issue for this: http://code.google.com/p/lilypond/issues/detail?id=2587 Colin, please do not forget to inform the list when you add an tracker issue... :( Hey, Marek, I'm guessing you started work on this and then found 2587. I know how annoying that can be. Sorry about any wasted effort on your part. Federico, being a well behaved user, filed separate bug reports for distinct problems even though both problems were about slurs and TabStaff. Thank you, Federico! It is a bit confusing because the two reports look similar. First, on 3th June Ugly slur in TabStaff if font is changed Report: http://lists.gnu.org/archive/html/bug-lilypond/2012-06/msg00019.html Tracker: http://code.google.com/p/lilypond/issues/detail?id=2587 Acknowledgement and link to tracker: http://lists.gnu.org/archive/html/bug-lilypond/2012-06/msg00025.html Second, also 3th June slurs in polyphony and TabStaff problems Report: http://lists.gnu.org/archive/html/bug-lilypond/2012-06/msg00022.html This one appears to be under discussion by the devs. Mike has solicited input from the guitar community. It is not clear to me that there is a bug here. If you'd like to create a tracker for this second report, that would be great. Finally, on 6th June, NR: repeat slurs and glissando workaround which Ralph handled. Report: http://lists.gnu.org/archive/html/bug-lilypond/2012-06/msg00045.html Tracker: http://code.google.com/p/lilypond/issues/detail?id=2591 Acknowledgement and link to tracker: http://lists.gnu.org/archive/html/bug-lilypond/2012-06/msg00049.html I hope that helps. Cheers, Colin. -- Colin Hall ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: slurs in polyphony and TabStaff problems
On 7 juin 2012, at 07:36, Federico Bruni wrote: Il 04/06/2012 09:11, m...@apollinemike.com ha scritto: On 4 juin 2012, at 08:05, David Kastrup wrote: Federico Brunifedel...@gmail.com writes: Another report about slurs and TabStaff. IIUC, now slurs connect note heads in polyphony (instead of stems). I _think_ that it's a desired output. Frankly, it does not look like an improvement to me on the normal staff either. I thought that maybe the EventChord changes would have been responsible, but it does not seem so. Maybe Stem/Flag? You're right. Solution found, running regtests, will post soon. Hey Mike, I _think_ this is related: try the attached example, the problem is with \voiceTwo activated. The slur in TabStaff is really ugly. Tested with 2.15.40 packaged version Thanks, Federico Thanks Federico, The issue must be that, somewhere, stems are being read as visible for the slur. Should be a one liner[1]. ~Mike [1] If I had a nickel for every time I said should be a one liner and I was wrong by 3 orders of magnitude, I'd have at least 95 cents! ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: slurs in polyphony and TabStaff problems
On 7 juin 2012, at 07:36, Federico Bruni wrote: Il 04/06/2012 09:11, m...@apollinemike.com ha scritto: On 4 juin 2012, at 08:05, David Kastrup wrote: Federico Brunifedel...@gmail.com writes: Another report about slurs and TabStaff. IIUC, now slurs connect note heads in polyphony (instead of stems). I _think_ that it's a desired output. Frankly, it does not look like an improvement to me on the normal staff either. I thought that maybe the EventChord changes would have been responsible, but it does not seem so. Maybe Stem/Flag? You're right. Solution found, running regtests, will post soon. Hey Mike, I _think_ this is related: try the attached example, the problem is with \voiceTwo activated. The slur in TabStaff is really ugly. Tested with 2.15.40 packaged version Thanks, Federico Hey Federico, It is and it isn't. It's likely linked to the same underlying problem, but the problem you identify above already exists in 2.14.0. My work on Stems and Flags exacerbated the problem for certain slurs. The problem is that, around line 167 of lily/slur-scoring.cc, there is not enough checking to see if the stems are printed on the page. As a result, ghosted stems are taken into account. Before I fix this, I'll need a bit of feedback from a guitar player/enthusiast - could someone who knows tablature inside out look at Federico's example and let me know how the slur should be typeset (ideally w/ a PDF)? Should these be treated more or less like whole notes? Cheers, MS ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: slurs in polyphony and TabStaff problems
m...@apollinemike.com m...@apollinemike.com writes: Thanks Federico, The issue must be that, somewhere, stems are being read as visible for the slur. Should be a one liner[1]. ~Mike [1] If I had a nickel for every time I said should be a one liner and I was wrong by 3 orders of magnitude, I'd have at least 95 cents! I may repeat myself here: invisible objects are to be treated like visible ones: that is the main point of them. If you don't want them to be involved in collision avoidance, set their stencil to #f. -- David Kastrup ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: slurs in polyphony and TabStaff problems
Il 04/06/2012 09:11, m...@apollinemike.com ha scritto:
On 4 juin 2012, at 08:05, David Kastrup wrote:
Federico Brunifedel...@gmail.com writes:
Another report about slurs and TabStaff.
IIUC, now slurs connect note heads in polyphony (instead of stems).
I _think_ that it's a desired output.
Frankly, it does not look like an improvement to me on the normal staff
either. I thought that maybe the EventChord changes would have been
responsible, but it does not seem so. Maybe Stem/Flag?
You're right. Solution found, running regtests, will post soon.
Hey Mike,
I _think_ this is related: try the attached example, the problem
is with \voiceTwo activated.
The slur in TabStaff is really ugly.
Tested with 2.15.40 packaged version
Thanks,
Federico
\version 2.15.40
music = \relative c {
\set stringTunings = #guitar-open-d-tuning
% comment \voiceTwo and the output is good
\voiceTwo
g4 \acciaccatura g8 f4 d \acciaccatura { f16[ f] } f4
}
\score {
\new StaffGroup
\new Staff
\context Voice { \clef G_8 \music }
\new TabStaff
\context TabVoice { \clef moderntab \music }
}attachment: document.preview.png___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: slurs in polyphony and TabStaff problems
Federico Bruni fedel...@gmail.com writes: Another report about slurs and TabStaff. IIUC, now slurs connect note heads in polyphony (instead of stems). I _think_ that it's a desired output. Frankly, it does not look like an improvement to me on the normal staff either. I thought that maybe the EventChord changes would have been responsible, but it does not seem so. Maybe Stem/Flag? Or was this indeed intentional? -- David Kastrup ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: slurs in polyphony and TabStaff problems
On 4 juin 2012, at 08:05, David Kastrup wrote: Federico Bruni fedel...@gmail.com writes: Another report about slurs and TabStaff. IIUC, now slurs connect note heads in polyphony (instead of stems). I _think_ that it's a desired output. Frankly, it does not look like an improvement to me on the normal staff either. I thought that maybe the EventChord changes would have been responsible, but it does not seem so. Maybe Stem/Flag? You're right. Solution found, running regtests, will post soon. Cheers, MS ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: slurs in polyphony and TabStaff problems
On Sun, Jun 03, 2012 at 03:06:43PM +0200, Federico Bruni wrote: Another report about slurs and TabStaff. IIUC, now slurs connect note heads in polyphony (instead of stems). I _think_ that it's a desired output. Thanks for the report, Federico. I'll look at this one tomorrow. Cheers, Colin. -- Colin Hall ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
