Re: commit 12fe78825798191ecb7e5a4ee3064679773ae1ab is broken
"James Lowe" writes:
> Knut,
>
> On Sat, 9 Jun 2018 23:19:01 +0200, Knut Petersen
> wrote:
>
>> Hi James!
>> > Checking out the commit before any of those three that Malte
>> > checed in and then I built LilyPond and simply ran
>> >
>> > lilypond -png $LILYPOND_GIT/input/regression
>>
>> encodingdefs.ps is unused if neither '-O TeX' nor '-O TeX-GS' is
>> used on the command line.
>>
>> Checkout, make and install 12fe788, create a file test.ly:
>>
>> \version "2.21.0"
>> {c''-.}
>>
>> Then compile with
>>
>> lilypond -O TeX --png --pdf test.pdf
>
> Thanks.
>
> I appreciate the time you have taken with me to explain this.
>
> I went back and re-did the 'tests' I would have done with Malte's patch.
>
> And now I can see it - the incorrect pizzicato glyph does show up. I
> simply must have missed this when testing Malte's patch.
>
> All I can do now is apologise to you (for all the extra explaining I
> made you do) and to Malte for not spotting this at the time and the
> rest of the dev team allowing this through. I guess I am just so used
> to using the test-distance reg diff showing up only to show me the
> tests completed 'properly' - i.e if I don't see this reg test diff
> show up I know the patch has gone wrong.
Uh, the procedures are designed as a safety net, not a trampoline.
The actually surprising thing is how much relevant feedback you are able
to provide.
--
David Kastrup
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: commit 12fe78825798191ecb7e5a4ee3064679773ae1ab is broken
Am 10.06.2018 um 16:51 schrieb James Lowe: All I can do now is apologise to you Don't feel bad about this ... thanks for the time you spend doing all those tests! Knut ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: commit 12fe78825798191ecb7e5a4ee3064679773ae1ab is broken
Knut,
On Sat, 9 Jun 2018 23:19:01 +0200, Knut Petersen
wrote:
> Hi James!
> > Checking out the commit before any of those three that Malte checed in and
> > then I built LilyPond and simply ran
> >
> > lilypond -png $LILYPOND_GIT/input/regression
>
> encodingdefs.ps is unused if neither '-O TeX' nor '-O TeX-GS' is used on the
> command line.
>
> Checkout, make and install 12fe788, create a file test.ly:
>
> \version "2.21.0"
> {c''-.}
>
> Then compile with
>
> lilypond -O TeX --png --pdf test.pdf
Thanks.
I appreciate the time you have taken with me to explain this.
I went back and re-did the 'tests' I would have done with Malte's patch.
And now I can see it - the incorrect pizzicato glyph does show up. I simply
must have missed this when testing Malte's patch.
All I can do now is apologise to you (for all the extra explaining I made you
do) and to Malte for not spotting this at the time and the rest of the dev team
allowing this through. I guess I am just so used to using the test-distance reg
diff showing up only to show me the tests completed 'properly' - i.e if I don't
see this reg test diff show up I know the patch has gone wrong.
Thanks again (and to Phil for pointing out the 'bleeding' obvious).
At least the testing methodology is not fundamentally broken.
James
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: commit 12fe78825798191ecb7e5a4ee3064679773ae1ab is broken
Hi James!
Checking out the commit before any of those three that Malte checed in and then
I built LilyPond and simply ran
lilypond -png $LILYPOND_GIT/input/regression
encodingdefs.ps is unused if neither '-O TeX' nor '-O TeX-GS' is used on the
command line.
Checkout, make and install 12fe788, create a file test.ly:
\version "2.21.0"
{c''-.}
Then compile with
lilypond -O TeX --png --pdf test.pdf
Knut
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: commit 12fe78825798191ecb7e5a4ee3064679773ae1ab is broken
2018-06-09 17:02 GMT+02:00 James Lowe : > Attached diff > > ? > > On Sat, 9 Jun 2018 15:38:51 +0100, "Phil Holmes" wrote: > >> "James Lowe" wrote in message >> news:E1fReNj-0003az-Ki@rmmprod07.runbox... >> >> [snip] >> >> > I then ran through the diff files visually and only 2 files showed diffs; >> > >> > test-output-distance (obviously) and 'rest-dot-positions' (again I believe >> > this is also expected at the moment) but not other files showed any >> > diffs. >> > >> > Thanks again for your consideration. >> > >> > James >> >> James, >> >> What Knut is saying is that there is more than the expected variation in the >> test-output-distance test. Not only have the notes moved as expected, but >> also the staccato mark has been incorrectly changed. Have a detailed look >> at the last note of t-o-p and check whether it is a staccato. >> >> -- >> Phil Holmes I'm as puzzled as James, a checkout from 12fe788 always returns a simple staccato-dot for me, while compiling any file with staccati. Cheers, Harm ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: commit 12fe78825798191ecb7e5a4ee3064679773ae1ab is broken
Attached diff ? On Sat, 9 Jun 2018 15:38:51 +0100, "Phil Holmes" wrote: > "James Lowe" wrote in message > news:E1fReNj-0003az-Ki@rmmprod07.runbox... > > [snip] > > > I then ran through the diff files visually and only 2 files showed diffs; > > > > test-output-distance (obviously) and 'rest-dot-positions' (again I believe > > this is also expected at the moment) but not other files showed any > > diffs. > > > > Thanks again for your consideration. > > > > James > > James, > > What Knut is saying is that there is more than the expected variation in the > test-output-distance test. Not only have the notes moved as expected, but > also the staccato mark has been incorrectly changed. Have a detailed look > at the last note of t-o-p and check whether it is a staccato. > > -- > Phil Holmes > > > > ___ > bug-lilypond mailing list > bug-lilypond@gnu.org > https://lists.gnu.org/mailman/listinfo/bug-lilypond ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: commit 12fe78825798191ecb7e5a4ee3064679773ae1ab is broken
"James Lowe" wrote in message news:E1fReNj-0003az-Ki@rmmprod07.runbox... [snip] I then ran through the diff files visually and only 2 files showed diffs; test-output-distance (obviously) and 'rest-dot-positions' (again I believe this is also expected at the moment) but not other files showed any diffs. Thanks again for your consideration. James James, What Knut is saying is that there is more than the expected variation in the test-output-distance test. Not only have the notes moved as expected, but also the staccato mark has been incorrectly changed. Have a detailed look at the last note of t-o-p and check whether it is a staccato. -- Phil Holmes ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: commit 12fe78825798191ecb7e5a4ee3064679773ae1ab is broken
Knut On Fri, 8 Jun 2018 19:13:23 +0200, Knut Petersen wrote: > Am 08.06.2018 um 18:20 schrieb James Lowe: > > How come I did not see anything different with the reg test output at the > > time? > > Maybe you did not see the correct images? pngs / jpegs might be cached by the > browser. > At least konqueror 5.0.97 on my openSuSE Tumbleweed system definitely has > this problem. > > We could append a timestamp to the image urls, e.g. > > > href="input/regression/out-test-baseline/test-output-distance.png?20180608191147" > > Sorry to keep on about this - I just want to understand, that is all. I don't think the browser is caching images. However I decided to do check this 'semi-manually' by doing the following Checking out the commit before any of those three that Malte checed in and then I built LilyPond and simply ran lilypond -png $LILYPOND_GIT/input/regression This produced a full set of png files which I copied to a separate directory Then I checked out *just* the next 3 commits that Malte did (only because they were all for the same issue) and built that version of LilyPond and then ran the same command to get a second set of png files that I then copied to a second separate directory. Finally I ran a simple bash 1-liner to read the files from the first dir and compare them with files of the same name in the second dir, usig imagemagicks compare CLI and output the 'diffs' to a third dir e.g. from within the first dir of the pngs created before Malte's checkin: for f in * ; do compare $f '../malte/'$f -compose Src '../diff/'$f ; done This produced the resultant diff files which only showed the differing pixels. I then ran through the diff files visually and only 2 files showed diffs; test-output-distance (obviously) and 'rest-dot-positions' (again I believe this is also expected at the moment) but not other files showed any diffs. Thanks again for your consideration. James ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: commit 12fe78825798191ecb7e5a4ee3064679773ae1ab is broken
Am 08.06.2018 um 18:20 schrieb James Lowe: How come I did not see anything different with the reg test output at the time? Maybe you did not see the correct images? pngs / jpegs might be cached by the browser. At least konqueror 5.0.97 on my openSuSE Tumbleweed system definitely has this problem. We could append a timestamp to the image urls, e.g. href="input/regression/out-test-baseline/test-output-distance.png?20180608191147" Knut ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: commit 12fe78825798191ecb7e5a4ee3064679773ae1ab is broken
Knut On Fri, 8 Jun 2018 11:59:43 +0200, Knut Petersen wrote: > Am 07.06.2018 um 19:08 schrieb James Lowe: > > > > OK But I assume I would have tested that patch against current master at > > the time which would have caused the failure? > > I'm sure you did. But everybody expects test-output-distance to fail, and a > staccato dot is small ... > > Nevertheless, see https://codereview.appspot.com/347870043/ and > https://sourceforge.net/p/testlilyissues/issues/5338/ Yes. And we evidently have different concepts of what 'pass' means in terms of make check. ;) The tests I run make sure I can 'compile' every thing but the make test-baseline/make check will output the diffs once they were complete according to those 'make' functions - whatever 'check' is coded to do. I wnt back and looked at the tracker for Malte's patch https://sourceforge.net/p/testlilyissues/issues/3128/ and I can see my own comments (i.e. 'passes make, make check etc ...' ) a few times in that thread but no where do I see a 'reg test diff' attached by myself which I always do if I see any (unless it is the test-output and now this annoying staccato dot problem). So when I ran the make test baseline / check for the patch it would have been on current master at that time, but no diffs were shown. Else I would have posted them on the tracker. This is the method that has been used for the last 5 or 6 years by myself. How come I did not see anything different with the reg test output at the time? James ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: commit 12fe78825798191ecb7e5a4ee3064679773ae1ab is broken
Am 07.06.2018 um 19:08 schrieb James Lowe: OK But I assume I would have tested that patch against current master at the time which would have caused the failure? I'm sure you did. But everybody expects test-output-distance to fail, and a staccato dot is small ... Nevertheless, see https://codereview.appspot.com/347870043/ and https://sourceforge.net/p/testlilyissues/issues/5338/ Knut ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: commit 12fe78825798191ecb7e5a4ee3064679773ae1ab is broken
Hello Knut, On Thu, 7 Jun 2018 18:34:10 +0200, Knut Petersen wrote: > Am 07.06.2018 um 15:24 schrieb James Lowe: > > Hello > > > > On Tue, 5 Jun 2018 14:12:16 +0200, Knut Petersen > > wrote: > > > >> Commit 12fe788... caused encodingdefs.ps to be out of sync > >> with the emmentaler fonts. > >> > >> It even does not pass a 'make check' against the previous commit - have a > >> look at the staccato in test-output-distance. The png generated from commit > >> be08490329a2242... shows the expected staccato, the png from commit > >> 12fe788... > >> clearly shows a snappizzicato. > >> > >> Malte, please fix the problem. > >> > >> BTW: we also have make-regtest-pngs.sh ... > >> > >> Knut > > Excuse my ignorance but if this were true > > I checked it twice before writing to bug-lilypond, and now I checked a third > time: > > knut@golem:~/sources/lily> ../mklily-regtest > exec git clean -dfx in /home/knut/sources/lily ... succeeded after 1 > seconds > exec git checkout be08490329a22423bb2a723eea7a5cd33f3a42d8 in > /home/knut/sources/lily ... succeeded after 0 seconds > Building LILYPOND be08490329a22423bb2a723eea7a5cd33f3a42d8... > exec ./autogen.sh --noconfigure in /home/knut/sources/lily ... > succeeded after 0 seconds > exec mkdir -p build in /home/knut/sources/lily ... succeeded after 0 > seconds > exec cd /home/knut/sources/lily/build in /home/knut/sources/lily ... > succeeded after 0 seconds > exec ../configure --prefix=/home/knut/sources/lilybuilt > --with-urwotf-dir=/home/knut/sources/urw-core35-fonts in > /home/knut/sources/lily/build ... succeeded after 7 seconds > exec make -j 11 CPU_COUNT=11 all in /home/knut/sources/lily/build ... > succeeded after 103 seconds > exec make -j 11 CPU_COUNT=11 test-baseline in > /home/knut/sources/lily/build ... succeeded after 152 seconds > exec ./make-regtest-pngs.sh -j9 -o in > /home/knut/sources/lily/scripts/auxiliar ... succeeded after 55 seconds > exec git checkout 12fe78825798191ecb7e5a4ee3064679773ae1ab in > /home/knut/sources/lily ... succeeded after 0 seconds > Building LILYPOND 12fe78825798191ecb7e5a4ee3064679773ae1ab... > exec ./autogen.sh --noconfigure in /home/knut/sources/lily ... > succeeded after 0 seconds > exec mkdir -p build in /home/knut/sources/lily ... succeeded after 0 > seconds > exec cd /home/knut/sources/lily/build in /home/knut/sources/lily ... > succeeded after 0 seconds > exec ../configure --prefix=/home/knut/sources/lilybuilt > --with-urwotf-dir=/home/knut/sources/urw-core35-fonts in > /home/knut/sources/lily/build ... succeeded after 6 seconds > exec make -j 11 CPU_COUNT=11 all in /home/knut/sources/lily/build ... > succeeded after 9 seconds > exec make -j 11 CPU_COUNT=11 test-clean in > /home/knut/sources/lily/build ... succeeded after 0 seconds > exec make -j 11 CPU_COUNT=11 check in /home/knut/sources/lily/build > ... succeeded after 163 seconds > exec ./make-regtest-pngs.sh -j9 -n in > /home/knut/sources/lily/scripts/auxiliar ... succeeded after 306 seconds > > The result still is: > > * test-output-distance.png from be084... shows a staccato under the last > note, the same source compiled with 12fe7... shows a snappizzicato instead. > * merge-rests-engraver.png, bar 11, 2nd rest: staccato under and above the > rest compiled with be084... , snappizzicatos if compiled with 12fe7... > > Have a look at the attached files. > > > wouldn't all the patches I have tested since this was checked in have > > failed with the make check? > > If the next test is based on 12fe7... or later, the error will not show up > again. Since 12fe7 lilypond produces some wrong glyphs (if called with a > command line that exposes the problem, there is no problem with the legacy > postscript code generator that does not use encodings.ps). OK But I assume I would have tested that patch against current master at the time which would have caused the failure? > > BTW: I dont know the script you use. I use pretty much what you do, however your set of steps are different in some ways. This is how I do it (without all the extra make options listed for clarity) autogen.sh --noconfigure mkdir build cd build ../configure --disable-optimising make make test-baseline cd .. [apply patch here - I use 'git apply --index' for the raw download from the Rietveld issue] cd build make clean make make check make doc Then I open in a web browser for the diffs posted in ./out/test-results/index.html -- James ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: commit 12fe78825798191ecb7e5a4ee3064679773ae1ab is broken
Am 07.06.2018 um 15:24 schrieb James Lowe: Hello On Tue, 5 Jun 2018 14:12:16 +0200, Knut Petersen wrote: Commit 12fe788... caused encodingdefs.ps to be out of sync with the emmentaler fonts. It even does not pass a 'make check' against the previous commit - have a look at the staccato in test-output-distance. The png generated from commit be08490329a2242... shows the expected staccato, the png from commit 12fe788... clearly shows a snappizzicato. Malte, please fix the problem. BTW: we also have make-regtest-pngs.sh ... Knut Excuse my ignorance but if this were true I checked it twice before writing to bug-lilypond, and now I checked a third time: knut@golem:~/sources/lily> ../mklily-regtest exec git clean -dfx in /home/knut/sources/lily ... succeeded after 1 seconds exec git checkout be08490329a22423bb2a723eea7a5cd33f3a42d8 in /home/knut/sources/lily ... succeeded after 0 seconds Building LILYPOND be08490329a22423bb2a723eea7a5cd33f3a42d8... exec ./autogen.sh --noconfigure in /home/knut/sources/lily ... succeeded after 0 seconds exec mkdir -p build in /home/knut/sources/lily ... succeeded after 0 seconds exec cd /home/knut/sources/lily/build in /home/knut/sources/lily ... succeeded after 0 seconds exec ../configure --prefix=/home/knut/sources/lilybuilt --with-urwotf-dir=/home/knut/sources/urw-core35-fonts in /home/knut/sources/lily/build ... succeeded after 7 seconds exec make -j 11 CPU_COUNT=11 all in /home/knut/sources/lily/build ... succeeded after 103 seconds exec make -j 11 CPU_COUNT=11 test-baseline in /home/knut/sources/lily/build ... succeeded after 152 seconds exec ./make-regtest-pngs.sh -j9 -o in /home/knut/sources/lily/scripts/auxiliar ... succeeded after 55 seconds exec git checkout 12fe78825798191ecb7e5a4ee3064679773ae1ab in /home/knut/sources/lily ... succeeded after 0 seconds Building LILYPOND 12fe78825798191ecb7e5a4ee3064679773ae1ab... exec ./autogen.sh --noconfigure in /home/knut/sources/lily ... succeeded after 0 seconds exec mkdir -p build in /home/knut/sources/lily ... succeeded after 0 seconds exec cd /home/knut/sources/lily/build in /home/knut/sources/lily ... succeeded after 0 seconds exec ../configure --prefix=/home/knut/sources/lilybuilt --with-urwotf-dir=/home/knut/sources/urw-core35-fonts in /home/knut/sources/lily/build ... succeeded after 6 seconds exec make -j 11 CPU_COUNT=11 all in /home/knut/sources/lily/build ... succeeded after 9 seconds exec make -j 11 CPU_COUNT=11 test-clean in /home/knut/sources/lily/build ... succeeded after 0 seconds exec make -j 11 CPU_COUNT=11 check in /home/knut/sources/lily/build ... succeeded after 163 seconds exec ./make-regtest-pngs.sh -j9 -n in /home/knut/sources/lily/scripts/auxiliar ... succeeded after 306 seconds The result still is: * test-output-distance.png from be084... shows a staccato under the last note, the same source compiled with 12fe7... shows a snappizzicato instead. * merge-rests-engraver.png, bar 11, 2nd rest: staccato under and above the rest compiled with be084... , snappizzicatos if compiled with 12fe7... Have a look at the attached files. wouldn't all the patches I have tested since this was checked in have failed with the make check? If the next test is based on 12fe7... or later, the error will not show up again. Since 12fe7 lilypond produces some wrong glyphs (if called with a command line that exposes the problem, there is no problem with the legacy postscript code generator that does not use encodings.ps). BTW: I dont know the script you use. If you try to use ghostscript on the eps source files used to generate the pngs be aware of the fact that our regtest eps files load emmentaler fonts with absolute paths, not with relative paths to the fonts in /build/input/regression/midi/out-test-baseline/... and /build/input/regression/midi/out-test/... After 'make check' these files are still present, but they will not be used by ghostscript, even if you override lilypond-datadir on the ghostscript command line. knut@golem:~/sources/lily> grep loadfont ./build/input/regression/out-test-baseline/test-output-distance.eps (/home/knut/sources/lily/build/out/share/lilypond/current/fonts/otf/emmentaler-20.otf) (r) file .loadfont (/home/knut/sources/lily/build/out/share/lilypond/current/fonts/otf/emmentaler-20.otf) (r) file .loadfont (/home/knut/sources/lily/build/out/share/lilypond/current/fonts/otf/emmentaler-brace.otf) (r) file .loadfont knut@golem:~/sources/lily> grep loadfont ./build/input/regression/out-test/test-output-distance.eps (/home/knut/sources/lily/build/out/share/lilypond/current/fonts/otf/emmentaler-20.otf) (r) file .loadfont (/home/knut/sources/lily/build/out/share/lilypond/current/fonts/otf/emmentaler-20.otf) (r) file .loadfont
Re: commit 12fe78825798191ecb7e5a4ee3064679773ae1ab is broken
Hello On Tue, 5 Jun 2018 14:12:16 +0200, Knut Petersen wrote: > Commit 12fe788... caused encodingdefs.ps to be out of sync > with the emmentaler fonts. > > It even does not pass a 'make check' against the previous commit - have a > look at the staccato in test-output-distance. The png generated from commit > be08490329a2242... shows the expected staccato, the png from commit 12fe788... > clearly shows a snappizzicato. > > Malte, please fix the problem. > > BTW: we also have make-regtest-pngs.sh ... > > Knut Excuse my ignorance but if this were true wouldn't all the patches I have tested since this was checked in have failed with the make check? http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=12fe78825798191ecb7e5a4ee3064679773ae1ab Regards James ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
commit 12fe78825798191ecb7e5a4ee3064679773ae1ab is broken
Commit 12fe788... caused encodingdefs.ps to be out of sync with the emmentaler fonts. It even does not pass a 'make check' against the previous commit - have a look at the staccato in test-output-distance. The png generated from commit be08490329a2242... shows the expected staccato, the png from commit 12fe788... clearly shows a snappizzicato. Malte, please fix the problem. BTW: we also have make-regtest-pngs.sh ... Knut ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
