Re: v2.23.8: \fine seems to break \midi

2022-08-29 Thread Nikolai Hedler
I apologize for my curt response in the last email I sent (and forgot to
copy the list); I intended to add more info, but it seems I forgot. The
section I removed during testing starts at line 476 (code beginning at
485), and in my specific use case, simply deleting the entire section (and
the singular reference to it at line 922) and adding \unfoldRepeats in the
MIDI \score resulted in output that seems to be as expected.

- Nikolai


On Fri, Jul 1, 2022 at 4:52 PM Mats Bengtsson 
wrote:

> I can't seem to find any implementation of unfoldRepeats in articulate.ly.
> I see that it plays a bit with unfolding, but not by redefining the default
> implementation, as far as I can see. Do you remember what you changed in
> articulate.ly?
>
>/Mats
> On 2022-07-01 16:42, Nikolai Hedler wrote:
>
> For what it's worth, I deleted the implementation of \unfoldRepeats from
> articulate.ly and found it caused no problems with my scores.
>
> - Nikolai
>
> On Fri, Jul 1, 2022, 10:12 Mats Bengtsson 
> wrote:
>
>>On 2022-06-29 23:28, Dan Eble wrote:
>>
>> On Jun 29, 2022, at 16:14, Jean Abou Samra [1] wrote:
>>
>> Le 28/06/2022 à 01:33, Nikolai Hedler a écrit :
>>
>>  MIDI ends late if |\fine| followed by a pitch.
>>
>> [2]https://gitlab.com/lilypond/lilypond/-/issues/6368
>>
>>
>>  Beaming and |\fine|
>>
>> [3]https://gitlab.com/lilypond/lilypond/-/issues/6369
>>
>>
>>  Multi-measure rests
>>
>> [4]https://gitlab.com/lilypond/lilypond/-/issues/6370
>> —
>> Dan
>>
>>Yet another flavor of the problem is that \fine doesn't play well with
>>\articulate (I know that \articulate only should be used on MIDI
>>output, but here we can visually see the problems that also are heard
>>in the MIDI):
>>
>>\version "2.23.10"
>>\include "articulate.ly"
>>\markup "Failing example using \fine"
>>test_segno = \relative c' {
>>c1 |
>>\repeat segno 2 {
>>e2 c \volta 2 \fine |
>>g'4 f e d | }
>>}
>>\new Staff \test_segno
>>\new Staff {<>^"\\unfoldRepeats" \unfoldRepeats \test_segno }
>>\new Staff {<>^"\\articulate \\unfoldRepeats" \articulate
>>\unfoldRepeats \test_segno }
>>\new Staff {<>^"\\articulate" \articulate \test_segno }
>>\markup "Successful example without \fine"
>>test_volta = \relative c' {
>>c1 |
>>\repeat segno 2 {
>>  e2 c |
>>  g'4 f e d |}
>>c1 |
>>}
>>\new Staff \test_volta
>>\new Staff {<>^"\\unfoldRepeats" \unfoldRepeats \test_volta }
>>\new Staff {<>^"\\articulate \\unfoldRepeats" \articulate
>>\unfoldRepeats \test_volta }
>>\new Staff {<>^"\\articulate" \articulate \test_volta }
>>   /Mats
>>
>> References
>>
>>1. mailto:j...@abou-samra.fr
>>2. https://gitlab.com/lilypond/lilypond/-/issues/6368
>>3. https://gitlab.com/lilypond/lilypond/-/issues/6369
>>4. https://gitlab.com/lilypond/lilypond/-/issues/6370
>> ___
>> bug-lilypond mailing list
>> bug-lilypond@gnu.org
>> https://lists.gnu.org/mailman/listinfo/bug-lilypond
>>
>
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: v2.23.8: \fine seems to break \midi

2022-07-01 Thread Mats Bengtsson
   I can't seem to find any implementation of unfoldRepeats in
   articulate.ly. I see that it plays a bit with unfolding, but not by
   redefining the default implementation, as far as I can see. Do you
   remember what you changed in articulate.ly?

  /Mats

   On 2022-07-01 16:42, Nikolai Hedler wrote:

   For what it's worth, I deleted the implementation of \unfoldRepeats
   from [1]articulate.ly and found it caused no problems with my scores.
   - Nikolai

   On Fri, Jul 1, 2022, 10:12 Mats Bengtsson <[2]matsboxergr...@gmail.com>
   wrote:

On 2022-06-29 23:28, Dan Eble wrote:
 On Jun 29, 2022, at 16:14, Jean Abou Samra
 [1]<[3]j...@abou-samra.fr> wrote:
 Le 28/06/2022 à 01:33, Nikolai Hedler a écrit :
  MIDI ends late if |\fine| followed by a pitch.
 [2][4]https://gitlab.com/lilypond/lilypond/-/issues/6368
  Beaming and |\fine|
 [3][5]https://gitlab.com/lilypond/lilypond/-/issues/6369
  Multi-measure rests
 [4][6]https://gitlab.com/lilypond/lilypond/-/issues/6370
 —
 Dan
Yet another flavor of the problem is that \fine doesn't play well
 with
\articulate (I know that \articulate only should be used on MIDI
output, but here we can visually see the problems that also are
 heard
in the MIDI):
\version "2.23.10"
\include "[7]articulate.ly"
\markup "Failing example using \fine"
test_segno = \relative c' {
c1 |
\repeat segno 2 {
e2 c \volta 2 \fine |
g'4 f e d | }
}
\new Staff \test_segno
\new Staff {<>^"\\unfoldRepeats" \unfoldRepeats \test_segno }
\new Staff {<>^"\\articulate \\unfoldRepeats" \articulate
\unfoldRepeats \test_segno }
\new Staff {<>^"\\articulate" \articulate \test_segno }
\markup "Successful example without \fine"
test_volta = \relative c' {
c1 |
\repeat segno 2 {
  e2 c |
  g'4 f e d |}
c1 |
}
\new Staff \test_volta
\new Staff {<>^"\\unfoldRepeats" \unfoldRepeats \test_volta }
\new Staff {<>^"\\articulate \\unfoldRepeats" \articulate
\unfoldRepeats \test_volta }
\new Staff {<>^"\\articulate" \articulate \test_volta }
   /Mats
 References
1. mailto:[8]j...@abou-samra.fr
2. [9]https://gitlab.com/lilypond/lilypond/-/issues/6368
3. [10]https://gitlab.com/lilypond/lilypond/-/issues/6369
4. [11]https://gitlab.com/lilypond/lilypond/-/issues/6370
 ___
 bug-lilypond mailing list
 [12]bug-lilypond@gnu.org
 [13]https://lists.gnu.org/mailman/listinfo/bug-lilypond

References

   1. http://articulate.ly/
   2. mailto:matsboxergr...@gmail.com
   3. mailto:j...@abou-samra.fr
   4. https://gitlab.com/lilypond/lilypond/-/issues/6368
   5. https://gitlab.com/lilypond/lilypond/-/issues/6369
   6. https://gitlab.com/lilypond/lilypond/-/issues/6370
   7. http://articulate.ly/
   8. mailto:j...@abou-samra.fr
   9. https://gitlab.com/lilypond/lilypond/-/issues/6368
  10. https://gitlab.com/lilypond/lilypond/-/issues/6369
  11. https://gitlab.com/lilypond/lilypond/-/issues/6370
  12. mailto:bug-lilypond@gnu.org
  13. https://lists.gnu.org/mailman/listinfo/bug-lilypond
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: v2.23.8: \fine seems to break \midi

2022-07-01 Thread Nikolai Hedler
For what it's worth, I deleted the implementation of \unfoldRepeats from
articulate.ly and found it caused no problems with my scores.

- Nikolai

On Fri, Jul 1, 2022, 10:12 Mats Bengtsson  wrote:

>On 2022-06-29 23:28, Dan Eble wrote:
>
> On Jun 29, 2022, at 16:14, Jean Abou Samra [1] wrote:
>
> Le 28/06/2022 à 01:33, Nikolai Hedler a écrit :
>
>  MIDI ends late if |\fine| followed by a pitch.
>
> [2]https://gitlab.com/lilypond/lilypond/-/issues/6368
>
>
>  Beaming and |\fine|
>
> [3]https://gitlab.com/lilypond/lilypond/-/issues/6369
>
>
>  Multi-measure rests
>
> [4]https://gitlab.com/lilypond/lilypond/-/issues/6370
> —
> Dan
>
>Yet another flavor of the problem is that \fine doesn't play well with
>\articulate (I know that \articulate only should be used on MIDI
>output, but here we can visually see the problems that also are heard
>in the MIDI):
>
>\version "2.23.10"
>\include "articulate.ly"
>\markup "Failing example using \fine"
>test_segno = \relative c' {
>c1 |
>\repeat segno 2 {
>e2 c \volta 2 \fine |
>g'4 f e d | }
>}
>\new Staff \test_segno
>\new Staff {<>^"\\unfoldRepeats" \unfoldRepeats \test_segno }
>\new Staff {<>^"\\articulate \\unfoldRepeats" \articulate
>\unfoldRepeats \test_segno }
>\new Staff {<>^"\\articulate" \articulate \test_segno }
>\markup "Successful example without \fine"
>test_volta = \relative c' {
>c1 |
>\repeat segno 2 {
>  e2 c |
>  g'4 f e d |}
>c1 |
>}
>\new Staff \test_volta
>\new Staff {<>^"\\unfoldRepeats" \unfoldRepeats \test_volta }
>\new Staff {<>^"\\articulate \\unfoldRepeats" \articulate
>\unfoldRepeats \test_volta }
>\new Staff {<>^"\\articulate" \articulate \test_volta }
>   /Mats
>
> References
>
>1. mailto:j...@abou-samra.fr
>2. https://gitlab.com/lilypond/lilypond/-/issues/6368
>3. https://gitlab.com/lilypond/lilypond/-/issues/6369
>4. https://gitlab.com/lilypond/lilypond/-/issues/6370
> ___
> bug-lilypond mailing list
> bug-lilypond@gnu.org
> https://lists.gnu.org/mailman/listinfo/bug-lilypond
>
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: v2.23.8: \fine seems to break \midi

2022-07-01 Thread Mats Bengtsson
   On 2022-06-29 23:28, Dan Eble wrote:

On Jun 29, 2022, at 16:14, Jean Abou Samra [1] wrote:

Le 28/06/2022 à 01:33, Nikolai Hedler a écrit :

 MIDI ends late if |\fine| followed by a pitch.

[2]https://gitlab.com/lilypond/lilypond/-/issues/6368


 Beaming and |\fine|

[3]https://gitlab.com/lilypond/lilypond/-/issues/6369


 Multi-measure rests

[4]https://gitlab.com/lilypond/lilypond/-/issues/6370
—
Dan

   Yet another flavor of the problem is that \fine doesn't play well with
   \articulate (I know that \articulate only should be used on MIDI
   output, but here we can visually see the problems that also are heard
   in the MIDI):

   \version "2.23.10"
   \include "articulate.ly"
   \markup "Failing example using \fine"
   test_segno = \relative c' {
   c1 |
   \repeat segno 2 {
   e2 c \volta 2 \fine |
   g'4 f e d | }
   }
   \new Staff \test_segno
   \new Staff {<>^"\\unfoldRepeats" \unfoldRepeats \test_segno }
   \new Staff {<>^"\\articulate \\unfoldRepeats" \articulate
   \unfoldRepeats \test_segno }
   \new Staff {<>^"\\articulate" \articulate \test_segno }
   \markup "Successful example without \fine"
   test_volta = \relative c' {
   c1 |
   \repeat segno 2 {
 e2 c |
 g'4 f e d |}
   c1 |
   }
   \new Staff \test_volta
   \new Staff {<>^"\\unfoldRepeats" \unfoldRepeats \test_volta }
   \new Staff {<>^"\\articulate \\unfoldRepeats" \articulate
   \unfoldRepeats \test_volta }
   \new Staff {<>^"\\articulate" \articulate \test_volta }
  /Mats

References

   1. mailto:j...@abou-samra.fr
   2. https://gitlab.com/lilypond/lilypond/-/issues/6368
   3. https://gitlab.com/lilypond/lilypond/-/issues/6369
   4. https://gitlab.com/lilypond/lilypond/-/issues/6370
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: v2.23.8: \fine seems to break \midi

2022-06-29 Thread Dan Eble
On Jun 29, 2022, at 16:14, Jean Abou Samra  wrote:
> 
> Le 28/06/2022 à 01:33, Nikolai Hedler a écrit :
>> 
>>  MIDI ends late if |\fine| followed by a pitch.

https://gitlab.com/lilypond/lilypond/-/issues/6368

>>  Beaming and |\fine|

https://gitlab.com/lilypond/lilypond/-/issues/6369

>>  Multi-measure rests

https://gitlab.com/lilypond/lilypond/-/issues/6370
— 
Dan


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: v2.23.8: \fine seems to break \midi

2022-06-29 Thread Jean Abou Samra

Le 28/06/2022 à 01:33, Nikolai Hedler a écrit :


Copied from my comment on GitLab:

It seems that the programming error re: dynamics actually obscured 
some other problems I encountered in my project. I had assumed that 
there was only one fault at play here, but there's more to it than I 
thought.



  MIDI ends late if |\fine| followed by a pitch.

|\version "2.23.10" \score { \unfoldRepeats \repeat segno 2 { c'1 
\volta 2 \fine 2 2 } \layout { } \midi { } }|


This produces correct sheet music but the MIDI file contains 4 notes 
(ending one note /after/ the |\fine|). No errors are logged. Changing 
the second bar from 2 2 to r1 causes the MIDI output to behave as 
expected, ending after the 2nd C without an extraneous rest.



  Beaming and |\fine|

There's something funky going on with beaming: changing the 2nd bar 
from 2 2 to 8[ 8] 4 2 returns a couple of errors, but claims to 
compile successfully and returns expected sheet music. Again, the MIDI 
output erroneously includes the first note after the |\fine| on the 
2nd repeat.


Log here:
|Processing `[redacted]/document.ly ' Parsing... 
Interpreting music... [redacted]/document.ly:5:6: warning: 
unterminated beam c'8 [ 8] 4 2 Preprocessing graphical objects... 
[redacted]/document.ly:5:3: programming error: cyclic dependency: 
calculation-in-progress encountered for Stem.direction c'8[ 8] 4 2 
[redacted]/document.ly:5:3: continuing, cross fingers 
[redacted]/document.ly:5:3: warning: direction of grob Stem must be UP 
or DOWN; using UP c'8[ 8] 4 2 Interpreting music... MIDI output to 
`document.mid'... Finding the ideal number of pages... Fitting music 
on 1 page... Drawing systems... Converting to `document.pdf'... 
Success: compilation successfully completed|



  Multi-measure rests

This one is very strange.

|\version "2.23.10" \score { \unfoldRepeats \repeat segno 2 { c'1 
\volta 2 \fine R1 } \layout { } \midi { } }|


Errors in the log during MIDI processing, but the output seems correct 
(MIDI file ends after |\fine| instead of including extraneous rest).


Log here:
|Parsing... Interpreting music... Preprocessing graphical objects... 
programming error: Multi measure rest seems misplaced. continuing, 
cross fingers programming error: Object is not a markup. continuing, 
cross fingers programming error: Multi measure rest seems misplaced. 
continuing, cross fingers Interpreting music... MIDI output to 
`document.mid'... Finding the ideal number of pages... Fitting music 
on 1 page... Drawing systems... Converting to `document.pdf'... This 
object should be a markup: () Success: compilation successfully completed|

- Nikolai



Dan, would you mind triaging this one? I don't know if it should be one 
or several issues given that all the problems appear to relate to the 
same root cause. My guess is that the final timestep where finalize is 
called, which normally happens at the final moment and sees no events, 
is happening at the final moments and sees the events that would have 
happened at that moment if \fine hadn't been there. We probably need to 
stop events from being listened at the final timestep triggered by \fine.


Jean


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: v2.23.8: \fine seems to break \midi

2022-06-27 Thread Nikolai Hedler
Copied from my comment on GitLab:

It seems that the programming error re: dynamics actually obscured some
other problems I encountered in my project. I had assumed that there was
only one fault at play here, but there's more to it than I thought.
MIDI ends late if \fine followed by a pitch.

\version "2.23.10"\score {  \unfoldRepeats  \repeat segno 2 {c'1
\volta 2 \fine2 2  }  \layout { }  \midi { }}

This produces correct sheet music but the MIDI file contains 4 notes
(ending one note *after* the \fine). No errors are logged. Changing the
second bar from 2 2 to r1 causes the MIDI output to behave as expected,
ending after the 2nd C without an extraneous rest.
Beaming and \fine

There's something funky going on with beaming: changing the 2nd bar from 2 2 to
8[ 8] 4 2 returns a couple of errors, but claims to compile successfully
and returns expected sheet music. Again, the MIDI output erroneously
includes the first note after the \fine on the 2nd repeat.
Log here:

Processing `[redacted]/document.ly'Parsing...Interpreting
music...[redacted]/document.ly:5:6: warning: unterminated beam  c'8
 [ 8] 4 2Preprocessing graphical objects...[redacted]/document.ly:5:3:
programming error: cyclic dependency: calculation-in-progress
encountered for Stem.directionc'8[ 8] 4
2[redacted]/document.ly:5:3: continuing, cross
fingers[redacted]/document.ly:5:3: warning: direction of grob Stem
must be UP or DOWN; using UPc'8[ 8] 4 2Interpreting music...MIDI
output to `document.mid'...Finding the ideal number of pages...Fitting
music on 1 page...Drawing systems...Converting to
`document.pdf'...Success: compilation successfully completed

Multi-measure rests

This one is very strange.

\version "2.23.10"\score {  \unfoldRepeats  \repeat segno 2 {c'1
\volta 2 \fineR1  }  \layout { }  \midi { }}

Errors in the log during MIDI processing, but the output seems correct
(MIDI file ends after \fine instead of including extraneous rest).

Log here:

Parsing...Interpreting music...Preprocessing graphical
objects...programming error: Multi measure rest seems
misplaced.continuing, cross fingersprogramming error: Object is not a
markup.continuing, cross fingersprogramming error: Multi measure rest
seems misplaced.continuing, cross fingersInterpreting music...MIDI
output to `document.mid'...Finding the ideal number of pages...Fitting
music on 1 page...Drawing systems...Converting to
`document.pdf'...This object should be a markup: ()Success:
compilation successfully completed

- Nikolai

On Tue, May 17, 2022 at 4:38 AM Jean Abou Samra  wrote:

>
>
> Le 09/05/2022 à 20:11, Nikolai Hedler a écrit :
> > Windows 10, 64-bit
> >
> > I discovered the new \fine feature and looked to implement it in a
> project
> > of mine, and I believe I've discovered a bug in its interaction with
> \midi
> > blocks. The following appears to be a minimal example which produces the
> > error for me:
> >
> > \version "2.23.8"
> > \score {
> >\unfoldRepeats
> >\relative f' {
> >  \repeat segno 2 {
> >c1 \volta 2 \fine
> >c
> >  }
> >}
> >\midi { }
> > }
> >
> > The expected result is 3 notes played, but it inexplicably produces 4.
> The
> > log includes the following inscrutable error in duplicate:
> >
> > programming error: asked to compute volume at +3.00 for dynamic span
> of
> > duration 3.00 starting at 0
> > continuing, cross fingers
> >
> > Not sure what other info may be helpful.
>
> Thanks, opened
>
> https://gitlab.com/lilypond/lilypond/-/issues/6345
>
> Best,
> Jean
>
>
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: v2.23.8: \fine seems to break \midi

2022-05-17 Thread Jean Abou Samra



Le 09/05/2022 à 20:11, Nikolai Hedler a écrit :

Windows 10, 64-bit

I discovered the new \fine feature and looked to implement it in a project
of mine, and I believe I've discovered a bug in its interaction with \midi
blocks. The following appears to be a minimal example which produces the
error for me:

\version "2.23.8"
\score {
   \unfoldRepeats
   \relative f' {
 \repeat segno 2 {
   c1 \volta 2 \fine
   c
 }
   }
   \midi { }
}

The expected result is 3 notes played, but it inexplicably produces 4. The
log includes the following inscrutable error in duplicate:

programming error: asked to compute volume at +3.00 for dynamic span of
duration 3.00 starting at 0
continuing, cross fingers

Not sure what other info may be helpful.


Thanks, opened

https://gitlab.com/lilypond/lilypond/-/issues/6345

Best,
Jean


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


v2.23.8: \fine seems to break \midi

2022-05-09 Thread Nikolai Hedler
Windows 10, 64-bit

I discovered the new \fine feature and looked to implement it in a project
of mine, and I believe I've discovered a bug in its interaction with \midi
blocks. The following appears to be a minimal example which produces the
error for me:

\version "2.23.8"
\score {
  \unfoldRepeats
  \relative f' {
\repeat segno 2 {
  c1 \volta 2 \fine
  c
}
  }
  \midi { }
}

The expected result is 3 notes played, but it inexplicably produces 4. The
log includes the following inscrutable error in duplicate:

programming error: asked to compute volume at +3.00 for dynamic span of
duration 3.00 starting at 0
continuing, cross fingers

Not sure what other info may be helpful.

- Nikolai
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond