Re: Test harness on VMS, running 489 tests, 141 tests failing.

2014-03-20 Thread John E. Malmberg
A bug in having the test harness compare_output that was supposed to 
compensate for VMS differences in output caused a number of tests to 
report success that actually failed.


Running with out -keep, so do not have an exact count of logs.

Current status: 136 Tests in 54 Categories Failed.

Known issues so far:

features/archives:  fail - 3/10 pass.
   Ticket 41758 - VMS archive support incomplete.

features/override: with patch - pass 4/4.

features/parallism: fail - 3/9 pass, 1 skipped.
   VMS not running jobs in parallel so output in wrong order.

features/recursion: fail - 1/2 pass.
   Looks like it is expecting environment variables to
   pass information to a child, and child is not getting
   them.

features/reinvoke: fail - 4/5 pass.
   One run is not interpreting a macro properly.

features/se_explicit: fail 9/10 pass
   $(addsuffix ) and $(addprefix ) expect space delimited
   arguments.  On VMS commas are used.  Not sure how that
   can be reconciled.

features/vpath3: Skipping.
   Test requires .LIBPATTERNS, which does not appear
   to be implemented on VMS, yet the variables/LIBPATTERNS
   tests are passing.

features/vpathgpath: fail - 0/1 pass
   gpaths not followed on VMS.  Reason why not obvious.

Still working my way triaging the other issues.

Regards,
-John




___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make


Re: [bug #41813] Mult-line override define failing on VMS.

2014-03-20 Thread h.becker
On 03/20/2014 11:32 PM, John E. Malmberg wrote:
>> The broken ECHO is one reason I flagged the fix "temporary". It seems,
>> there should be a builtin_echo for VMS.  Shouldn't be too hard, but I
>> haven't looked at it. That way some old VMS makefile which make use of
>> ECHO will continue to work. The question is, whether one would want to
>> support DCL symbols within the to be echoed text.
> 
> Another question is how much of the Unix environment should be simulated
> when running Gnu make from DCL?

In my local copy of the sources, I changed the ECHO variable defined in
default.c to builtin_echo, which I implemented in vmsjobs.c as a simple
wrapper for write sys$output. That way, whatever worked for VMS/DCL
users with $(ECHO) will work, even with multilines.

OK there are a few exceptions. If someone knew that there was a missing
double quote and coded $(ECHO) hello" the old output was hello and the
new output will be hello". Also, if someone wanted to use DCL
symbols/lexcials and knew that $(ECHO) "+f$$time() would get the wanted
result, the new code will give a %DCL-W-EXPSYN and the code has to
change to $(ECHO) "+f$$time()+ to get the wanted result.

I don't know of anything of a Unix environment which should be
simulated, here. But obviously there is no parity. In Unix you can have
a shell variable in the to be echoed text and - if defined - it will
show. As I showed in the above example, it's not that intuitive/easy for
VMS/DCL symbols.

___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make


Re: Test harness on VMS, running 511 tests, 60 tests failing.

2014-03-20 Thread John E. Malmberg

On 3/16/2014 11:27 PM, Paul Smith wrote:

On Sun, 2014-03-16 at 21:43 -0500, John E. Malmberg wrote:

With that correction, I am back to 60 tests failing in 29 categories
failing if I use the -keep option.


You should never use -keep when invoking the full test suite.


I understand that.  The -keep option is the easiest way to get a count 
of how many tests are actually getting run.


Regards,
-John



___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make


Re: [bug #41813] Mult-line override define failing on VMS.

2014-03-20 Thread John E. Malmberg

On 3/18/2014 11:30 AM, h.becker wrote:

On 03/17/2014 11:34 PM, John E. Malmberg wrote:

On 3/16/2014 4:13 PM, h.becker wrote:

Appended is a temporary fix for the multiline problem.


The fix appears to work.

I think your comment about it breaking the echo being defined as
sys$output is wrong though.  I tested it with no echo symbol and with
echo as a symbol and it generates the expected output now in both cases.


It seems you aren't using plain VMS, which has no echo command nor echo
symbol. I'm talking about the make variable ECHO as defined for VMS in:


The test works as long as echo is a foreign command because no macro 
substition is done.


Because of a bug in my copy of the test harness, I was not seeing the 
errors about undefined symbols.



The broken ECHO is one reason I flagged the fix "temporary". It seems,
there should be a builtin_echo for VMS.  Shouldn't be too hard, but I
haven't looked at it. That way some old VMS makefile which make use of
ECHO will continue to work. The question is, whether one would want to
support DCL symbols within the to be echoed text.


Another question is how much of the Unix environment should be simulated 
when running Gnu make from DCL?


Regards,
-John



___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make