[bug #58529] MAKEOVERRIDES does not change the origin

2020-06-07 Thread Masahiro Yamada 
Follow-up Comment #1, bug #58529 (project make):

MAKEOVERRIDES += FOO=overridden-value

in the test code is:

MAKEOVERRIDES += FOO=y


___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #58529] MAKEOVERRIDES does not change the origin

2020-06-07 Thread Masahiro Yamada 
URL:
  

 Summary: MAKEOVERRIDES does not change the origin
 Project: make
Submitted by: masahiroy
Submitted on: Mon 08 Jun 2020 04:56:27 AM UTC
Severity: 3 - Normal
  Item Group: None
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
   Component Version: None
Operating System: None
   Fixed Release: None
   Triage Status: None

___

Details:

MAKEOVERRIDES += FOO=y

correctly overrides the value of FOO in
the recursive invocations, but
$(origin FOO) still returns 'command line'.



(test code)--
MAKEOVERRIDES += FOO=overridden-value

all:
@$(MAKE) sub-make

sub-make:
@echo FOO is $(FOO)
@echo origin of FOO is $(origin FOO)
(test code end)--


$ make FOO=x
make[1]: Entering directory '/home/masahiro/workspace/test/'
FOO is y
origin of FOO is command line
make[1]: Leaving directory '/home/masahiro/workspace/test/'


I think $(origin FOO) should return 'override' in this case.





___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #58497] inconsistent newline removal in $(file <)

2020-06-07 Thread Dmitry Goncharov 
Follow-up Comment #2, bug #58497 (project make):

However, i'd like to be able to reproduce realloc returning a smaller
address.
Ken, do you have a makefile which reproduces this?

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #58497] inconsistent newline removal in $(file <)

2020-06-07 Thread Dmitry Goncharov 
Follow-up Comment #1, bug #58497 (project make):

Attached another fix along with new tests.

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #58497] inconsistent newline removal in $(file <)

2020-06-07 Thread Dmitry Goncharov 
Additional Item Attachment, bug #58497 (project make):

File name: sv_58497_fix_function_file.diff Size:0 KB
   


File name: sv_58497_fix_function_file_tests.diff Size:2 KB
   




___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/