[bug #60699] Avoid calling strlen repeatedly in a loop.

2021-05-30 Thread Dmitry Goncharov 
Follow-up Comment #2, bug #60699 (project make):

Sure, here is a unified diff.

Rather than attaching diffs, we could submit git branches for review. What do
you think?

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #60699] Avoid calling strlen repeatedly in a loop.

2021-05-30 Thread Dmitry Goncharov 
Additional Item Attachment, bug #60699 (project make):

File name: sv60699_fix.diff   Size:1 KB




___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #60699] Avoid calling strlen repeatedly in a loop.

2021-05-30 Thread Paul D. Smith 
Follow-up Comment #1, bug #60699 (project make):

Sorry I messed up; please use the '-u' option when creating diffs but don't
use the '-b' option.  Can you re-attach as diffs without -u are not very
helpful.

Sorry for the dumb mistake! :(

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #60659] Incorrect 2nd expansion of $$< inside a function in the prerequisite list.

2021-05-30 Thread Paul D. Smith 
Follow-up Comment #4, bug #60659 (project make):

Sorry, I messed up.  You should definitely use '-u' when creating diffs... I
meant, please do not use '-b' when creating diffs!

That was dumb.  Sorry :(.

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

Re: shell assignment operator documentation missing 'not'

2021-05-30 Thread Paul Smith 
On Tue, 2021-05-25 at 10:33 +, Ronald Hoogenboom wrote:
> In the info file documenting the shell assignment operator in section
> 3.7 "reading makefiles", there is the phrase:
> 
> "...that variable becomes a simple variable (and will thus be re-
> evaluated on each reference)." 
> 
> A simple variable is NOT re-evaluated on each reference, so the word
> "not" is missing in the parenthesized part.

Actually, it's correct to not have the "not" there: the problem is that
the variable is a recursive variable not a simple variable.

If it were a simple variable then the two assignments ":=" and "!="
would be identical in behavior.

Thanks for pointing out this error in the documentation!