Re: Report 3 UBSan integer overflow bugs found by an automatic fuzzer

[Paul Smith]

On Wed, 2021-06-30 at 17:34 +, He  Jingxuan wrote:
> We tested GNU make with an automatic tool (based on the fuzzer AFL).
> A number of test cases triggering UBSan integer overflow errors were
> generated. We manually checked those test cases and filtered out
> benign cases. Finally, we identified and report 3 cases that could
> trigger bugs. Below is the information for reproducing the bugs.

I made changes to resolve these issues.  Thanks!

[bug #61069] Document phony order-only prerequisites.

[Paul D. Smith]

Update of bug #61069 (project make):

  Status:None => Fixed  
 Assigned to:None => psmith 
 Open/Closed:Open => Closed 
Operating System:None => Any
   Fixed Release:None => SCM
   Triage Status:None => Small Effort   

___

Follow-up Comment #1:

I applied an update to the documentation but with different wording.  Thanks
for noting this!

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

Re: GNU make man page typo

[Paul Smith]

On Thu, 2021-09-02 at 20:37 +, John Marshall wrote:
> On 2 Sep 2021, at 06:40, Zach Petch wrote:
> > The second paragraph under DESCRIPTION reads,
> > 
> > > To prepare to use make, you must write a file called the makefile
> > that describes the relationships among files in your program, and
> > the states the commands for updating each file.
> 
> The same text was previously in make.texi but was updated (rather
> astonishingly) 30 years ago in 45fa41f:
> 
>  To prepare to use @code{make}, you must write a file called
>  the @dfn{makefile} that describes the relationships among files
> -in your program, and the states the commands for updating each file.
> +in your program and provides commands for updating each file.

I've applied this change to the man page, thanks!

[bug #60659] Incorrect 2nd expansion of $$< inside a function in the prerequisite list.

[Paul D. Smith]

Update of bug #60659 (project make):

  Status:None => Fixed  
 Assigned to:None => psmith 
 Open/Closed:Open => Closed 
Operating System:None => Any
   Fixed Release:None => SCM
   Triage Status:None => Small Effort   

___

Follow-up Comment #5:

Thanks, pushed to Git.

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #60297] optimize autodeps

[Paul D. Smith]

Update of bug #60297 (project make):

  Status:None => Fixed  
 Assigned to:None => psmith 
 Open/Closed:Open => Closed 
Operating System:None => Any
   Fixed Release:None => SCM
   Triage Status:None => Small Effort   

___

Follow-up Comment #19:

Thanks, applied this to Git.


___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #58341] MAKEFLAGS in the makefile contains only simple options

[Paul D. Smith]

Update of bug #58341 (project make):

  Status:None => Fixed  
 Assigned to:None => psmith 
 Open/Closed:Open => Closed 
Operating System:None => Any
   Fixed Release:None => SCM
   Triage Status:None => Medium Effort  

___

Follow-up Comment #2:

I've pushed a fix for this to Git.  It will be available in the next release
of GNU make.

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #60699] Avoid calling strlen repeatedly in a loop.

[Paul D. Smith]

Update of bug #60699 (project make):

  Status:None => Fixed  
 Assigned to:None => psmith 
 Open/Closed:Open => Closed 
Operating System:None => Any
   Fixed Release:None => SCM
   Triage Status:None => Small Effort   

___

Follow-up Comment #3:

Thanks, applied.

We should discuss how to manage patches on the mailing lists rather than here.
 Using git branches in Savannah isn't so great for me because there's no code
review feature.  It's actually simpler to have a discussion / patch review on
the mailing lists than using git branches directly.

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #60412] Avoid default include directories when searching for included files.

[Paul D. Smith]

Update of bug #60412 (project make):

  Status:None => Fixed  
 Assigned to:None => psmith 
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

This was fixed by providing two enhancements:

First, it's now possible to add a "-I-" option to the command line.  If this
is done then make forgets about any include file search directories that
precede this option (including the default ones).

Second, changes to the MAKEFLAGS variable inside the makefile are now parsed
immediately when that variable is modified rather than only after all
makefiles are read in.

So, it is now possible to say:

  make -I-

to remove all default search directories, and also to add:

  MAKEFLAGS += -I-

to remove all default search directories from within the makefile.

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #60595] make doesn't always restart when a makefile is rebuilt

[Paul D. Smith]

Update of bug #60595 (project make):

  Status:None => Fixed  
 Assigned to:None => psmith 
 Open/Closed:Open => Closed 
   Fixed Release:None => SCM
   Triage Status:None => Medium Effort  

___

Follow-up Comment #8:

This fix has been pushed to Git.  Thanks!

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/