[bug #16788] 'ORDINARY_MTIME_MAX' macro causes integral constant overflow

[Paul D. Smith]

Follow-up Comment #5, bug #16788 (project make):

I always do my compilation on Windows using straight MSVC.  I don't have any
cygwin or mingw compiler installed there.  I don't own a license for Windows
so I use the developer download to run it in a VM; this expires every 90 days
so I only do the most minimal setup on it and the developer VM comes with MSVC
pre-installed.

Admittedly it's the newest version of MSVC; maybe an older version would throw
a warning.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #16788] 'ORDINARY_MTIME_MAX' macro causes integral constant overflow

[Eli Zaretskii]

Follow-up Comment #4, bug #16788 (project make):

With what compiler? The original warning seems to be from MSVC or maybe
something else, but not from GCC.



___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #16788] 'ORDINARY_MTIME_MAX' macro causes integral constant overflow

[Paul D. Smith]

Update of bug #16788 (project make):

  Status:None => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #3:

I don't see any warnings in the current builds on Windows, so I guess this was
resolved?


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #16788] 'ORDINARY_MTIME_MAX' macro causes integral constant overflow

[anonymous]

URL:
  http://savannah.gnu.org/bugs/?func=detailitemitem_id=16788

 Summary: 'ORDINARY_MTIME_MAX' macro causes integral constant
overflow
 Project: make
Submitted by: None
Submitted on: Thursday 06/08/06 at 19:09 UTC
Severity: 3 - Normal
  Item Group: Enhancement
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
   Component Version: 3.81
Operating System: MS Windows
   Fixed Release: None

___

Details:

Abstract: The macro causes a compiler warning.  Workaround: rearrange the
additions.  The details are attached in XML below.

bug-report
behaviour
location path=make-3.81/file.c line=775
FILE_TIMESTAMP_S (ORDINARY_MTIME_MAX)
/location
output
warning C4307: '+' : integral constant overflow
/output
/behaviour
reason
The warning is caused by the addition (FILE_TIMESTAMP_S (NEW_MTIME) lt;lt;
FILE_TIMESTAMP_LO_BITS) + ORDINARY_MTIME_MIN + FILE_TIMESTAMPS_PER_S
/reason
remedy
location path=make-3.81/filedef.h line=188
#define ORDINARY_MTIME_MAX ((FILE_TIMESTAMP_S (NEW_MTIME) \
 lt;lt; FILE_TIMESTAMP_LO_BITS) \
+ ORDINARY_MTIME_MIN - 1 + FILE_TIMESTAMPS_PER_S)
/location
/remedy
/bug-report






___

Reply to this item at:

  http://savannah.gnu.org/bugs/?func=detailitemitem_id=16788

___
  Message sent via/by Savannah
  http://savannah.gnu.org/



___
Bug-make mailing list
Bug-make@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-make