[bug #17381] Compile errors under DJGPP

[Paul D. Smith]

Update of bug #17381 (project make):

  Status:None => Fixed  
   Fixed Release:None => CVS


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
Bug-make mailing list
Bug-make@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-make

[bug #17381] Compile errors under DJGPP

[Eli Zaretskii]

Update of bug #17381 (project make):

 Open/Closed:Open => Closed 
Operating System:  MS Windows => MS-DOS 

___

Follow-up Comment #3:

The MS-DOS build does not call child_execute_job at all.  In Make 3.81, the
definition of the function was mistakenly conditioned on __MSDOS__ as well. 
Now it is only defined on other systems.  So this patch is not needed.

I'm closing this report.


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
Bug-make mailing list
Bug-make@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-make

[bug #17381] Compile errors under DJGPP

[Paul D. Smith]

Update of bug #17381 (project make):

 Assigned to:None => eliz   

___

Follow-up Comment #2:

Eli: I don't see this patch in the current CVS version.  Is this still
needed?

Thanks!

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
Bug-make mailing list
Bug-make@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-make

Re: [bug #17381] Compile errors under DJGPP

[Eli Zaretskii]

> Date: Tue,  8 Aug 2006 23:03:15 +
> From: anonymous <[EMAIL PROTECTED]>
> Cc: 
> 
> job.c:1898: error: conflicting types for 'child_execute_job'
> job.h:79: error: previous declaration of 'child_execute_job' was here
> job.c: In function 'child_execute_job':
> job.c:1931: error: void value not ignored as it ought to be

Thanks.

Here's a patch to fix this:

2006-08-12  Eli Zaretskii  <[EMAIL PROTECTED]>

* job.h [__MSDOS__]: Use the same prototype for child_execute_job
as __EMX__ does.


--- job.h~0 2006-02-12 02:16:04.0 +0200
+++ job.h   2006-08-12 15:44:06.87500 +0300
@@ -73,7 +73,7 @@
 extern char **construct_command_argv PARAMS ((char *line, char **restp, struct 
file *file, char** batch_file));
 #ifdef VMS
 extern int child_execute_job PARAMS ((char *argv, struct child *child));
-#elif defined(__EMX__)
+#elif defined(__MSDOS__) || defined(__EMX__)
 extern int child_execute_job PARAMS ((int stdin_fd, int stdout_fd, char 
**argv, char **envp));
 #else
 extern void child_execute_job PARAMS ((int stdin_fd, int stdout_fd, char 
**argv, char **envp));


___
Bug-make mailing list
Bug-make@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-make

[bug #17381] Compile errors under DJGPP

[Eli Zaretskii]

Follow-up Comment #1, bug #17381 (project make):

The following patch should take care of this:

2006-08-12  Eli Zaretskii  <[EMAIL PROTECTED]>

* job.h [__MSDOS__]: Use the same prototype for child_execute_job as 
__EMX__
does.


--- job.h~0 2006-02-12 02:16:04.0 +0200
+++ job.h   2006-08-12 15:44:06.87500 +0300
@@ -73,7 +73,7 @@
 extern char **construct_command_argv PARAMS ((char *line, char **restp,
struct file *file, char** batch_file));
 #ifdef VMS
 extern int child_execute_job PARAMS ((char *argv, struct child *child));
-#elif defined(__EMX__)
+#elif defined(__MSDOS__) || defined(__EMX__)
 extern int child_execute_job PARAMS ((int stdin_fd, int stdout_fd, char
**argv, char **envp));
 #else
 extern void child_execute_job PARAMS ((int stdin_fd, int stdout_fd, char
**argv, char **envp));


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/



___
Bug-make mailing list
Bug-make@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-make

[bug #17381] Compile errors under DJGPP

[anonymous]

URL:
  

 Summary: Compile errors under DJGPP
 Project: make
Submitted by: None
Submitted on: Tuesday 08/08/06 at 23:03 UTC
Severity: 3 - Normal
  Item Group: Build/Install
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
   Component Version: 3.81
Operating System: MS Windows
   Fixed Release: None

___

Details:

Having run sh ./configure the makefile is produced successfully.
However, executing make results in the following error:

job.c:1898: error: conflicting types for 'child_execute_job'
job.h:79: error: previous declaration of 'child_execute_job' was here
job.c: In function 'child_execute_job':
job.c:1931: error: void value not ignored as it ought to be

Entire log attached as text file.

Notably, using exactly the same procedure the v3.80 compiles... but then
again there are extra #ifdef conditions in v3.81.





___

File Attachments:


---
Date: Tuesday 08/08/06 at 23:03 UTC  Name: log.txt  Size: 1.55KB   By: None
Make log


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/



___
Bug-make mailing list
Bug-make@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-make