[bug #50372] gmk_floc missing offset member

[anonymous]

URL:
  

 Summary: gmk_floc missing offset member
 Project: make
Submitted by: None
Submitted on: Tue 21 Feb 2017 07:18:21 PM UTC
Severity: 3 - Normal
  Item Group: Bug
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
   Component Version: SCM
Operating System: Any
   Fixed Release: None
   Triage Status: None

___

Details:

The definition of the gmk_floc struct is not consistent with the floc struct
used in calling the dynamic objects' initialization function.

The attached patch corrects the gmk_floc definition. It also includes
suggested changes to the documentation.

This fix does not resolve violation of C strict aliasing rules. For this we
would need to use the same floc struct.




___

File Attachments:


---
Date: Tue 21 Feb 2017 07:18:21 PM UTC  Name: gnumake-gmk-floc-fix.patch  Size:
3kB   By: None
Patch to current git repository version.


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make

[bug #50372] gmk_floc missing offset member

[Paul D. Smith]

Follow-up Comment #1, bug #50372 (project make):

The offset field is not really needed by the load setup function.  It only has
a value inside a recipe: lineno is the line number of the start of the rule,
and offset is the number of lines into the recipe.  Since load operations
don't appear within recipes this offset value will be zero anyway.

I suppose that it's possible that a load directive could be invoked from
within an eval function in a recipe.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

Re: [bug #50372] gmk_floc missing offset member

[Brian Vandenberg]

Originally there was only one struct that didn't have an offset member.  I
submitted a patch that added offset and made various code changes to ensure
its use so warnings/error messages could correctly calculate the line
number.

Although I didn't like that "offset" was left out of the public-facing API,
there was a legitimate need: it would've forced a backward incompatibility
when shared libraries or windows DLLs using the old API were used.

To account for this it was proposed that a 2nd "internal" type be made that
has offset, while the public API version of the type remained the same.

-brian
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make