[bug #57778] Stop looking for an included file once found, even if cannot be opened.

[Paul D. Smith]

Update of bug #57778 (project make):

  Status:None => Fixed  
 Assigned to:None => psmith 
 Open/Closed:Open => Closed 
Operating System:None => Any
   Fixed Release:None => SCM
   Triage Status:None => Small Effort   

___

Follow-up Comment #2:

I've applied this fix, lightly edited for other changes since the patch was
created.

Thanks!

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #57778] Stop looking for an included file once found, even if cannot be opened.

[Dmitry Goncharov]

URL:
  

 Summary: Stop looking for an included file once found, even
if cannot be opened.
 Project: make
Submitted by: dgoncharov
Submitted on: Sun 09 Feb 2020 05:07:07 PM UTC
Severity: 3 - Normal
  Item Group: None
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
   Component Version: None
Operating System: None
   Fixed Release: None
   Triage Status: None

___

Details:

Good morning. 
  
  
  
  
  
Stop looking for an included file once found, even if cannot be opened.   
  
  
  
  
  
If the current directory contains a not readable file and an additional
include directory contains a readable file the current file is silently
ignored and the file from the additional include directory is silently
included.
This can come as an unpleasant surprise and is hardly useful.
This behavior contradicts gnu make manual and usual practice in similar
situations.

Gnu make manual explicitly states that lookup continues only if the file is
missing.
Gnu make itself stops looking for a prerequisite file in vpath directories,
once it found one, even if cannot be opened.
Gnu make stops looking for an included file once it found one and the found
one turns out to be corrupt or a directory.
Similarly a compiler stops looking for a header once it found one, even if
cannot be opened.


The change from rmfiles to unlink in features/included is needed to have the
test pass when -keep is specified.

regards, Dmitry




___

File Attachments:


---
Date: Sun 09 Feb 2020 05:07:07 PM UTC  Name: stop_lookup_for_included.diff 
Size: 5KiB   By: dgoncharov



___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/