[bug #63047] --shuffle mode does not work on .SECONDEXPANSION targets

2022-09-12 Thread Paul D. Smith 
Update of bug #63047 (project make):

  Item Group:None => Bug
  Status:None => Fixed  
 Open/Closed:Open => Closed 
   Component Version:None => SCM
Operating System:None => Any
   Fixed Release:None => SCM
   Triage Status:None => Small Effort   

___

Follow-up Comment #2:

Applied; thanks Sergei!


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #63047] --shuffle mode does not work on .SECONDEXPANSION targets

2022-09-11 Thread Sergei Trofimovich 
Follow-up Comment #1, bug #63047 (project make):

Posted the patch for review as
https://lists.gnu.org/archive/html/bug-make/2022-09/msg00069.html


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #63047] --shuffle mode does not work on .SECONDEXPANSION targets

2022-09-11 Thread Sergei Trofimovich 
Additional Item Attachment, bug #63047 (project make):

File name: 0001-Fix-shuffle-for-SECONDEXPANSION-prerequisites.patch Size:3 KB
   




___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #63047] --shuffle mode does not work on .SECONDEXPANSION targets

2022-09-11 Thread Sergei Trofimovich 
URL:
  

 Summary: --shuffle mode does not work on .SECONDEXPANSION
targets
 Project: make
   Submitter: slyfox
   Submitted: Sun 11 Sep 2022 08:13:12 PM UTC
Severity: 3 - Normal
  Item Group: None
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
   Component Version: None
Operating System: None
   Fixed Release: None
   Triage Status: None


___

Follow-up Comments:


---
Date: Sun 11 Sep 2022 08:13:12 PM UTC By: Sergei Trofimovich 
Since commit 07eea3aa496184bb763b7306e9de6a40a94605c9 ("[SV 62706] Only
second-expand targets that might be built") `make --shuffle` stopped shuffling
.SECONDEXPANSION. Example `Makefile`:

.SECONDEXPANSION:
all: $$(var)
%_: ; @echo $@
var = a_ b_ c_

Before (good):

$ make --shuffle=reverse
c_
b_
a_

After (bad):

$ ./make --shuffle=reverse
a_
b_
c_


I'll send a possible fix today.







___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/