Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-23 Thread Tim Rühsen 
Am Montag, 22. Juli 2013, 23:13:17 schrieb Darshit Shah:


This patch seems to break for normal builds. 

I get the following error on running make:


configure: error: conditional HAVE_NETTLE was never defined.
Usually this means the macro was only invoked conditionally. 
make: *** [config.status] Error 1


After
AC_CHECK_LIB(nettle, ...
the variable $HAVE_NETTE should/must be defined.

The above error puzzles me.
Did you do an 'autoreconf' after you locally applied the commit ?
Could someone explain that error to me ?

Regards, Tim



signature.asc
Description: This is a digitally signed message part.

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-23 Thread Tim Rühsen 
Am Dienstag, 23. Juli 2013, 13:43:13 schrieb Giuseppe Scrivano:
 Tim Rühsen tim.rueh...@gmx.de writes:
  The above error puzzles me.
  
  Did you do an 'autoreconf' after you locally applied the commit ?
  
  Could someone explain that error to me ?
 
 I think you can reproduce it when you try to build with openssl instead
 of gnutls.
 
 What do you get when you use ./configure --with-ssl=openssl?
 
 Moving the AM_CONDITIONAL line seems to fix it.

You changed my original patch in a way, that you won't need AM_CONDITIONAL any 
more. Try commenting it out - it should work.

Regards, Tim

signature.asc
Description: This is a digitally signed message part.

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-23 Thread Giuseppe Scrivano 
Tim Rühsen tim.rueh...@gmx.de writes:

 You changed my original patch in a way, that you won't need AM_CONDITIONAL 
 any 
 more. Try commenting it out - it should work.

Thanks, it seems to work here.  Are you ok with this commit?

I have also added a missing entry for the ChangeLog file.

Giuseppe



From ffb94036f2116649a8de1a930820056aea9cb65f Mon Sep 17 00:00:00 2001
From: Tim Ruehsen tim.rueh...@gmx.de
Date: Tue, 23 Jul 2013 15:45:30 +0200
Subject: [PATCH] openssl: fix build.

---
 ChangeLog| 9 +
 configure.ac | 1 -
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 62c36d4..07340b5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2013-07-23  Tim Ruehsen  tim.rueh...@gmx.de
+
+   * configure.ac: Remove AM_CONDITIONAL HAVE_NETTLE.
+   Reported by: Darshit Shah  dar...@gmail.com.
+
+2013-07-13  Tim Ruehsen  tim.rueh...@gmx.de
+
+   * configure.ac: check for libnettle when GNU TLS is used.
+
 2013-05-17 Bykov Aleksey gnfa...@rambler.ru
 
* bootstrap: Add `mkostemp'
diff --git a/configure.ac b/configure.ac
index c26dae6..5173d42 100644
--- a/configure.ac
+++ b/configure.ac
@@ -340,7 +340,6 @@ then
   fi
 else
   AC_CHECK_LIB(nettle, nettle_md4_init, [HAVE_NETTLE=yes], [HAVE_NETTLE=no; 
AC_MSG_WARN(*** libnettle was not found. You will not be able to use NTLM)])
-  AM_CONDITIONAL([HAVE_NETTLE], [test x$HAVE_NETTLE = xyes])
 
   if test x$HAVE_NETTLE = xyes
   then
-- 
1.8.3.1

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-23 Thread Tim Rühsen 
Am Dienstag, 23. Juli 2013, 15:47:35 schrieb Giuseppe Scrivano:
 Tim Rühsen tim.rueh...@gmx.de writes:
  You changed my original patch in a way, that you won't need AM_CONDITIONAL
  any more. Try commenting it out - it should work.
 
 Thanks, it seems to work here.  Are you ok with this commit?
 
 I have also added a missing entry for the ChangeLog file.

Thanks, perfect.

Regards, Tim

signature.asc
Description: This is a digitally signed message part.

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-23 Thread Giuseppe Scrivano 
Tim Rühsen tim.rueh...@gmx.de writes:

 Thanks, perfect.

pushed!

Giuseppe

[Bug-wget] problem

2013-07-23 Thread jordie9 

this is what i get trying to use wget:

 wget -d
wget: Syntax error in /etc/wgetrc at line 83.
Parsing system wgetrc file failed.  Please check
'/etc/wgetrc',

please, any help welcome. I am a n00b. lol

Ade